From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BAD797803CE for ; Fri, 10 Nov 2023 01:13:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7Xe1eWaTPIuSj2mSqvzVvUmMvnJ5b8P3KUBhpOPwsZA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699578812; v=1; b=qYh9sL/Hd5nREMYjChsSxYksAC16c8u/bovuiBrFvxz4l4ILbGTFji/O7AClQnqsnkLGZFq8 4OoFcpPR3JqAemSUOCGlXkU5A0Z4wFdy9DrXJ9klNiS47bPYB6Y5ozpAQWqgTuHzNt7FW6KWPX0 LA2niTy7khnP263SJWrfKiKA= X-Received: by 127.0.0.2 with SMTP id HBl4YY7687511xuvkWu3oJUt; Thu, 09 Nov 2023 17:13:32 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.18413.1699578811385754199 for ; Thu, 09 Nov 2023 17:13:31 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="380500755" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="380500755" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 17:13:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="798478512" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="798478512" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2023 17:13:30 -0800 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 17:13:30 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 9 Nov 2023 17:13:30 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 9 Nov 2023 17:13:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZvnW49h9UwQYtyGij6Ioua4wEpKVW/W1VV2iOx49fMsHV6+gTO9N0asyIYONzitiTRPtEbHPbBNCZLlK5XcKRI4GRR59PFDr6uwobToklNfaFonI0VeTVUxP/gD2fxrezY6mwqLlxd0b9OH/au9MmfHAPZ2q7g1HTr53CG8ZWHcONBGeoWKwpb1ZALYAEFHIRF+K45vx2x6G5y/bLh1oJKSRBROkz6b27q9Qx6y1CsmF8u4l3v7mayhs2UBXhMfYySzu5ZjdfrpihF12JD3AUGwu1IJRJeC7A3qwFRYD4OP6IGmA0JXUCuiW69ty+/pKI7nU17Kp6cFsnHD6yGIhJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=up6naFVQgPpaq7ijtG2yvBzJVAu4iUi0d0ozYeDmBd8=; b=JbAMpMk2qcfvotnBUU0ISt8tx6nEf5oFOu9uItsPo9GShBVBq6s1bZ2wsLtUN+g69rVbnQ9H7u4p5OOAbAFo9OC+wnVWzq+uBqkh9ScbtGqWmJnGmmYB8ucb5AgbEkekKm/hi9lYTVraFryqzt3L8FvZy1MnQkfdU+9uT5Y1gbWPztPq3iuvsFv5Vb2w/8tQqPBlrU3tAOS6wMjXyd/Lm/c+4pVdztjDZwD4RF5FmkypPEs5Igcf+hTgI85kmfEEwxir4sV2AJx6GgZqokKyF1ViebM7nEa29yCGnSXZ9l6+Y+i0pDqpjWyUUSEY8aYebeOQllVXsDPUQsiG866Vhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CH0PR11MB5475.namprd11.prod.outlook.com (2603:10b6:610:d6::21) by CO1PR11MB5138.namprd11.prod.outlook.com (2603:10b6:303:94::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Fri, 10 Nov 2023 01:13:28 +0000 X-Received: from CH0PR11MB5475.namprd11.prod.outlook.com ([fe80::b80d:966d:e08c:2f05]) by CH0PR11MB5475.namprd11.prod.outlook.com ([fe80::b80d:966d:e08c:2f05%6]) with mapi id 15.20.6977.019; Fri, 10 Nov 2023 01:13:28 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Chiu, Chasel" Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references Thread-Topic: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references Thread-Index: AQHaEwUzU/UaQY8J5EiFoN/HcUwp2rByvhCg Date: Fri, 10 Nov 2023 01:13:27 +0000 Message-ID: References: <6f4604d0-c12e-f818-2de1-44e9b1f4dbc7@redhat.com> <20231109120610.55894-1-lersek@redhat.com> <20231109120610.55894-2-lersek@redhat.com> In-Reply-To: <20231109120610.55894-2-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB5475:EE_|CO1PR11MB5138:EE_ x-ms-office365-filtering-correlation-id: 529960ef-ecee-436e-f4ab-08dbe18a3e95 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: NGdvAzX3Tz0DVmLfkvaRcYgxMWzDvJFCIb+3sROMxlhWjn3G+1Cwmv1jDOFcdIbZhtfA4VXECm8jqKnuNbSKfZe6JfuxAXGn2KY/FNTsXE1DVNYChrjTrVs4cxZb8Ia3qeeqOLBTsgQptTNbBjlVtUgCGuzxwefmGHt68oA8hX4bQVrZftbixUUSASUiMCRgcj2nlWyEVR54ENq3PHB1rQNcMginlIwJslSiIlIj0kSzIhGlb6Z9c4b7FzAiqrd4lXA9Godek/3xfk9t3wgpzk7rc5C22rtGxosLlAIO0SWZv6aiperObsLXHMO1LKmIehLMmg+RkZQsIxgSLMKdRHkWbvUg4Ymrow7g35xoe5lQlEccqtMWdZiF+jnRPcVEpdyTYcBkIlb78B07myqoWcfQdU5XNW+rHQQCjQ738LM17GIgSMB2x9azetJB6DABFOlkIUyIabqVhgWntPlluBRvsSb9IwjgEipyD5lFba4x6vUfgA5YvbtJw7GRucpSwQambveWqIZcn+zQkJ02Xo1yXEn18iCPfi2+ZiusDja8iilv69io0988VZgtfheOzP0JioIirSFJ+7dZ40T2hAbkaEGp5jIUm8unFQsRE2S7n2COzx6ojRc3zXDXcRK3joMlLR/UH2gGxNKFajI5Fg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GFM/Y5w5KfQHjyPhiKDkVbu0yY56HVfYC1Kjv1zRNxRw/yt280p8czPQmKMJ?= =?us-ascii?Q?oz9yUOowVa972ncEyhvdkvSdYWNiJiGjKaKzHd9xnDfeh92ouwplGgh0f+3v?= =?us-ascii?Q?cXCDjctVZd35rwA+nvJJlBUhhodKtsiL24V3xyScZVF0UCJPdlPZis9QHNGB?= =?us-ascii?Q?HOM/ZBToAV9xOSUTxWYgcpgJV0GpDXnPZVCoWHeScMHTM7ZI0imYY+lgPGuE?= =?us-ascii?Q?h/MTit02bcBbh/CrVLtUdDpfdL8NobvOrhDQQTOBerj3vuPGDqFiYU6QKIRo?= =?us-ascii?Q?0PuNXOEVNN6bjOFEsKKPEd92aV5PJBHD72QejhL7pUTBiQMcjB6EPsYgHO9x?= =?us-ascii?Q?UTj3rdIMiRXZT7w9A95GkSuHgdJujhXa3qeQEGWJ6uR5f9ln6Dx54vGlQzfl?= =?us-ascii?Q?Xi27HoOjI0AWJrq8yoL+Y7s2mDGd6SAiuOjabMRf88Virdb7vIFr8BvYBCoe?= =?us-ascii?Q?cqW3oQDRieBitdkswdeyTBRvWzxpobo+WqsKSoc3UYcROJywl8VCnHO6C1uu?= =?us-ascii?Q?Aixuioq262xBa+TEnzTYEfU0uDNufiscZvzfkE5vwHPEn44CIinljosxNEL0?= =?us-ascii?Q?WdEgHfjOYkFjrmRrimag+lkGQuECfPoN8gMd+/nND4puu+2RjysUcEHcnDSk?= =?us-ascii?Q?W5gHyptISq7gfRs4pVntwS3aS+9OQlr4s+7C2JAjJMtWbnEbKIzQoCNQHndY?= =?us-ascii?Q?WHQ4hG99kNLIq0VwxPaTX/dLYJWMyp1ALEsTJBjz6bIZI+Ryu4RpatZTde5V?= =?us-ascii?Q?qJ0M1KfumLopCCkHIG+jyODC1n1dkzzOmygEDTe1k39Zx/e0aFTnyaDkW1Mi?= =?us-ascii?Q?x/g4mqLR/VWmry/WfU5Yb2ykOlWtm77FHeYSzQcdE/9jzxmZTGEeJCoI7n85?= =?us-ascii?Q?4kNbQ5KlKoBl+OmqnGPwfLfDzz/b/VVXhwEKCqGSeIndj/8s8wpsLN5zgeFQ?= =?us-ascii?Q?Ol4+MDtexrCDoB0aI8L7L+cX3ALv20n3gut3bImTMhWCAbJ3tGNMMDXu1cbb?= =?us-ascii?Q?EjYtdxDUa87TuSrT5G+3vo1EThlHf8u7jfeeegvS0XoZH7PG589YoSWg6HSC?= =?us-ascii?Q?LYOFwTykS9Vb8GY1NkBxfP3B1C0xz7LF58AuIvT3rAV7ihsgF5ibjxg7teHa?= =?us-ascii?Q?G7dgRL9Cy3U8f6lNhXTq90KFzF6L0TC0nLlfDJKC9x6sYrm9M+EW30D3d7UG?= =?us-ascii?Q?5oQ698XblWOh/hfCmxpdCGJDKHbNKNR7v//rx+KfjUPMYbYygdxoBECmM5Dw?= =?us-ascii?Q?u+a1ie8/tsBp4/rbaxAAVkQ+8rL/t4oAwL5hn6uE/SEfZsjYPZw7VLp/6yFt?= =?us-ascii?Q?GkuyQhw50UT2peiu6OLCfU3xToSYrsOgB+72BP+F65P7a4c62wsDTQs5kKBQ?= =?us-ascii?Q?51IeHs5a19LHGZG9Rk1tXdZVEyfAXhsKrJbDmnUqU5cgKRQYs5EaleYDpLh3?= =?us-ascii?Q?yORKPwRthAUfaWdcWGfqkKwlHRKL8KWf/cM7gfjL+2COVfaV/Vv80tR91Dix?= =?us-ascii?Q?fL7y2GTKuNH6LuLfX+VTe98xunimpobAAqp67/qHHQMm/HEXRsq44GxCtcGQ?= =?us-ascii?Q?zkBy5+nc0F4PpWrja8ZIhyRZX4K8KLQFKskyT8zc?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5475.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 529960ef-ecee-436e-f4ab-08dbe18a3e95 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2023 01:13:27.4744 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ESAESoyLDRN1lkFVWXOUyy1kAM1+3bKdgThmEPJsrzcXYt+dnXfwD4lUsiMRQSMKyGOMIWMhYXHWfSJApvcjDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5138 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: reLfZ7MGk1BpMBhGYUZC1BiZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="qYh9sL/H"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Laszlo, I verified and encountered build failure as some files still consuming defi= nitions from LegacyBiosMpTable.h, for example: https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01= ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/Sy= stemBoardInfoDxe/SystemBoardInfoDxe.c#L22 Any suggestion that we can reduce impact to existing platforms? Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Laszlo Ers= ek > Sent: Thursday, November 9, 2023 4:06 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, Natha= niel > L ; Chiu, Chasel > Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: > remove references >=20 > For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from > edk2, first remove the edk2-platforms references to that header file. >=20 > I can't build-test this change. As far as I can tell, building the Cooper= CityRvp and > WilsonCityRvp platforms with "build_bios.py" should build these changes; > however, both platforms fail to build without FSP blobs. >=20 > I think there's a fair chance that this patch should work nonetheless; > introduces names prefixed with > EFI_LEGACY_MP_TABLE_, and edk2-platforms doesn't contain that string. (Th= e > one exception is FEATUREBYTE2_5, which is also absent from edk2-platforms= .) >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Chasel Chiu > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1754 > Signed-off-by: Laszlo Ersek > --- >=20 > Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoar > dInfoDxe/SystemBoardInfoDxe.h | 1 - >=20 > Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platform > DeviceDataSRP10nm.c | 1 - > 2 files changed, 2 deletions(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo > ardInfoDxe/SystemBoardInfoDxe.h > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo > ardInfoDxe/SystemBoardInfoDxe.h > index 32c16ff9110a..d8c209a57f75 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo > ardInfoDxe/SystemBoardInfoDxe.h > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo > +++ ardInfoDxe/SystemBoardInfoDxe.h > @@ -27,7 +27,6 @@ > #include > #include >=20 > -#include > #include >=20 > #endif //_SYSTEM_BOARD_INFO_DXE_H_ > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor > mDeviceDataSRP10nm.c > b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor > mDeviceDataSRP10nm.c > index ed9f80734cd7..b69ae1736bb8 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor > mDeviceDataSRP10nm.c > +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Pl > +++ atformDeviceDataSRP10nm.c > @@ -8,7 +8,6 @@ >=20 > #include > #include > -#include >=20 > #ifndef V_INTEL_VID > #define V_INTEL_VID 0x8086 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111005): https://edk2.groups.io/g/devel/message/111005 Mute This Topic: https://groups.io/mt/102483850/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-