public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build
Date: Fri, 23 Feb 2024 23:33:48 +0000	[thread overview]
Message-ID: <CH0PR11MB5475BEEA6DAC740177FE82C9E6552@CH0PR11MB5475.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240209224819.11355-2-nathaniel.l.desimone@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Friday, February 9, 2024 2:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build
> 
> Adds library instances for MM_Standalone, which are now required to build
> IpmiFeaturePkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc  | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git
> a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc
> b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc
> index 64e8978942..7738120017 100644
> --- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc
> +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc
> @@ -160,6 +160,8 @@
>  !else
> 
> BoardBdsHookLib|$(PLATFORM_BOARD_PACKAGE)/Override/Platform/Intel/Boa
> rdModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf
>  !endif
> +
> +[LibraryClasses.common.DXE_DRIVER, LibraryClasses.common.UEFI_DRIVER]
>  !if gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable == TRUE
> 
> IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/Ipmi
> BaseLib.inf
>  !endif
> @@ -169,6 +171,8 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Smm
> TestPointCheckLib.inf
>  !endif
> 
> TestPointLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointLib/SmmTestPointLib
> .inf
> +
> +[LibraryClasses.common.DXE_SMM_DRIVER,
> +LibraryClasses.common.MM_STANDALONE]
>  !if gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable == TRUE
> 
> IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib
> /SmmIpmiBaseLib.inf
>  !endif
> --
> 2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115898): https://edk2.groups.io/g/devel/message/115898
Mute This Topic: https://groups.io/mt/104269624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-02-23 23:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 22:48 [edk2-devel] [PATCH v1] MinPlatformPkg: Add MM_STANDALONE LibraryClasses Nate DeSimone
2024-02-09 22:48 ` [edk2-devel] [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build Nate DeSimone
2024-02-23 23:33   ` Chiu, Chasel [this message]
     [not found] ` <17B253693AD67D93.14481@groups.io>
2024-02-23 23:42   ` Nate DeSimone
2024-05-06 18:39 ` [edk2-devel] [PATCH v1] MinPlatformPkg: Add MM_STANDALONE LibraryClasses Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH0PR11MB5475BEEA6DAC740177FE82C9E6552@CH0PR11MB5475.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox