From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.41]) by mx.groups.io with SMTP id smtpd.web10.47478.1681709182724865409 for ; Sun, 16 Apr 2023 22:26:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=qmzYbyL8; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.41, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gxe2nfeiS0T4wEJYcCdPbab0YCA501nRHHhYaj4AieLuyvZdQ5nkjoEw7dPMnhDSswYckQsIAPCQuAmAxonTWnFQJogPAadssP00slD8d4gkrAAaQxTbrH2hKgnxMnB4Sdz50JwhkDxcIUTVv6AFD5EED93vGdZg2e6b/7/CVgO0f+4QgzNjFz///EPDB0LT1B97yqjzSRqzL/nY5KjCQG2Xlt5LmjwGfjRA9TBvdmuq+HaiAzZHUpmDkBt/Sej0Dp9JNYzxm5T1NQ9fKphFrCQl+tfFJNrIk0MQ4zQxrzodmfewnmhQjxbaUql0tl+mU4I4hRO8FqtsIJAECBU01A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dr0uQtER8VKSUdk0hBj+YpcPIZ0E4lol5HF1j0XQ7bo=; b=mbmCr71OzCCP03dHnPYzQ3wN8FFheEDHVR56T+9nUP1jPnvD8Tffg9jroUyvoAgVx5WxF2Z5NFniJpcKWUW7aR/VA0MUM185F83lhdRdIgD+O4zj9irH4VGqSGB7Ci8NTnkKmDIrh0UqtHaOBBdpxZLIGnTFIN/G7g4gPMKzekZlRh05Fo9mGB7pmOGhX5L2cGhMqv38SK4H4YX3EVZeGNud7CwJNvWDj2LwEUCr1nNJOuc8/ALNqno4H4mg8rAbalimqWugCSOTbxIpdOTXTEiHHyUHMkBzZqvC4gZ75J6G9Rx+Py8sF/DP+UR4eWhqzLnzePYHAg7tvwI9jFlujA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dr0uQtER8VKSUdk0hBj+YpcPIZ0E4lol5HF1j0XQ7bo=; b=qmzYbyL8iXc7tSJlp3Bu88xI7/LTdtDq5w67/VozaPTSPuCGbxv6sno/QPF0Vvvup9/BmmyIplmJckgKOsvbKqAPJO+BQ8nWooFtlxojagl0zsYvkdNE3q5n+0312RKHAwAg+8IE5CoxBAY1e/WzUtY5AyIG6lDJ6GROOcOhGXU= Received: from CH2PR12MB3957.namprd12.prod.outlook.com (2603:10b6:610:2c::17) by PH7PR12MB7329.namprd12.prod.outlook.com (2603:10b6:510:20c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Mon, 17 Apr 2023 05:22:57 +0000 Received: from CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::8859:e888:875a:bdda]) by CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::8859:e888:875a:bdda%7]) with mapi id 15.20.6298.045; Mon, 17 Apr 2023 05:22:56 +0000 From: "Chang, Abner" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" CC: Isaac Oram , Nickle Wang , Tinh Nguyen Subject: Re: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Thread-Topic: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Thread-Index: AQHZb5GDQGu6D71tCkGmy6eYG8qzla8u74vAgAAKgtA= Date: Mon, 17 Apr 2023 05:22:56 +0000 Message-ID: References: <20230415115727.805-1-abner.chang@amd.com> <20230415115727.805-2-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-17T05:22:54Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ed80a8d6-d15c-4592-9617-217afc8527d2; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB3957:EE_|PH7PR12MB7329:EE_ x-ms-office365-filtering-correlation-id: fbc7a881-fe8c-4de9-50ab-08db3f03cd4c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /AS2y5LDtiCf7ueuRNl+8Zv1RqKWy599Q2L07ipcOIhsJsHadS0WU4AvYZZEkkfzH0A4zVjBxYF79it6kGz3Xe7Joe0dG44JpIhWI7xaeyv9R1JKHByI6mOesvogP4MivS2wTyLVz4p79u6ddI6rIulXPrc8m/owbvH6cf92pB/uR2i6IuG71hTvrUp7ULs+hRIN2sHedRpweMubtahIGhRPqlsGmtUIOfPLae3XpD4cquxIUOR9A4mKFVyCrkCUAwhV4DjH5z/qmWzALzwntYcEvWHlyLpEtNpYWPb0jIE8uHy0j/9SvfeEDuPWk52zYVLrC1GNnUNCJ0V33zoPVWOkVfwMmddxJbkiMhVfI9CiCjFo4coK1nN9kb5fEdROGbsySoy6PnESi2EOjr2mz+OxMKOTtuTZtfoyCP2+2Dqe11l+nspNBFQWo/3w8kgHqneocrUxIEagn+UAM2MHm87PR/G1WFw5RkCqIF+YNKiAvrHYZZf3ZPf/Yc4fBL3dsW80g/txEtexLLPhEAnYrXIJDw0Fo8bsmv+0JPNGEeJ/btdzBNFv6RjYp3LO1tdxEr32pj9l8nvqdOcjiCkXfMIPC4DCCvou14pUOU8JVr9kGagc2zDTDWO/VB1gWP47 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3957.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(451199021)(2906002)(8936002)(76116006)(8676002)(5660300002)(52536014)(478600001)(19627235002)(41300700001)(316002)(64756008)(66946007)(83380400001)(66476007)(66556008)(55016003)(54906003)(33656002)(66446008)(110136005)(4326008)(122000001)(86362001)(6506007)(7696005)(186003)(38070700005)(38100700002)(53546011)(26005)(9686003)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PwIHV19JKIyJeR70J0z9vB5r1m8NNawLtx1Hgn4i6/VUheUkql5O4TYjoDcC?= =?us-ascii?Q?XP16i5pMfPOpW7uhz63lJNCplB94W/ba1e1YkisiiObYeMdlsq4lPQrAvj8U?= =?us-ascii?Q?uzmXd2F6wMo0z5TJW7o1XnVFF+7/mjjxMzfnLbBuafKTFj/ysYQGzTy0PGpv?= =?us-ascii?Q?qyybjp+LbWBKWBgvI87SU8ff7gYIl+TIy7Fwprzsj2CJay0YhGDmIID+w/aM?= =?us-ascii?Q?mhMbT/dKHiGPjyGsldCUwL1IcXPJs47DN1WTOf4+omgMoGHcpDyJTyXZpIZH?= =?us-ascii?Q?+FZaZMRdIMYcDKX3ZiVJf1wr3Nq9hlh9xZDkpzZnDF5BI6HgNlY0d8ONu7aU?= =?us-ascii?Q?b2O41lo+79+18v6HpG8KkIgDIpTOSXfwNZoxzGWRrVFdWjYMUPnGswOO8IzZ?= =?us-ascii?Q?EcE9X1CD8YGVv3Rf6HUvrL17ixcj9jw8lFUmAAi5Z9rLjZc6iuQnaEU0C+UI?= =?us-ascii?Q?U56GGNfOHqw4DvnzcQMPH2jy3iId7kMqNvlhp6IScDke2cWVP18Bfae+I3eu?= =?us-ascii?Q?mvGLvV6Vts85RJJP8O1U3+MJsc0ggc3V6v/uo4JovYXdd8f4FwRvyRKFzs8A?= =?us-ascii?Q?eY0ZvWMEy9+BBvnIHwqfMFJkwpAAtlSKguaFLhdW7q1rjjdlNVYenPBMT0Ak?= =?us-ascii?Q?PK9qsq9ekpinwKDj1qRnrC2FqDc05zc6+HupRESCFsgPSLt1NTaYFs5uLpv0?= =?us-ascii?Q?x0yKpDIrCUFz+CFMpPIJuCoknSLgyWKGL9PZqe7lWa6CC2ZPyzUd7k6lCEnU?= =?us-ascii?Q?B672IcKiyySg42canyTXohHuHOzOr+zIJodKwriDxVXv8rY9GGuUoIq84YMT?= =?us-ascii?Q?JAbNZBWbSd3L5++AmIBoX3cCfaIUYmQe4Cd64tJ43H1pUDQ3UhgWxGtxGpwo?= =?us-ascii?Q?6z2OR6aLRlZ7sg9nlQIMbksiMS/o+TjChd8dcazmZBJR2mTyX8gqrYc7yNlq?= =?us-ascii?Q?/GqdB/BlpX9lTc151Os3FwiSZSTsJKPLuN3GepphKCd8SUJEUz+wl3tUU/nq?= =?us-ascii?Q?ZEDyDTTd1FQrZleUNu5p3gCNV+9EhFGHQqsPi2XoVy17J9yyvm0Xj9PL4wEX?= =?us-ascii?Q?m5DNmEhpiiid7u0V/r8RJNFnVNvF6tAmTA1jBGzUGdk1I0of37pg2jWCEFp9?= =?us-ascii?Q?HutNQRqvhzynYER7S0zXliHm42GH2C7tICJ6UOs46epoHIpOBeufvUyr7vUB?= =?us-ascii?Q?llC1PxAkkKvn6/3a/G6/4IK4TbZXeIYtQx7eMuHDYz1hVx/wsStble6thHJr?= =?us-ascii?Q?GJmBg7+SQG3Jiu1lCf2FnzObEZJ/pba57YmQa0hU4AELGE/ohlSCcT8GwIoy?= =?us-ascii?Q?Prx5BbvM/MvhBQXKV/9boyrkFTQQuC+QptNJmR8u6xJ8SRLOfGXsEsMeBU72?= =?us-ascii?Q?f1Jp1frFiF5F8IWqFAPKTpMuMu30JrCVLyqnyeJ4XIEqJBC/OTCAHd1cqNTE?= =?us-ascii?Q?4uR/aHJWYN8NRaFGCdcOgqRFWlLu31VBru/RWj3B/TGLOnJMHqB+/JM77+ID?= =?us-ascii?Q?DobzbWwDT9WKSdPascQdwBniL2tTUYBGuHKenFIU0r3tG/ffqZ2rFFRMsxuO?= =?us-ascii?Q?I8/M3p5lnW0wkrlyStU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3957.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbc7a881-fe8c-4de9-50ab-08db3f03cd4c X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2023 05:22:56.4433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kfWkecJ/NcE2WnzlFCh37RDcJJ1VpEgKM8TKE0sdKlvFuPthTXWdb/BOuAj0tEJNlBo2l6N9s59Cj/fDx9ewSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7329 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Sure. I was wondering to use I2C or I2c. I will update it. Thanks Abner > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Monday, April 17, 2023 12:50 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Isaac Oram ; Nickle Wang > ; Tinh Nguyen > > Subject: RE: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C > instead of I2C >=20 > [AMD Official Use Only - General] >=20 > Hi Abner, > I think EDK2 uses the below naming convention for variables which > are acronyms. > First letter is capitalized, and rest all are smaller. > Its better to rename below variables from I2C to > I2c. >=20 > -----Original Message----- > From: Chang, Abner > Sent: Saturday, April 15, 2023 5:27 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef= ) > ; Nickle Wang ; Tinh > Nguyen > Subject: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C > instead of I2C >=20 > From: Abner Chang >=20 > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Tinh Nguyen > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +++++----- > .../BaseManageabilityTransportHelper.inf | 2 +- > .../BaseManageabilityTransportHelper.c | 14 +++++++------- > 3 files changed, 13 insertions(+), 13 deletions(-) >=20 > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec > b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 9a930d3e4b..3656190a70 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -32,13 +32,13 @@ > # Manageability Transport Interface type > # > # Manageability Transport KCS > - gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, { = 0xAA, > 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } > - # Manageability Transport I2C > - gManageabilityTransportI2CGuid =3D { 0x5B174658, 0x8263, 0x4CB8, { = 0xA0, > 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } > Change to I2c > + gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, > { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } > + # Manageability Transport SMBUS I2C > + gManageabilityTransportSmbusI2CGuid =3D { 0x5B174658, 0x8263, 0x4CB8, > { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } > Change to I2c > # Manageability Transport PCI VDM > - gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, > { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } > + gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, > { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } > # Manageability Transport MCTP > - gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, { = 0x82, > 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } > + gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, > { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } >=20 > # Manageability Protocol Specification > # > diff --git > a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.inf > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.inf > index 95c3362ddb..8876e36480 100644 > --- > a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.inf > +++ > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.inf > @@ -32,7 +32,7 @@ >=20 > [Guids] > gManageabilityTransportKcsGuid > - gManageabilityTransportI2CGuid > + gManageabilityTransportSmbusI2CGuid > Change to I2c > gManageabilityTransportPciVdmGuid > gManageabilityTransportMctpGuid > gManageabilityProtocolIpmiGuid > diff --git > a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.c > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.c > index 81da209764..6454f32670 100644 > --- > a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.c > +++ > b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib > /BaseManageabilityTransportHelper.c > @@ -15,13 +15,13 @@ > // Make sure the global variables added here should be unchangable. > // > MANAGEABILITY_SPECIFICATION_NAME ManageabilitySpecNameTable[] =3D > { > - { &gManageabilityTransportKcsGuid, L"KCS" }, > - { &gManageabilityTransportI2CGuid, L"I2C" }, > - { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, > - { &gManageabilityTransportMctpGuid, L"MCTP" }, > - { &gManageabilityProtocolIpmiGuid, L"IPMI" }, > - { &gManageabilityProtocolMctpGuid, L"MCTP" }, > - { &gManageabilityProtocolPldmGuid, L"PLDM" } > + { &gManageabilityTransportKcsGuid, L"KCS" }, > + { &gManageabilityTransportSmbusI2CGuid, L"SMBUS I2C"}, > Change to I2c > + { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, > + { &gManageabilityTransportMctpGuid, L"MCTP" }, > + { &gManageabilityProtocolIpmiGuid, L"IPMI" }, > + { &gManageabilityProtocolMctpGuid, L"MCTP" }, > + { &gManageabilityProtocolPldmGuid, L"PLDM" } > }; >=20 > UINT16 mManageabilitySpecNum =3D sizeof (ManageabilitySpecNameTable)/ > sizeof (MANAGEABILITY_SPECIFICATION_NAME); > -- > 2.37.1.windows.1