From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 535887803CC for ; Tue, 24 Oct 2023 05:23:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bjq2OcTE8d3ZrARgUfDjLvjg/XuIcQygsV9GGUkL0ao=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698124987; v=1; b=akescbBuSHltwQG2FMgq4ZNdNVktnYsxp50nkIlBMN4rwNHf4DtsBXt58giQP3F/02seziQY tZtrYdv7z3bXSz6fKUF3Q9ECiWE7bdu1+YwNlGcEim9eQtMseKwWOZMr/O8BkM+IUwzeyg6fciK T2bqYv/De4O2xh3KzPaZrwWk= X-Received: by 127.0.0.2 with SMTP id iKU5YY7687511xlaITCODquP; Mon, 23 Oct 2023 22:23:07 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.51]) by mx.groups.io with SMTP id smtpd.web10.141444.1698124986380101466 for ; Mon, 23 Oct 2023 22:23:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJQT70Bfxq5tr9WvEhFPLKMu8JB+vsQ9ntsDGkLkzuWJ0sOiQ8mn63e/h1WsRb5MG3WnVQw5QQRGsETeJ7dao/lSxMrmoe6U1PKvL4GGUpbcQwsCEgCh5HJF7HAau6XvJ0HuRuJCSflYdE+h6/heqP6UjGlykKEvVh847cfYVgR8Oyqkc1j6/IaWb72vV+TKLb9/iuCURN+YQ131yZZoI8TIssmEF+PXl5KiB9h969jWt5wySEPjGWRg7YsWFVsIDU95Azt/ada7KEnX2qqBPTd+OnFGhF5strhTFYHatg/xWRjtRAYclBgu3FxxJQ1C+vOmddwMoXVok1vCcs5ovQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1eLxiSlJaz5c/WDlFE+pxgy4czpsyUlYNBQIEdCtcIw=; b=M29qmb+W5BBSgt5vbqVYuUIn+bY5DeSCtzYXD+JzAy13H3kY3rVyfNGtLLf/YdhG6Aw6MN1ChsQ+Sf6Dksycsea1dNdsPUADgsBy+XHB/acY3bB18G/Dio+MasOEj6lkK9A9SEGcCej+iNK+7FN0Jhwx8RH4GV5zKI/j5OCuEwlv7zi5bfIMitt8g6vNjdonNUNd8mdphc+WroRBLvIjL1QzioG66gBPL7uwSqg6lLID3rkm1IW6lcL54/z41Xf8L8COj7C+yTp7MTYUrQhKYIE917Wte6waviKim85ztaU3MxubZ7zyyuur8une5U5kzcBSmLVcSuHSilpbsPvdig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from CH2PR12MB3957.namprd12.prod.outlook.com (2603:10b6:610:2c::17) by DM4PR12MB5087.namprd12.prod.outlook.com (2603:10b6:5:38a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Tue, 24 Oct 2023 05:23:02 +0000 X-Received: from CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::ed0:5e27:ff94:5d4f]) by CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::ed0:5e27:ff94:5d4f%6]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 05:23:02 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" , "lisa.huang@intel.com" CC: Isaac Oram , Nate DeSimone Subject: Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaAyEmQZRi0Xh2AE2Iy6Gd4leWvrBYbU0Q Date: Tue, 24 Oct 2023 05:23:02 +0000 Message-ID: References: <20231020064616.6637-1-lisa.huang@intel.com> In-Reply-To: <20231020064616.6637-1-lisa.huang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b8f29a4e-ea19-4efd-a32a-a2482775b195;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-24T05:20:19Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB3957:EE_|DM4PR12MB5087:EE_ x-ms-office365-filtering-correlation-id: a05faeb8-6be1-44eb-5cc9-08dbd4514b3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2oKqeTxq6/MeZDRwvOXOroUimKQfsJfnFg2EYdxqDSieIN2DjrdBp36TMjQQRHxeOUfEhb77GWptpAmUbUjeVoo6wbhd6Mu4yy0e+hoTQAiMK/Mve9h6nnvafxlu4QnO69biEaGwwoUZLQ8wH6gEOTFDy99pqZwRdz3imRW8RPRHEiN2daQ9cFyewz91RaAxoVIEbLr60GKc5jMXhFZBROvI/dApK0UQXGb11GPXIOBzpXPY/Q3NOwLKCJgASviSuHoX0tdKV2yEE82AnHFFHjhHXmsBQJ/4q8ci7e8wD4WM4TkE8mKUkyObM9tLV4dF2hmQWV0W8jDCRsUgDeQbFJDDX4Oi2wrq4fTsFzsHTmcovckXMw42vwgnO/5/dZXDXu0g2bQIMMMc1XqpEmP+C2H/CZ+AC/HI2tYResKthf7ZpnFhQ+l6i9b4hXGNMmtretHWBJj3XcfLAugL2YTKwi+MWdxRHA+mPKivDrHOja7DgMvwJ5wMwu2KiTyhKGFdoZk06n28/6SlTQBX8L28wlm2DJGPeJYWWgw+6QnnPDi7WHf6y4PF0DiMTv6hGRSZnXU6+lUdqsO7K+doFJsZGZdWHyTU5WOKO4q3zIQ92b4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gQEkEhKmZaaeeW7YNy1Z4nZhYt7imZ+HfvoeC8Ym5011UdREQIhxRrTZQjhZ?= =?us-ascii?Q?7tolW/4KEcBjvVSNcuUisdTpfav9ijTC8wgZtvKq4/oMxwIqeSwQNH+hGQl6?= =?us-ascii?Q?no5Ryq8KA2j8q5TlDD37FQuBcfj6JUhPUrfP4xsOVj2UNOuwYYXChF2eMgGc?= =?us-ascii?Q?r6Dxi0yOYoxkhd5m1LEhtLx7p+5MC9yKX/IdW2RW+ezQ7OSuGVjNMu34L7bi?= =?us-ascii?Q?decbEmhzzLfjHCyAJN8/xSzzYaIK0422JJCpiDAEgm5fSXdfrg71QTZimNG6?= =?us-ascii?Q?aGGHgJ7zD6z2U+RsAj1TN0Ra0SxFM/V/lj1CbD9SJ5KzM0mrG9hnrbPF+BJm?= =?us-ascii?Q?6k4xbn6CuP2S8C0Nll9OabUDKfCP7QYRnmGnUAE1mddy6tbk5KsAs0OL0PRK?= =?us-ascii?Q?E8A6dllVOwv3U537s+JLuFa1tt5tboi/DWQE7XRZ7tpiSBh/c70fUA3713tm?= =?us-ascii?Q?7rPVOcXdIBTGoX56I1ljLJZJgjLoDc43PuLBcu0E7aHZ5TSxppdX4LjJ+RwY?= =?us-ascii?Q?tRSXpABtCFKYvwR6o6u9b/xBDyRvsqadNWe/UUxVwKWG5LafamctpMh1hBok?= =?us-ascii?Q?u/jmFANs/dMrK/looOGK4oftbRKFk8T8YQ4DkFwDbgS3KqQCzeGkWd6lGg/c?= =?us-ascii?Q?AqRriPxGA7w2XOFUTOLcHNArxQ4KJKCAF8OqjnwjjZ3cmuAS7w8Gyk3n45u4?= =?us-ascii?Q?i5iw/Gv3XY8PEpaTcZya8qK11pX1NM+OchrIzAtXqlzC+U4A4vmx2ywfKakn?= =?us-ascii?Q?z8bQM7rVmuu0QzfHUoD50FN/ey31TXW0RifxMBddCem1tVMBdkYcaxrqtvD1?= =?us-ascii?Q?zpz/9UtIIr4B7XJri8JAZnR1yKkBIAApK8DRxzCtc4Q8W1XmvQSUFxAXnFrI?= =?us-ascii?Q?jCz1GcRybBHTgkt/fQJuYJnhiNWjysnFspvS5oQ3/+dvV/SeQm3DmNbK7j35?= =?us-ascii?Q?4HRSXUoW5Lz3i64PN+KSAQKbtaL1hWUKtG0BOifV+WpZsFpmMwgRCE4N8zYR?= =?us-ascii?Q?E1th1gLXblZ9uhVRiIN5l4mKFJqKw6rztQ8GUHHwLDXIr6ti4inOBzh+iIvA?= =?us-ascii?Q?YOEWxzdomtlCCw1nWukObura8b4r7EyZCALkpjwTvBUNFpjxM/RNELFu+XQw?= =?us-ascii?Q?4n+qWuNYKC1EUEABWCwgRA5s+lCiwOxSsJ94GFdSH+Ueq8haj6IR9mTG+sSc?= =?us-ascii?Q?jpRExlrQHG4EBrHU1JMBh+s0nGIEin7yC2jzCLe13w4xX+QSCsiLWSsmPSq8?= =?us-ascii?Q?MRB2+E6TS2YX5FuVENDNXKEtxFHBP3zZxT4NWLxZWkqZSqe0FGq5CeW3NlVc?= =?us-ascii?Q?dZZ7sT5Cv1TA75Km0OK8SD3o2qnfv5yaTU82q2Wt+uUFm8DA+DDZe4tZoDFz?= =?us-ascii?Q?5/BxG2MtvsywwWeFwnHUFEmAovpiGjXLw91sCYB3sHG8d2P6stc9bmm8Gvl8?= =?us-ascii?Q?GpgCL1ghDdtE8Z0+iOIM+xSvAYmJtXMV3u3aLKR8UVChBZg9BEDmUykGyrp3?= =?us-ascii?Q?nxQpZ/4+viaNiQ7qNAipfIRZvPETCRMm/ixhzrh0rw44BkcQUIoSLE9ZsfKw?= =?us-ascii?Q?nSpJNqo2ZkmV8EBNULxrDdWb4GvPeG5DJdd9Rus+?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3957.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a05faeb8-6be1-44eb-5cc9-08dbd4514b3b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2023 05:23:02.2313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I4zTdKziacuBI3G8Dl40ayyDN9rbypd2ZwLuQ93vz94LmjGAb32f+98IfZ2NR55IBFPqU40Zc3VknsV3jB8Wag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5087 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RZPI23W0eSRQe6VzoewBrhPKx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=akescbBu; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Lisa, The patch has the format that can't be applied, neither from email or the m= essage on Group.io. Could you please check your email setting or the options used against Git f= ormat-patch? Thank you Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Huang, > Li-Xia via groups.io > Sent: Friday, October 20, 2023 2:46 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Nate DeSimone > > Subject: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support > Standalone MM > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > Cc: Isaac Oram > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.c | 148 ++++++++++++++++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.inf | 52 +++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > | 2 + > 3 files changed, 202 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > new file mode 100644 > index 000000000000..52d8d2abdd0d > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > @@ -0,0 +1,148 @@ > +/** @file > > + Generic StandaloneMm IPMI stack driver > > + > > + @copyright > > + Copyright 2023 Intel Corporation.
> > + SPDX-License-Identifier: BSD-2-Clause-Patent > > +**/ > > + > > +// > > +// Statements that include other files > > +// > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include "IpmiHooks.h" > > +#include "IpmiBmcCommon.h" > > +#include "IpmiBmc.h" > > +#include > > + > > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > > +EFI_HANDLE mHandle; > > + > > +EFI_STATUS > > +SmmInitializeIpmiKcsPhysicalLayer ( > > + VOID > > + ) > > +/*++ > > + > > +Routine Description: > > + Setup and initialize the BMC for the SMM phase. In order to verify th= e BMC > is functioning > > + as expected, the BMC Selftest is performed. The results are then chec= ked > and any errors are > > + reported to the error manager. Errors are collected throughout this r= outine > and reported > > + just prior to installing the driver. If there are more errors than > MAX_SOFT_COUNT, then they > > + will be ignored. > > + > > +Arguments: > > + ImageHandle - Handle of this driver image > > + SystemTable - Table containing standard EFI services > > + > > +Returns: > > + EFI_SUCCESS - Successful driver initialization > > + > > +--*/ > > +{ > > + EFI_STATUS Status; > > + > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > > + > > + Status =3D gMmst->MmAllocatePool ( > > + EfiRuntimeServicesData, > > + sizeof (IPMI_BMC_INSTANCE_DATA), > > + (VOID **)&mIpmiInstance); > > + > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > Status)); > > + return Status; > > + } else { > > + > > + // > > + // Initialize the KCS transaction timeout. Assume delay unit is 1000= us. > > + // > > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) / > KCS_DELAY_UNIT; > > + > > + // > > + // Initialize IPMI IO Base, we still use SMS IO base to get device I= D and > Seltest result since SMM IF may have different cmds supported > > + // > > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > (PcdIpmiSmmIoBaseAddress); > > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGN= ATURE; > > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRES= S; > > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > IpmiSendCommand; > > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus= ; > > + > > + mHandle =3D NULL; > > + Status =3D gMmst->MmInstallProtocolInterface ( > > + &mHandle, > > + &gSmmIpmiTransportProtocolGuid, > > + EFI_NATIVE_INTERFACE, > > + &mIpmiInstance->IpmiTransport > > + ); > > + ASSERT_EFI_ERROR (Status); > > + > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > > + > > + return EFI_SUCCESS; > > + } > > +} > > + > > +/** > > + The module Entry Point of driver. > > + > > + @param ImageHandle The firmware allocated handle for the EFI image= . > > + @param SystemTable A pointer to the MM System Table. > > + > > + @retval EFI_SUCCESS The entry point is executed successfully. > > + @retval Other Some error occurs when executing this entry poi= nt. > > + > > +**/ > > +EFI_STATUS > > +InitializeGenericIpmiStandaloneMm ( > > + IN EFI_HANDLE ImageHandle, > > + IN EFI_MM_SYSTEM_TABLE *SystemTable > > + ) > > +{ > > + SmmInitializeIpmiKcsPhysicalLayer (); > > + return EFI_SUCCESS; > > +} > > + > > +/** > > + Unloads an image. > > + > > + @param[in] ImageHandle Handle that identifies the image to be > unloaded. > > + > > + @retval EFI_SUCCESS The image has been unloaded. > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +GenericIpmiStandaloneMmUnload ( > > + IN EFI_HANDLE ImageHandle > > + ) > > +{ > > + EFI_STATUS Status; > > + > > + Status =3D EFI_SUCCESS; > > + if (mIpmiInstance !=3D NULL) { > > + if (mHandle !=3D NULL) { > > + Status =3D gMmst->MmUninstallProtocolInterface ( > > + mHandle, > > + &gSmmIpmiTransportProtocolGuid, > > + &mIpmiInstance->IpmiTransport > > + ); > > + ASSERT_EFI_ERROR (Status); > > + } > > + gMmst->MmFreePool (mIpmiInstance); > > + } > > + > > + return Status; > > +} > \ No newline at end of file > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > new file mode 100644 > index 000000000000..336e28368ed6 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > @@ -0,0 +1,52 @@ > +## @file > > +# StandaloneMm Generic IPMI SMM Driver. > > +# > > +# @copyright > > +# Copyright 2023 Intel Corporation.
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +## > > + > > +[Defines] > > + INF_VERSION =3D 0x00010017 > > + BASE_NAME =3D StandaloneMmGenericIpmi > > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f00= f81060 > > + MODULE_TYPE =3D MM_STANDALONE > > + VERSION_STRING =3D 1.0 > > + PI_SPECIFICATION_VERSION =3D 0x00010032 > > + ENTRY_POINT =3D InitializeGenericIpmiStandalon= eMm > > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnload > > + > > +[Sources] > > + ../Common/IpmiHooks.h > > + ../Common/IpmiHooks.c > > + ../Common/IpmiBmcCommon.h > > + ../Common/KcsBmc.c > > + ../Common/KcsBmc.h > > + ../Common/IpmiBmc.c > > + ../Common/IpmiBmc.h > > + StandaloneMmGenericIpmi.c > > + > > +[Packages] > > + MdePkg/MdePkg.dec > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > + > > +[LibraryClasses] > > + MemoryAllocationLib > > + BaseLib > > + MmServicesTableLib > > + DebugLib > > + StandaloneMmDriverEntryPoint > > + IoLib > > + ReportStatusCodeLib > > + TimerLib > > + > > +[Protocols] > > + gSmmIpmiTransportProtocolGuid # PROTOCOL > ALWAYS_PRODUCED > > + > > +[Guids] > > + > > +[Pcd] > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > > + > > +[Depex] > > + gIpmiTransportProtocolGuid > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cbd1..73dca30caae9 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > @@ -129,4 +129,6 @@ > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > D0000003 > > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > |0xD0000004 > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > 0xD0000005 > > + > > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > 6|0xD0000006 > > -- > 2.26.2.windows.1 > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#109823): > https://edk2.groups.io/g/devel/message/109823 > Mute This Topic: https://groups.io/mt/102076516/7039027 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [abner.chang@amd.com] > -=3D-=3D-=3D-=3D-=3D-=3D > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109984): https://edk2.groups.io/g/devel/message/109984 Mute This Topic: https://groups.io/mt/102076516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-