Re: [edk2-devel] 回复: [PATCH] MdePkg/Include: Add IPMI KCS definitions

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, March 23, 2023 10:19 AM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Chang,
> Abner <Abner.Chang@amd.com>
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; 'Nickle Wang'
> <nicklew@nvidia.com>; 'Igor Kulchytskyy' <igork@ami.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] 回复: [PATCH] MdePkg/Include: Add IPMI KCS
> definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Is that an I/O Port address or an MMIO address?  Can it be either?
In IPMI spec, KCS register base address is defined as I/O mapped 0xca2.
For MCTP over KCS, KCS register base address could be either I/O mapped or memory mapped.

> 
> If it must be I/O Port address, then the PCD name should convey that.
Sounds good. I will update the PCD name.

> 
> If it can be either, then need another PCD to specify the type so the Code
> can do the access with the correct IoLib APIs.
We do have a PCD for KCS access type, but that was defined in the Manageability package and leverage by both IPMI driver, MCTP driver and KCS manageability transport library.

Thanks
Abner
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > gaoliming via groups.io
> > Sent: Wednesday, March 22, 2023 6:37 PM
> > To: abner.chang@amd.com; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; 'Nickle Wang' <nicklew@nvidia.com>; 'Igor
> > Kulchytskyy' <igork@ami.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> > 'Abdul Lateef Attar' <AbdulLateef.Attar@amd.com>
> > Subject: [edk2-devel] 回复: [PATCH] MdePkg/Include: Add IPMI KCS
> > definitions
> >
> > Abner:
> >   This patch also adds one PCD PcdIpmiKcsBaseAddress. I see its
> > default value is 0xca2. Can you add comments for this default value?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: abner.chang@amd.com <abner.chang@amd.com>
> > > 发送时间: 2023年3月3日 10:32
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>;
> > > Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>;
> > > Isaac Oram <isaac.w.oram@intel.com>; Abdul Lateef Attar
> > > <AbdulLateef.Attar@amd.com>
> > > 主题: [PATCH] MdePkg/Include: Add IPMI KCS definitions
> > >
> > > From: Abner Chang <abner.chang@amd.com>
> > >
> > > BZ #4354
> > > This change adds definitions for IPMI KCS.
> > >
> > > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > ---
> > >  MdePkg/MdePkg.dec                         |  5 ++
> > >  MdePkg/Include/IndustryStandard/IpmiKcs.h | 72
> > > +++++++++++++++++++++++
> > >  2 files changed, 77 insertions(+)
> > >  create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h
> > >
> > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > > 3d08f20d15b..0ed033983bf 100644
> > > --- a/MdePkg/MdePkg.dec
> > > +++ b/MdePkg/MdePkg.dec
> > > @@ -9,6 +9,7 @@
> > >  # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development
> > > LP<BR>  # Copyright (c) 2022, Loongson Technology Corporation
> > > Limited. All rights reserved.<BR>  # Copyright (c) 2021 - 2022, Arm
> > > Limited. All rights reserved.<BR>
> > > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > reserved.<BR>
> > >  #
> > >  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -2332,6
> > > +2333,10 @@
> > >    # @Prompt Memory Address of GuidedExtractHandler Table.
> > >
> > >
> gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000
> 0
> > > 00|UINT64|0x30001015
> > >
> > > +  ## This value is the IPMI KCS Interface I/O base address used to
> > transmit
> > > IPMI commands.
> > > +  # @Prompt IPMI KCS Interface I/O Base Address
> > > +
> > >
> gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsBaseAddress|0xca2|UINT16|0x0000
> > > 0031
> > > +
> > >  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
> PcdsDynamicEx]
> > >    ## This value is used to set the base address of PCI express hierarchy.
> > >    # @Prompt PCI Express Base Address.
> > > diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > > b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > > new file mode 100644
> > > index 00000000000..2a51698b126
> > > --- /dev/null
> > > +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h
> > > @@ -0,0 +1,72 @@
> > > +/** @file
> > > +  IPMI KCS Register Definitions
> > > +
> > > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > reserved.<BR>
> > > +  SPDX-License-Identifier: BSD-2-Clause-Patent **/
> > > +
> > > +#ifndef IPMI_KCS_H_
> > > +#define IPMI_KCS_H_
> > > +
> > > +#define IPMI_KCS_STATUS_REGISTER_OFFSET    1
> > > +#define IPMI_KCS_COMMAND_REGISTER_OFFSET   1
> > > +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET  0
> > > +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET   0
> > > +
> > > +///
> > > +/// IPMI KCS Interface Status Bits
> > > +///
> > > +#define IPMI_KCS_OBF           BIT0
> > > +#define IPMI_KCS_IBF           BIT1
> > > +#define IPMI_KCS_SMS_ATN       BIT2
> > > +#define IPMI_KCS_COMMAND_DATA  BIT3
> > > +#define IPMI_KCS_OEM1          BIT4
> > > +#define IPMI_KCS_OEM2          BIT5
> > > +#define IPMI_KCS_S0            BIT6
> > > +#define IPMI_KCS_S1            BIT7
> > > +
> > > +///
> > > +/// IPMI KCS Interface Control Codes /// #define
> > > +IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT  0x60
> > > +#define IPMI_KCS_CONTROL_CODE_WRITE_START       0x61
> > > +#define IPMI_KCS_CONTROL_CODE_WRITE_END         0x62
> > > +#define IPMI_KCS_CONTROL_CODE_READ              0x68
> > > +
> > > +///
> > > +/// Status Codes
> > > +///
> > > +#define IPMI_KCS_STATUS_NO_ERROR      0x00
> > > +#define IPMI_KCS_STATUS_ABORT         0x01
> > > +#define IPMI_KCS_STATUS_ILLEGAL       0x02
> > > +#define IPMI_KCS_STATUS_LENGTH_ERROR  0x06
> > > +#define IPMI_KCS_STATUS_UNSPECIFIED   0xFF
> > > +
> > > +///
> > > +/// KCS Interface State Bit
> > > +///
> > > +typedef enum {
> > > +  IPMI_KCS_IDLE_STATE = 0,
> > > +  IPMI_KCS_READ_STATE,
> > > +  IPMI_KCS_WRITE_STATE,
> > > +  IPMI_KCS_ERROR_STATE
> > > +} IPMI_KCS_STATE;
> > > +
> > > +///
> > > +/// IPMI KCS Interface Request Format /// typedef struct {
> > > +  UINT8    NetFunc;
> > > +  UINT8    Command;
> > > +  UINT8    Data[0];
> > > +} IPMI_KCS_RESQUEST_HEADER;
> > > +
> > > +///
> > > +/// IPMI KCS Interface Response Format /// typedef struct {
> > > +  UINT8    NetFunc;
> > > +  UINT8    Command;
> > > +  UINT8    CompletionCode;
> > > +} IPMI_KCS_RESPONSE_HEADER;
> > > +#endif
> > > --
> > > 2.37.1.windows.1
> >
> >
> >
> >
> >
> > 
> >