From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.79]) by mx.groups.io with SMTP id smtpd.web10.38785.1679478901481839592 for ; Wed, 22 Mar 2023 02:55:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=4qe4jnmW; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.79, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U1UF7hFC2pJdkh6LH7h6zSQr/hiv506BZDrc7RYJKvX7L53IuMh5sPYeYnWizDHZB6ee5FBbalk1pmksZDa0KQmS1ox96ZhLepaKtXD9wDNIygaIoT2e/LLOdFOwfGz1LaWzUEnHflaZFHbEDI/ex0wl8U49rMhxQ5IKaRJGqZVleHRLmbv/3R3RHwWJe0mIz9UYM6dqTZc3pmMwqvmRdokX6zP/cDPwUi/23HjT0x5UUjat7dzewbUVf8Qy6u5UwFRcfNI/IsRkczBstLNdvjjESMd+Sw2TWafoQ82Rtet0nq/wgyvgNRxlTyHyFeahuDEQg8ln26hktx1DxQJy0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EIqkDM7V7bW9CdCIWII+UcX5yNMB4/ZCO4922Tl0tFk=; b=glRFcCG1g5cN2CCH0xlk0krvNWL+devIz81A39AWDyniqOY7Ej/1W6hD/C17pWHgvpR7SvjDllc5FKstqukfTZx37OuAMgsvy1RakCgrGrIYVxjAZQ3UeQPE5tqp3T1myGWt/YZpEnd7YJ32Onanj6OvvHDV6j1siH79djYHPstwJecdjbgHm3MWckEo3ERvcixo1e6wEX60rpdZLOhR975N/UWCg5g8oWex7sp1KY/2B35YRzQy9UiApnQUMlOUXx6Yk6a7LdNRLBJvN/knaurRtH8+4GXy7yoIIV8uGx5EQafBBXkhoG+nRaoc/eCXW+oVut6W0d8C8m0puVs49w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EIqkDM7V7bW9CdCIWII+UcX5yNMB4/ZCO4922Tl0tFk=; b=4qe4jnmWh6fVGdkUMJFhsxUxmY+fJY4Bp4qTfT3o9Fk2jqp02zwShBfgdSnuEKiDwUy3Nz132bRCn4kmfjpEr1IvwEjjPfjXYA66uScI9bKN5VjATW28AJBKss9sqxIoU3Ib600+oLDew1jIspy5+qx1bENvTVUnnnU0Ju+Bkz0= Received: from CH2PR12MB3957.namprd12.prod.outlook.com (2603:10b6:610:2c::17) by CH3PR12MB8306.namprd12.prod.outlook.com (2603:10b6:610:12c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 09:54:59 +0000 Received: from CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::356e:95ec:357b:3472]) by CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::356e:95ec:357b:3472%7]) with mapi id 15.20.6178.037; Wed, 22 Mar 2023 09:54:59 +0000 From: "Chang, Abner" To: "Attar, AbdulLateef (Abdul Lateef)" , Leif Lindholm CC: "devel@edk2.groups.io" , Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Topic: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Index: AQHZWJzK/hdjnQ7YVkyH7BItRXgOQ67/JFoAgAEdZ4CAA2YwgIAAEeuAgABBPYCAAJZEAIACBQFA Date: Wed, 22 Mar 2023 09:54:58 +0000 Message-ID: References: <3c02d9dae4384688b596a6617a8bb05ce84bade7.1679035605.git.abdattar@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-03-22T09:54:56Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=17d4252a-7d40-4469-8e9f-cbfc960e5d25; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB3957:EE_|CH3PR12MB8306:EE_ x-ms-office365-filtering-correlation-id: f339b6ac-eadd-4f02-91d4-08db2abb7f89 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JRxr6wKYguPE6v/4Qgq+LHvMRkhlPA0CtR3L+fCkE34UcnU1S2+ugGkvB+u8nEa8O/O4F5xgHaz9isEpSTpsIo68kXbYiBqzVWtYC+Hv35ey5w1LTs51D/w+HmX2Heq1a/cRFESpxrBcnnqK4AdmzXOty6C1LB8uNKiDOEIdyizTQkWoGjfcs25ab7VVpg4IkZFq2DKjTeR5/uXiGICNEmAFvIoQfbOA6qcbuMQQyTJaHJQ59ogn4fkbT9+cdY+pqgBitexPp6ApQLHWAZJt2mgaFr6ywhqRKh7yVx8W9zgjGv8DPjpkTazKRTCuacXfsZsSYwO2tskKlYtu+EStAV7cBooUzBbmeyGWl2cUAHJ7rbg11b45t3SsEVHePr+PL9PW+B877II7LkIT2t/sbywHFUPFmfM9sm17Gwry3nm2wSyr2fs7CH5ewtLXmTz6wWs53Clkhz50kHHI8KNXq2feCQ8gp1iFj7yu+kOWOM7Eudnu27ITh9UBDwxydNXSstaxb04mcmfFQYAVwHRjie/2fUoB6wKh0i/jRN6ZkyYI4Cb8ltC+OwMYxbdM0ufTZalR1Yjl8c1pDH80sHt02KI+FlIYw9kkWIDds4Eu1iYZxhS9rL1Trj0D5OkWu8fvpM6m3XdXK1t4lCEN6UlfG0MBye7JZi6XV8VptDlyr9jLuG+aJqXuJ8iS/w8kH03U x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3957.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199018)(66899018)(83380400001)(71200400001)(26005)(5660300002)(53546011)(478600001)(186003)(966005)(9686003)(6506007)(7696005)(19627235002)(316002)(55016003)(122000001)(110136005)(33656002)(38100700002)(86362001)(38070700005)(52536014)(66946007)(41300700001)(76116006)(54906003)(64756008)(66476007)(8676002)(2906002)(8936002)(66446008)(4326008)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7Nnjxg/MPi298QheBDZMOg+5/WyCcP7cZIX/r4RvXgHNXW8nMCwzSgyZzHEx?= =?us-ascii?Q?xGybZWDsa1Oh4dz1sm4/+/sAuY9dleEv5YaGw/w8miBsSQNi5+w0VPbUIFO+?= =?us-ascii?Q?dpGmd5bgQxTuQJRt5qNHeTR95zIKRptmifmp1/PVeTUG4tO5Yj+KCw57GaWg?= =?us-ascii?Q?EIf1F5kNoDAR0okzNobFNHUDSFwalC+7m1hkrUL7HAgveGXvr6m5YDnjnyU0?= =?us-ascii?Q?vEKdlmMYmsJwg7sNcYSAFOUPPYQHg+7dyRlUt+WswhoyO8+VOrOlqTYLu9ma?= =?us-ascii?Q?WBdeKJqQvZu2SLbAWhptfCTNw8f1+kUgr7pifNMUoQx/scYsfPSVFF+mOJXw?= =?us-ascii?Q?1w3xwmoTolOfYIqkZh4s+/fgAqpGTl+XjxUOvgUz3BfV7OtgijAoGENcB63Y?= =?us-ascii?Q?LnkYeIE2X5ueaa0I9KOwivzliuGpZhUTcTqt7GFCZTybSCMjShEFLmWQh0te?= =?us-ascii?Q?YXymgu6j4ingGwYJ8BrnCdVwIec0Ze6lmd4noy4Dh7w9ZyZQH9V4iJLxLEY/?= =?us-ascii?Q?iPQVYLgmBsOTIXpR/8MQAA49Q/uDiluFdkVdP9EYdkmLMjXnUAVcUvg5aPwY?= =?us-ascii?Q?d5gc/qpH9hZXakPBV6ifgIq52pB9zM7YuqqiCUSTAB4jM48MTVI0JxPvvhXb?= =?us-ascii?Q?1p0M0ECgw1H9df8Gj2LU9KomcQPqq9XMqqqJM2LK7BFJDfG7V6UjhQgGOBfN?= =?us-ascii?Q?WDsnnB54YeVWsuDkpcQruRclT4GaMZ9rF2xclVCNzKVd9EK8Qw7jdrSgOBxH?= =?us-ascii?Q?X5L9pN/JKIb3nfZhWMKr+PWt0NJRlitAaLXHd1k8XinrQ+Tbqx0rNMGxdDhi?= =?us-ascii?Q?tPnvc5XrdGxDwPOkbJ5fwSsPnv0HISE7SltFadIKLGWynRMnct0y8IyZKJ8+?= =?us-ascii?Q?qM+3uqQXYBuff0mJ8huBD7hdwiykD0LqLdC/eZ5ykPAzgcZ8QKcNALdRpJIR?= =?us-ascii?Q?kTq4UsK2NcZMe8RClhIWL/jVo32DXUxa8sH0SGaXq1TjGluQiTwMdKpsfuPd?= =?us-ascii?Q?u4aCyE+by2IZ5KQIV/MWLeyAk0WpU5WVcL0X1/H0K7rQTnXDWGEFZqLDPK3Q?= =?us-ascii?Q?Tj3RuzkhLR0huwlqHN7eOhnLdqH/TnOXCfXl0l6jSPhq6amnAsGGks1Mu0GD?= =?us-ascii?Q?IvmkHnMKhoBd6A6PI2F8tjzXK59yH/INrqG2odsGEQTBro5gISaIKZwz0f2A?= =?us-ascii?Q?CuWJyfqecUn/t4RbChq2rlWX553sEQ1uB6iWRqbPg9IVmyzM2b5VAbBfr7Kn?= =?us-ascii?Q?LV03bVTlYVcPIGxLiUwcpjr00Pe58xj3dwyxx2Eqdlo4X9UHk818ouHs4EDR?= =?us-ascii?Q?AeXM7Ic5iS3Tw2HN0OM8b78n8JQRiBxsIept+AGtzeZPFntWMzibh6RcMYnT?= =?us-ascii?Q?OPVK+Ni7fZ2R0g4haU699Bt6+02eVHBD6004O0XLKnT9rT5Vw2J+DovlNwFK?= =?us-ascii?Q?NRsYk4XGJC6g8aCHnvMIVubnj+E8K+qWclyZNXadK5w9eoOpXn14pT7CHZw+?= =?us-ascii?Q?10Npc2iEC6EYve6sjBoRWEnsY+8UqXqrb0qEwrgUJiD4lqG5ok59PQabBkt6?= =?us-ascii?Q?VA4lvnp9pL2elmhOCaU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3957.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f339b6ac-eadd-4f02-91d4-08db2abb7f89 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2023 09:54:58.9405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sGmdyGiQGZ9sBAdAd46yK5QWTinfVsnSC+lZ/TtSDHe+dAlFGuL091GgglOA1ni9+GIQfqJ6IebPN0npN5h8Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8306 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Tuesday, March 21, 2023 11:01 AM > To: Leif Lindholm > Cc: devel@edk2.groups.io; Chang, Abner ; Ard > Biesheuvel ; Michael D Kinney > > Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > AMD/BoardPkg and AMD/PlatformPkg maintainers >=20 > [AMD Official Use Only - General] >=20 > Hi Leif, > AMD/BoardPkg will implements modules specific to boards(one or mo= re > motherboards). > It will not contain any module specific to Platform or Silicon, which are= part of > MinPlatformPkg. >=20 > How about just Min prefix? > AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in AMD > folder). I am good with this naming. So we will have AMD boards that leverage MinPla= tform under MinBoardPkg. Those boards which are not Minplatform based can j= ust stay under Platforms/AMD (e.g., OverdriveBoard.), is my understanding c= orrect Abdul? Abner >=20 > AMD board package for MinPlatformPkg > F: Platform/AMD/MinBoardPkg > M: Maintainer1 > M: Maintainer2 >=20 > Thanks > AbduL >=20 > -----Original Message----- > From: Leif Lindholm > Sent: 20 March 2023 23:33 > To: Attar, AbdulLateef (Abdul Lateef) > Cc: devel@edk2.groups.io; Chang, Abner ; Ard > Biesheuvel ; Michael D Kinney > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > AMD/BoardPkg and AMD/PlatformPkg maintainers >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Hi Abdul, >=20 > On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul Lateef) > wrote: > > AMD/BoardPkg will contains the modules/drivers to support > MinPlatformPkg framework. > > BoardPkg will be generic across all AMD boards which are based on > MinPlatformPkg framework. > > It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg". > > We will gradually add modules and libraries to it. >=20 > So, if the purpose is exclusively to support MinPlatformPkg platforms, I = think > that should be part of the name. > Like Platform/AMD/AmdMinPlatformPkg (for example). >=20 > > AMD/PlatformPkg will contain the modules/drivers which are generic to > future AMD platform. > > Currently we don't have complete platform, we can drop > > PlatformPkg for now till we have complete(reasonable modules) > > solution. >=20 > It will certainly be easier to reason about what the preferred naming/lay= out > should be once there is code to look at for examples. > It may be that parts of it would live more naturally under Silicon/AMD, f= or > example. >=20 > > It's better to not touch existing AMD/OverdriveBoard, restructuring > > requires changes to .dsc and .fdf files, might break backward > > compatibility. >=20 > No problem. Config files occasionally need to be revamped, but that's sim= ply > a mechanical exercise. >=20 > > How about having just BoardPkg like below? >=20 > That, too, is a completely generic name that conveys no information about > *what* boards one can expect to find in there. >=20 > Regards, >=20 > Leif >=20 > > AMD board package > > F: Platform/AMD/BoardPkg > > M: Maintainer1 > > M: Maintainer2 > > > > Please let me know your thoughts. > > > > Thanks > > AbduL > > > > > > > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: 20 March 2023 18:35 > > To: devel@edk2.groups.io; Chang, Abner > > Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard > > Biesheuvel ; Michael D Kinney > > > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > > > > Hi Abner, > > > > On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrot= e: > > > I don't see any modules under OverdriveBoard, is this package still > > > > The code is split between Platform/AMD and Silicon/AMD/Styx, the latter > also being used by SoftIron/Overdrive1000 and LeMaker Cello (although tha= t > one is pretty much defunct and should probably be dropped). > > > > > in use? Do you still remember where is FDF and DSC come from (as > > > there is AMD copyright 2014-2016) back to the moment when you was > > > introduced this package? > > > > As the git history tells you: > > --- > > commit f4d38e50c0f24eb78eb003a94f583025621c63db > > Author: Leif Lindholm > > Date: Thu Aug 3 12:24:22 2017 +0100 > > > > Platform,Silicon: import AMD Styx SoC support and platforms > > > > Common files for AMD Overdrive, SoftIron Overdrive 1000 > > and LeMaker Cello, as well as actual platform support. > > Imported from commit efd798c1eb of > > https://git.linaro.org/uefi/OpenPlatformPkg.git > > --- > > > > and the initial commit of the platform in that repository is: > > --- > > From: Leo Duran > > Date: Thu, 20 Aug 2015 13:30:24 -0500 > > > > Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker > > Cello > > > > This adds support for the AMD Seattle based Overdrive and Husky > > platforms, > > and the Lemaker Cello which is derived from it. > > > > This code was tested with upstream EDK2 commit 758ea94651. > > > > The binaries in this branch are based on SeattleFDK 1.0.0.2 > > (Linaro SeattleFDK commit 4b419f2ef2) > > --- > > > > Regards, > > > > Leif > > > > > > > > Thanks > > > Abner > > > > > > > -----Original Message----- > > > > From: Leif Lindholm > > > > Sent: Saturday, March 18, 2023 12:09 AM > > > > To: Attar, AbdulLateef (Abdul Lateef) > > > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > > > > ; Ard Biesheuvel > > > > ; Chang, Abner > ; > > > > Michael D Kinney > > > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > > > > > Caution: This message originated from an External Source. Use > > > > proper caution when opening attachments, clicking links, or respond= ing. > > > > > > > > > > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote: > > > > > From: Abdul Lateef Attar > > > > > > > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg. > > > > > > > > > > Signed-off-by: Abdul Lateef Attar > > > > > Cc: Ard Biesheuvel > > > > > Cc: Leif Lindholm > > > > > Cc: Abner Chang > > > > > Cc: Michael D Kinney > > > > > --- > > > > > Maintainers.txt | 6 ++++++ > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > > > > 747191366070..bb8ab643e090 100644 > > > > > --- a/Maintainers.txt > > > > > +++ b/Maintainers.txt > > > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/ > > > > > M: Ard Biesheuvel > > > > > M: Leif Lindholm > > > > > > > > > > +AMD Platform > > > > > > > > Annoyingly, I'm now going to ask the question I have been avoiding > > > > up until now. What does "AMD Platform" mean? > > > > I mean, you've placed this straight after the entry for the Seattle > platforms. > > > > I think the name, and package names, are too generic. > > > > > > > > / > > > > Leif > > > > > > > > > +F: Platform/AMD/BoardPkg > > > > > +F: Platform/AMD/PlatformPkg > > > > > +M: Abner Chang > > > > > +M: Abdul Lateef Attar > > > > > + > > > > > Ampere Computing > > > > > F: Platform/Ampere > > > > > F: Silicon/Ampere > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > > > >=20 > > > > > >