From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.89]) by mx.groups.io with SMTP id smtpd.web11.10477.1679838947145233548 for ; Sun, 26 Mar 2023 06:55:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=LTT0TyK+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.101.89, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mSDzR5LN9/I90lTfT+r4kfn33LBaVJpP7hnNJTO895sBhoiSTHCC3RfTfiGg9AnFGjE+Ua+wUHPc0qvY7QbcFdoQC2ga2SkRpvwk974KuOQe/D/DteLo4VzaL+CB1VkQ40/XidDkUtnn5xlq2aCJoTKXNilWvYhLwO2mCs5je5kn4F1E6qiActI76HaYnaE2MFCFZyBGbI8SAkZLb/NYI53xS2vAih3+W+1mGDB0+LYzKXBzBnwCw9/KQpppnB+1pPAlA8cH5MRuZ0mVbYUTD1DgdQCkfgvUijn8JOwtGst5xo7PO4MPgB6G70DXxfMxrRrpPPzHtk1nu+8iFZ7b4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zpVNodAARyithDpVlJHw5bNrc2N/b9q1SZ3ysXZN4uw=; b=RC5gceMIGakFq2jqKoY2UxheeaorrscIFRocd3s6Z9tmzhibr6NvS0qrvCmx2LheJnlYjiNc1ackylpIZd55ZHpVlFSyTC843EiLbJs0nevby5CSEdlIIsxjosZJWRWBRHbIP+0brKJq5Hz+IqURMlnkHx3fgzPQTeUVVuKft9LFeKGf6rhJ/Lseg9JUCZ36ea5oUEkGzQJTBj/S+/7EU2yqAdMcglob0ZdfMf051oOLef+YP4fXOOWa5o0ViZizkyA3s+8xrthQSUYtU4JDUR49LsUpWepkJjG6asxdPxfw3nWk/tCvKUk+tYwlVb+EBR7sGX14+J1LrLItV15mEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zpVNodAARyithDpVlJHw5bNrc2N/b9q1SZ3ysXZN4uw=; b=LTT0TyK+kMDGquBGq9sizJUZq1ZpzKEw3e2yfeeHSkmUtTDYYWIg4qDq2zlivSXGwzuByPODOYlXYpWDiakeKWF1NeQ0iBMbFfGr1KspXDZ8GqtdRmJJ/7xkaqJvWbTGN6X0vU4nXWcqqQOhHUCsnO2K9qy+EH4xIv0hC270b7w= Received: from CH2PR12MB3957.namprd12.prod.outlook.com (2603:10b6:610:2c::17) by MW3PR12MB4347.namprd12.prod.outlook.com (2603:10b6:303:2e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.28; Sun, 26 Mar 2023 13:55:44 +0000 Received: from CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::356e:95ec:357b:3472]) by CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::356e:95ec:357b:3472%7]) with mapi id 15.20.6178.041; Sun, 26 Mar 2023 13:55:44 +0000 From: "Chang, Abner" To: "Kinney, Michael D" , "devel@edk2.groups.io" , Nickle Wang , "Oram, Isaac W" , Leif Lindholm , Andrew Fish CC: "Gao, Liming" , "Liu, Zhiguang" , Igor Kulchytskyy , "Attar, AbdulLateef (Abdul Lateef)" Subject: Re: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions Thread-Topic: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS definitions Thread-Index: AQHZXjEYbeu57eJzrEqJ7e75yCDMyq8LodgwgADZjsA= Date: Sun, 26 Mar 2023 13:55:44 +0000 Message-ID: References: <20230324091418.1095-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-Mentions: michael.d.kinney@intel.com,nicklew@nvidia.com,isaac.w.oram@intel.com,quic_llindhol@quicinc.com,afish@apple.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-03-26T13:55:40Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=4e9acb9d-5532-4f31-b2bf-56d8d80bda69; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB3957:EE_|MW3PR12MB4347:EE_ x-ms-office365-filtering-correlation-id: dfdacf60-145e-4275-4b2c-08db2e01cb1f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TFScQ/8y2WA2jvqam3NH58cloliaharEDtgZ/ujYtLsnNN5CWbbpfaVoO6YuKN7b9b4ZUOaqlkmI4IAm5STdgt/SyiBFVFvBk/q1uCgi4ct1+w4jaudcwrE6rvRbvesxG4Zq3F9PU46cN/45b61H9IgpUC6DJSSQ6vot/xiCwOyJ7Jzcgx6U6bHiR0l6GD42vEE7hf7FpGdbZeW9D7wzTAumhiGsw+GUhleruSoUJhTM3SaYA8qH+PBWNWtsIcoqI3rGWTquDgWeXoKOFPxD+LhzpA7K7l60gjcXXV5d6tIdYRCG4brgs9H9reOHTLS+OsuoB+tB3YXAgYuixZTPWLj/61u7ZchMZBiaWqxy4GpfShA9nBrZOUHdzgTJHpYiaqrzwqt8TF45DJysQLekfnirskKrft6MZFek7TzBe+lBqNP32bkCxioeWa0rHXCnkA7HMuk/+Ldi5Mug4XoGyEGZJ6SvvPmX6Q/DflbaL70C/sJ9QHiez4NQo82tHYpC9+YzgVRdwtAHpD2UiqHmR2/lMm8uWNWZRPYJePtrm1GtWrK3rfKLO86jYxW+0ZFOY0Cx8qk91IlkbeV4AWOn9pth1NWPGjO8n7QGP0Q6fmN2QX03lymfx5XQEMXcHQVTPIRTHQEqV6p17NAMcbtz3g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3957.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199021)(83380400001)(76116006)(4326008)(66446008)(66476007)(66946007)(66556008)(64756008)(8676002)(966005)(54906003)(7696005)(71200400001)(478600001)(53546011)(9686003)(6506007)(26005)(186003)(110136005)(316002)(55016003)(38070700005)(2906002)(166002)(33656002)(86362001)(41300700001)(52536014)(38100700002)(5660300002)(8936002)(122000001)(66899021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QsavZM5u2v7MeY71JGggrft27pcDT8CXWjCN1kBH3Rkhm3RiQXPi+dzoKnp1?= =?us-ascii?Q?HmOkNcNZ6bcjLZt05bQErM3E9Pm66Ok5OV7lE+xhNlC9dlA5kRZpHNeNEvx4?= =?us-ascii?Q?jsxx+xIPcgvDPiHNOO4Hk8cfylooXosC11GXRRasB8l8FYQg/6ELMdId8Qkw?= =?us-ascii?Q?1D8E9foY4w4EgM74KlbspZ4Lomw2uzDxqJ8jgpcoUhbFqZk+vQNl5cI7iJot?= =?us-ascii?Q?NMgsviRPOAHRMSTqQ5DRurk5P3J6vBBisbU0NeJPINpCSveF6fRoWQln6Ug2?= =?us-ascii?Q?FWwTPz12nfbLI4C9+DppsDgNdxdjvAbfk7eN9tdTet/henLp/MchEgfQ+DXt?= =?us-ascii?Q?5NOE8WZFHzpBdext6niWZnYvUKOGOgVmgbmV7amwQdkbgkmBXpRSjQv1ux/F?= =?us-ascii?Q?w5LkLrAsJWGZ5x0fVa7skJUQgnGIIy0iGSZNO7e0vSlHYUEteoQur9Cyibct?= =?us-ascii?Q?RhSJR+nkBnyHrKv+HZBU+k8sMQySvhgGIN8XtHuksM59KS5+/Jum2tDXUBOJ?= =?us-ascii?Q?aij1frPZ/nJV6fCBNQ9HkOTx9rLbPWBnfZ36Iw7OVuBykGAYR+C+14LmNz0P?= =?us-ascii?Q?56v/ERE+TKvS+R200kFSyNoGRexo7wvre1KnNVHOXGoFJwldUIjHCITIbw8T?= =?us-ascii?Q?0DZW1p77I7zCUanDAMRXnoGQyIfLwzlEeV4W7yAoRMYJ66IbFl9GjbHWON9a?= =?us-ascii?Q?9E3gQEFtDwhYYuiOq3sACnqcUIYOHOLwLliara5wOJ6l0Y2rUzRVv5jsIbEY?= =?us-ascii?Q?53jp5j3RMdmdyoNlF7V8TKursP9Azfi/NUjT28xCXsMbAKH3VgqzUyxfpa+A?= =?us-ascii?Q?jLeCSKMYcu1cSTHINDopSSrSYYcllux170w5kinr6LgDyxZNmDbFQ0rpXQ7U?= =?us-ascii?Q?uB6e6xU5yeL1CsLl+HayfA48vvWqK6ijnyNt5ZlIDK+/7PnFr5jl1S10NDzb?= =?us-ascii?Q?gJsHH7A+24QQH1t2GuZTuzO0JDiNmQzlR16DCS66SC+sUErGp1zYiEcZQjnD?= =?us-ascii?Q?XieBRTpFgmOBqaDk67dkFPqDDXcgB4QMMnLrRy9OPMxVgGi54YGcDu67T6cP?= =?us-ascii?Q?kC3MiX/BlcuAD9IN1t9/BMdX7pJTdVM4eyb5jKBJI28Vwj6hpPtomeQXVSgC?= =?us-ascii?Q?O2s91QD78RTiOE9+VQzHEmLxzI+Q2WPA1+P95R4F9aV8D8nN9AdVkd5mkjAZ?= =?us-ascii?Q?bgvcLwL/XTkRjmfIT82lSyaGg0DTrbwimFVapacm8zBXgj4n40h3blFKuqVD?= =?us-ascii?Q?3uCl8YMtghFuxgPT75IbLRbQ6rtCOuxBDrmZ/hUE8TwPUTKKIwtpPNnu3Yt9?= =?us-ascii?Q?MpvTwv4GEx1zMWy1CGaLTFZ55+4wH3bFW3UbCDX2Y6mlWCHpYogn0rNgfwP6?= =?us-ascii?Q?dhIpNzmrntXI49XxIAFIbmhxYsbNKZeKpQ5IcsLE9+Bdmi0gpm6LyBqJ+4aW?= =?us-ascii?Q?93tw5vNDC+xuIU/4KmiNPCAjlWeZFKq1T3wWMfj97ZsAsMiPRthlXLCfCmnx?= =?us-ascii?Q?1a3db6aR68WO6XJMSCkW53XK8BA5UEgLh3Z99dTZEHUxacfefsSOOREZL/uj?= =?us-ascii?Q?MdTEk11AooRLaGqxxkQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3957.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfdacf60-145e-4275-4b2c-08db2e01cb1f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2023 13:55:44.0415 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IA52Yc85aeHz5cY9CndKXmcTu64YpbqjfMyBXpRjtnY5as4Gg3D6ZtZTL+cwF/5wqwFY/KBHEgI+sI8FF9YgrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4347 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CH2PR12MB3957E728E4CF258D5DA04FBAEA8A9CH2PR12MB3957namp_" --_000_CH2PR12MB3957E728E4CF258D5DA04FBAEA8A9CH2PR12MB3957namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks Mike, IPMI KCS: https://github.com/tianocore/edk2/pull/4184 MCTP: https://github.com/tianocore/edk2/pull/4183 We also fixed the ECC error in these two PRs, please also help to push it. @Kinney, Michael D, @Leif Lindholm, @Andrew Fish Hi stewards, I would like to be the maintainer for *IPMI* and *MCTP* files under both Md= ePkg and MdeModulePkg. I will send the Maintainers.txt update for that if y= ou have no concerns. Will also invite Isaac @Oram, Isaac W from I= ntel and Nickle @Nickle Wang from Nvidia as revi= ewers. Thanks Abner > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, March 25, 2023 11:33 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Gao, Liming ; Liu, Zhiguang > ; Nickle Wang ; Igor > Kulchytskyy ; Oram, Isaac W ; > Attar, AbdulLateef (Abdul Lateef) ; Kinney, > Michael D > Subject: RE: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS > definitions > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Reviewed-by: Michael D Kinney > > > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Chang, > > Abner via groups.io > > Sent: Friday, March 24, 2023 2:14 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D >; Gao, Liming > > >; Liu, Zhigu= ang >; > > Nickle Wang >; Igor Kulch= ytskyy >; > > Oram, Isaac W >; = Abdul Lateef Attar > > > > > Subject: [edk2-devel] [PATCH v5] MdePkg/Include: Add IPMI KCS > > definitions > > > > From: Abner Chang > > > > > BZ #4354 > > This change adds definitions for IPMI KCS. > > > > Spec ref: > > > https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i > pm > > i-second-gen-interface-spec-v2-rev1-1.html > > > > Signed-off-by: Abner Chang > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Zhiguang Liu = > > > Cc: Nickle Wang > > > Cc: Igor Kulchytskyy > > > Cc: Isaac Oram > > > Cc: Abdul Lateef Attar > > > Acked-by: Isaac Oram > > > --- > > MdePkg/MdePkg.dec | 6 ++ > > MdePkg/Include/IndustryStandard/IpmiKcs.h | 76 > > +++++++++++++++++++++++ > > 2 files changed, 82 insertions(+) > > create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > 2d643bede1d..5cf04bc0cb6 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -9,6 +9,7 @@ > > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development > > LP
# Copyright (c) 2022, Loongson Technology Corporation Limited. > > All rights reserved.
# Copyright (c) 2021 - 2022, Arm Limited. > > All rights reserved.
> > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2342,6 +2343,11 > > @@ > > # @Prompt Memory Address of GuidedExtractHandler Table. > > > > > gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000 > 000 > > |UINT64|0x30001015 > > > > + ## This value is the IPMI KCS Interface I/O base address used to tra= nsmit > IPMI commands. > > + # The value of 0xca2 is the default I/O base address defined in IPM= I > specification. > > + # @Prompt IPMI KCS Interface I/O Base Address > > + > > + > gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00 > 00 > > + 0031 > > + > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > > ## This value is used to set the base address of PCI express hierarc= hy. > > # @Prompt PCI Express Base Address. > > diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h > > b/MdePkg/Include/IndustryStandard/IpmiKcs.h > > new file mode 100644 > > index 00000000000..7b3ba45bf9d > > --- /dev/null > > +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h > > @@ -0,0 +1,76 @@ > > +/** @file > > + IPMI KCS Register Definitions > > + > > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > + @par Revision Reference: > > + IPMI Specification > > + Version 2.0, Rev. 1.1 > > + > > > +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ > ip > > +mi-second-gen-interface-spec-v2-rev1-1.html > > +**/ > > + > > +#ifndef IPMI_KCS_H_ > > +#define IPMI_KCS_H_ > > + > > +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1 > > +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1 > > +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0 > > +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0 > > + > > +/// > > +/// IPMI KCS Interface Status Bits > > +/// > > +#define IPMI_KCS_OBF BIT0 > > +#define IPMI_KCS_IBF BIT1 > > +#define IPMI_KCS_SMS_ATN BIT2 > > +#define IPMI_KCS_COMMAND_DATA BIT3 > > +#define IPMI_KCS_OEM1 BIT4 > > +#define IPMI_KCS_OEM2 BIT5 > > +#define IPMI_KCS_S0 BIT6 > > +#define IPMI_KCS_S1 BIT7 > > + > > +/// > > +/// IPMI KCS Interface Control Codes > > +/// > > +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60 > > +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61 > > +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62 > > +#define IPMI_KCS_CONTROL_CODE_READ 0x68 > > + > > +/// > > +/// Status Codes > > +/// > > +#define IPMI_KCS_STATUS_NO_ERROR 0x00 > > +#define IPMI_KCS_STATUS_ABORT 0x01 > > +#define IPMI_KCS_STATUS_ILLEGAL 0x02 > > +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06 > > +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF > > + > > +/// > > +/// KCS Interface State Bit > > +/// > > +typedef enum { > > + IPMI_KCS_IDLE_STATE =3D 0, > > + IPMI_KCS_READ_STATE, > > + IPMI_KCS_WRITE_STATE, > > + IPMI_KCS_ERROR_STATE > > +} IPMI_KCS_STATE; > > + > > +/// > > +/// IPMI KCS Interface Request Format /// typedef struct { > > + UINT8 NetFunc; > > + UINT8 Command; > > + UINT8 Data[]; > > +} IPMI_KCS_REQUEST_HEADER; > > + > > +/// > > +/// IPMI KCS Interface Response Format /// typedef struct { > > + UINT8 NetFunc; > > + UINT8 Command; > > +} IPMI_KCS_RESPONSE_HEADER; > > +#endif > > -- > > 2.37.1.windows.1 > > > > > > > >=20 > > --_000_CH2PR12MB3957E728E4CF258D5DA04FBAEA8A9CH2PR12MB3957namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Officia= l Use Only - General]

 

Thanks Mike,

 

IPMI KCS: https://github.com/tianocore/edk2/pull/4184

MCTP: https://github.com/tianocore/edk2/pull/4183

We also fixed the ECC error in these two PRs, ple= ase also help to push it.

 

@Kinney, Michael D, @Leif Lindholm, @Andrew Fish

Hi stewards,

I would like to be the maintainer for *IPMI* and = *MCTP* files under both MdePkg and MdeModulePkg. I will send the Maintainer= s.txt update for that if you have no concerns.

Will also invite Isaac @Oram, Isaac W from Intel and Nickle @Nickle Wang from Nvidia as reviewers.

Thanks

Abner

 

> -----Original Message-----

> From: Kinney, Michael D <michael.d.kinney= @intel.com>

> Sent: Saturday, March 25, 2023 11:33 PM=

> To: devel@edk2.groups.io; Chang, Abner <A= bner.Chang@amd.com>

> Cc: Gao, Liming <gaoliming@byosoft.com.cn= >; Liu, Zhiguang

> <zhiguang.liu@intel.com>; Nickle Wang = <nicklew@nvidia.com>; Igor

> Kulchytskyy <igork@ami.com>; Oram, Isa= ac W <isaac.w.oram@intel.com>;

> Attar, AbdulLateef (Abdul Lateef) <AbdulL= ateef.Attar@amd.com>; Kinney,

> Michael D <michael.d.kinney@intel.com>=

> Subject: RE: [edk2-devel] [PATCH v5] MdePkg/= Include: Add IPMI KCS

> definitions

>

> Caution: This message originated from an Ext= ernal Source. Use proper

> caution when opening attachments, clicking l= inks, or responding.

>

>

> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

>

> > -----Original Message-----

> > From: devel@edk2.gro= ups.io <devel@edk2.groups.io&= gt; On Behalf Of Chang,

> > Abner via groups.io

> > Sent: Friday, March 24, 2023 2:14 AM

> > To: devel@edk2.group= s.io

> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming

> > <gaoliming@by= osoft.com.cn>; Liu, Zhiguang <zhiguan= g.liu@intel.com>;

> > Nickle Wang <nickle= w@nvidia.com>; Igor Kulchytskyy <igork@ami.com= >;

> > Oram, Isaac W <= isaac.w.oram@intel.com>; Abdul Lateef Attar

> > <AbdulLateef= .Attar@amd.com>

> > Subject: [edk2-devel] [PATCH v5] MdePkg= /Include: Add IPMI KCS

> > definitions

> >

> > From: Abner Chang <abner.chang@amd.com>

> >

> > BZ #4354

> > This change adds definitions for IPMI K= CS.

> >

> > Spec ref:

> >

> https://www.intel.com= /content/www/us/en/products/docs/servers/ipmi/i

> pm

> > i-second-gen-interface-spec-v2-rev1-1.h= tml

> >

> > Signed-off-by: Abner Chang <abner.chang@amd.com>

> > Cc: Michael D Kinney <michael.d.kinney@intel.com>

> > Cc: Liming Gao <gaoliming@byosoft.com.cn>

> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>

> > Cc: Nickle Wang <ni= cklew@nvidia.com>

> > Cc: Igor Kulchytskyy <ig= ork@ami.com>

> > Cc: Isaac Oram <isaac.w.oram@intel.com>

> > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>

> > Acked-by: Isaac Oram <isaac.w.oram@intel.com>

> > ---

> >  MdePkg/MdePkg.dec  &nbs= p;             =          |  6 ++

> >  MdePkg/Include/IndustryStandard/I= pmiKcs.h | 76

> > +++++++++++++++++++++++

> >  2 files changed, 82 insertions(+)=

> >  create mode 100644 MdePkg/Include= /IndustryStandard/IpmiKcs.h

> >

> > diff --git a/MdePkg/MdePkg.dec b/MdePkg= /MdePkg.dec index

> > 2d643bede1d..5cf04bc0cb6 100644

> > --- a/MdePkg/MdePkg.dec

> > +++ b/MdePkg/MdePkg.dec

> > @@ -9,6 +9,7 @@

> >  # (C) Copyright 2016 - 2021 Hewle= tt Packard Enterprise Development

> > LP<BR>  # Copyright (c) 2022= , Loongson Technology Corporation Limited.

> > All rights reserved.<BR>  # = Copyright (c) 2021 - 2022, Arm Limited.

> > All rights reserved.<BR>

> > +# Copyright (C) 2023 Advanced Micro De= vices, Inc. All rights

> > +reserved.<BR>

> >  #

> >  # SPDX-License-Identifier: BSD-2-= Clause-Patent  # @@ -2342,6 +2343,11

> > @@

> >    # @Prompt Memory Addr= ess of GuidedExtractHandler Table.

> >

> >

> gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHan= dlerTableAddress|0x1000

> 000

> > |UINT64|0x30001015

> >

> > +  ## This value is the IPMI KCS I= nterface I/O base address used to transmit

> IPMI commands.

> > +  #  The value of 0xca2 is t= he default I/O base address defined in IPMI

> specification.

> > +  # @Prompt IPMI KCS Interface I/= O Base Address

> > +

> > +

> gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAdd= ress|0xca2|UINT16|0x00

> 00

> > + 0031

> > +

> >  [PcdsFixedAtBuild, PcdsPatchableI= nModule, PcdsDynamic, PcdsDynamicEx]

> >    ## This value is used= to set the base address of PCI express hierarchy.

> >    # @Prompt PCI Express= Base Address.

> > diff --git a/MdePkg/Include/IndustrySta= ndard/IpmiKcs.h

> > b/MdePkg/Include/IndustryStandard/IpmiK= cs.h

> > new file mode 100644

> > index 00000000000..7b3ba45bf9d

> > --- /dev/null

> > +++ b/MdePkg/Include/IndustryStandard/I= pmiKcs.h

> > @@ -0,0 +1,76 @@

> > +/** @file

> > +  IPMI KCS Register Definitions

> > +

> > +  Copyright (C) 2023 Advanced Mic= ro Devices, Inc. All rights

> > + reserved.<BR>

> > +  SPDX-License-Identifier: BSD-2-= Clause-Patent

> > +

> > +  @par Revision Reference:

> > +  IPMI Specification

> > +  Version 2.0, Rev. 1.1

> > +

> >

> +https://www.intel.com/content/www/us/en/pro= ducts/docs/servers/ipmi/

> ip

> > +mi-second-gen-interface-spec-v2-rev1-1= .html

> > +**/

> > +

> > +#ifndef IPMI_KCS_H_

> > +#define IPMI_KCS_H_

> > +

> > +#define IPMI_KCS_STATUS_REGISTER_OFFSE= T    1

> > +#define IPMI_KCS_COMMAND_REGISTER_OFFS= ET   1

> > +#define IPMI_KCS_DATA_OUT_REGISTER_OFF= SET  0

> > +#define IPMI_KCS_DATA_IN_REGISTER_OFFS= ET   0

> > +

> > +///

> > +/// IPMI KCS Interface Status Bits

> > +///

> > +#define IPMI_KCS_OBF   =         BIT0

> > +#define IPMI_KCS_IBF   =         BIT1

> > +#define IPMI_KCS_SMS_ATN  &n= bsp;    BIT2

> > +#define IPMI_KCS_COMMAND_DATA  BI= T3

> > +#define IPMI_KCS_OEM1   = ;       BIT4

> > +#define IPMI_KCS_OEM2   = ;       BIT5

> > +#define IPMI_KCS_S0   &= nbsp;        BIT6

> > +#define IPMI_KCS_S1   &= nbsp;        BIT7

> > +

> > +///

> > +/// IPMI KCS Interface Control Codes

> > +///

> > +#define IPMI_KCS_CONTROL_CODE_GET_STAT= US_ABORT  0x60

> > +#define IPMI_KCS_CONTROL_CODE_WRITE_ST= ART       0x61

> > +#define IPMI_KCS_CONTROL_CODE_WRITE_EN= D         0x62

> > +#define IPMI_KCS_CONTROL_CODE_READ&nbs= p;             = 0x68

> > +

> > +///

> > +/// Status Codes

> > +///

> > +#define IPMI_KCS_STATUS_NO_ERROR =      0x00

> > +#define IPMI_KCS_STATUS_ABORT &nb= sp;       0x01

> > +#define IPMI_KCS_STATUS_ILLEGAL &= nbsp;     0x02

> > +#define IPMI_KCS_STATUS_LENGTH_ERROR&n= bsp; 0x06

> > +#define IPMI_KCS_STATUS_UNSPECIFIED&nb= sp;  0xFF

> > +

> > +///

> > +/// KCS Interface State Bit=

> > +///

> > +typedef enum {

> > +  IPMI_KCS_IDLE_STATE =3D 0,=

> > +  IPMI_KCS_READ_STATE,=

> > +  IPMI_KCS_WRITE_STATE,

> > +  IPMI_KCS_ERROR_STATE=

> > +} IPMI_KCS_STATE;

> > +

> > +///

> > +/// IPMI KCS Interface Request Format = /// typedef struct {

> > +  UINT8    NetFunc= ;

> > +  UINT8    Command= ;

> > +  UINT8    Data[];=

> > +} IPMI_KCS_REQUEST_HEADER;<= /p>

> > +

> > +///

> > +/// IPMI KCS Interface Response Format= /// typedef struct {

> > +  UINT8    NetFunc= ;

> > +  UINT8    Command= ;

> > +} IPMI_KCS_RESPONSE_HEADER;=

> > +#endif

> > --

> > 2.37.1.windows.1

> >

> >

> >

> >

> >

 

--_000_CH2PR12MB3957E728E4CF258D5DA04FBAEA8A9CH2PR12MB3957namp_--