From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 85CF894107E for ; Tue, 24 Oct 2023 05:07:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kum8S2YIomEfGQQu97OtnzM/BDZamq47mOU8WySHvdU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698124048; v=1; b=vcjI5Bx6GiupuzwwM4ouu+5rtxAyTSY0NiVPDsIm/XOjsaEp8y2CcCdQR3cFIRYwbpa+ybNG blmRaXGZw5MdV8933nggJgANqKimxbaXJOuB1/iEv19VhrjUWVTZQzUct6Nre7WsgE0jQG+F7oD O9mvpuON/HD2HL3D/87uU4bc= X-Received: by 127.0.0.2 with SMTP id isv2YY7687511xj0xt9tMgJV; Mon, 23 Oct 2023 22:07:28 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.73]) by mx.groups.io with SMTP id smtpd.web10.141318.1698124047332110248 for ; Mon, 23 Oct 2023 22:07:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k+5F6TVyt8qr4KD89v46Zd7qzDHL0ihx8l7PASN0AcTNhyB9q5CmsEkh9qlyGd4PciUBndzmy4ELZX0H44VdzM/2lFvJwixhAXbjKql63uWFRhrfydGQhCz2uzOS9PtQMGMzm2VOk+cJEAm2xR8BhZqSxWrleQmClvrZmtZuMlsB9yOTQH+u+0z6580OeVHD9SgHjpv5h+ZmcAgpZRLzDPWhfQaN55kXFkKjDj4607jnVsgH+p4qk9+/PBhbZWwzHFwvQAg8r0HVSbPjs3dXODGZ2m9epHXhIxweBaRNt2uugQMshuuqeFsERjvf34PzVUdExhNiW6ReEzZggxn9vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J4R16aR6S2+l+TjAPZ9h6VrlTdSEV0/s47Dlfa9nV8c=; b=FQbyQsnSmB3ifkMrD8WvjWUnP/q0dl2klElwOOTTTMNMQzENGgKUkbwyiPKC7d0EP1uE7CAwNDyRzA4zdCVtDfZRwL1l4aOYCX/ShQCkf2Ninuo+dOjL++FzKdyA7JIHw9K7qiB+rF5YoEOCY4OWKTM8MuyRQLdm2U5y3pheAhl+Gjv0d+MQcXVwpPAeB54hJKAxLnitvNoICFktkIleUclXgQN7cGoriFh8VfG8KmUcb6bLVbT1Nr7iMrqRQYUkm7VBxztzsucr9VRRzsVsUHF+anXUdzJ2vBV70ppdTn5sLMZK+Nr6yGcKHYc4BawheCn3GvairJaco6GctlRU2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from CH2PR12MB3957.namprd12.prod.outlook.com (2603:10b6:610:2c::17) by DS7PR12MB6144.namprd12.prod.outlook.com (2603:10b6:8:98::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Tue, 24 Oct 2023 05:07:24 +0000 X-Received: from CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::ed0:5e27:ff94:5d4f]) by CH2PR12MB3957.namprd12.prod.outlook.com ([fe80::ed0:5e27:ff94:5d4f%6]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 05:07:24 +0000 From: "Chang, Abner via groups.io" To: "Huang, Li-Xia" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Wu, Yidong" , "Xu, Wei6" Subject: Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaAyEmQZRi0Xh2AE2Iy6Gd4leWvrBUSH3AgAJVdjCAAciDwA== Date: Tue, 24 Oct 2023 05:07:24 +0000 Message-ID: References: <20231020064616.6637-1-lisa.huang@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f5680497-faff-4ef9-95fb-0d394246569a;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-21T14:03:32Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR12MB3957:EE_|DS7PR12MB6144:EE_ x-ms-office365-filtering-correlation-id: c406c4d8-5c71-427a-18cc-08dbd44f1c13 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: YjEKFTplayt0QdY+CZoTeuHloKtKYZ828ltmnaA4LWBsM8Tcm6SSasm/iGeEpsa1LKFGLGZrnQdW1Yv1sc+PUrXJi8y8X5LlJ3E8BNqgIacAvZ/3wf+Cd5rE4lP4t0EFtJZUvJTEjgsqRlgjAxQz+kl5tLYrLmRfodO/uUKElkP5hEHzW2qVRbisXLmORCqhFzQOaJHHPRoO+F2K5ECpg9sfANhKqNOdoWtOTz6t+jBgBKBjyX/UdkQmatcID2WfhV1HjSAW8F8vuWKkNdwwRo85/LEvwK6iy6aldsNv/ryJcd/PAXsxIuDf2BGssToFOCKRAfjgcPnyau7ksl5EaJePDBT6H3Ky758+SIgPTAIWjkHm0aF96GWZo39pGFH9MEkB2uhAuxE9MsM/EDvKoqyMhOtGeS1tE/0GcZ5y9u/IGn0DUyFyUua0nWWctBkQtBKJ5NpmwwCTq9eZE3GFdN8iLqeTtSd+BWTgeOv1ozcUu7clRcsefukGCA0+H5kRQ7FpwU7Gf5M9UjcI/J6cAhpj0QIJ22JzPXtDnqGY1HFAfzjGR6/mIcami/donc+p55dQqAe+db5Xm0umAAMp8nX5UbUyikm/K7dxpas0zvM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qsR9+vpz9xyACniodCxBkUIO+bu0JNT98y81AEzGkgYYU4RksOiyI13RmmLm?= =?us-ascii?Q?XHysvcllxvCyYWsrzDBqF63SdEwywT5x+Rr03K7/u1VROLf2dYqAGfQFLHf3?= =?us-ascii?Q?/mjLuX+rjheRTuhEUgtw2uYHMey4/XWFV5DVkeAG5rXtaLSQRfnB/+VUFpmw?= =?us-ascii?Q?Cw49+pD1qj3s1dPuXiAIdcCc4ah4ttu2/tReSsZj0hkmoB7AW0x3hnH0d1Gf?= =?us-ascii?Q?YL7M4XgBZDAqqued7pZ8xoMMMoERcIWgq087eC+mn1mSpqjyAVFMIjtMqpHz?= =?us-ascii?Q?oW7kez3FtclVeC0t+ju/uhv5fRr4AoN1U9B1nV6cd9D2u+RhyjCoPmoUMhBG?= =?us-ascii?Q?aESxpWTODSe322tXjV07TGzU/6XEglCHr5ucSd/caJ0fOXUEP7WG6LxoKa75?= =?us-ascii?Q?naYGTxGFvod0qBAyD8IjZ7clvestCdjieHdIob6rP3g90OEGd7Iyg0XffSEj?= =?us-ascii?Q?Na6O0klTX1Fm8z5QuU8HMnw/B9Pf+Qh1QBG01u7gMw841+pluxhz/Hel89He?= =?us-ascii?Q?Iu9EL3Nqb/XQ/jT86vyIoDJZY5Mp37sVVcjHzcouzcx8v/pdE8g8Uys6GZzs?= =?us-ascii?Q?qoR4gs+Y61GjL7SfSvkaAvtlF7Y3fxuNN9aNDh2TU6UBPO1jygqcg3jpoiQT?= =?us-ascii?Q?hCojDLEu22F4cw54EbXsm+7431j+w0x2J+2o/ArHfEbxuYL9W0Qa+EQKODwx?= =?us-ascii?Q?W3wWZWSvT7xeAubJ0XDrA9IuJh8k3j0H/7c/IYXe2QtGTlhK+EnBU1U8r57U?= =?us-ascii?Q?+JaoSzLOS3IRQSk4EXuT2CQTuBQENDszIRChKhfVlEeG/Wwln6HDjj6ss6wc?= =?us-ascii?Q?EaxVIEvif5VF4Iefj/V/fdIABAcPkefWnfRw9+5iKR3Q3W/FRkxwLEJkmbUk?= =?us-ascii?Q?OP9Vk95qigdBzQlCXqoyJbJrTC8iALbHUJlbE93OqmoqvUCYk5TtH8vUbvld?= =?us-ascii?Q?voo8RlHa8Ide9WliVvzsM6/qJ28poWX6xFp1iCy0K0vbJjE+HjzmdHGCO5d/?= =?us-ascii?Q?aCdbWfx5FMpyQNxdE72NVjYVooyUwLu/YPaRB/t75DsE0GBIn9esp1ZHTXPK?= =?us-ascii?Q?WsO+vk/QGk0qKg2/llZV1AhqGFKJzOqaS5lTTwd3jMIRC8TATEp0ltdT+I87?= =?us-ascii?Q?tqqX9ZJr40l0zcl1SVCm04IjmaDmqBFbgOXxeAvbMBOyQrv9A6pLZ9K/DFXU?= =?us-ascii?Q?Lj4q0t1L5KC9P7MW2aqVFjSG4r2/aZ2LhlFXzJJZJoeVdLIkYsifYiUakEL0?= =?us-ascii?Q?WmGPGIpKX5gQoM6QoM3FwA0Is2MrdFjCYdDz6eF4df4LMEo6UIjKwnTMwcRh?= =?us-ascii?Q?mr7yKExAgiFL+U2MpS+WMdYxWAxB/HPjDPJs9VJYB5aTpTribHrcWENV5Yjb?= =?us-ascii?Q?nNAhojeCq24o3xHgQXpEtUduj17ghK0XYmPCpTc36GXotySCbCA6fp9DPZ3T?= =?us-ascii?Q?JgwqIc4/MiZMBymRKsZRbgl79lu5miDJxuSIkvVH4HJM6/s0dDoicFd5nwR8?= =?us-ascii?Q?FSV+odf7ieSYGyBSausKwnPUM3aHoAJ42x9J7ZDYlvkzm7BiUJ1RC3pi0tOC?= =?us-ascii?Q?4hBNO3nz4mqU55AjnvRW/a4ivzrQJYu2+Z7dYaOn?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3957.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c406c4d8-5c71-427a-18cc-08dbd44f1c13 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2023 05:07:24.1416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8VEe0rUCBVfGi0SdTk3HCRXQFJnYH3zgYqCyke9aftzMm76JfiVlYZ5+vru6k2bUdln9ZCdNyV/u7hNB97Zpxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6144 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7XKkbYz9bV8ZFUs4rD8tmOlqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vcjI5Bx6; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Issac is removed. Hi Lisa, These two packages are diverging in IPMI transport (GenricIpmi) and some ot= her high level drivers such as IpmiCommandLib. I plan to take below actions= . 1. Remove IpmiCommandLib from IpmiFeaturePkg, as the IPMI command support i= n ManageabilityPkg has the same functionalities with few newly added IPMI c= ommands. This library is independent of IPMI transport interface. 2. Remove Frb, IpmiFru, OsWdt and SolStatus from IpmiFeaturePkg as those we= re migrated to ManageabilityPkg already. 3. I will get back to GenericIpmi and turn it into ManageabilityPkg framewo= rk then remove GenericIpmi from IpmiFeaturePkg. So I would like to take back my suggestion having you to send the patch aga= inst ManageabilityPkg. As the transport implementation has some gap between= these two packages. Thank you Abner > -----Original Message----- > From: Huang, Li-Xia > Sent: Monday, October 23, 2023 1:48 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Isaac Oram ; Desimone, Nathaniel L > ; Wu, Yidong ; Xu, > Wei6 > Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > Support Standalone MM > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hi Abner, > > Thanks for your feedback. > Since the IPMI implementation in these two packages are diverging now, an= d > my patch has some dependency with common code in IpmiFeaturePkg , it will > be better to resend this patch after the diverging is done. > > Our target schedule is '23 WW51', could you let me know what's the sched= ule > for these two packages'(IpmiFeaturePkg and ManageabilityPkg) diverging? > Thanks. > > Regards, > Lisa > > -----Original Message----- > From: Chang, Abner > Sent: Saturday, October 21, 2023 10:15 PM > To: devel@edk2.groups.io; Huang, Li-Xia > Cc: Isaac Oram ; Desimone, Nathaniel L > > Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > Support Standalone MM > > [AMD Official Use Only - General] > > Hi Lisa, > Issac was no longer the maintainer of IpmiFeaturePkg as he was retired. N= ate > had sent the maintainers update for review. > As the conversation I had with Issac, we all agreed IpmiFeaturePkg should= be > deprecated as the IPMI related drivers are now located under > ManageabilityPkg in edk2-platforms. The IPMI implementation in these two > packages are diverging now, which is not good. > Could you please send this patch against ManageabilityPkg? I can help to > review it, so does Nate as he also proposed himself as the maintainers of > ManageabilityPkg. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Huang, > > Li-Xia via groups.io > > Sent: Friday, October 20, 2023 2:46 PM > > To: devel@edk2.groups.io > > Cc: Isaac Oram ; Nate DeSimone > > > > Subject: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > > Support Standalone MM > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > > > Cc: Isaac Oram > > Cc: Nate DeSimone > > Signed-off-by: Lixia Huang > > --- > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > > loneMm/StandaloneMmGenericIpmi.c | 148 ++++++++++++++++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > > loneMm/StandaloneMmGenericIpmi.inf | 52 +++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > > | 2 + > > 3 files changed, 202 insertions(+) > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > new file mode 100644 > > index 000000000000..52d8d2abdd0d > > --- /dev/null > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > @@ -0,0 +1,148 @@ > > +/** @file > > > > + Generic StandaloneMm IPMI stack driver > > > > + > > > > + @copyright > > > > + Copyright 2023 Intel Corporation.
> > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +**/ > > > > + > > > > +// > > > > +// Statements that include other files > > > > +// > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include "IpmiHooks.h" > > > > +#include "IpmiBmcCommon.h" > > > > +#include "IpmiBmc.h" > > > > +#include > > > > + > > > > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > > > > +EFI_HANDLE mHandle; > > > > + > > > > +EFI_STATUS > > > > +SmmInitializeIpmiKcsPhysicalLayer ( > > > > + VOID > > > > + ) > > > > +/*++ > > > > + > > > > +Routine Description: > > > > + Setup and initialize the BMC for the SMM phase. In order to verify > > + the BMC > > is functioning > > > > + as expected, the BMC Selftest is performed. The results are then > > + checked > > and any errors are > > > > + reported to the error manager. Errors are collected throughout > > + this routine > > and reported > > > > + just prior to installing the driver. If there are more errors than > > MAX_SOFT_COUNT, then they > > > > + will be ignored. > > > > + > > > > +Arguments: > > > > + ImageHandle - Handle of this driver image > > > > + SystemTable - Table containing standard EFI services > > > > + > > > > +Returns: > > > > + EFI_SUCCESS - Successful driver initialization > > > > + > > > > +--*/ > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > > > > + > > > > + Status =3D gMmst->MmAllocatePool ( > > > > + EfiRuntimeServicesData, > > > > + sizeof (IPMI_BMC_INSTANCE_DATA), > > > > + (VOID **)&mIpmiInstance); > > > > + > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > > Status)); > > > > + return Status; > > > > + } else { > > > > + > > > > + // > > > > + // Initialize the KCS transaction timeout. Assume delay unit is 10= 00 us. > > > > + // > > > > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) > / > > KCS_DELAY_UNIT; > > > > + > > > > + // > > > > + // Initialize IPMI IO Base, we still use SMS IO base to get > > + device ID and > > Seltest result since SMM IF may have different cmds supported > > > > + // > > > > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > > (PcdIpmiSmmIoBaseAddress); > > > > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SI= GNATURE; > > > > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDR= ESS; > > > > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > > > > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > > IpmiSendCommand; > > > > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStat= us; > > > > + > > > > + mHandle =3D NULL; > > > > + Status =3D gMmst->MmInstallProtocolInterface ( > > > > + &mHandle, > > > > + &gSmmIpmiTransportProtocolGuid, > > > > + EFI_NATIVE_INTERFACE, > > > > + &mIpmiInstance->IpmiTransport > > > > + ); > > > > + ASSERT_EFI_ERROR (Status); > > > > + > > > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > > > > + > > > > + return EFI_SUCCESS; > > > > + } > > > > +} > > > > + > > > > +/** > > > > + The module Entry Point of driver. > > > > + > > > > + @param ImageHandle The firmware allocated handle for the EFI ima= ge. > > > > + @param SystemTable A pointer to the MM System Table. > > > > + > > > > + @retval EFI_SUCCESS The entry point is executed successfully. > > > > + @retval Other Some error occurs when executing this entry p= oint. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +InitializeGenericIpmiStandaloneMm ( > > > > + IN EFI_HANDLE ImageHandle, > > > > + IN EFI_MM_SYSTEM_TABLE *SystemTable > > > > + ) > > > > +{ > > > > + SmmInitializeIpmiKcsPhysicalLayer (); > > > > + return EFI_SUCCESS; > > > > +} > > > > + > > > > +/** > > > > + Unloads an image. > > > > + > > > > + @param[in] ImageHandle Handle that identifies the image to be > > unloaded. > > > > + > > > > + @retval EFI_SUCCESS The image has been unloaded. > > > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image > handle. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +EFIAPI > > > > +GenericIpmiStandaloneMmUnload ( > > > > + IN EFI_HANDLE ImageHandle > > > > + ) > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + Status =3D EFI_SUCCESS; > > > > + if (mIpmiInstance !=3D NULL) { > > > > + if (mHandle !=3D NULL) { > > > > + Status =3D gMmst->MmUninstallProtocolInterface ( > > > > + mHandle, > > > > + &gSmmIpmiTransportProtocolGuid, > > > > + &mIpmiInstance->IpmiTransport > > > > + ); > > > > + ASSERT_EFI_ERROR (Status); > > > > + } > > > > + gMmst->MmFreePool (mIpmiInstance); > > > > + } > > > > + > > > > + return Status; > > > > +} > > \ No newline at end of file > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > new file mode 100644 > > index 000000000000..336e28368ed6 > > --- /dev/null > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > @@ -0,0 +1,52 @@ > > +## @file > > > > +# StandaloneMm Generic IPMI SMM Driver. > > > > +# > > > > +# @copyright > > > > +# Copyright 2023 Intel Corporation.
> > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +## > > > > + > > > > +[Defines] > > > > + INF_VERSION =3D 0x00010017 > > > > + BASE_NAME =3D StandaloneMmGenericIpmi > > > > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f= 00f81060 > > > > + MODULE_TYPE =3D MM_STANDALONE > > > > + VERSION_STRING =3D 1.0 > > > > + PI_SPECIFICATION_VERSION =3D 0x00010032 > > > > + ENTRY_POINT =3D InitializeGenericIpmiStandal= oneMm > > > > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnloa= d > > > > + > > > > +[Sources] > > > > + ../Common/IpmiHooks.h > > > > + ../Common/IpmiHooks.c > > > > + ../Common/IpmiBmcCommon.h > > > > + ../Common/KcsBmc.c > > > > + ../Common/KcsBmc.h > > > > + ../Common/IpmiBmc.c > > > > + ../Common/IpmiBmc.h > > > > + StandaloneMmGenericIpmi.c > > > > + > > > > +[Packages] > > > > + MdePkg/MdePkg.dec > > > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > + > > > > +[LibraryClasses] > > > > + MemoryAllocationLib > > > > + BaseLib > > > > + MmServicesTableLib > > > > + DebugLib > > > > + StandaloneMmDriverEntryPoint > > > > + IoLib > > > > + ReportStatusCodeLib > > > > + TimerLib > > > > + > > > > +[Protocols] > > > > + gSmmIpmiTransportProtocolGuid # PROTOCOL > > ALWAYS_PRODUCED > > > > + > > > > +[Guids] > > > > + > > > > +[Pcd] > > > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > > > > + > > > > +[Depex] > > > > + gIpmiTransportProtocolGuid > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > index 5df71300cbd1..73dca30caae9 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > @@ -129,4 +129,6 @@ > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > > D0000003 > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > > |0xD0000004 > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > > 0xD0000005 > > > > + > > > > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > > 6|0xD0000006 > > > > -- > > 2.26.2.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#109823): > > https://edk2.groups.io/g/devel/message/109823 > > Mute This Topic: https://groups.io/mt/102076516/7039027 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [abner.chang@amd.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109981): https://edk2.groups.io/g/devel/message/109981 Mute This Topic: https://groups.io/mt/102076516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-