From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.83659.1682903946077956697 for ; Sun, 30 Apr 2023 18:19:06 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YB/7IHY5; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: james.lu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682903946; x=1714439946; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Mk6VHh86PPXQnBn4u63tkicB65k7JXxVwxuhD80AZlI=; b=YB/7IHY5PaD3Y9S/8tkAX+9tqCfbXxrmbyxqIHcKg0RZ1zka9gzCfdw8 x7gRTJlrM7R5RBXD1RpBIWMMFxjVOv11WZ0rJ4+zG9D+4cMbTsdjbpozg C2s3WWw14ZdNgConBP8DuyV//9NPK7yCHKBUrsmWAA4eJnvYvEk/6cL+G 4IZINqlTHzGUDPtF4i7dONPWCX8yy9JeLMIeYjsmMHzScrYr7FAHTEKC8 V+kXIydCv9iFs+INwZQRnVNN3+1dxel++jAyLOKCNlTkg3NZz8XX9qmdf R5ljiDMpgezPFeKFg2aCgH714T8oP1GJGo/BFRFI772BVwIAlt0tHRg/O w==; X-IronPort-AV: E=McAfee;i="6600,9927,10696"; a="328423545" X-IronPort-AV: E=Sophos;i="5.99,239,1677571200"; d="scan'208";a="328423545" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2023 18:19:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10696"; a="941882758" X-IronPort-AV: E=Sophos;i="5.99,239,1677571200"; d="scan'208";a="941882758" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 30 Apr 2023 18:19:05 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 30 Apr 2023 18:19:05 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 30 Apr 2023 18:19:05 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 30 Apr 2023 18:19:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZCrxzGFgysCKafE6RXsY21LySClVnxwuKQNKdLJOb+6bcTQzjm1FL3g88SS21uKxQJkTlYd21s24xA3w7oJg6qDhHCKGV43rqIAc5jkGlGIJ/cGdxbq17hqBa/3/u+2ljG0wREsfMhpCDoMLWEzsL5z3X21xaC5GP1m9cgKVe6tkHNgN+AHgF6KFXCYnDDfQ/u0rEOBvDcY3RkxRwAq1EEAtsxQtH02/1ciHu9p0CgHj29qjhJhrmCtjun4gjHZ3cqtA23vSzXq3mVUBzNwd5IncVJGSeVHkZ/SMOfMvqn8oFIZk4oFUGtNUJeu2r6xXaoieKfbz7nGbBK9k+encg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arqkZxYaOBgBMJmouMVzB5cJrZBeeqYXgyap4VM4vUY=; b=VhmDnKHlncqyJy6uhrTdVBjYof2PKnEhnSqB73K2TVBRi9Tw0Gdb7f/X9IjDV4A43OJJ/xCve7xnu8T2gaqwMSGLzMONrDCNetNRgwUTBGldJPGs4qppUq98iQkORbfmT9M2QoQDyrilgt8IdL/Sbmlb4fDb29J2qXj3aHkEltJdaZfr4+z2A3zKULU8CLrGkeUdWb6RkeC9GN9W8rIA3Zlm4M5T895C1BTnq2dCd9VfGJVefVofmkmtq+fXpvsocDqRoTAYI/jTOBdMCOoECYMQx+B63c6Wv95gff9yaMhsYi9t+R3uNPXh0LaJEPQaXu2L3ttK12vJVG8VP1p21g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7819.namprd11.prod.outlook.com (2603:10b6:610:125::20) by PH0PR11MB7494.namprd11.prod.outlook.com (2603:10b6:510:283::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 1 May 2023 01:19:02 +0000 Received: from CH3PR11MB7819.namprd11.prod.outlook.com ([fe80::6cff:33a5:d30b:9ddb]) by CH3PR11MB7819.namprd11.prod.outlook.com ([fe80::6cff:33a5:d30b:9ddb%5]) with mapi id 15.20.6340.028; Mon, 1 May 2023 01:19:01 +0000 From: "Lu, James" To: "devel@edk2.groups.io" , "dhaval@rivosinc.com" CC: "Dong, Guo" , "Ni, Ray" , "Rhodes, Sean" , "Guo, Gua" Subject: Re: [edk2-devel] [PATCH v4 1/2] UefiPayloadPkg: Remove FP Init from UPL entry Thread-Topic: [edk2-devel] [PATCH v4 1/2] UefiPayloadPkg: Remove FP Init from UPL entry Thread-Index: AQHZVzhkUiXT9wp0Y0axNZyK8Eb/Eq9E5z3A Date: Mon, 1 May 2023 01:19:01 +0000 Message-ID: References: <20230315121913.119025-1-dhaval@rivosinc.com> <20230315121913.119025-2-dhaval@rivosinc.com> In-Reply-To: <20230315121913.119025-2-dhaval@rivosinc.com> Accept-Language: en-001, en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7819:EE_|PH0PR11MB7494:EE_ x-ms-office365-filtering-correlation-id: a3c7657c-2c99-46bc-ae90-08db49e20bc9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3B/1bQNNGBGDSxoN7H7Hu86PrxYH5jNUwxYC1aUWXgx0qf0BRMQGoeKvHdTwUy4g6cwBj+MYjo+2lAWBsySkMa2AVL+x5ZtcJrMMdsTaaG99V29bWbEedtAVAS9wRaanBkpGhVzKG0edhd4E2AVwls1sLWA3gGrHE4J/mOncVbikev/qg45GQ6K7NuNZZiDAl45Zpp3zjs6O8TmMzDRXWRXP3S549vGXe/zv3ruPexnwMvr/W2NBxzsEWWAjAjL7ROwSWGWMMNmy6I6BODwhJ9Dm7Us+FsSJZTwURYl8Ler8QMrqV62Dl7XbEgl8shvca7hGXqvy9d/DNafYrvo3DNHdpRw1zkYUwWTkGfSURg0VrA+dD5MtSofM7xZ9CgYWF+pa17eqTQDcQDlnO8Cv00Ww7z/c0ozSfswDsOoskLIoVndVjqhNWamQ8ieglVREF4LRgyEuImugghbVmJoTxv+8pg1IzpPC22lv3ASfJ4NDqAqGXL1I1bPHEOipLNlGsg9di8Udqb17eac+zIWMT18t5nS2ZwTfuktVJwVeNqocv9iKn7AUOIijLij7n+FgkzM5grBdHP/V6VhSWYGNmhWknGr/8gtWs4EiHM9jJzxQS7osTTo7esGOAr4bCd4llgjnzil1loJ0sr+Ep1Gq4Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR11MB7819.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(376002)(396003)(39860400002)(136003)(451199021)(19627235002)(478600001)(66899021)(110136005)(86362001)(54906003)(966005)(107886003)(186003)(53546011)(9686003)(316002)(55016003)(33656002)(71200400001)(66446008)(82960400001)(64756008)(66476007)(66556008)(76116006)(6506007)(83380400001)(4326008)(2906002)(66946007)(41300700001)(122000001)(38100700002)(8676002)(7696005)(26005)(38070700005)(5660300002)(8936002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uA56Yfv6PfDf6W9BLotlfRClo7peCJUca70EsfyqNzPA22QUtGvOVY1OZN65?= =?us-ascii?Q?grLzCxc2pMpeL3sPzhfh11vTWm8qdw1zJXGkOCLnL3zamG8R023PwascnTQl?= =?us-ascii?Q?3D4RAJjOVok03/kCeREY/Itl2gHKo0PkvgYcoisosGJNDXAVmcwlzfFqOzJR?= =?us-ascii?Q?aSjvbj5lO9NNnlNagarNQQlPLv/sK80f8XnUbZAjD8TfxbxlN9p3/e42/UpX?= =?us-ascii?Q?mcYJJ8UGTmYb/I7dT1JxEokPkBw7gxRQ/APMq4lUfbDqsprsnqSM0LffC2Ib?= =?us-ascii?Q?pXWQYidusuzzmeZo2NnumItPHiT80XS+g0Gql1uGrMNpNH4VTF/pT5YEfWu1?= =?us-ascii?Q?/EPD+O9kwOmvpYQzVUuJFMgAXaZQvdj6FDgxhGBs6BLvGwc+dAjqyUi+Gvdl?= =?us-ascii?Q?IDkcA+20Me4JlPkIrXiSRrVm1Yb25awg0Is6ggV46tb8zoLL3LCDwq0376oo?= =?us-ascii?Q?bQRxV2X5qKuP4Aa2BRCrPgstHcN4mplHp4EkFes7yZqYSa0ITmybX9VaGHdB?= =?us-ascii?Q?hRTbHRXrMVQTxxVaYTU2jp+yaivyWP9NKLp81tkoqNYGAvZYgDTshy/vPCMq?= =?us-ascii?Q?H+yxyB0ieUe99ayJQ/Ih2YKYqoLQtdc4HRy00rakhsW5RQNvWySm4dgP08cj?= =?us-ascii?Q?KU4tkaBHHo7Lst/VpwvvkMcEqEljAgcud4dW0S4mwKiBG9sCiUBLlcgMqYaJ?= =?us-ascii?Q?JD+Gex5gypHqtDrJOpBO4g53HLFXX+C/xVibp6Y8ar8b91NqEHioJhAmxvx8?= =?us-ascii?Q?1NTPqgv3QxQP+vVjpv0nhF/xKJgva9myceA4DkUdolsYCdV+/chx7+jLf3OP?= =?us-ascii?Q?3K/JEwNdauNWo/s99P9Py48k1sBhDbaQhTfdCxlxcnaahkbjg12bn5FqUggu?= =?us-ascii?Q?7juCRST0FpP80BKEMV2+jDyn6adnpognrcobm24gee9EkSB2s12ndT2Lm+RB?= =?us-ascii?Q?VmyNIiOdsFYjm0/giPksoPTrViEluYl0AxxGRqQwS6L7YWDQzqC1qIMIjQfV?= =?us-ascii?Q?rwQBKAyylsVs22bbC15P6tIa23jaj52ouiNAvMJRkVwnapDYH9SzVywoDeuC?= =?us-ascii?Q?OMV8tRjbbnm52xKXF+tLDPUDisKW9UHdkeoGa2GkGKO+33vy11atSmMQUwNd?= =?us-ascii?Q?atiZ533IWLEAdQiuPXBnSUE+D2xzuocqy8AUygv22yQUdLVWA0RdUNAVo1aU?= =?us-ascii?Q?KBbr6yym802BWaY5PmsgGayUSJc4/yG9EGn6TabE3nOa3vY4tY9R/XkrzmiY?= =?us-ascii?Q?G4r88WcZvSWVGjCTX34XS0whHZ4/VYJueuMJehF5ditubGXgUkaE1/hxsz/Q?= =?us-ascii?Q?ArM9OZkyFTGZyuhrZRQM3i02Q919Xetzl9iLTbXyJe+iI5uFFXSFLFlhjlrf?= =?us-ascii?Q?TqxoaywOy9c/URq+4fWI3kS+nqy2oeTpBAQtSZYTRGdZCjEBB7Spo8EMuPWT?= =?us-ascii?Q?4u5SQrVnveEL5bb28raAxVMIcfKw7aEFQf6mriF3IR+MG+Xv5FD4jB9lzKoq?= =?us-ascii?Q?HLcPw9anjVpmv9FvnAA3+KcaGv95/vyTOhiAM4N4eC/Khw9GnqlrF6JcKs46?= =?us-ascii?Q?4hkab3bFegwiIFTpTPcxsKWOg+XPx3ek4dXMKvD8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7819.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3c7657c-2c99-46bc-ae90-08db49e20bc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2023 01:19:01.1763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JCDtIMZLIq74sTayiuoQ89wTT2RU1XqvYRA2PoXY+Jj2qcCcrp4JZIG+0A3pq5K9/rSMvJlruEY1XJuuhdmK8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7494 Return-Path: james.lu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: James Lu Thanks, James -----Original Message----- From: devel@edk2.groups.io On Behalf Of Dhaval Sharm= a Sent: Wednesday, March 15, 2023 8:19 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sea= n ; Lu, James ; Guo, Gua Subject: [edk2-devel] [PATCH v4 1/2] UefiPayloadPkg: Remove FP Init from UP= L entry According to UPL spec BL should initialize FP init meaning UPL does not nee= d to initialize it. Besides this is arch specific init and needs to be move= d out of UPL common flow. In order to not break current BL implementations,= for now just moving the init to later point of time but for both x32 and x= 64 eventually this should be removed once BL impelement this logic. Test: Verified booting UEFI shell on coreboot on qemu. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Dhaval Sharma Reviewed-by: Gua Guo --- Notes: v3: - Added FP initialization to X64 path as well v4: - Updated reviewed-by tag UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c | 3 +++ UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 --- UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c | 3 +++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c b/UefiPaylo= adPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c index c66e56aee15a..9d2bfb2fa654 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c +++ b/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c @@ -268,6 +268,9 @@ HandOffToDxeCore ( UINT32 Index; X64_IDT_TABLE *IdtTableForX64; =20 + // Initialize floating point operating environment to be compliant with = UEFI spec. + InitializeFloatingPointUnits (); + // // Clear page 0 and mark it as allocated if NULL pointer detection is en= abled. // diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/Uefi= PayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c index 46ee27c905e9..07f4c1d29686 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -470,9 +470,6 @@ _ModuleEntryPoint ( PrintHob (mHobList); ); =20 - // Initialize floating point operating environment to be compliant with = UEFI spec. - InitializeFloatingPointUnits (); - // Build HOB based on information from Bootloader Status =3D BuildHobs (BootloaderParameter, &DxeFv); ASSERT_EFI_ERROR (Status); diff --git a/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c b/UefiPayloa= dPkg/UefiPayloadEntry/X64/DxeLoadFunc.c index 346e3feb0459..84a6112ce64a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c +++ b/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c @@ -40,6 +40,9 @@ HandOffToDxeCore ( VOID *GhcbBase; UINTN GhcbSize; =20 + // Initialize floating point operating environment to be compliant with = UEFI spec. + InitializeFloatingPointUnits (); + // // Clear page 0 and mark it as allocated if NULL pointer detection is en= abled. // -- 2.40.0.rc0.57.g454dfcbddf