Re: [edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check

["Lu, James" <james.lu@intel.com>]

Reviewed-by: James Lu <james.lu@intel.com>


Thanks, 
James


-----Original Message-----
From: Guo, Gua <gua.guo@intel.com> 
Sent: Monday, January 8, 2024 3:30 PM
To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: RE: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check

Reviewed-by: Gua Guo <gua.guo@intel.com>

-----Original Message-----
From: Chen, Gang C <gang.c.chen@intel.com> 
Sent: Monday, January 8, 2024 3:26 PM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>; Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Chen, Gang C <gang.c.chen@intel.com>
Subject: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check

It's too early to check the SCI enable status, which is set in the BDS phase ususally. Remove the check from UPL.

Signed-off-by: Gang Chen <gang.c.chen@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
---
 UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 ---------------------
 1 file changed, 38 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c
index 1b9208b6d3..748728981a 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c
@@ -134,44 +134,6 @@ Done:
   ASSERT (Fadt->Pm1aEvtBlk != 0);   ASSERT (Fadt->Gpe0Blk != 0); -  DEBUG_CODE_BEGIN ();-  BOOLEAN  SciEnabled;--  //-  // Check the consistency of SCI enabling-  //--  //-  // Get SCI_EN value-  //-  if (Fadt->Pm1CntLen == 4) {-    SciEnabled = (IoRead32 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE;-  } else {-    //-    // if (Pm1CntLen == 2), use 16 bit IO read;-    // if (Pm1CntLen != 2 && Pm1CntLen != 4), use 16 bit IO read as a fallback-    //-    SciEnabled = (IoRead16 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE;-  }--  if (!(Fadt->Flags & EFI_ACPI_5_0_HW_REDUCED_ACPI) &&-      (Fadt->SmiCmd == 0) &&-      !SciEnabled)-  {-    //-    // The ACPI enabling status is inconsistent: SCI is not enabled but ACPI-    // table does not provide a means to enable it through FADT->SmiCmd-    //-    DEBUG ((-      DEBUG_ERROR,-      "ERROR: The ACPI enabling status is inconsistent: SCI is not"-      " enabled but the ACPI table does not provide a means to enable it through FADT->SmiCmd."-      " This may cause issues in OS.\n"-      ));-  }--  DEBUG_CODE_END ();-   return RETURN_SUCCESS; } -- 
2.40.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113369): https://edk2.groups.io/g/devel/message/113369
Mute This Topic: https://groups.io/mt/103593439/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-