From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 322097803D0 for ; Mon, 8 Jan 2024 07:51:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=L7XYxD8uAcAzqSVkio2G+y0aOaFegarbODFlxey/4yg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704700292; v=1; b=UK21vUgxMnH+kovt/guJGOXK33XQ3/eCxS/5RUQDARLnJiRvmrUvDFaUaSCuGoSqPAA9Wceo 7Sdyc3EUsV/k9D1JSla11q97BFh5ANOMVCkCOrcgeVW67Xcdb2jePmwSZllgXlWtxdwDrYL0q3A DuNdK+wNm8XRBHlYHfxkeE5A= X-Received: by 127.0.0.2 with SMTP id 0JgTYY7687511xGswEztD1q5; Sun, 07 Jan 2024 23:51:32 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mx.groups.io with SMTP id smtpd.web11.2163.1704700292316537424 for ; Sun, 07 Jan 2024 23:51:32 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="4898932" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="4898932" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 23:51:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="851710261" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="851710261" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Jan 2024 23:51:31 -0800 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 7 Jan 2024 23:51:30 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 7 Jan 2024 23:51:30 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Jan 2024 23:51:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nu8csx1eP4y9W8ci2sYdSfi8wnNV4zSZaZcmtoWxwLuSTgoaU50OODZbSORGPlClyg7b4K7ssgF3Vo40unMrB0xQRENMGflZdgmaodXiQruElM2s8y9rSD5/mZ80hBmB3xikBOVuhiRqACqLhkQAQbKT+DZhc0CKdZEHMrCSaMwBUIbiOP1nMmrQknLoxA+CeQ8Z4L3xWYfsimU2LpYUEpwTjbNY4APSGFbY2gxyJjJaa0oSabPE2eDA2YBCO/+TLfBrWXkLhhRJ2rEjAKDQBBv3r7zxakSxfN3JFsVkrCJ04/FHNVjEXahkDoAPtLqL5IT+gP6yAdFIRCwd9lnAhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKaK2z29QoJMaJUNisLiP/yBu43at2Tkhcz7EbNuEGM=; b=cARASX9QWy0CO/7c1y6gjwzvAkLPKOyDw1SyAMBGOCrTxZIOxReieYUgxMZieqv7k749QkjWSMh6lQCa6sDtUwzvcy+yqPvbBQDBlLeELj90Cn80b+o4BMQ//Bk3HGWG3RGiQH5MODfr3y7RC29ZnyniKwXGlIxGOrblHmWQVr13RQaZHP6OjAmUxbjKwYHU2lYpCcvHHLtSiWY/IDFQOEhmct5tS2zDBuPMtEO1hQgUsUrUII9IWNaMw1IfmHNiE2Xdh7Bz9eeSUJr5HdZRiYd6qzrfakonKeTgEItv8ZQvpjVRbK9e3OcLZws6Qhaj8wjtyxRsAddBNjR+VDORbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CH3PR11MB7819.namprd11.prod.outlook.com (2603:10b6:610:125::20) by SA2PR11MB4954.namprd11.prod.outlook.com (2603:10b6:806:11b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 07:51:08 +0000 X-Received: from CH3PR11MB7819.namprd11.prod.outlook.com ([fe80::37b:399f:3ab9:84e8]) by CH3PR11MB7819.namprd11.prod.outlook.com ([fe80::37b:399f:3ab9:84e8%6]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 07:51:07 +0000 From: "Lu, James" To: "Guo, Gua" , "Chen, Gang C" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Rhodes, Sean" Subject: Re: [edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check Thread-Topic: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check Thread-Index: AQHaQgO4xe0w9y5PkUyVW35ahDlzj7DPhN4AgAAFw7A= Date: Mon, 8 Jan 2024 07:51:07 +0000 Message-ID: References: <20240108072531.3344290-1-gang.c.chen@intel.com> <20240108072531.3344290-4-gang.c.chen@intel.com> In-Reply-To: Accept-Language: en-001, en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7819:EE_|SA2PR11MB4954:EE_ x-ms-office365-filtering-correlation-id: f287317f-9e2f-43f4-fe06-08dc101e92da x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: uCumo3LprDMZEYOb+P9Nwf4pUkGyxPjpOVlNexqmHJCoWvNNiGhKq8XVyGpH4ib/cn085A6usOuAbG2u9rKJ9img80QrOl6eDQVl2xtqzdI/I0MFJUhPZ6rsgr0031CbN97ymzEf3yiepA8i1i8VbouKoeyymoDuFOeZlyHUrlOChDKN94fQb9D3iCKZgkzD5vfkGyxWj73b/zvxHaqq2NHXrBqHnGYwRhmEzMcLuRM0QhH0S/7Ky7Eax0qtlZ7ru9Z2JySd+HB0ksZC4ZKVVzupqO1vM2N9NwCIn+Lb3KeF3yf91DUlSvZp+w7NZPyKo2lLQxd8aHKyRWkEM7yvVyKMDFSBZNf15NE9cL4BZ07yOTVAct62DGpiIYEdFT+TxT41DEmYVUJ43cH3alc0QGTcRltRclSc861X1oexAPjKCkSoQpvCheqQ38pzxE9N5I2VZKMv0QnMRCMx5vHReP0GmCzRoKKjvZqbTcXlvwG3tuzyrpqWWtbKeBEHKL9teDpO3t4cLEC1hhW+zS3JAe3noh6wLxb+pIWNZ08U4W2vVLVFTyjlmHVd1oOZDiv/erZpo/y1Fugo+cH0F303vDhmEFOOCY4wC+JLAI58NcUZuk8EAAwXKW5yLM9aO9h+ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EHj81y0Wv8tKB/HQfoJQD2kiJr7BQrUXzhrd46me/1XIhCncb1Dd/vrUoDIS?= =?us-ascii?Q?3edxLlsO8c2BTspkmT+bHWntXIQP7qYNh+8R3tIu83ls0gk5Az+jpfk96OwM?= =?us-ascii?Q?Ed4jGOq/u5wCrH+8bV6C9CJmmAt+Gy6cND6yX2wxFWmt/80hSSJFWOMX6Tmz?= =?us-ascii?Q?JHbyEa/6SIMKwZ9a8crNmUEASJ803ZeqZPF+W9E7e3DtRZZM7rVl1IiUN5Wi?= =?us-ascii?Q?hRDXsJ/yrAFYxQ1P4ValRmtLLCV35F73hZZIx36032wFsINN9CsNniZMyLXH?= =?us-ascii?Q?gGq6QjuQ9L0JVWCAZx+Z2gGtB0yen59n4o4/CQRIgBD91lRVvaw/iegf2mFC?= =?us-ascii?Q?oSWw6qwIYNPwaQIZNylr8CezePtHR4GHrxy0hdX6BivTjEh3t/HLmTlKW7qs?= =?us-ascii?Q?ALD3r0DRIg/20cEZ5c7OK0CmkmKdIl4Ob/kQR40GzEADCDM7OEO0oexkk5Yy?= =?us-ascii?Q?ckY7Jr1VU2VB4S40iGG1I40PR3RT9+baqG75DJ90ojFm/eE3mI3URAgXXvrR?= =?us-ascii?Q?ASCJtdaK1WJVtzg7iAOYU74f5Re+z4c/kEU7tDtcSa5wraYtF/jK6xApLWng?= =?us-ascii?Q?ejVX4Fjd4c9k6hY6SJR8NPd2WWIaCAYfi/d9hYp3rwcjZB5qADRey2q60uk/?= =?us-ascii?Q?njqiGes2l92ErDuGNE74u2dnl9Jv879Xpr90j9Bjl6BUPcHK5jUS0I6Pb4xH?= =?us-ascii?Q?qyOp9lj9lhz0b/CazpJikZrahxWW29eqIYQagWztwptSAvDOdjkS1rQzdfbJ?= =?us-ascii?Q?yX9N8CzBKZTCqGr5CaKKelKYm6n1O4nyrP7OCXymDr8yKGru4WzgKLmwXr+G?= =?us-ascii?Q?IFv4CeoRxRqFvI0KitSqy3DCC5JVA3xWq9+oOaJNFmjVwNAV0w07Nh1algUa?= =?us-ascii?Q?cIjOD9TkcLUFbK2IcfLSzRJVZAr78wqSiJ2tf4S99CsrqoWvhx4szK0R6wpy?= =?us-ascii?Q?98Az9CNCSpMd1Y2YGEo0lWQYgYBhwPC7H/chv4oSiI+6bsTOwx+pnMeOeRja?= =?us-ascii?Q?mMRUR3vSnq9bRXL2GsCryaX5xA2C4ZWWsz2TwJ4r2AU1HmAdcxWMvrr7RuXf?= =?us-ascii?Q?1qzQ3oZSGKDRkgfri/Kmtj5uSgfITiF3SN5ke4OmqhI0lCQxWvLt3aU9SQzB?= =?us-ascii?Q?WCcO2CVj7gtwOHj9CtSxsR/Ow6ECN/oJxl8KQEcMheX4RgnVPnVqu2JwUBuO?= =?us-ascii?Q?sehtrzm6Wpe3ENjjc0z3X+lxOw5WJfPY+jaERv6IghaO7E0S6M2Hr2qKNLL3?= =?us-ascii?Q?zdO1UaT815A70jiFydnBAtRZjpdTBiDfC8VvMy3/l6Uu5YMX/i21FBeXOJPV?= =?us-ascii?Q?h5FUJvSqKgfH3XOImhsGSiO88hULUKgreb6IPIGuUwOFLe4bUVF7bheuDS46?= =?us-ascii?Q?eXW+/ccOQ/a8Akm//q71+z8lNfDXVLLB4BCcXrOJZEKCmshb0cpRyBEm7rQN?= =?us-ascii?Q?jBlx8Ld59qz03QzJUJcGzPHwXi1qexQzQTVEF6QvJ204X+NR85xgTcX6ePVe?= =?us-ascii?Q?eNNqtLmT3nsBNqBdFfUWCPmJjc26TgRLYDfkWjfejAvxKXeaROQYRZePddbj?= =?us-ascii?Q?9UJN5ENENLlTHh2jYOj9e+hawTL7U0Oe7eyjz192?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7819.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f287317f-9e2f-43f4-fe06-08dc101e92da X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 07:51:07.8497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bIeuGpZMV9ZWZezpgYVnUPTIa2WTUKn6BRZuEIAL9/8Bku3Q2xMqqtqVK1iO6X0eW27b6DVR5SeevhlGRoSqRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4954 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,james.lu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MW1awEsyBkGQxoxiqhjfRipxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UK21vUgx; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: James Lu Thanks,=20 James -----Original Message----- From: Guo, Gua =20 Sent: Monday, January 8, 2024 3:30 PM To: Chen, Gang C ; devel@edk2.groups.io Cc: Dong, Guo ; Lu, James ; Rhodes,= Sean Subject: RE: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabli= ng check Reviewed-by: Gua Guo -----Original Message----- From: Chen, Gang C =20 Sent: Monday, January 8, 2024 3:26 PM To: devel@edk2.groups.io Cc: Guo, Gua ; Dong, Guo ; Lu, James= ; Rhodes, Sean ; Chen, Gang C <= gang.c.chen@intel.com> Subject: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling c= heck It's too early to check the SCI enable status, which is set in the BDS phas= e ususally. Remove the check from UPL. Signed-off-by: Gang Chen Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes --- UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 --------------------- 1 file changed, 38 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c b/UefiPayloadPkg/U= efiPayloadEntry/AcpiTable.c index 1b9208b6d3..748728981a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c +++ b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c @@ -134,44 +134,6 @@ Done: ASSERT (Fadt->Pm1aEvtBlk !=3D 0); ASSERT (Fadt->Gpe0Blk !=3D 0); - DE= BUG_CODE_BEGIN ();- BOOLEAN SciEnabled;-- //- // Check the consistency = of SCI enabling- //-- //- // Get SCI_EN value- //- if (Fadt->Pm1CntLen= =3D=3D 4) {- SciEnabled =3D (IoRead32 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE= : FALSE;- } else {- //- // if (Pm1CntLen =3D=3D 2), use 16 bit IO r= ead;- // if (Pm1CntLen !=3D 2 && Pm1CntLen !=3D 4), use 16 bit IO read a= s a fallback- //- SciEnabled =3D (IoRead16 (Fadt->Pm1aCntBlk) & BIT0)= ? TRUE : FALSE;- }-- if (!(Fadt->Flags & EFI_ACPI_5_0_HW_REDUCED_ACPI) &= &- (Fadt->SmiCmd =3D=3D 0) &&- !SciEnabled)- {- //- // The= ACPI enabling status is inconsistent: SCI is not enabled but ACPI- // t= able does not provide a means to enable it through FADT->SmiCmd- //- = DEBUG ((- DEBUG_ERROR,- "ERROR: The ACPI enabling status is incon= sistent: SCI is not"- " enabled but the ACPI table does not provide a = means to enable it through FADT->SmiCmd."- " This may cause issues in = OS.\n"- ));- }-- DEBUG_CODE_END ();- return RETURN_SUCCESS; } --= =20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113369): https://edk2.groups.io/g/devel/message/113369 Mute This Topic: https://groups.io/mt/103593439/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-