From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 30BC6740048 for ; Thu, 25 Jan 2024 06:02:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ElS1RhXMxi+dMZzrn9868Rm8ZqEN0+DxpvvR77VwtYo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706162538; v=1; b=Csp/Vjr1/HH20LpIs5cXj5k2qJosxN7w7Tjg80HEMMQhAXhkVrSAqQDLn5bA5K1jdTB5RiYw xCe+DPZNx+722jt51E+L2lqB1ztvxXlcKyeOREgXloXgpiDMAzYz1m01zxFS+/J0sXb2OrydhHt 1iYiQFGSmn3DkIiksguRnLC4= X-Received: by 127.0.0.2 with SMTP id L0vzYY7687511xWUNebnWo4w; Wed, 24 Jan 2024 22:02:18 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.10714.1706162536898764181 for ; Wed, 24 Jan 2024 22:02:17 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="401719640" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="401719640" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 22:02:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="28651834" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2024 22:02:17 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 22:02:15 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Jan 2024 22:02:15 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 24 Jan 2024 22:02:15 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Jan 2024 22:02:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFDtkzjt74++1mUAwYlZwrn9drMAunkCwvw1TGuJCHOxFp3zhOL1wSUc8xXkzfbPBLGirgXGFQp7OAamlHiAACnxBUw5s9vssHWeGWy2ToxljiygtLKMk3i8v/J93KqalQ32wHeoBbRpPIkDlUoJmyZcv3WF45vxCtheCQDohEJvAE0ZgLrOChH6H/GzeO5qg7aanirWB84L0rP7GkyMpGIf/WEZ5b3VKI6SjuLwxVR5uGTNujNXwLXPVb3yrvZf7Akm0JECxeQ4mz/y6pOF6omwApQgNDbq6absGXeQZE75CtMyG87arE5hKhKs+XkPZVHEwU2kGOtNS5p7r3Yq7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uOStdQZTAGY43vwHf95ylkCGzm+YeXdeCFnEDd7lI5U=; b=WiI9Sc2ITqGucYazvb++tcKaSNKUhjnB6NOOpaEzi03uNHf3pd4tumJ2hGiv5W3j91gmRgUoNSSFkkClY7I2F8H5RNTzhLjXjylemYBUqzI4KMV8v7bLwWX1CQ7KlJ2zgZwLzUG1JfwvJcy6xpdfykYuPKT+zhOkzkcRFpUp16UqWqAqR3326ecAvtb4eqIMLA1oAcVFjX3xmQhX9X/ghFl1NSyssVlPX47mMbyOsZc6zyYXsoIkAKizs0r8B2JxtFpJ1NFWPeehk8omVDAF/6ostx7ZDZcTr4XTirT56EZWVNkhUp6nYHCUKpfGttcc+2PNlLHvC6PnJzQ3Cv/Kdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CH3PR11MB7819.namprd11.prod.outlook.com (2603:10b6:610:125::20) by BN0PR11MB5695.namprd11.prod.outlook.com (2603:10b6:408:163::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Thu, 25 Jan 2024 06:02:12 +0000 X-Received: from CH3PR11MB7819.namprd11.prod.outlook.com ([fe80::37b:399f:3ab9:84e8]) by CH3PR11MB7819.namprd11.prod.outlook.com ([fe80::37b:399f:3ab9:84e8%6]) with mapi id 15.20.7228.022; Thu, 25 Jan 2024 06:02:12 +0000 From: "Lu, James" To: "Guo, Gua" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Dong, Guo" , "Rhodes, Sean" Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto drivers. Thread-Topic: [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto drivers. Thread-Index: AQHaT0ynhUg6IGCANE2eNmeWgh6YkbDqCUhw Date: Thu, 25 Jan 2024 06:02:12 +0000 Message-ID: References: <20240125050857.561-1-gua.guo@intel.com> In-Reply-To: <20240125050857.561-1-gua.guo@intel.com> Accept-Language: en-001, en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7819:EE_|BN0PR11MB5695:EE_ x-ms-office365-filtering-correlation-id: d970e6e2-fca9-419a-b44b-08dc1d6b2c61 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: /lGwzhdMquHlh67RQ2TogQqjuaFD+3Sdduj8m+v7lgTzL/ey2H7AeQc9LviGJi/Y5sAe5q9y1j4nYxWfhUihUJjCYWBj3cmtAiBmUiUlbb7NupJwvnr/mgpmJgQRpDwLvQw9T/2e+9nP6/5cC/21fpfs+9IhkYew8OJIbqlyWN//F/+25WCHoqZfIEu2ROjGr8L9cgXIGjYQwdmqc1T0OLzEqL4mEFPtIauC97k74ogxffsCsQhZnvC3SMNGOoP9C/NYVD78TkUQEuYalXIwyK/gkyuVsdCN+FFIu2nt6CSARtMphSLD9rNfQ542qWBalnzHT4SLKW5VX/XtSGG14Gtz7OuArEAl5Fv177g6SmkS0tuSL8xDl58lZuRqb9rmUdY/aBG8Ggsf5JHIYSf9EjLVE3VpnbzqNdtQ5yZHknpZ/PINEnQu0Ksfmcb7Mhx57qn/vKeQHmObkCyRwp3q7MHLbR8Z7EXGco/gUhwOKn/DQsj3fOVFetJ+ShkQdD4DqB+KVvNvwJsWM7Sd/3rNmWkWWfGrntdUJAyDFImFEWg9EhtzfDQJqvlyafJ0fI/XIK1jJtsiXFJZoe8jK+5hnX26Qc1tQJkXhesAkx4dATvq0PYXpaultOkodrNRadcndNeRklCMNIceqXGJydp5a31lfsgkelvayJobUIxylME= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N+/ooOfUCSTwas57DF3a9PNSLmbGnrRVvhjelJs3VGrh4d7rjCk7fzBGO7Yp?= =?us-ascii?Q?PU89hRrLOFUecy6HrWrHI/cr5doTV/6FV68L20cnS+QXHaUpjVoojIFQRSJi?= =?us-ascii?Q?VOb65Y7aySreQNTNuF0M+sn99Z2dwWsCOrH4dHrs8IEz0mII3uMTlEk34Tba?= =?us-ascii?Q?8bH0eayoJTzjpdIlTWRTHsTeofsRvDdtYar9qQNwSdG5vTr50SHAuZAkfDBG?= =?us-ascii?Q?usFKYI5kQniSBpFoj9Eq/ic3lltyttUEHhakMdaRLEoldbFoosbCuTuFPIA4?= =?us-ascii?Q?hyyfN8rufo1o/RJvHyMqUVq1jm/e4sIocOHDZQNBFfadpxzPYwQnxDDu583B?= =?us-ascii?Q?URpCVbobtrq7D17G/QW3p36C1C7DJfI1FxUAa4bSjOCywpEJgRiEjJim+7nI?= =?us-ascii?Q?2CfA73E5sf31sCWN10fNXqkjnCu/nntSpZ8Zdznq+n8TmZIEGi2tfrtmtVr1?= =?us-ascii?Q?gBaRsyn/zIHnMCSKX/TgZDDcw1ClLmIoWKo8sb/uGbt5s5H9oTbsdjCYTNTS?= =?us-ascii?Q?vkKCaiE+E+QTbN+jUBX213h7v5EovJBKDVsUloNVPOzF8INmG2YrgOIaNrNT?= =?us-ascii?Q?56c8RPW9OkqUrEXc8uDSUIqBQYGEEHNmd13QjWfu6UF6elrXRV+RFb+N4trD?= =?us-ascii?Q?hiPfJ5stQfRTQw/S1Hijm50hrqoZOQvaGXvXPqcB/KUjr2ZQB2hQMPPw/R5/?= =?us-ascii?Q?Dme7bUmg1o16HTr8wwf6trMYKItAVllXodw/TUVvhdOt3/gG7Yq4AKI6ckLN?= =?us-ascii?Q?2n3Iz+86MnVlVCnMchlz6JQD73S1VTNTGcVLE1jM9TOkfi+rwHC+R1qcml9i?= =?us-ascii?Q?SVvRTr4r25BOliUDJGeoL0NpCxUbpPNypOXsaasgrfNspV52e1ui9lm7igOq?= =?us-ascii?Q?dMy9jRrCRuvbxFxptiKXSAQk/coK8zYgz5ZEXB5+9nboe/tkxC3Mfud5yKl8?= =?us-ascii?Q?Sv+NG9kr6Wk7LMyZiBjxdrnKukM1KY8odfxvP6xcrDzcXRTD4AhHMre/tSYT?= =?us-ascii?Q?CDgCNrYLcLYuNqge1WGXmmPJ6jaMW9VzR6z0nhIc0hswHKuyr7xCyo4UzilM?= =?us-ascii?Q?9RxpbBFFgccxlF8rfHORvNf1c9/uvpFNMp+GtYDRQ9LtcYFOivw4xZ90z/ZT?= =?us-ascii?Q?BYRaqpjSkFRWjHW4ciHUR2wzjHAHoIPDlTkmTjRF4GZFIXmyKWpfUk3Qruay?= =?us-ascii?Q?2X6z6QAychuesCMxzRRON8LkhS7+uaL5Xv50ps9mlNiZEgUSl144xzQgXTqY?= =?us-ascii?Q?kkQqlQIa6O3SwJBqPPG+PaMatteUPuItLseyYjKCpLmSLB/5Z2HSWA8p2u/G?= =?us-ascii?Q?4jtJEGwua8tTm2lu7YJC10J/uhEJQ7EPbzZ3Ef6WO/kRH8GcJkjYCuKHDtbm?= =?us-ascii?Q?9eYWYiwKyGModEIvMv/ZBH/7JcYNXAYumbpAenJLSeIfbhJ6EZE4MXgwHrX4?= =?us-ascii?Q?SmkDKwn8f+JEIS2urD1IOjKKQIjC0MVPWXHEwQC5VkdFvMtA8ETFNfdlTzpA?= =?us-ascii?Q?iJ3bWeYakznvzte4Tr1RNwX6Ag/MKS7DIE5re4IcqSo2+10ZH0Sv3eZq8fvh?= =?us-ascii?Q?8+fzYCFdmWER8R8arMI7p+dcxQ/fvrs//qH4lGwf?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7819.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d970e6e2-fca9-419a-b44b-08dc1d6b2c61 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2024 06:02:12.2766 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fDWmHntKVfL2jkRbdnY/LvpRB97XoAcgCSQf1EaODqI1sYw7HPcjNH+5rUSwPzkfhwzAD6xctsjaET0Fz7n/Pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5695 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,james.lu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JSD8axN0gvSOfggJM6wI9qY6x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Csp/Vjr1"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: James Lu Thanks,=20 James -----Original Message----- From: Guo, Gua =20 Sent: Thursday, January 25, 2024 1:09 PM To: devel@edk2.groups.io Cc: Guo, Gua ; Chiu, Chasel ; Don= g, Guo ; Rhodes, Sean ; Lu, Jame= s Subject: [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto drivers. From: Gua Guo Crypto in serveral case will use old version or latest version, Platform may choose to only update Crypto drivers without updating whole UPL, in this case the Crypto driver will provide by platform payload outside the common UPL binary. Cc: Chasel Chiu Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Gua Guo --- UefiPayloadPkg/UefiPayloadPkg.dsc | 10 +++++++++- UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 4f195c1e52..2c4013bd9d 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -37,12 +37,18 @@ DEFINE ATA_ENABLE =3D TRUE DEFINE SD_ENABLE =3D TRUE DEFINE PS2_MOUSE_ENABLE =3D TRUE - DEFINE CRYPTO_PROTOCOL_SUPPORT =3D FALSE DEFINE SD_MMC_TIMEOUT =3D 1000000 DEFINE USE_CBMEM_FOR_CONSOLE =3D FALSE DEFINE BOOTSPLASH_IMAGE =3D FALSE DEFINE NVME_ENABLE =3D TRUE DEFINE CAPSULE_SUPPORT =3D FALSE + + # + # Crypto Support + # + DEFINE CRYPTO_PROTOCOL_SUPPORT =3D FALSE + DEFINE CRYPTO_DRIVER_EXTERNAL_SUPPORT =3D FALSE + # # Setup Universal Payload # @@ -860,11 +866,13 @@ # Misc # !if $(CRYPTO_PROTOCOL_SUPPORT) =3D=3D TRUE +!if $(CRYPTO_DRIVER_EXTERNAL_SUPPORT) =3D=3D FALSE CryptoPkg/Driver/CryptoDxe.inf { BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf } +!endif !endif #------------------------------ diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayload= Pkg.fdf index 7d04a8cffd..c1b1e35f32 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.fdf +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf @@ -154,8 +154,10 @@ INF MdeModulePkg/Universal/ReportStatusCodeRouter/Runt= imeDxe/ReportStatusCodeRou INF MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerR= untimeDxe.inf !if $(CRYPTO_PROTOCOL_SUPPORT) =3D=3D TRUE +!if $(CRYPTO_DRIVER_EXTERNAL_SUPPORT) =3D=3D FALSE INF CryptoPkg/Driver/CryptoDxe.inf !endif +!endif !if $(SECURITY_STUB_ENABLE) =3D=3D TRUE INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf !endif -- 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114366): https://edk2.groups.io/g/devel/message/114366 Mute This Topic: https://groups.io/mt/103948651/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-