From: "Xu, Wei6" <wei6.xu@intel.com>
To: "Li, Yi1" <yi1.li@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency expression
Date: Tue, 2 Jan 2024 01:43:18 +0000 [thread overview]
Message-ID: <CH3PR11MB834234232B983056F50D4ADEA161A@CH3PR11MB8342.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231220015455.1636-1-yi1.li@intel.com>
Reviewed-by: Wei6 Xu <wei6.xu@intel.com>
-----Original Message-----
From: Li, Yi1 <yi1.li@intel.com>
Sent: Wednesday, December 20, 2023 9:55 AM
To: devel@edk2.groups.io
Cc: Li, Yi1 <yi1.li@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Xu, Wei6 <wei6.xu@intel.com>
Subject: [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency expression
To avoid messy parsing of the Depex section of a Capsule, it would be a lot easier for everyone involved if we preceded the Capsule Depex Section with a length declaration. It provides simple bounds checking to avoid having to parse the op-codes, but in the case of a malformed depex being parsed, avoid other issues which can be messy.
Syntax
DECLARE_LENGTH <32-bit Length>
Description
Declares an 32-bit byte length of the entire dependency expression.
Behaviors and Restrictions
This opcode must be the first one in a dependency expression.
REF: UEFI spec 2.10 Table 23.4
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Yi Li (2):
MdePkg: Add DECLARE_LENGTH opcode of dependency expression
FmpDevicePkg: Add DECLARE_LENGTH opcode of dependency expression
.../FmpDependencyLib/FmpDependencyLib.c | 35 ++++++++
.../PrivateInclude/FmpLastAttemptStatus.h | 3 +
.../EvaluateDependencyUnitTest.c | 84 ++++++++++++++++---
MdePkg/Include/Protocol/FirmwareManagement.h | 29 +++----
4 files changed, 125 insertions(+), 26 deletions(-)
--
2.42.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113016): https://edk2.groups.io/g/devel/message/113016
Mute This Topic: https://groups.io/mt/103274336/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-02 1:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 1:54 [edk2-devel] [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency expression Li, Yi
2023-12-20 1:54 ` [edk2-devel] [PATCH V2 1/2] MdePkg: " Li, Yi
2023-12-20 1:54 ` [edk2-devel] [PATCH V2 2/2] FmpDevicePkg: " Li, Yi
2024-01-02 1:43 ` Xu, Wei6 [this message]
2024-01-03 0:52 ` [edk2-devel] 回复: [PATCH V2 0/2] " gaoliming via groups.io
2024-01-03 10:36 ` [edk2-devel] " Li, Yi
[not found] <17A26769C8DD363C.24485@groups.io>
2023-12-29 13:09 ` Li, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR11MB834234232B983056F50D4ADEA161A@CH3PR11MB8342.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox