From: "Heng Luo" <heng.luo@intel.com>
To: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kasbekar, Saloni" <saloni.kasbekar@intel.com>,
"Clark-williams, Zachary" <zachary.clark-williams@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP
Date: Tue, 9 Jan 2024 03:17:29 +0000 [thread overview]
Message-ID: <CH3PR11MB8776165CE0CDC2CFF4B569B9936A2@CH3PR11MB8776.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CH3PR11MB877688AB9B4C393FB0723F559360A@CH3PR11MB8776.namprd11.prod.outlook.com>
HI Liming,
All checks have passed in https://github.com/tianocore/edk2/pull/5075. What do I need to do?
Thanks,
Heng
> -----Original Message-----
> From: Luo, Heng
> Sent: Wednesday, January 3, 2024 1:55 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary
> <Zachary.Clark-williams@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if
> not connect to AP
>
> Thank Liming, here is the PR:
> https://github.com/tianocore/edk2/pull/5075
>
> Thanks,
> Heng
>
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Wednesday, January 3, 2024 8:55 AM
> > To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Kasbekar,
> > Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary
> > <zachary.clark- williams@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan
> > only if not connect to AP
> >
> > Heng:
> > Can you help create pull request for this patch? Once it pass CI, I
> > will merge it.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng Luo
> > > 发送时间: 2024年1月2日 16:55
> > > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams,
> > > Zachary <zachary.clark-williams@intel.com>; devel@edk2.groups.io;
> > > Kinney, Michael D <michael.d.kinney@intel.com>
> > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan
> > > only
> > if
> > > not connect to AP
> > >
> > > Hi Mike,
> > > Would you like to help us merge the patch?
> > >
> > > Thanks,
> > > Heng
> > >
> > > > -----Original Message-----
> > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > > > Sent: Friday, December 15, 2023 4:36 AM
> > > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary
> > > <zachary.clark-
> > > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > > not
> > > connect
> > > > to AP
> > > >
> > > > Mike,
> > > >
> > > > Would you be able to help us merge the patch?
> > > >
> > > > Thanks,
> > > > Saloni
> > > >
> > > > -----Original Message-----
> > > > From: Luo, Heng <heng.luo@intel.com>
> > > > Sent: Thursday, December 14, 2023 3:20 AM
> > > > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>;
> > Kasbekar,
> > > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io
> > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > > not
> > > connect
> > > > to AP
> > > >
> > > > Hi Saloni,
> > > > Could you help to merge the patch?
> > > >
> > > > Thanks,
> > > > Heng
> > > >
> > > > > -----Original Message-----
> > > > > From: Luo, Heng
> > > > > Sent: Monday, December 11, 2023 4:13 PM
> > > > > To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>;
> > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>;
> > > > > devel@edk2.groups.io
> > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only
> > > > > if not connect to AP
> > > > >
> > > > > Hi Zack,
> > > > > Could you please review the change?
> > > > > Thanks,
> > > > > Heng
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > > > > > Sent: Saturday, December 2, 2023 5:25 AM
> > > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io
> > > > > > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com>
> > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only
> > > > > > if not connect to AP
> > > > > >
> > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > > > > >
> > > > > > Thanks,
> > > > > > Saloni
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Luo, Heng <heng.luo@intel.com>
> > > > > > Sent: Monday, November 27, 2023 7:07 PM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>;
> > > > > > Clark-williams, Zachary <zachary.clark-williams@intel.com>
> > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if
> > > > > > not connect to AP
> > > > > >
> > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
> > > > > >
> > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is
> > > > > > considered as a static and Wi-Fi roaming support is not needed.
> > > > > > Wifi connection manager should not initiate Scan requests in
> > > > > > this state affect BSS client connectivity and must be avoided.
> > > > > > Triger regularly scan only if not connect to AP.
> > > > > >
> > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com>
> > > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> > > > > > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> > > > > > ---
> > > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> |
> > > 4
> > > > ++-
> > > > > -
> > > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git
> > > > > >
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > >
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > > index d1182e52bd..4c5460b65c 100644
> > > > > > ---
> > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > > +++
> > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
> > > > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime >
> > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&-
> > > (Nic-
> > > > > > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime
> > > > > > >>
> > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
> > > > > WifiMgrConnectedToAp))
> > > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState ==
> > > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE;
> > > Nic-
> > > > > > >ScanTickTime = 0;--
> > > > > > 2.31.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113419): https://edk2.groups.io/g/devel/message/113419
Mute This Topic: https://groups.io/mt/103497585/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-09 3:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 3:06 [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Heng Luo
2023-12-01 21:24 ` Saloni Kasbekar
2023-12-11 8:12 ` Heng Luo
2023-12-14 11:19 ` Heng Luo
2023-12-14 20:36 ` Saloni Kasbekar
2024-01-02 8:54 ` Heng Luo
2024-01-03 0:54 ` 回复: " gaoliming via groups.io
2024-01-03 5:55 ` Heng Luo
2024-01-09 3:17 ` Heng Luo [this message]
[not found] ` <17A88F83F824C8C1.24350@groups.io>
2024-01-15 3:08 ` Heng Luo
2024-01-15 5:01 ` 回复: " gaoliming via groups.io
2024-01-15 5:31 ` Heng Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR11MB8776165CE0CDC2CFF4B569B9936A2@CH3PR11MB8776.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox