From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4E496740049 for ; Mon, 11 Dec 2023 08:13:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=y7/DLYvuXXbWUnNvc8QpcIMyvoqeuFk6BR+PwQyCOiE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702282384; v=1; b=riXkniWLdh8Hw6KgUdB8bRSuGe5fAUK077a47jNVF/cKO3q6EC2AorGQVxevwSaRDgtnFHjN 6Bzk2/zZF0QT6JU6gnDBRqjYX+kP1kDVUptrSDqMADLMY3E17wEz3OIoLZzONG+4E15Uxg1NcDC EAKphzvjc07DvU3/M5NyqmqY= X-Received: by 127.0.0.2 with SMTP id 09ZYYY7687511xoCyWRlkHxI; Mon, 11 Dec 2023 00:13:04 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mx.groups.io with SMTP id smtpd.web11.3691.1702282383851632397 for ; Mon, 11 Dec 2023 00:13:04 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="1421610" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="1421610" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 00:13:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="776580080" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="776580080" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Dec 2023 00:13:02 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Dec 2023 00:12:59 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 11 Dec 2023 00:12:59 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 11 Dec 2023 00:12:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etKqQpw5UUkzVAEdeclPnm7lFsVJQQsaecv/eaHEzG1oaetexg/CSH07fw/74H1ukMffyIdkuvdSMP4i8IkUDkRhNq8A1/L7lRlfotzrzLGvJJ02fCHKTi3a/iq5C/Vk/6TTpjczOfKFd3q2la/9MTCIlYW3LW67ASm6VOSxMFORasie3GNWPyjt8m/g2PT1m0iE32u9/SnEujKSxC2ANl7MpLpPMDYuwWwWggO05u9llJK7r04kB7T2Gn9gDSMke6Rs6olm8BYUbClGz/0UhOu7SgWdjW2FNeyhtIcqSm3iELJI2HuRK6h1IizLLC750m6lkKXbs3dFu+QeS9utrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vWz2dhEoFDwgL1tN3ZE9ZOiMmTGkNaPCDhRh82Ve7A8=; b=bdpIdbQsepXlGqmymA+5SxNBqhtSR1yLyDqZkoIeDGEfYZMsI9KrmRYZHNdESgCDS0NldjYyxPKT4GFs7pI5exIXeAbe+72WO+QtSA1os6rohcjAi/HxiZ2xuyoyDkNZkb67NJCb9/ckb5C23pcwIiyBjSNibuQx7PQ1PIeXCePFqwOFoM9aI1Qk9H/Du/7htKSyoKAX/XfcDP4eiZIpJD8sTYqm7dz2DrLxBgQa/1a2+G1nu45CcLgH5d2ZDeic2re30RqfH6hHRB366PaR2vYShW1eAxjMQuLVQbf5QAfAAzmdBZQ0FaTFjZUsQzUoKF88h0tRP1aIbvjFuF4xnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CH3PR11MB8776.namprd11.prod.outlook.com (2603:10b6:610:1c1::21) by SA1PR11MB7038.namprd11.prod.outlook.com (2603:10b6:806:2b3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 08:12:55 +0000 X-Received: from CH3PR11MB8776.namprd11.prod.outlook.com ([fe80::911b:5048:c9d:a09a]) by CH3PR11MB8776.namprd11.prod.outlook.com ([fe80::911b:5048:c9d:a09a%4]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023 08:12:54 +0000 From: "Heng Luo" To: "Clark-williams, Zachary" , "Kasbekar, Saloni" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Thread-Topic: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Thread-Index: AQHaIaf8hTGKBhWZSEude7fCg2ClbbCU9gPggA7Z3uA= Date: Mon, 11 Dec 2023 08:12:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB8776:EE_|SA1PR11MB7038:EE_ x-ms-office365-filtering-correlation-id: 453e4b0d-370b-41d5-4671-08dbfa20f9ce x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: MWm+WVj5ij117cY48N5+pzKsxkCUkF/1urdyYqVBhIebJmS/8XKPhzexCE2CFsltvB7GAuPmA35tH3dzqTr9n7VUoEgWyeyvRwu+bNsyLjsiaw/WWP3LHzf+W48t6Y4qWdmobjmafqVZLuomPLJBP54AI1KeOll08SH6JgIb7PY4kXKPFhKHvCGjvZBfDGY8dcRM4E40vqQmvmVaPvZqbYxA3JnnvC7M9hrU18vpdyMRuNIv3y09jadMG1wLLI+/SluGZSj6KUNrPE5crSv3zoMgSxlTInoN9ravAvbRgmbzxbI3qvPTuPboCQrl6PQx0fcB5RT9bsTgmxE6cy7i4hcQlcJWpF1/MLSpEzWBca9c7CJRPGt1kjO1cBLGcmkbHARtjVHFbVvSUAF37WXH164duS3C1Hrd0LV1KtV/w5BNk4yWCCkR3r60s+eC2NUPqzzd42WK4s6pDNY2foVHRLygSpvGkRHiRo7egd22SYymQBj4s/6IAMsHpuaWqomSzfpp2cylrQGYWpr+PHbUIhA+Jj/28gA3HeTqonVTpT23zNRp+UJiSaCfhBYPFiffKa6AoxRE88uFu5lABGNS4hXPSzHmshma/j7tirooLbI= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gOf+W5uxQ7EgO8cHsGg09FG39OjM36xkecns71JZkiPYyCcYMzwPDmRapndr?= =?us-ascii?Q?/62dUux0SX4WRR1kNY5A5nMmC27NwiwHpOdHQmfpTbA/bMPiFirGbH7kvYhK?= =?us-ascii?Q?F/unRue7agnQmPluRYFHnoA0NsDG6+E7BqcOiuISw2WykFX4JVTQV9snUvsn?= =?us-ascii?Q?sp+OnMs5mlhDvuhUjSuBasoB+IcHuTxw+UFlo0ghYxgNtDdXbDKbZ6rCh2yg?= =?us-ascii?Q?BldFfn4quqoytL2x3fDdzKd9vFFNim7gsvPJ0kgq/9wgEHHtmi5LBuLDQzYN?= =?us-ascii?Q?h+ppU2fWcJgX8+NNAEHBSxaMm+4Se9jaJ4LsN/1xlFSLcMsX3t1Bki4gvhfG?= =?us-ascii?Q?xifY7YyXTMJVaunbL9xJwIDJufSKdvBAUjjlryIgQk+5Y/o/rWrG3yFni7xg?= =?us-ascii?Q?UC6aghrXuUrUXie1X7kz2KbYL6PU5lmWaEJh2q50zYcDIkrRKgP6YWfZAqvG?= =?us-ascii?Q?XPWVxljNjxzikXBOUAmppVnXdgUJTzYh4JoCi8j6AkAijaWfYtl8MNtQkfwz?= =?us-ascii?Q?3qGGYVn8mTQQqobs3SHB0dcEmFKvAMFc5UleBaiJxi8LmOUjD2z9ptq4KGHE?= =?us-ascii?Q?BISvpf1H+ZmFhZXKVQnapMQiH9SYH4egQomDyM3gBnZAccJphEROqALwww68?= =?us-ascii?Q?mb2kySc5NNKzPxkVIY1B8V5MEy4OnvxPc1esNCdJY+dWsagfY70QbrOS84GT?= =?us-ascii?Q?zumzFGVj9GFW8AnuZe93UPKrAJKSnjChxWXNG0GkIQfgndoKdlrmyCO6hl/a?= =?us-ascii?Q?EmbSBaPcR0DhgLjWaihloVC/96JfDm8+Z2e+ZzkPNpiL54sdmMvj+zapiHXK?= =?us-ascii?Q?Fjq+jZSW33fUA/HcLpJanQHPJ2B43v+bwiRWQA25bC19xIGpl0HhcyDMA6PY?= =?us-ascii?Q?20uMfnhhDnFU/xuCwg5pXd70ENOZFCRBksqoLu+xy3nIpzCb8NE2I70YbIqQ?= =?us-ascii?Q?oJ1JMTieFiII4Z+rKCi2gWedvt7VHZCpV7AVnJfAwh+mPnq3GhokyRsd8x2o?= =?us-ascii?Q?j+YekziQyzXZG8OIVBJAxRa2IboJuEZk4dMMuC7HCpn9837QTL9MLeynhAqu?= =?us-ascii?Q?pGgNWMX+dP+xhp+F/1QdRQ9q9iU+S6so8+wCGqBJRnHMxwgbNn71Ko+NzKvv?= =?us-ascii?Q?mBuXwcGq03l6SjiiVLnyYWjbD9Dgc4zSxubGvdGAbD5BGnaSpt7MnXQMu6Ca?= =?us-ascii?Q?ATBaPzTemrl2SOKsNDfu1gKK5m5EenPeLz2i8TFIPw9e3Q5YtRnM0v3h5jgW?= =?us-ascii?Q?b1NNcmT+2YbNjIj0ifPz1zjopA5a4cvFOCgwCD8aqAZoRnvJRgCfh4Z0n3A9?= =?us-ascii?Q?u1JUGiGYiK/x00JIYhm72hpxBg7+CFgHEKHd6bJ1tWniXbDMY5RArVgq0PDz?= =?us-ascii?Q?A7SXsCvCReuv4SDGhilgnFIc/hYVslCuGcLGFoNAG6hBEHD1wWZ0hWpSWC6Y?= =?us-ascii?Q?BxovhHO3tPkC/WlJI0HNzY3EicSS3eg5eVMJQKBQX5EPXLo7p+wjraWSR8A0?= =?us-ascii?Q?mKS2Wa3FWgQ2udms0noZ969yZAhzVVof4t+sGa9weRUTKrWhObgbyVrzQAo9?= =?us-ascii?Q?bCSremNyiVsgrPLfbxs=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 453e4b0d-370b-41d5-4671-08dbfa20f9ce X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2023 08:12:53.9701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V/NvbW/PrIvaCiMc4dIslER59o+h7kUK2gAMu1wIMVMpXjiCv7fkZL11IjaxxcgMvGkaZ85Rr/3TTAqCwSAczQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7038 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heng.luo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LE6t8h3XPtaOTxzdGhpq6mWbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=riXkniWL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Zack, Could you please review the change? Thanks, Heng > -----Original Message----- > From: Kasbekar, Saloni > Sent: Saturday, December 2, 2023 5:25 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Clark-williams, Zachary > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not con= nect > to AP >=20 > Reviewed-by: Kasbekar, Saloni >=20 > Thanks, > Saloni >=20 > -----Original Message----- > From: Luo, Heng > Sent: Monday, November 27, 2023 7:07 PM > To: devel@edk2.groups.io > Cc: Kasbekar, Saloni ; Clark-williams, Zachary > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect= to > AP >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4605 >=20 > When UEFI Wi-Fi is in BSS connected state, the platform is considered as = a > static and Wi-Fi roaming support is not needed. > Wifi connection manager should not initiate Scan requests in this state a= ffect > BSS client connectivity and must be avoided. > Triger regularly scan only if not connect to AP. >=20 > Signed-off-by: Heng Luo > Cc: Saloni Kasbekar > Cc: Zachary Clark-williams > --- > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > index d1182e52bd..4c5460b65c 100644 > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > >ScanState =3D=3D WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=3D WifiMgrConnectedToAp)) > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState =3D=3D > WifiMgrScanFinished)) { Nic->OneTimeScanRequest =3D FALSE; Nic- > >ScanTickTime =3D 0;-- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112272): https://edk2.groups.io/g/devel/message/112272 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-