From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 110BB94151E for ; Thu, 14 Dec 2023 11:19:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XcsUPh48BjwrqSxbRHKAwMP0oIH1e1w32cxxezvOpbY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702552781; v=1; b=rAUhM67QQwMRrnWeNo5UaDyneyVNiyDsGWtdVOCAN+NSSye6K+qa6spHiUUe1ZmoO8bIpdIv ruz2I47SrhkllW2s6hI40I32S78uX11ICHaP/lYH9bthadm9SaRsoEw9ZoJn2Mty2BLFKGZy/vF Z/CNiYoEx/tSAmWyEfddSWew= X-Received: by 127.0.0.2 with SMTP id yxFsYY7687511xHtlxu3PHbt; Thu, 14 Dec 2023 03:19:41 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.19734.1702552780804735177 for ; Thu, 14 Dec 2023 03:19:41 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="375259366" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="375259366" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 03:19:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1105669760" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="1105669760" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Dec 2023 03:19:40 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Dec 2023 03:19:40 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 14 Dec 2023 03:19:40 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 14 Dec 2023 03:19:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IwVQTqQ90btO+7LWy2/yMEjfhfK7a6HDVEcc2UGSPyn8YOXdBJ3vSWR3lAEDScj/j9i2lM/KSb54562ri7Cdb0E9CL/m0kqzKvIvfXdzEtiYjVSIGQVWTBIW2WaALZ9lM+UnhBpdvVGJSEFkqalEjjRptsEvlSbkIkQ6y5vVkh3wooMtH0ZzyILw8so5B7J3O4QbKXR5DaOeM1oDdbVqKetHEI76oxmE24D/qD84esys3lFv2FmD8V2OOa8XkP0iw85HjUwBQRwLpH03Ev1FeYue8m/1u0/IiSiBjfTz9siJM7cLLAOPlyuvxaF/LKa9xBa7xCkIKHN/VpVVLgjrGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hB22+B/6j2ElS8jgN6Fn22IaqmxXtWTKsneUPAKxvpc=; b=RzXg9K+822BpvQfqyKCoend6xeZ6pqNJdUf9BngnCL/EVTCnqpvnq9aa16repxZu9uUVNhj4s3V9DzDY5Gcj3gSDqBmKwRcXwa8m6fNkA2KOYj1WZpjcUk/N3kkCac2z0BgX8DeL3yD3LRSf2k9mUxia67esS2v1PGZyWewPcNYX/HELIiEr8WGWuTgWa0yXlaQPk114tSqiiotp8tm0VrRlgQS52fMio+9DKTolM9LY9claMA8kj/D07nhtlo/7vdf6xFg3DScBfcssBLsVZVh3Vy6JzaFRhw5newNpVxlxyIlfg94lrKjz3Dfx0Mgm3YgRfjgOXWS6BT+vomPX3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CH3PR11MB8776.namprd11.prod.outlook.com (2603:10b6:610:1c1::21) by PH0PR11MB5782.namprd11.prod.outlook.com (2603:10b6:510:147::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 11:19:37 +0000 X-Received: from CH3PR11MB8776.namprd11.prod.outlook.com ([fe80::911b:5048:c9d:a09a]) by CH3PR11MB8776.namprd11.prod.outlook.com ([fe80::911b:5048:c9d:a09a%4]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 11:19:37 +0000 From: "Heng Luo" To: "Clark-williams, Zachary" , "Kasbekar, Saloni" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Thread-Topic: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Thread-Index: AQHaIaf8hTGKBhWZSEude7fCg2ClbbCU9gPggA7Z3uCABOsO0A== Date: Thu, 14 Dec 2023 11:19:36 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB8776:EE_|PH0PR11MB5782:EE_ x-ms-office365-filtering-correlation-id: 1a4cacc2-51c9-464a-42ad-08dbfc968e48 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: n2+5mzz5quwrhu8en9sqolBP9JeQRugj7qLO4A8CyOvmkdZRKq3htMCWWm90KRMSFSNs87MDK3xIpff9NWgFcurNY8jcDYKPGHndWHQGCIMxec6nAoYaeV0czGcegoDEET8hJ/MmdokyqgcYKRwAH9mpQNFjUvRNao8wqfluen2b5+uw74TMv5V4uzMoUGZvIOsDU0xhmTGTeVHqZ6EPNtz7pXpl3xXPW4mt0xnn73HoOd0rBT2TM0LYzwaL6GuSPVY43i/QTjO3vVW/Be1xgrL+wR4XHvcmBcIMBvvEjtrAvwHFRbGsmz2IK7cc3YNANKtFIKPsZHjyUDi9voxmtNNrUywol6NbI5ApDXIjC2D/0W3PfuBp4IMcJXD1wR0t+Hz4HqdR7uXOiI+tmGr5zGQ/rmYCgiQtv1IRAQmoZw/SaWaOot3LrgbSYwTIMMcbufsf0kHN60TxdRAI3yNsMQkbHrEiKmBEvc+wIFyidpv4ahlnseEi6ScxkM8KDkRkM+PlGtV62gBRXPJ2IAqeiEjxljO5kkgethbJgWH+NW8gajW/HiO/QXkR9gBQkxnavh35IAP24d8XzDAd6AfTjib4hRfTBOgxF+6UfLxGFhA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e5NEnt8/CeAUnDg8KppGWTdwI2tErm9VkGf2uu+BnPgHdshcjdTG01dOn1Uw?= =?us-ascii?Q?l9UhYb2CxFTK7rvBAaxl4ftHYGvWhpRxVXby+nI0OK8qBAukC40jCDsSssJh?= =?us-ascii?Q?A3D6cuYNv9vzWsi33Phnbn/C6m4ZnPWwfqJAOuBhOwJrgRy31IGBRNgL7S7x?= =?us-ascii?Q?8pjHO4MwAwVJxniDPY1+Mg7wglLgCCRW9KrDAD0DfSjBiGY1unh+d2s4a53l?= =?us-ascii?Q?vd4i6URU6T6WLf/HdBkM6pb7LGy9NuVEmkwGd8OFduu6cJaTmWCoiHoCTBxP?= =?us-ascii?Q?jf6exDwhRnkPcP+Exw9SKG3UrJTjfiMDU458gn6FgxyPAX8UMY/Ztrz2GlGp?= =?us-ascii?Q?WeVyasxMEcbD5VQjgfzu/gUh5nKXtyvr3o8BhK+TBVChjFJwTkluSa1LfDJY?= =?us-ascii?Q?K1o2oAD175PARySLsEf9Udx4NhOkcxrWatTVcDonPk6hQrvwONPOEx14RJSl?= =?us-ascii?Q?IaBxwVXBX0zfTx+1pRbM8bC7j6jZaxH/1SfNZbmtvViP/wE6zmSxcVWl5Blr?= =?us-ascii?Q?4Pk6DUhyCdhEoBKlgJFTfkRjSPImbSBkn2f4ShxSKDV0UXFAbx6oHeNsZWHO?= =?us-ascii?Q?5oCXiPxTAr7Q26gaYpDEQFrXtDf1fNUe2L78Eua4MesaEW4gdEwwzXfSLLR6?= =?us-ascii?Q?4tuJTpC41+r6vKPZuuNxG8o3lDrW2rrVEN7zsaoMCCaur1L0jQypmCpYV0W3?= =?us-ascii?Q?pcTdV0M2kbI7RfiG/BSxp6PTeBJnH6RolRg0ckXqcwdSolWaSdCdCzLeksOP?= =?us-ascii?Q?r/LLOzbTdtysukx34tBvzHveq+TGF08oYrgx0QVi/dmk8V2+/9WeVV58Nyyb?= =?us-ascii?Q?00S2Z+6J8fmP/yOrZYNqqiah6lnTd+Bw3LppE0OcK/4MTX8/5iolpcz7IOXr?= =?us-ascii?Q?fc2W+FQGh/Rgo6JiJhuZhY8Ffsoserzq8UFvmg7Ge2TA0/ZF5Ud3FiY6ivpD?= =?us-ascii?Q?m2LWVDBhM6CGOJypJNWIUHketf/LLGqgkBBmyeeebLKuuVWDyatlTFwONKRD?= =?us-ascii?Q?YExD+fHqTp6KelbvAajQ5PMLRorkC2kBCZLKzz4qghvy+MF7wolZ547f4zaB?= =?us-ascii?Q?bASjZgvkY1NkxorvhLK50dh3skyQAm0/L3dDlBPaySFKUicG5ju/7G5vRtaz?= =?us-ascii?Q?FJW1NmrgPeZGmVB2n+EEQBPSwda/t4icc9rEDQpkl6Bz337uM+BeRjN/wYiZ?= =?us-ascii?Q?+JVD4PcpFkl5d8J/dw4B4M7fJSpanG+jLHzI3WuX/XLXEjYKFhMU9Pmq4HoK?= =?us-ascii?Q?EEpPB1OsBXMRwD375rTy6233Rm8kAJRIJETy4JDglKF14Nsho3tLNfkrix0h?= =?us-ascii?Q?GeS8d139Y/+/Ir6u1cJPoZngj9edSRP2qEWAmMuGQBmYxNIdQZz/vpWgKN/K?= =?us-ascii?Q?t3tRbazlTNa7PoQjsQQdIfKRSpl66fD/zNlgRkFfIDIlN/zzM6gaAL2baDnx?= =?us-ascii?Q?g2A/FWRdi+ISbowXKAUaZ79JVIqnJOsyXOvJ2Km8P8vpGO12TjtYuw1Yfsw7?= =?us-ascii?Q?wT877TrGbUTSI8+eJRr9U93vmoG+6z4/cD6z3o8ClUmTacHs/47SU+G1FaPx?= =?us-ascii?Q?sbO6684aOHN8yUW8i9fgX729sXeR7BDWPHycMK+b?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a4cacc2-51c9-464a-42ad-08dbfc968e48 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2023 11:19:36.5376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9crJO+2EQ4HAQOj0ZTtuGprkaIGjOAoJxDwydeKCNg9and+xp4DeUDYUHfABb0kknSx6sVuT/XjNnmlezHNaTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5782 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heng.luo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: datQcg62mo1KnfIR6VLavd8cx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rAUhM67Q; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Saloni, Could you help to merge the patch? Thanks, Heng > -----Original Message----- > From: Luo, Heng > Sent: Monday, December 11, 2023 4:13 PM > To: Clark-williams, Zachary ; Kasbekar, > Saloni ; devel@edk2.groups.io > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not con= nect > to AP >=20 > Hi Zack, > Could you please review the change? > Thanks, > Heng >=20 > > -----Original Message----- > > From: Kasbekar, Saloni > > Sent: Saturday, December 2, 2023 5:25 AM > > To: Luo, Heng ; devel@edk2.groups.io > > Cc: Clark-williams, Zachary > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > connect to AP > > > > Reviewed-by: Kasbekar, Saloni > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Luo, Heng > > Sent: Monday, November 27, 2023 7:07 PM > > To: devel@edk2.groups.io > > Cc: Kasbekar, Saloni ; Clark-williams, > > Zachary > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > connect to AP > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4605 > > > > When UEFI Wi-Fi is in BSS connected state, the platform is considered > > as a static and Wi-Fi roaming support is not needed. > > Wifi connection manager should not initiate Scan requests in this > > state affect BSS client connectivity and must be avoided. > > Triger regularly scan only if not connect to AP. > > > > Signed-off-by: Heng Luo > > Cc: Saloni Kasbekar > > Cc: Zachary Clark-williams > > --- > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++- > - > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > index d1182e52bd..4c5460b65c 100644 > > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > > >ScanState =3D=3D WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=3D > WifiMgrConnectedToAp)) > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState =3D=3D > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest =3D FALSE; Ni= c- > > >ScanTickTime =3D 0;-- > > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112521): https://edk2.groups.io/g/devel/message/112521 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-