* [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP @ 2023-11-28 3:06 Heng Luo 2023-12-01 21:24 ` Saloni Kasbekar 0 siblings, 1 reply; 12+ messages in thread From: Heng Luo @ 2023-11-28 3:06 UTC (permalink / raw) To: devel; +Cc: Saloni Kasbekar, Zachary Clark-williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 When UEFI Wi-Fi is in BSS connected state, the platform is considered as a static and Wi-Fi roaming support is not needed. Wifi connection manager should not initiate Scan requests in this state affect BSS client connectivity and must be avoided. Triger regularly scan only if not connect to AP. Signed-off-by: Heng Luo <heng.luo@intel.com> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> --- NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c index d1182e52bd..4c5460b65c 100644 --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( } Nic->ScanTickTime++; - if (((Nic->ScanTickTime > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) && - (Nic->ScanState == WifiMgrScanFinished)) + if ((((Nic->ScanTickTime > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != WifiMgrConnectedToAp)) || + Nic->OneTimeScanRequest) && (Nic->ScanState == WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic->ScanTickTime = 0; -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111780): https://edk2.groups.io/g/devel/message/111780 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2023-11-28 3:06 [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Heng Luo @ 2023-12-01 21:24 ` Saloni Kasbekar 2023-12-11 8:12 ` Heng Luo 0 siblings, 1 reply; 12+ messages in thread From: Saloni Kasbekar @ 2023-12-01 21:24 UTC (permalink / raw) To: Luo, Heng, devel@edk2.groups.io; +Cc: Clark-williams, Zachary Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> Thanks, Saloni -----Original Message----- From: Luo, Heng <heng.luo@intel.com> Sent: Monday, November 27, 2023 7:07 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark-williams@intel.com> Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 When UEFI Wi-Fi is in BSS connected state, the platform is considered as a static and Wi-Fi roaming support is not needed. Wifi connection manager should not initiate Scan requests in this state affect BSS client connectivity and must be avoided. Triger regularly scan only if not connect to AP. Signed-off-by: Heng Luo <heng.luo@intel.com> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> --- NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c index d1182e52bd..4c5460b65c 100644 --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic->ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != WifiMgrConnectedToAp)) ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic->ScanTickTime = 0;-- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111987): https://edk2.groups.io/g/devel/message/111987 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2023-12-01 21:24 ` Saloni Kasbekar @ 2023-12-11 8:12 ` Heng Luo 2023-12-14 11:19 ` Heng Luo 0 siblings, 1 reply; 12+ messages in thread From: Heng Luo @ 2023-12-11 8:12 UTC (permalink / raw) To: Clark-williams, Zachary, Kasbekar, Saloni, devel@edk2.groups.io Hi Zack, Could you please review the change? Thanks, Heng > -----Original Message----- > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > Sent: Saturday, December 2, 2023 5:25 AM > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com> > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect > to AP > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > Thanks, > Saloni > > -----Original Message----- > From: Luo, Heng <heng.luo@intel.com> > Sent: Monday, November 27, 2023 7:07 PM > To: devel@edk2.groups.io > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > <zachary.clark-williams@intel.com> > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to > AP > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > When UEFI Wi-Fi is in BSS connected state, the platform is considered as a > static and Wi-Fi roaming support is not needed. > Wifi connection manager should not initiate Scan requests in this state affect > BSS client connectivity and must be avoided. > Triger regularly scan only if not connect to AP. > > Signed-off-by: Heng Luo <heng.luo@intel.com> > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> > --- > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > index d1182e52bd..4c5460b65c 100644 > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != WifiMgrConnectedToAp)) > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic- > >ScanTickTime = 0;-- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112272): https://edk2.groups.io/g/devel/message/112272 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2023-12-11 8:12 ` Heng Luo @ 2023-12-14 11:19 ` Heng Luo 2023-12-14 20:36 ` Saloni Kasbekar 0 siblings, 1 reply; 12+ messages in thread From: Heng Luo @ 2023-12-14 11:19 UTC (permalink / raw) To: Clark-williams, Zachary, Kasbekar, Saloni, devel@edk2.groups.io Hi Saloni, Could you help to merge the patch? Thanks, Heng > -----Original Message----- > From: Luo, Heng > Sent: Monday, December 11, 2023 4:13 PM > To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>; Kasbekar, > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect > to AP > > Hi Zack, > Could you please review the change? > Thanks, > Heng > > > -----Original Message----- > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > Sent: Saturday, December 2, 2023 5:25 AM > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com> > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > connect to AP > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Luo, Heng <heng.luo@intel.com> > > Sent: Monday, November 27, 2023 7:07 PM > > To: devel@edk2.groups.io > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > Zachary <zachary.clark-williams@intel.com> > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > connect to AP > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > When UEFI Wi-Fi is in BSS connected state, the platform is considered > > as a static and Wi-Fi roaming support is not needed. > > Wifi connection manager should not initiate Scan requests in this > > state affect BSS client connectivity and must be avoided. > > Triger regularly scan only if not connect to AP. > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> > > --- > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++- > - > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > index d1182e52bd..4c5460b65c 100644 > > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > WifiMgrConnectedToAp)) > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic- > > >ScanTickTime = 0;-- > > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112521): https://edk2.groups.io/g/devel/message/112521 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2023-12-14 11:19 ` Heng Luo @ 2023-12-14 20:36 ` Saloni Kasbekar 2024-01-02 8:54 ` Heng Luo 0 siblings, 1 reply; 12+ messages in thread From: Saloni Kasbekar @ 2023-12-14 20:36 UTC (permalink / raw) To: Luo, Heng, Clark-williams, Zachary, devel@edk2.groups.io, Kinney, Michael D Mike, Would you be able to help us merge the patch? Thanks, Saloni -----Original Message----- From: Luo, Heng <heng.luo@intel.com> Sent: Thursday, December 14, 2023 3:20 AM To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Hi Saloni, Could you help to merge the patch? Thanks, Heng > -----Original Message----- > From: Luo, Heng > Sent: Monday, December 11, 2023 4:13 PM > To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>; > Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not > connect to AP > > Hi Zack, > Could you please review the change? > Thanks, > Heng > > > -----Original Message----- > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > Sent: Saturday, December 2, 2023 5:25 AM > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com> > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > not connect to AP > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Luo, Heng <heng.luo@intel.com> > > Sent: Monday, November 27, 2023 7:07 PM > > To: devel@edk2.groups.io > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > Zachary <zachary.clark-williams@intel.com> > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > connect to AP > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > considered as a static and Wi-Fi roaming support is not needed. > > Wifi connection manager should not initiate Scan requests in this > > state affect BSS client connectivity and must be avoided. > > Triger regularly scan only if not connect to AP. > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> > > --- > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++- > - > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > index d1182e52bd..4c5460b65c 100644 > > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > WifiMgrConnectedToAp)) > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic- > > >ScanTickTime = 0;-- > > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112548): https://edk2.groups.io/g/devel/message/112548 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2023-12-14 20:36 ` Saloni Kasbekar @ 2024-01-02 8:54 ` Heng Luo 2024-01-03 0:54 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 12+ messages in thread From: Heng Luo @ 2024-01-02 8:54 UTC (permalink / raw) To: Kasbekar, Saloni, Clark-williams, Zachary, devel@edk2.groups.io, Kinney, Michael D Hi Mike, Would you like to help us merge the patch? Thanks, Heng > -----Original Message----- > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > Sent: Friday, December 15, 2023 4:36 AM > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary <zachary.clark- > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect > to AP > > Mike, > > Would you be able to help us merge the patch? > > Thanks, > Saloni > > -----Original Message----- > From: Luo, Heng <heng.luo@intel.com> > Sent: Thursday, December 14, 2023 3:20 AM > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; Kasbekar, > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect > to AP > > Hi Saloni, > Could you help to merge the patch? > > Thanks, > Heng > > > -----Original Message----- > > From: Luo, Heng > > Sent: Monday, December 11, 2023 4:13 PM > > To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>; > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > connect to AP > > > > Hi Zack, > > Could you please review the change? > > Thanks, > > Heng > > > > > -----Original Message----- > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > Sent: Saturday, December 2, 2023 5:25 AM > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > not connect to AP > > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > Thanks, > > > Saloni > > > > > > -----Original Message----- > > > From: Luo, Heng <heng.luo@intel.com> > > > Sent: Monday, November 27, 2023 7:07 PM > > > To: devel@edk2.groups.io > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > > Zachary <zachary.clark-williams@intel.com> > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > > connect to AP > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > > considered as a static and Wi-Fi roaming support is not needed. > > > Wifi connection manager should not initiate Scan requests in this > > > state affect BSS client connectivity and must be avoided. > > > Triger regularly scan only if not connect to AP. > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> > > > --- > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 > ++- > > - > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > index d1182e52bd..4c5460b65c 100644 > > > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > +++ > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > > > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > > WifiMgrConnectedToAp)) > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; Nic- > > > >ScanTickTime = 0;-- > > > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113031): https://edk2.groups.io/g/devel/message/113031 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2024-01-02 8:54 ` Heng Luo @ 2024-01-03 0:54 ` gaoliming via groups.io 2024-01-03 5:55 ` Heng Luo 0 siblings, 1 reply; 12+ messages in thread From: gaoliming via groups.io @ 2024-01-03 0:54 UTC (permalink / raw) To: devel, heng.luo, 'Kasbekar, Saloni', 'Clark-williams, Zachary', 'Kinney, Michael D' Heng: Can you help create pull request for this patch? Once it pass CI, I will merge it. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng Luo > 发送时间: 2024年1月2日 16:55 > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > Zachary <zachary.clark-williams@intel.com>; devel@edk2.groups.io; Kinney, > Michael D <michael.d.kinney@intel.com> > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > Hi Mike, > Would you like to help us merge the patch? > > Thanks, > Heng > > > -----Original Message----- > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > Sent: Friday, December 15, 2023 4:36 AM > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary > <zachary.clark- > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not > connect > > to AP > > > > Mike, > > > > Would you be able to help us merge the patch? > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Luo, Heng <heng.luo@intel.com> > > Sent: Thursday, December 14, 2023 3:20 AM > > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; Kasbekar, > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not > connect > > to AP > > > > Hi Saloni, > > Could you help to merge the patch? > > > > Thanks, > > Heng > > > > > -----Original Message----- > > > From: Luo, Heng > > > Sent: Monday, December 11, 2023 4:13 PM > > > To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>; > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > > connect to AP > > > > > > Hi Zack, > > > Could you please review the change? > > > Thanks, > > > Heng > > > > > > > -----Original Message----- > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > > > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > not connect to AP > > > > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > > Thanks, > > > > Saloni > > > > > > > > -----Original Message----- > > > > From: Luo, Heng <heng.luo@intel.com> > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > To: devel@edk2.groups.io > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > > > Zachary <zachary.clark-williams@intel.com> > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not > > > > connect to AP > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > > > considered as a static and Wi-Fi roaming support is not needed. > > > > Wifi connection manager should not initiate Scan requests in this > > > > state affect BSS client connectivity and must be avoided. > > > > Triger regularly scan only if not connect to AP. > > > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > > > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> > > > > --- > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | > 4 > > ++- > > > - > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > index d1182e52bd..4c5460b65c 100644 > > > > --- > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > +++ > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- > (Nic- > > > > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > > > WifiMgrConnectedToAp)) > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; > Nic- > > > > >ScanTickTime = 0;-- > > > > 2.31.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113046): https://edk2.groups.io/g/devel/message/113046 Mute This Topic: https://groups.io/mt/103494072/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2024-01-03 0:54 ` 回复: " gaoliming via groups.io @ 2024-01-03 5:55 ` Heng Luo 2024-01-09 3:17 ` Heng Luo [not found] ` <17A88F83F824C8C1.24350@groups.io> 0 siblings, 2 replies; 12+ messages in thread From: Heng Luo @ 2024-01-03 5:55 UTC (permalink / raw) To: Gao, Liming, devel@edk2.groups.io, Kasbekar, Saloni, Clark-williams, Zachary, Kinney, Michael D Thank Liming, here is the PR: https://github.com/tianocore/edk2/pull/5075 Thanks, Heng > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Wednesday, January 3, 2024 8:55 AM > To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Kasbekar, Saloni > <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark- > williams@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > if not connect to AP > > Heng: > Can you help create pull request for this patch? Once it pass CI, I will merge > it. > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng Luo > > 发送时间: 2024年1月2日 16:55 > > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > Zachary <zachary.clark-williams@intel.com>; devel@edk2.groups.io; > > Kinney, Michael D <michael.d.kinney@intel.com> > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > if > > not connect to AP > > > > Hi Mike, > > Would you like to help us merge the patch? > > > > Thanks, > > Heng > > > > > -----Original Message----- > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > Sent: Friday, December 15, 2023 4:36 AM > > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary > > <zachary.clark- > > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > <michael.d.kinney@intel.com> > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > not > > connect > > > to AP > > > > > > Mike, > > > > > > Would you be able to help us merge the patch? > > > > > > Thanks, > > > Saloni > > > > > > -----Original Message----- > > > From: Luo, Heng <heng.luo@intel.com> > > > Sent: Thursday, December 14, 2023 3:20 AM > > > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; > Kasbekar, > > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > not > > connect > > > to AP > > > > > > Hi Saloni, > > > Could you help to merge the patch? > > > > > > Thanks, > > > Heng > > > > > > > -----Original Message----- > > > > From: Luo, Heng > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>; > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > not connect to AP > > > > > > > > Hi Zack, > > > > Could you please review the change? > > > > Thanks, > > > > Heng > > > > > > > > > -----Original Message----- > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > > > > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not connect to AP > > > > > > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > > > > Thanks, > > > > > Saloni > > > > > > > > > > -----Original Message----- > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > > not connect to AP > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > > > > considered as a static and Wi-Fi roaming support is not needed. > > > > > Wifi connection manager should not initiate Scan requests in > > > > > this state affect BSS client connectivity and must be avoided. > > > > > Triger regularly scan only if not connect to AP. > > > > > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > > > > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> > > > > > --- > > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | > > 4 > > > ++- > > > > - > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git > > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > index d1182e52bd..4c5460b65c 100644 > > > > > --- > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > +++ > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- > > (Nic- > > > > > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > > > > WifiMgrConnectedToAp)) > > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; > > Nic- > > > > > >ScanTickTime = 0;-- > > > > > 2.31.1.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113058): https://edk2.groups.io/g/devel/message/113058 Mute This Topic: https://groups.io/mt/103497585/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2024-01-03 5:55 ` Heng Luo @ 2024-01-09 3:17 ` Heng Luo [not found] ` <17A88F83F824C8C1.24350@groups.io> 1 sibling, 0 replies; 12+ messages in thread From: Heng Luo @ 2024-01-09 3:17 UTC (permalink / raw) To: Gao, Liming, devel@edk2.groups.io, Kasbekar, Saloni, Clark-williams, Zachary, Kinney, Michael D HI Liming, All checks have passed in https://github.com/tianocore/edk2/pull/5075. What do I need to do? Thanks, Heng > -----Original Message----- > From: Luo, Heng > Sent: Wednesday, January 3, 2024 1:55 PM > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > <Zachary.Clark-williams@intel.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > Thank Liming, here is the PR: > https://github.com/tianocore/edk2/pull/5075 > > Thanks, > Heng > > > -----Original Message----- > > From: gaoliming <gaoliming@byosoft.com.cn> > > Sent: Wednesday, January 3, 2024 8:55 AM > > To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Kasbekar, > > Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > > <zachary.clark- williams@intel.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > only if not connect to AP > > > > Heng: > > Can you help create pull request for this patch? Once it pass CI, I > > will merge it. > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng Luo > > > 发送时间: 2024年1月2日 16:55 > > > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > > Zachary <zachary.clark-williams@intel.com>; devel@edk2.groups.io; > > > Kinney, Michael D <michael.d.kinney@intel.com> > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > only > > if > > > not connect to AP > > > > > > Hi Mike, > > > Would you like to help us merge the patch? > > > > > > Thanks, > > > Heng > > > > > > > -----Original Message----- > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary > > > <zachary.clark- > > > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > <michael.d.kinney@intel.com> > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > not > > > connect > > > > to AP > > > > > > > > Mike, > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > Thanks, > > > > Saloni > > > > > > > > -----Original Message----- > > > > From: Luo, Heng <heng.luo@intel.com> > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; > > Kasbekar, > > > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > not > > > connect > > > > to AP > > > > > > > > Hi Saloni, > > > > Could you help to merge the patch? > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -----Original Message----- > > > > > From: Luo, Heng > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>; > > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > devel@edk2.groups.io > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not connect to AP > > > > > > > > > > Hi Zack, > > > > > Could you please review the change? > > > > > Thanks, > > > > > Heng > > > > > > > > > > > -----Original Message----- > > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > > > > > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not connect to AP > > > > > > > > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > > > > > > Thanks, > > > > > > Saloni > > > > > > > > > > > > -----Original Message----- > > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > > Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if > > > > > > not connect to AP > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > > > > > considered as a static and Wi-Fi roaming support is not needed. > > > > > > Wifi connection manager should not initiate Scan requests in > > > > > > this state affect BSS client connectivity and must be avoided. > > > > > > Triger regularly scan only if not connect to AP. > > > > > > > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > > > > > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> > > > > > > --- > > > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > | > > > 4 > > > > ++- > > > > > - > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git > > > > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > index d1182e52bd..4c5460b65c 100644 > > > > > > --- > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > +++ > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > > > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- > > > (Nic- > > > > > > >ScanState == WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > > > > >> > > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > > > > > WifiMgrConnectedToAp)) > > > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; > > > Nic- > > > > > > >ScanTickTime = 0;-- > > > > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113419): https://edk2.groups.io/g/devel/message/113419 Mute This Topic: https://groups.io/mt/103497585/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <17A88F83F824C8C1.24350@groups.io>]
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP [not found] ` <17A88F83F824C8C1.24350@groups.io> @ 2024-01-15 3:08 ` Heng Luo 2024-01-15 5:01 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 12+ messages in thread From: Heng Luo @ 2024-01-15 3:08 UTC (permalink / raw) To: devel@edk2.groups.io, Luo, Heng, Gao, Liming, Kasbekar, Saloni, Clark-williams, Zachary, Kinney, Michael D Hi Liming & Mike, Could you please help to merge PR https://github.com/tianocore/edk2/pull/5075 ? Thanks, Heng > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo > Sent: Tuesday, January 9, 2024 11:17 AM > To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > <zachary.clark-williams@intel.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > HI Liming, > All checks have passed in https://github.com/tianocore/edk2/pull/5075. What > do I need to do? > > Thanks, > Heng > > > -----Original Message----- > > From: Luo, Heng > > Sent: Wednesday, January 3, 2024 1:55 PM > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > > <Zachary.Clark-williams@intel.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > only if not connect to AP > > > > Thank Liming, here is the PR: > > https://github.com/tianocore/edk2/pull/5075 > > > > Thanks, > > Heng > > > > > -----Original Message----- > > > From: gaoliming <gaoliming@byosoft.com.cn> > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Kasbekar, > > > Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > > > <zachary.clark- williams@intel.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com> > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > scan only if not connect to AP > > > > > > Heng: > > > Can you help create pull request for this patch? Once it pass CI, > > > I will merge it. > > > > > > Thanks > > > Liming > > > > -----邮件原件----- > > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng Luo > > > > 发送时间: 2024年1月2日 16:55 > > > > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > > > Zachary <zachary.clark-williams@intel.com>; devel@edk2.groups.io; > > > > Kinney, Michael D <michael.d.kinney@intel.com> > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > > only > > > if > > > > not connect to AP > > > > > > > > Hi Mike, > > > > Would you like to help us merge the patch? > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -----Original Message----- > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary > > > > <zachary.clark- > > > > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > <michael.d.kinney@intel.com> > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not > > > > connect > > > > > to AP > > > > > > > > > > Mike, > > > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > > > Thanks, > > > > > Saloni > > > > > > > > > > -----Original Message----- > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; > > > Kasbekar, > > > > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > if not > > > > connect > > > > > to AP > > > > > > > > > > Hi Saloni, > > > > > Could you help to merge the patch? > > > > > > > > > > Thanks, > > > > > Heng > > > > > > > > > > > -----Original Message----- > > > > > > From: Luo, Heng > > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > > To: Clark-williams, Zachary > > > > > > <Zachary.Clark-williams@intel.com>; > > > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > > devel@edk2.groups.io > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not connect to AP > > > > > > > > > > > > Hi Zack, > > > > > > Could you please review the change? > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > > > > > > Cc: Clark-williams, Zachary > > > > > > > <zachary.clark-williams@intel.com> > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > only if not connect to AP > > > > > > > > > > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > > > > > > > > Thanks, > > > > > > > Saloni > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > > > To: devel@edk2.groups.io > > > > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > > > Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > > if not connect to AP > > > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > > > > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > > > > > > considered as a static and Wi-Fi roaming support is not needed. > > > > > > > Wifi connection manager should not initiate Scan requests in > > > > > > > this state affect BSS client connectivity and must be avoided. > > > > > > > Triger regularly scan only if not connect to AP. > > > > > > > > > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > > > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > > > > > > Cc: Zachary Clark-williams > > > > > > > <zachary.clark-williams@intel.com> > > > > > > > --- > > > > > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > | > > > > 4 > > > > > ++- > > > > > > - > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git > > > > > > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > index d1182e52bd..4c5460b65c 100644 > > > > > > > --- > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > +++ > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > > > > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- > > > > (Nic- > > > > > > > >ScanState == WifiMgrScanFinished))+ if > > > > > > > >((((Nic->ScanTickTime > > > > > > > >> > > > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > > > > > > WifiMgrConnectedToAp)) > > > > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > > > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = FALSE; > > > > Nic- > > > > > > > >ScanTickTime = 0;-- > > > > > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113788): https://edk2.groups.io/g/devel/message/113788 Mute This Topic: https://groups.io/mt/103497585/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2024-01-15 3:08 ` Heng Luo @ 2024-01-15 5:01 ` gaoliming via groups.io 2024-01-15 5:31 ` Heng Luo 0 siblings, 1 reply; 12+ messages in thread From: gaoliming via groups.io @ 2024-01-15 5:01 UTC (permalink / raw) To: 'Luo, Heng', devel, 'Kasbekar, Saloni', 'Clark-williams, Zachary', 'Kinney, Michael D' Heng: This one has been merged. Thanks Liming > -----邮件原件----- > 发件人: Luo, Heng <heng.luo@intel.com> > 发送时间: 2024年1月15日 11:08 > 收件人: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Gao, > Liming <gaoliming@byosoft.com.cn>; Kasbekar, Saloni > <saloni.kasbekar@intel.com>; Clark-williams, Zachary > <zachary.clark-williams@intel.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > 主题: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if > not connect to AP > > Hi Liming & Mike, > Could you please help to merge PR > https://github.com/tianocore/edk2/pull/5075 ? > > Thanks, > Heng > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng > Luo > > Sent: Tuesday, January 9, 2024 11:17 AM > > To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > > <zachary.clark-williams@intel.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > if > > not connect to AP > > > > HI Liming, > > All checks have passed in https://github.com/tianocore/edk2/pull/5075. > What > > do I need to do? > > > > Thanks, > > Heng > > > > > -----Original Message----- > > > From: Luo, Heng > > > Sent: Wednesday, January 3, 2024 1:55 PM > > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > > > <Zachary.Clark-williams@intel.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com> > > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > only if not connect to AP > > > > > > Thank Liming, here is the PR: > > > https://github.com/tianocore/edk2/pull/5075 > > > > > > Thanks, > > > Heng > > > > > > > -----Original Message----- > > > > From: gaoliming <gaoliming@byosoft.com.cn> > > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > > To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Kasbekar, > > > > Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary > > > > <zachary.clark- williams@intel.com>; Kinney, Michael D > > > > <michael.d.kinney@intel.com> > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > scan only if not connect to AP > > > > > > > > Heng: > > > > Can you help create pull request for this patch? Once it pass CI, > > > > I will merge it. > > > > > > > > Thanks > > > > Liming > > > > > -----邮件原件----- > > > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng > Luo > > > > > 发送时间: 2024年1月2日 16:55 > > > > > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; > Clark-williams, > > > > > Zachary <zachary.clark-williams@intel.com>; devel@edk2.groups.io; > > > > > Kinney, Michael D <michael.d.kinney@intel.com> > > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan > > > > > only > > > > if > > > > > not connect to AP > > > > > > > > > > Hi Mike, > > > > > Would you like to help us merge the patch? > > > > > > > > > > Thanks, > > > > > Heng > > > > > > > > > > > -----Original Message----- > > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary > > > > > <zachary.clark- > > > > > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > <michael.d.kinney@intel.com> > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not > > > > > connect > > > > > > to AP > > > > > > > > > > > > Mike, > > > > > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > > > > > Thanks, > > > > > > Saloni > > > > > > > > > > > > -----Original Message----- > > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > > > To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; > > > > Kasbekar, > > > > > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > if not > > > > > connect > > > > > > to AP > > > > > > > > > > > > Hi Saloni, > > > > > > Could you help to merge the patch? > > > > > > > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Luo, Heng > > > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > > > To: Clark-williams, Zachary > > > > > > > <Zachary.Clark-williams@intel.com>; > > > > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > > > devel@edk2.groups.io > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > > if not connect to AP > > > > > > > > > > > > > > Hi Zack, > > > > > > > Could you please review the change? > > > > > > > Thanks, > > > > > > > Heng > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > > > > > > > Cc: Clark-williams, Zachary > > > > > > > > <zachary.clark-williams@intel.com> > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > > only if not connect to AP > > > > > > > > > > > > > > > > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Saloni > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > > > > To: devel@edk2.groups.io > > > > > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > > > > Clark-williams, Zachary <zachary.clark-williams@intel.com> > > > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only > > > > > > > > if not connect to AP > > > > > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > > > > > > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform is > > > > > > > > considered as a static and Wi-Fi roaming support is not needed. > > > > > > > > Wifi connection manager should not initiate Scan requests in > > > > > > > > this state affect BSS client connectivity and must be avoided. > > > > > > > > Triger regularly scan only if not connect to AP. > > > > > > > > > > > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > > > > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > > > > > > > Cc: Zachary Clark-williams > > > > > > > > <zachary.clark-williams@intel.com> > > > > > > > > --- > > > > > > > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > | > > > > > 4 > > > > > > ++- > > > > > > > - > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > diff --git > > > > > > > > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > index d1182e52bd..4c5460b65c 100644 > > > > > > > > --- > > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > +++ > > > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > > > > > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > > > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- > > > > > (Nic- > > > > > > > > >ScanState == WifiMgrScanFinished))+ if > > > > > > > > >((((Nic->ScanTickTime > > > > > > > > >> > > > > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > > > > > > > WifiMgrConnectedToAp)) > > > > > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > > > > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = > FALSE; > > > > > Nic- > > > > > > > > >ScanTickTime = 0;-- > > > > > > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113792): https://edk2.groups.io/g/devel/message/113792 Mute This Topic: https://groups.io/mt/103733502/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP 2024-01-15 5:01 ` 回复: " gaoliming via groups.io @ 2024-01-15 5:31 ` Heng Luo 0 siblings, 0 replies; 12+ messages in thread From: Heng Luo @ 2024-01-15 5:31 UTC (permalink / raw) To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, Kasbekar, Saloni, Clark-williams, Zachary, Kinney, Michael D Thank Liming! > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > gaoliming via groups.io > Sent: Monday, January 15, 2024 1:02 PM > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io; Kasbekar, Saloni > <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark- > williams@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > if not connect to AP > > Heng: > This one has been merged. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Luo, Heng <heng.luo@intel.com> > > 发送时间: 2024年1月15日 11:08 > > 收件人: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; Gao, > Liming > > <gaoliming@byosoft.com.cn>; Kasbekar, Saloni > > <saloni.kasbekar@intel.com>; Clark-williams, Zachary > > <zachary.clark-williams@intel.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > 主题: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only > > if not connect to AP > > > > Hi Liming & Mike, > > Could you please help to merge PR > > https://github.com/tianocore/edk2/pull/5075 ? > > > > Thanks, > > Heng > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng > > Luo > > > Sent: Tuesday, January 9, 2024 11:17 AM > > > To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > > Zachary <zachary.clark-williams@intel.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com> > > > Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > scan only > > if > > > not connect to AP > > > > > > HI Liming, > > > All checks have passed in https://github.com/tianocore/edk2/pull/5075. > > What > > > do I need to do? > > > > > > Thanks, > > > Heng > > > > > > > -----Original Message----- > > > > From: Luo, Heng > > > > Sent: Wednesday, January 3, 2024 1:55 PM > > > > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > > > Zachary <Zachary.Clark-williams@intel.com>; Kinney, Michael D > > > > <michael.d.kinney@intel.com> > > > > Subject: RE: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > scan only if not connect to AP > > > > > > > > Thank Liming, here is the PR: > > > > https://github.com/tianocore/edk2/pull/5075 > > > > > > > > Thanks, > > > > Heng > > > > > > > > > -----Original Message----- > > > > > From: gaoliming <gaoliming@byosoft.com.cn> > > > > > Sent: Wednesday, January 3, 2024 8:55 AM > > > > > To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>; > > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, > > > > > Zachary > > > > > <zachary.clark- williams@intel.com>; Kinney, Michael D > > > > > <michael.d.kinney@intel.com> > > > > > Subject: 回复: [edk2-devel] [PATCH v2] NetworkPkg: Triger > > > > > regularly scan only if not connect to AP > > > > > > > > > > Heng: > > > > > Can you help create pull request for this patch? Once it pass > > > > > CI, I will merge it. > > > > > > > > > > Thanks > > > > > Liming > > > > > > -----邮件原件----- > > > > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Heng > > Luo > > > > > > 发送时间: 2024年1月2日 16:55 > > > > > > 收件人: Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > Clark-williams, > > > > > > Zachary <zachary.clark-williams@intel.com>; > > > > > > devel@edk2.groups.io; Kinney, Michael D > > > > > > <michael.d.kinney@intel.com> > > > > > > 主题: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly > > > > > > scan only > > > > > if > > > > > > not connect to AP > > > > > > > > > > > > Hi Mike, > > > > > > Would you like to help us merge the patch? > > > > > > > > > > > > Thanks, > > > > > > Heng > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > Sent: Friday, December 15, 2023 4:36 AM > > > > > > > To: Luo, Heng <heng.luo@intel.com>; Clark-williams, Zachary > > > > > > <zachary.clark- > > > > > > > williams@intel.com>; devel@edk2.groups.io; Kinney, Michael D > > > > > > > <michael.d.kinney@intel.com> > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > only if not > > > > > > connect > > > > > > > to AP > > > > > > > > > > > > > > Mike, > > > > > > > > > > > > > > Would you be able to help us merge the patch? > > > > > > > > > > > > > > Thanks, > > > > > > > Saloni > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > > > Sent: Thursday, December 14, 2023 3:20 AM > > > > > > > To: Clark-williams, Zachary > > > > > > > <zachary.clark-williams@intel.com>; > > > > > Kasbekar, > > > > > > > Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > only if not > > > > > > connect > > > > > > > to AP > > > > > > > > > > > > > > Hi Saloni, > > > > > > > Could you help to merge the patch? > > > > > > > > > > > > > > Thanks, > > > > > > > Heng > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Luo, Heng > > > > > > > > Sent: Monday, December 11, 2023 4:13 PM > > > > > > > > To: Clark-williams, Zachary > > > > > > > > <Zachary.Clark-williams@intel.com>; > > > > > > > > Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > > > > devel@edk2.groups.io > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > > only if not connect to AP > > > > > > > > > > > > > > > > Hi Zack, > > > > > > > > Could you please review the change? > > > > > > > > Thanks, > > > > > > > > Heng > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Kasbekar, Saloni <saloni.kasbekar@intel.com> > > > > > > > > > Sent: Saturday, December 2, 2023 5:25 AM > > > > > > > > > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io > > > > > > > > > Cc: Clark-williams, Zachary > > > > > > > > > <zachary.clark-williams@intel.com> > > > > > > > > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly > > > > > > > > > scan only if not connect to AP > > > > > > > > > > > > > > > > > > Reviewed-by: Kasbekar, Saloni > > > > > > > > > <saloni.kasbekar@intel.com> > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Saloni > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Luo, Heng <heng.luo@intel.com> > > > > > > > > > Sent: Monday, November 27, 2023 7:07 PM > > > > > > > > > To: devel@edk2.groups.io > > > > > > > > > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; > > > > > > > > > Clark-williams, Zachary > > > > > > > > > <zachary.clark-williams@intel.com> > > > > > > > > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan > > > > > > > > > only if not connect to AP > > > > > > > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 > > > > > > > > > > > > > > > > > > When UEFI Wi-Fi is in BSS connected state, the platform > > > > > > > > > is considered as a static and Wi-Fi roaming support is not > needed. > > > > > > > > > Wifi connection manager should not initiate Scan > > > > > > > > > requests in this state affect BSS client connectivity and must be > avoided. > > > > > > > > > Triger regularly scan only if not connect to AP. > > > > > > > > > > > > > > > > > > Signed-off-by: Heng Luo <heng.luo@intel.com> > > > > > > > > > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> > > > > > > > > > Cc: Zachary Clark-williams > > > > > > > > > <zachary.clark-williams@intel.com> > > > > > > > > > --- > > > > > > > > > > > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > | > > > > > > 4 > > > > > > > ++- > > > > > > > > - > > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > diff --git > > > > > > > > > > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > > index d1182e52bd..4c5460b65c 100644 > > > > > > > > > --- > > > > > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > > +++ > > > > > > > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > > > > > > > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > > > > > > > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > > > > > > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- > > > > > > (Nic- > > > > > > > > > >ScanState == WifiMgrScanFinished))+ if > > > > > > > > > >((((Nic->ScanTickTime > > > > > > > > > >> > > > > > > > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState != > > > > > > > > WifiMgrConnectedToAp)) > > > > > > > > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState == > > > > > > > > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest = > > FALSE; > > > > > > Nic- > > > > > > > > > >ScanTickTime = 0;-- > > > > > > > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113794): https://edk2.groups.io/g/devel/message/113794 Mute This Topic: https://groups.io/mt/103733790/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-01-16 7:34 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 3:06 [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Heng Luo
2023-12-01 21:24 ` Saloni Kasbekar
2023-12-11 8:12 ` Heng Luo
2023-12-14 11:19 ` Heng Luo
2023-12-14 20:36 ` Saloni Kasbekar
2024-01-02 8:54 ` Heng Luo
2024-01-03 0:54 ` 回复: " gaoliming via groups.io
2024-01-03 5:55 ` Heng Luo
2024-01-09 3:17 ` Heng Luo
[not found] ` <17A88F83F824C8C1.24350@groups.io>
2024-01-15 3:08 ` Heng Luo
2024-01-15 5:01 ` 回复: " gaoliming via groups.io
2024-01-15 5:31 ` Heng Luo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox