[edk2-devel] [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

[edk2-devel] [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

[SuqiangX Ren]

Add the description of FileName to align with UEFI spec 2.10.

REF: UEFI spec 2.10 Table 13.5.16

Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
---
 MdePkg/Include/Guid/FileInfo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/Guid/FileInfo.h b/MdePkg/Include/Guid/FileInfo.h
index 2b7edf36aabc..dad547a847d3 100644
--- a/MdePkg/Include/Guid/FileInfo.h
+++ b/MdePkg/Include/Guid/FileInfo.h
@@ -46,7 +46,7 @@ typedef struct {
   ///
   UINT64      Attribute;
   ///
-  /// The Null-terminated name of the file.
+  /// The Null-terminated name of the file.For a root directory, the name is an empty string.
   ///
   CHAR16      FileName[1];
 } EFI_FILE_INFO;
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112838): https://edk2.groups.io/g/devel/message/112838
Mute This Topic: https://groups.io/mt/103314485/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: RenSuqiang <suqiangx.ren@intel.com>
> 发送时间: 2023年12月22日 14:41
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li
> <yi1.li@intel.com>
> 主题: [PATCH 1/1] MdePkg: Updated the definition of FileName on
> EFI_FILE_INFO
> 
> Add the description of FileName to align with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 Table 13.5.16
> 
> Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Guid/FileInfo.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Guid/FileInfo.h
> b/MdePkg/Include/Guid/FileInfo.h
> index 2b7edf36aabc..dad547a847d3 100644
> --- a/MdePkg/Include/Guid/FileInfo.h
> +++ b/MdePkg/Include/Guid/FileInfo.h
> @@ -46,7 +46,7 @@ typedef struct {
>    ///
>    UINT64      Attribute;
>    ///
> -  /// The Null-terminated name of the file.
> +  /// The Null-terminated name of the file.For a root directory, the name
is
> an empty string.
>    ///
>    CHAR16      FileName[1];
>  } EFI_FILE_INFO;
> --
> 2.26.2.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112854): https://edk2.groups.io/g/devel/message/112854
Mute This Topic: https://groups.io/mt/103329359/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

[Pedro Falcato]

On Fri, Dec 22, 2023 at 6:40 AM SuqiangX Ren <suqiangx.ren@intel.com> wrote:
>
> Add the description of FileName to align with UEFI spec 2.10.
>
> REF: UEFI spec 2.10 Table 13.5.16
>
> Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Guid/FileInfo.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Guid/FileInfo.h b/MdePkg/Include/Guid/FileInfo.h
> index 2b7edf36aabc..dad547a847d3 100644
> --- a/MdePkg/Include/Guid/FileInfo.h
> +++ b/MdePkg/Include/Guid/FileInfo.h
> @@ -46,7 +46,7 @@ typedef struct {
>    ///
>    UINT64      Attribute;
>    ///
> -  /// The Null-terminated name of the file.
> +  /// The Null-terminated name of the file.For a root directory, the name is an empty string.

nit: add a space between '.' and 'For'

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112858): https://edk2.groups.io/g/devel/message/112858
Mute This Topic: https://groups.io/mt/103314485/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

[Ren, Suqiang]

Thanks for review, patch updated.

Thanks
Ren, Suqiang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pedro Falcato
Sent: Sunday, December 24, 2023 3:18 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

On Fri, Dec 22, 2023 at 6:40 AM SuqiangX Ren <suqiangx.ren@intel.com> wrote:
>
> Add the description of FileName to align with UEFI spec 2.10.
>
> REF: UEFI spec 2.10 Table 13.5.16
>
> Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Guid/FileInfo.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Guid/FileInfo.h 
> b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..dad547a847d3 
> 100644
> --- a/MdePkg/Include/Guid/FileInfo.h
> +++ b/MdePkg/Include/Guid/FileInfo.h
> @@ -46,7 +46,7 @@ typedef struct {
>    ///
>    UINT64      Attribute;
>    ///
> -  /// The Null-terminated name of the file.
> +  /// The Null-terminated name of the file.For a root directory, the name is an empty string.

nit: add a space between '.' and 'For'

--
Pedro







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112907): https://edk2.groups.io/g/devel/message/112907
Mute This Topic: https://groups.io/mt/103314485/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-