public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ren, Suqiang" <suqiangx.ren@intel.com>
To: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Li, Yi1" <yi1.li@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
Date: Mon, 8 Jan 2024 13:31:25 +0000	[thread overview]
Message-ID: <CO1PR11MB4916C241FE87E7B803F0FB93966B2@CO1PR11MB4916.namprd11.prod.outlook.com> (raw)
In-Reply-To: <01ff01da3545$25dce4e0$7196aea0$@byosoft.com.cn>

Hi Liming,

	Could you please help to check and merge this patch?
	https://github.com/tianocore/edk2/pull/5170


Thanks
Ren, Suqiang

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Saturday, December 23, 2023 10:10 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月21日 10:41
> 收件人: devel@edk2.groups.io
> 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney 
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; 
> Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of 
> HiiConfigAccess ExtractConfig
> 
> From: "Ren,Suqiang" <suqiangx.ren@intel.com>
> 
> Add status code returned for HiiConfigAccess ExtractConfig to align 
> with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 Table 35.5.2
> 
> Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> b/MdePkg/Include/Protocol/HiiConfigAccess.h
> index 3baf91e07b2e..fbee7c52b021 100644
> --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
>                                    string.
> 
>    @retval EFI_INVALID_PARAMETER   Unknown name. Progress points
> -                                  to the & before the name in
> +                                  to the "&" before the name in
>                                    question.
> 
> +  @retval EFI_INVALID_PARAMETER   If Results or Progress is NULL.
> +
> +  @retval EFI_ACCESS_DENIED       The action violated a system policy.
> +
> +  @retval EFI_DEVICE_ERROR        Failed to extract the current
> configuration
> +                                  for one or more named elements.
> +
>  **/
>  typedef
>  EFI_STATUS
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113392): https://edk2.groups.io/g/devel/message/113392
Mute This Topic: https://groups.io/mt/103596624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-01-08 13:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1703126089.git.suqiangx.ren@intel.com>
2023-12-21  2:40 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig SuqiangX Ren
2023-12-23  2:10   ` 回复: " gaoliming via groups.io
2024-01-08 13:31     ` Ren, Suqiang [this message]
2024-01-15  2:08       ` Ren, Suqiang
2024-01-16  0:35         ` 回复: " gaoliming via groups.io
2024-01-20  2:32         ` Michael D Kinney
2024-01-22  1:54           ` Tan, Ming
2024-01-23  1:35             ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4916C241FE87E7B803F0FB93966B2@CO1PR11MB4916.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox