public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ren, Suqiang" <suqiangx.ren@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Kasbekar, Saloni" <saloni.kasbekar@intel.com>,
	"Clark-williams, Zachary" <zachary.clark-williams@intel.com>
Subject: Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323
Date: Tue, 9 Jan 2024 09:32:37 +0000	[thread overview]
Message-ID: <CO1PR11MB4916CFA259B998C2A09121D6966A2@CO1PR11MB4916.namprd11.prod.outlook.com> (raw)
In-Reply-To: <029e01da41d0$0cb0d750$261285f0$@byosoft.com.cn>

Hi Liming,

	Thanks for review this Pull Request: https://github.com/tianocore/edk2/pull/5190.

	Since All checks have passed. Could you please help to push it?

Thanks
Ren, Suqiang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Monday, January 8, 2024 9:15 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary <zachary.clark-williams@intel.com>
Subject: 回复: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

This change looks good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

I will merge it. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ren, Suqiang
> 发送时间: 2024年1月3日 20:38
> 收件人: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>; Kasbekar, Saloni 
> <saloni.kasbekar@intel.com>; Clark-williams, Zachary 
> <zachary.clark-williams@intel.com>
> 主题: Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to
> RFC7323
> 
> Add the Pull Request link: https://github.com/tianocore/edk2/pull/5190.
> 
> Thanks
> Ren, Suqiang
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, 
> Suqiang
> Sent: Tuesday, January 2, 2024 2:33 PM
> To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; 
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary 
> <zachary.clark-williams@intel.com>
> Subject: Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 
> to
> RFC7323
> 
> Hi Liming,
> 
> 	This patch has reviewed by Kasbekar, Saloni:
> https://edk2.groups.io/g/devel/message/112933
> 
> 	Could you help to merge this patch?
> 
> 
> Thanks
> Ren, Suqiang
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren, 
> Suqiang
> Sent: Tuesday, December 26, 2023 5:02 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; 
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, Zachary 
> <zachary.clark-williams@intel.com>
> Subject: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to
> RFC7323
> 
> REF: UEFI spec 2.10 Table 28.2.5
> 
> Change the description of RFC1323 to align with UEFI spec 2.10.
> 
> v3:
> Add the NetworkPkg change for RFC1323.
> 
> v2:
> Update the commit message.
> 
> Signed-off-by: Suqiang Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> 
> Suqiang Ren (2):
>   MdePkg: RFC1323 definition changed to RFC7323
>   NetworkPkg: RFC1323 definition changed to RFC7323
> 
>  MdePkg/Include/Protocol/Tcp6.h | 4 ++--
>  NetworkPkg/TcpDxe/TcpInput.c   | 2 +-
>  NetworkPkg/TcpDxe/TcpProto.h   | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 










-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113437): https://edk2.groups.io/g/devel/message/113437
Mute This Topic: https://groups.io/mt/103616986/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-01-09  9:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <17A4563740565835.18542@groups.io>
2024-01-02  6:32 ` [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323 Ren, Suqiang
     [not found] ` <17A6741D07F39DED.19587@groups.io>
2024-01-03 12:38   ` Ren, Suqiang
2024-01-08  1:14     ` 回复: " gaoliming via groups.io
2024-01-09  9:32       ` Ren, Suqiang [this message]
2023-12-26  9:01 Ren, Suqiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4916CFA259B998C2A09121D6966A2@CO1PR11MB4916.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox