Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

["Ren, Suqiang" <suqiangx.ren@intel.com>]

Add the Pull Request link: https://github.com/tianocore/edk2/pull/5186.

Hi Liming,

	Could you please have a check and merge this patch?


Thanks
Ren, Suqiang

-----Original Message-----
From: Ren, SuqiangX 
Sent: Tuesday, January 2, 2024 10:43 AM
To: 'gaoliming' <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

Hi Liming,

	This patch has also reviewed by Felix Polyudov: https://edk2.groups.io/g/devel/message/113002

	Could you help to merge this patch?

Thanks
Ren, Suqiang

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Saturday, December 23, 2023 10:02 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月22日 14:33
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi 
> Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback 
> in EFI_FORM_BROWSER2_PROTOCOL
> 
> Add status code return for BROWSER callback in 
> EFI_FORM_BROWSER2_PROTOCOL to align with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 Table 35.6.3
> 
> Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/FormBrowser2.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/FormBrowser2.h
> b/MdePkg/Include/Protocol/FormBrowser2.h
> index 436a7723c1da..bc214caa7d93 100644
> --- a/MdePkg/Include/Protocol/FormBrowser2.h
> +++ b/MdePkg/Include/Protocol/FormBrowser2.h
> @@ -138,10 +138,13 @@ EFI_STATUS
>    @retval EFI_SUCCESS           The results have been distributed or
> are
>                                  awaiting distribution.
> 
> -  @retval EFI_OUT_OF_RESOURCES  The ResultsDataSize specified
> +  @retval EFI_BUFFER_TOO_SMALL  The ResultsDataSize specified
>                                  was too small to contain the
>                                  results data.
> 
> +  @retval EFI_UNSUPPORTED       Uncommitted browser state is not
> available
> +                                at the current stage of execution.
> +
>  **/
>  typedef
>  EFI_STATUS
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113367): https://edk2.groups.io/g/devel/message/113367
Mute This Topic: https://groups.io/mt/103475485/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-