[edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

[edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

[SuqiangX Ren]

Add status code return for BROWSER callback in EFI_FORM_BROWSER2_PROTOCOL
to align with UEFI spec 2.10.

REF: UEFI spec 2.10 Table 35.6.3

Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
---
 MdePkg/Include/Protocol/FormBrowser2.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Protocol/FormBrowser2.h b/MdePkg/Include/Protocol/FormBrowser2.h
index 436a7723c1da..bc214caa7d93 100644
--- a/MdePkg/Include/Protocol/FormBrowser2.h
+++ b/MdePkg/Include/Protocol/FormBrowser2.h
@@ -138,10 +138,13 @@ EFI_STATUS
   @retval EFI_SUCCESS           The results have been distributed or are
                                 awaiting distribution.
 
-  @retval EFI_OUT_OF_RESOURCES  The ResultsDataSize specified
+  @retval EFI_BUFFER_TOO_SMALL  The ResultsDataSize specified
                                 was too small to contain the
                                 results data.
 
+  @retval EFI_UNSUPPORTED       Uncommitted browser state is not available
+                                at the current stage of execution.
+
 **/
 typedef
 EFI_STATUS
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112837): https://edk2.groups.io/g/devel/message/112837
Mute This Topic: https://groups.io/mt/103314459/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月22日 14:33
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li
> <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in
> EFI_FORM_BROWSER2_PROTOCOL
> 
> Add status code return for BROWSER callback in
> EFI_FORM_BROWSER2_PROTOCOL
> to align with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 Table 35.6.3
> 
> Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/FormBrowser2.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/FormBrowser2.h
> b/MdePkg/Include/Protocol/FormBrowser2.h
> index 436a7723c1da..bc214caa7d93 100644
> --- a/MdePkg/Include/Protocol/FormBrowser2.h
> +++ b/MdePkg/Include/Protocol/FormBrowser2.h
> @@ -138,10 +138,13 @@ EFI_STATUS
>    @retval EFI_SUCCESS           The results have been distributed or
> are
>                                  awaiting distribution.
> 
> -  @retval EFI_OUT_OF_RESOURCES  The ResultsDataSize specified
> +  @retval EFI_BUFFER_TOO_SMALL  The ResultsDataSize specified
>                                  was too small to contain the
>                                  results data.
> 
> +  @retval EFI_UNSUPPORTED       Uncommitted browser state is not
> available
> +                                at the current stage of execution.
> +
>  **/
>  typedef
>  EFI_STATUS
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112855): https://edk2.groups.io/g/devel/message/112855
Mute This Topic: https://groups.io/mt/103329362/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

[Felix Polyudov via groups.io]

Reviewed by: Felix Polyudov <felixp@ami.com>

-----Original Message-----
From: Tan, Ming <ming.tan@intel.com>
Sent: Monday, December 25, 2023 3:20 AM
To: Felix Polyudov <Felixp@ami.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>; Ren, SuqiangX <suqiangx.ren@intel.com>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Hi:
  Would you like to review this patch?
  It is for your request: https://mantis.uefi.org/mantis/view.php?id=1908

  BR/Tan Ming.

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of SuqiangX Ren
Sent: Friday, December 22, 2023 2:33 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

Add status code return for BROWSER callback in EFI_FORM_BROWSER2_PROTOCOL to align with UEFI spec 2.10.

REF: UEFI spec 2.10 Table 35.6.3

Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
---
 MdePkg/Include/Protocol/FormBrowser2.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Protocol/FormBrowser2.h b/MdePkg/Include/Protocol/FormBrowser2.h
index 436a7723c1da..bc214caa7d93 100644
--- a/MdePkg/Include/Protocol/FormBrowser2.h
+++ b/MdePkg/Include/Protocol/FormBrowser2.h
@@ -138,10 +138,13 @@ EFI_STATUS
   @retval EFI_SUCCESS           The results have been distributed or are
                                 awaiting distribution.

-  @retval EFI_OUT_OF_RESOURCES  The ResultsDataSize specified
+  @retval EFI_BUFFER_TOO_SMALL  The ResultsDataSize specified
                                 was too small to contain the
                                 results data.

+  @retval EFI_UNSUPPORTED       Uncommitted browser state is not available
+                                at the current stage of execution.
+
 **/
 typedef
 EFI_STATUS
--
2.26.2.windows.1






-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113002): https://edk2.groups.io/g/devel/message/113002
Mute This Topic: https://groups.io/mt/103314459/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

[Ren, Suqiang]

Hi Liming,

	This patch has also reviewed by Felix Polyudov: https://edk2.groups.io/g/devel/message/113002

	Could you help to merge this patch?

Thanks
Ren, Suqiang

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Saturday, December 23, 2023 10:02 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月22日 14:33
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi 
> Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback 
> in EFI_FORM_BROWSER2_PROTOCOL
> 
> Add status code return for BROWSER callback in 
> EFI_FORM_BROWSER2_PROTOCOL to align with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 Table 35.6.3
> 
> Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/FormBrowser2.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/FormBrowser2.h
> b/MdePkg/Include/Protocol/FormBrowser2.h
> index 436a7723c1da..bc214caa7d93 100644
> --- a/MdePkg/Include/Protocol/FormBrowser2.h
> +++ b/MdePkg/Include/Protocol/FormBrowser2.h
> @@ -138,10 +138,13 @@ EFI_STATUS
>    @retval EFI_SUCCESS           The results have been distributed or
> are
>                                  awaiting distribution.
> 
> -  @retval EFI_OUT_OF_RESOURCES  The ResultsDataSize specified
> +  @retval EFI_BUFFER_TOO_SMALL  The ResultsDataSize specified
>                                  was too small to contain the
>                                  results data.
> 
> +  @retval EFI_UNSUPPORTED       Uncommitted browser state is not
> available
> +                                at the current stage of execution.
> +
>  **/
>  typedef
>  EFI_STATUS
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113019): https://edk2.groups.io/g/devel/message/113019
Mute This Topic: https://groups.io/mt/103475485/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

[Ren, Suqiang]

Add the Pull Request link: https://github.com/tianocore/edk2/pull/5186.

Hi Liming,

	Could you please have a check and merge this patch?


Thanks
Ren, Suqiang

-----Original Message-----
From: Ren, SuqiangX 
Sent: Tuesday, January 2, 2024 10:43 AM
To: 'gaoliming' <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

Hi Liming,

	This patch has also reviewed by Felix Polyudov: https://edk2.groups.io/g/devel/message/113002

	Could you help to merge this patch?

Thanks
Ren, Suqiang

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Saturday, December 23, 2023 10:02 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月22日 14:33
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi 
> Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback 
> in EFI_FORM_BROWSER2_PROTOCOL
> 
> Add status code return for BROWSER callback in 
> EFI_FORM_BROWSER2_PROTOCOL to align with UEFI spec 2.10.
> 
> REF: UEFI spec 2.10 Table 35.6.3
> 
> Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/FormBrowser2.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Protocol/FormBrowser2.h
> b/MdePkg/Include/Protocol/FormBrowser2.h
> index 436a7723c1da..bc214caa7d93 100644
> --- a/MdePkg/Include/Protocol/FormBrowser2.h
> +++ b/MdePkg/Include/Protocol/FormBrowser2.h
> @@ -138,10 +138,13 @@ EFI_STATUS
>    @retval EFI_SUCCESS           The results have been distributed or
> are
>                                  awaiting distribution.
> 
> -  @retval EFI_OUT_OF_RESOURCES  The ResultsDataSize specified
> +  @retval EFI_BUFFER_TOO_SMALL  The ResultsDataSize specified
>                                  was too small to contain the
>                                  results data.
> 
> +  @retval EFI_UNSUPPORTED       Uncommitted browser state is not
> available
> +                                at the current stage of execution.
> +
>  **/
>  typedef
>  EFI_STATUS
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113367): https://edk2.groups.io/g/devel/message/113367
Mute This Topic: https://groups.io/mt/103475485/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-