public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ren, Suqiang" <suqiangx.ren@intel.com>
To: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Li, Yi1" <yi1.li@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER
Date: Wed, 3 Jan 2024 12:35:01 +0000	[thread overview]
Message-ID: <CO1PR11MB4916E06882E031C84229A6749660A@CO1PR11MB4916.namprd11.prod.outlook.com> (raw)
In-Reply-To: <02d901da3dde$c1fa2080$45ee6180$@byosoft.com.cn>

Hi Liming,

	Thanks for reminding me. Here are the PR for test CI: https://github.com/tianocore/edk2/pull/5189.

	Could you help to merge this patch?

Thanks
Ren, Suqiang

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Wednesday, January 3, 2024 8:50 AM
To: Ren, SuqiangX <suqiangx.ren@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

Sure. Can you help create Pull Request to make sure it can pass CI first?

Thanks
Liming
> -----邮件原件-----
> 发件人: Ren, SuqiangX <suqiangx.ren@intel.com>
> 发送时间: 2024年1月2日 10:30
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> 主题: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of 
> CapsuleImageSize on EFI_CAPSULE_HEADER
> 
> Hi Liming,
> 
> 	This patch has also reviewed by Felix Polyudov:
> https://edk2.groups.io/g/devel/message/113003
> 
> 	Could you help to merge this patch?
> 
> Thanks
> Ren, Suqiang
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Saturday, December 23, 2023 10:01 AM
> To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of 
> CapsuleImageSize on EFI_CAPSULE_HEADER
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ren,
> Suqiang
> > 发送时间: 2023年12月22日 16:11
> > 收件人: devel@edk2.groups.io
> > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao 
> > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; 
> > Yi Li <yi1.li@intel.com>
> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of 
> > CapsuleImageSize on EFI_CAPSULE_HEADER
> >
> > Add the description of CapsuleImageSize to align with UEFI spec 2.10.
> >
> > REF: UEFI spec 2.10 Table 8.5.3.1
> >
> > Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > ---
> >  MdePkg/Include/Uefi/UefiSpec.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/Uefi/UefiSpec.h 
> > b/MdePkg/Include/Uefi/UefiSpec.h index 5de00e8ea2af..ad80afbe3499
> > 100644
> > --- a/MdePkg/Include/Uefi/UefiSpec.h
> > +++ b/MdePkg/Include/Uefi/UefiSpec.h
> > @@ -1663,7 +1663,7 @@ typedef struct {
> >    ///
> >    UINT32      Flags;
> >    ///
> > -  /// Size in bytes of the capsule.
> > +  /// Size in bytes of the capsule (including capsule header).
> >    ///
> >    UINT32      CapsuleImageSize;
> >  } EFI_CAPSULE_HEADER;
> > --
> > 2.26.2.windows.1
> >
> >
> >
> > 
> >
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113082): https://edk2.groups.io/g/devel/message/113082
Mute This Topic: https://groups.io/mt/103500749/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-01-03 12:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1703232567.git.suqiangx.ren@intel.com>
2023-12-22  8:11 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER Ren, Suqiang
2023-12-23  2:01   ` 回复: " gaoliming via groups.io
2024-01-02  2:30     ` Ren, Suqiang
2024-01-03  0:49       ` 回复: " gaoliming via groups.io
2024-01-03 12:35         ` Ren, Suqiang [this message]
2024-01-08  1:24           ` gaoliming via groups.io
     [not found]   ` <BN8PR11MB371356E2B4FF57218346308C9799A@BN8PR11MB3713.namprd11.prod.outlook.com>
     [not found]     ` <BN0PR10MB49813707FC133BE26B5350B2DE9FA@BN0PR10MB4981.namprd10.prod.outlook.com>
2023-12-29 21:27       ` Felix Polyudov via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4916E06882E031C84229A6749660A@CO1PR11MB4916.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox