From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A0900AC1391 for ; Tue, 30 Jan 2024 17:58:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LuRnp8GrogkNGJqG+UgWY4mu9c2zyr3PR+JsqdCKT84=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706637526; v=1; b=DxhJH/fHHILvNbprS5gNDz6wtX5Qm4+mSx4uPWbGni6BWMqXNG0hjx/Nc/L8E+vwU3jAqk6t e8QJJ0hdsbes3Gp3jIgCi3U20OKqQcEfNmAr5GlHxDsjdRYLTyXODoDtyzc9V0BUKJtXFWLaAEm MY2a+2jhiluO/e37RflvhtK0= X-Received: by 127.0.0.2 with SMTP id snVyYY7687511xWzAsKyAFv9; Tue, 30 Jan 2024 09:58:46 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mx.groups.io with SMTP id smtpd.web10.3004.1706637525366616678 for ; Tue, 30 Jan 2024 09:58:45 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="10002253" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="10002253" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 09:58:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="3757557" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Jan 2024 09:58:44 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 30 Jan 2024 09:58:44 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 30 Jan 2024 09:58:43 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 30 Jan 2024 09:58:43 -0800 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 30 Jan 2024 09:58:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAYy93flfzg9yharPLdei3VmQENTRHn9edMNaaezaii2jSVsFzNSCsS/DNVFiOFwUs/jrBeE5RdoECXcjrkVeOiwVEoDKMQyDvv4zAMfjUv/gWhGp8faaSkzRR43qemIWiqTDufMypYAOwfFMweoN0dY7UBwPbcHLAMim4xhkFSOQ27PPe4C1K5dNIEZHvcmNORDicPxjM2L1YU/ThY8IMo0SYO6PKr1UHefeVISlML09PmRprnGOCGGA1QQwij8yPgkDytZbO63UupcVOJg/Wc75S722waukPjrl+yzXYFyIUvLvUenSoESkxWgxQid2np7V/6tjRDz+WiWnrt2Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lqsuu4rNeDWTWsyEoTOcf9AAkmM/jqvY9kgatP0kv1s=; b=mKhM7sBjbZRf7eV9o/1+wGDZerlymj06QmteBz1yrU+pNIhMXqnzsF/f8ODw1w2NvAfozpAJ5V0VcEaYw76U0KWFgcVundbxldAiLEFC43yrEkORNdkVdG1hG0GFj1oP5E5q+M9phbtX4PrDPPtffqmti4ACd/lYTd+ALyL2aHbtCknEvWBQglt0xfoJqkeOyfSAmU75A5alVUl5/umuQkYjFZJ0aoH94jhF3xWXXeVs2XC+vkyXeXsQT2fan2m3KtsBCneVjOddiHh77sEeP1yLnuSzB8yJfH3HCeqreAm6BrJesb6UtZUD0ES49meTWRbE/aGgbpjO2bz5BERqxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by LV3PR11MB8725.namprd11.prod.outlook.com (2603:10b6:408:21e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Tue, 30 Jan 2024 17:58:40 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 17:58:40 +0000 From: "Michael D Kinney" To: "Shang, Qingyu" , "devel@edk2.groups.io" CC: "Tan, Ming" , "Li, Yi1" , Liming Gao , "Liu, Zhiguang" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Update ReceiveData and SendData function description Thread-Topic: [PATCH v3 1/1] MdePkg: Update ReceiveData and SendData function description Thread-Index: AQHaU1nXiioFWWiEmkedAAELfuQURLDypK6Q Date: Tue, 30 Jan 2024 17:58:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|LV3PR11MB8725:EE_ x-ms-office365-filtering-correlation-id: f922da33-1eb5-4299-925e-08dc21bd170c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: bqaNCtWrTBlaVjFXlWexzwgMobveQBCKElS0oKAC6ypnBwOV0x4JTHENjABkGAWdAZhgCGFFSxt0K1MRCL4YSfaQmthfy+QfOR4wkSnrBCCpbt4XbHsfDE9cMNJoLHztLDkEXuFjwNvimUuKMVLzFJFqK9zlPKYvdUPuoHM3JMD1XucK70n9ohXBxhj+C23IUNAkXj0YGwy1RyZuzksfpL1/D26jI4jppNCEUtdCSPSUUQZZg4QnsxTOX44EZm2mtRy6UmHy9kx6GofCETtbfGZJHXBTyMjc8ivApCijxO85Pm7c7FqkV399mN5VB3lXEl5M9RV2r4OE4dtmDjXy360b0SrpG+R3AK/qYJXYoalfa9yjKzLmDMMtNC240ScYburCPeFdsGFc2v2xWcGT350GRH8ICTpTJcmO9tJpGsH5W5VaqL3fclW4cMj0Vy4bRoTSe44QXyIlRC4qjn+eD+8wHWlP6UVu56MIm+ilbMvNPLu2R2mDpXlbDBpAcE/Sea+Vo3y1SyE228xPIAWIn++Ax24YNdWGoyuJnaJdqkFOfr1yZULXdR7w4pBPOTE9vuTMroJbNJku5NO7snmzSof1fbBQF3ukQFupPxsZBiWxZ5a0hu//wim5oEpIS6PD x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bfsVaxZCmeXRU6F4M6flkSlFkDe2PVfgq/D9rtbQS6KaSM6BWeINHIlDY6vS?= =?us-ascii?Q?U3hAbOO0c1zJk3RndBC24DSuR1lm4V9VfkA+kAGJi5b69xyjsk9gLehxdXN6?= =?us-ascii?Q?xtnS6ao9TCEarR9/2Vzq1MxZKXKHI0tQq5sNr4FEvxyQYFe3DO6leNRSj68t?= =?us-ascii?Q?wgtQo9zpfLx9UB450oHi6Ez+DE1nKdwkF0q2xXK7YuR/JO1rI6IX/NC4L+0y?= =?us-ascii?Q?F3GJQqWjn+GVG6KdnifUHZIqWnY2tj6XmqdWMmzyEsE1jgF/X2w1PCbSoJnN?= =?us-ascii?Q?aUbKFzJphqu9XP27rtR5mmQ1sdjnTovJr5KLoHV9fPxUKBGblMe8pfRjVN9o?= =?us-ascii?Q?E4J5qihDDwrDT2HJdbS+wHfGWOXNH6KSlGGiBymGJuH/VuqkDJWYw/rChiD2?= =?us-ascii?Q?imWN/qjNymXbvcMZZqS40hfkHGfJPovsnjJcLhXg6Uer64uu9dNUgICHzSlt?= =?us-ascii?Q?jrWPeil55wNUi0cZkBs3oQ3v8ay8REKok+scd0uvx3MGrwa+MaS4ZJFw75at?= =?us-ascii?Q?WBD3sqtypO+lIwk+zRSzkNTU7MSK/oaenkO1YDV1lYQeAuOxxrYKUq2zjJO/?= =?us-ascii?Q?H6yd8OiRF31i96XUpPgRvFtV6Ohgh9NxhMZUfh+oM/HNXlam8nM+KAOrCxLN?= =?us-ascii?Q?oPPUcRozi46BFmSaCYjw9UTjL+HjqvNsF4IU1vX7eBC0RSdfQdQkhDmLDKNC?= =?us-ascii?Q?HniUOVzSkgVdqECn1bDxtY5uQPJee8y2lp/sShpw1OCoI794HvlIqIkY/wr5?= =?us-ascii?Q?tJnhj2Q1Q1lconEDjaiwYWJX9nFwLSCodqpUEu4VBk7ADzKdNaSmGknkTIvG?= =?us-ascii?Q?7TOazppy6uR1impETyt21JI1QDcD7/Jw5cA81DLGB5NfYBnVbQU++vNts74y?= =?us-ascii?Q?6y7sfwgzBT9jtI/cAtu6DjSFN2Hza3yxz53WBp7N0kb7evCQB/XAcmtM3dAY?= =?us-ascii?Q?j3HBTYtSmVyXkejHefQg9octYCcMo6xfGGh67ON/spY1z8PrEiW34C/Jdiro?= =?us-ascii?Q?j9JQd9+6o/pcJSi8kd1+j3g9EeKrXQVbaFucbN9VltqKNSB16eRcnSF/Dug7?= =?us-ascii?Q?dkZtWAYkwtZXR7tsf3mMwPs0B2JmwQAD1CuV9lfKToDg4bvRDLjrQWahDbEr?= =?us-ascii?Q?I53VGB0N7yoQ+p8oBHbTlmgXltJJS9V8N2FpXg7W3d4HNG2Kj7MdpJsJXXGI?= =?us-ascii?Q?HcS7hsjyOze39AQNRVn1TLgseX2Zqj1fAcqIcl9m6vParHbLRViHnveHLrK0?= =?us-ascii?Q?MfPDf6kCCztpctpemDyMNyE4j4ee4N17nQ4NLb3BwGPu4rT7n88N+d3jHkVP?= =?us-ascii?Q?Hf+aApkuO+6/Pff/5i38sGzrCEawpwOhFSBmcN3MY+z4QTSi4isei20e8IAM?= =?us-ascii?Q?1OYXb5UottooYzspDYCkIG4op3Ugej2Q9KPGbSiRgkJb1/5GCCUDPOlh4qfM?= =?us-ascii?Q?klPJZ1xi0ic1N21ozRuw5IXPc9oACi4spbXL1Kmd0nrjxbwDurFiSTvOuoJ4?= =?us-ascii?Q?/o7bpZ2NSkUMiT/TOzcBpPMGFDHtYgYe3zhLFXk70fx35d9OWE2YWUkHNqtN?= =?us-ascii?Q?zC1b4MDBMSfuxqZPQthyFIBg6NoEN8PF0851HALQuSYDtLHI5Z6YhMRr93Yc?= =?us-ascii?Q?VQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f922da33-1eb5-4299-925e-08dc21bd170c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2024 17:58:39.6659 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2ZkelZabIiqrkXtAFjagN+44M+ezj0bALyWefosLiM8L9SBDJQv3ZSoyBKx2OxWHmEJkYUEnskalA+2Ksi5qUyOzUOXtX0FnXYk//4MXB+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8725 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AKp5bpVQhSURAdfHlP1HzzuUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="DxhJH/fH"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I see V2 was received after V3. Which one is correct? Also, same comments I have for V2 to split up based on packages applies to = V3. I also see some issues with the current Cc email addresses. Please do not use ',' separated names for commit message tag email addresse= s. Mike > -----Original Message----- > From: Shang, Qingyu > Sent: Tuesday, January 30, 2024 12:53 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Shang, Qingyu ; Tan; Tan, Ming > ; Li; Li, Yi1 ; Liming Gao > ; Liu, Zhiguang > Subject: [PATCH v3 1/1] MdePkg: Update ReceiveData and SendData function > description >=20 > From: Qingyu Shang >=20 > Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' > description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function > ReceiveData > and SendData. >=20 > Cc: Tan, Ming > Cc: Li, Yi1 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Qingyu Shang > --- > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 8 ++++++-- > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 8 ++++++-- > .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c | 8 ++++++-- > .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h | 8 ++++++-- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 8 ++++++-- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 8 ++++++-- > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 +++++++++--- > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 12 +++++++++--- > MdePkg/Include/Protocol/StorageSecurityCommand.h | 8 ++++++-- > SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++++++-- > 10 files changed, 66 insertions(+), 22 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > index a729c087ff5a..67c6389bb8b3 100644 > --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c > @@ -1483,7 +1483,9 @@ AtaDiskInfoWhichIde ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1600,7 +1602,9 @@ AtaStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > index 6bc345f7e777..8906947e28b3 100644 > --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h > @@ -927,7 +927,9 @@ AtaDiskInfoWhichIde ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1007,7 +1009,9 @@ AtaStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > index b6ed7f7031b3..e0a85c1cb34e 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c > @@ -1699,7 +1699,9 @@ TrustTransferNvmeDevice ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1812,7 +1814,9 @@ NvmeStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > index 8cad15efd33a..5547e057e77a 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h > @@ -289,7 +289,9 @@ NvmeBlockIoFlushBlocksEx ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -369,7 +371,9 @@ NvmeStorageSecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > index 670f70caf41f..e79110c14e11 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > @@ -1897,7 +1897,9 @@ Done: > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -2119,7 +2121,9 @@ Done: > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > index 5a25b55c4952..49a00403695f 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > @@ -677,7 +677,9 @@ ScsiDiskEraseBlocks ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -751,7 +753,9 @@ ScsiDiskReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > index 39b7c7ce6ef1..61fa740be505 100644 > --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c > @@ -1267,7 +1267,9 @@ EmmcFlushBlocksEx ( > function shall return EFI_DEVICE_ERROR. >=20 > @param[in] This Indicates a pointer to the > calling context. > - @param[in] MediaId ID of the medium to receive > data from. > + @param[in] MediaId ID of the medium to receive > data from. If there is no > + block IO protocol supported > by the physical device, the > + value of MediaId is > undefined. > @param[in] Timeout The timeout, in 100ns units, > to use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function > will wait indefinitely for the > @@ -1454,7 +1456,9 @@ EmmcSecurityProtocolInOut ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -1555,7 +1559,9 @@ EmmcSecurityProtocolIn ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > index 2568f0359df3..8c7e5d2675ff 100644 > --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h > @@ -250,7 +250,9 @@ EmmcFlushBlocksEx ( > function shall return EFI_DEVICE_ERROR. >=20 > @param[in] This Indicates a pointer to the > calling context. > - @param[in] MediaId ID of the medium to receive > data from. > + @param[in] MediaId ID of the medium to receive > data from. If there is no > + block IO protocol supported > by the physical device, the > + value of MediaId is > undefined. > @param[in] Timeout The timeout, in 100ns units, > to use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function > will wait indefinitely for the > @@ -337,7 +339,9 @@ EmmcSecurityProtocolInOut ( > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -417,7 +421,9 @@ EmmcSecurityProtocolIn ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/MdePkg/Include/Protocol/StorageSecurityCommand.h > b/MdePkg/Include/Protocol/StorageSecurityCommand.h > index 810af59b85c3..206ae79aff8d 100644 > --- a/MdePkg/Include/Protocol/StorageSecurityCommand.h > +++ b/MdePkg/Include/Protocol/StorageSecurityCommand.h > @@ -59,7 +59,9 @@ typedef struct _EFI_STORAGE_SECURITY_COMMAND_PROTOCOL > EFI_STORAGE_SECURITY_COMMA > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -138,7 +140,9 @@ EFI_STATUS > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > index 0fb6b1bf41d5..1ee55105e435 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > @@ -49,7 +49,9 @@ EFI_GUID mOpalDeviceLockBoxGuid =3D > OPAL_DEVICE_LOCKBOX_GUID; > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > @@ -148,7 +150,9 @@ SecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the > calling context. > - @param MediaId ID of the medium to receive data > from. > + @param MediaId ID of the medium to receive data > from. If there is no > + block IO protocol supported by > the physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to > use for the execution > of the security protocol > command. A Timeout value of 0 > means that this function will > wait indefinitely for the > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114811): https://edk2.groups.io/g/devel/message/114811 Mute This Topic: https://groups.io/mt/104056979/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-