public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
Date: Fri, 31 Mar 2023 16:13:17 +0000	[thread overview]
Message-ID: <CO1PR11MB4929025BB499410AF15B160BD28F9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230331161043.191-1-mikuback@linux.microsoft.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Friday, March 31, 2023 9:11 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> This is causing excessive boot times in the VS2019 IA32/X64 Full
> run to shell tasks (> 2 minutes) and blocking all edk2 CI.
> 
> This patch removes the change so it can be root caused separately
> without blocking other patches unrelated to OVMF.
> 
> Reverts f92a9dce10281c103b04d6b38283e0ff1d677b91
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index 1ff85fdc24bb..64fca48a7d1d 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -196,7 +196,6 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
>          args  = "-debugcon stdio"                                           # write messages to stdio
>          args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
>          args += " -net none"                                                # turn off network
> -        args += " -smp 4"
>          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
> 
>          if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):
> --
> 2.40.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#102321): https://edk2.groups.io/g/devel/message/102321
> Mute This Topic: https://groups.io/mt/97976680/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 


  reply	other threads:[~2023-03-31 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 16:10 [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode Michael Kubacki
2023-03-31 16:13 ` Michael D Kinney [this message]
2023-03-31 16:59   ` [edk2-devel] " Ni, Ray
2023-03-31 18:50     ` Michael Kubacki
2023-03-31 16:13 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929025BB499410AF15B160BD28F9@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox