Re: [edk2-devel] [PATCH] BaseTools: Change non-ascii character of StructurePcd comment

["Michael D Kinney" <michael.d.kinney@intel.com>]

What file type contains the non-ASCII character?

I would prefer to see the source file with non ASCII character be updated instead of building this conversion into the tools.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei Chen
> Sent: Wednesday, April 28, 2021 1:45 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] BaseTools: Change non-ascii character of StructurePcd comment
> 
> Currently, the ConvertFceToStructurePcd.py tool generate StructurePcd
> dsc file with comments including non-ascii character circle R. This
> patch changes the non-ascii character circle R to (R) when adding the
> comment.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
>  BaseTools/Scripts/ConvertFceToStructurePcd.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py b/BaseTools/Scripts/ConvertFceToStructurePcd.py
> index 2052db8c4b..d029ed6a28 100644
> --- a/BaseTools/Scripts/ConvertFceToStructurePcd.py
> +++ b/BaseTools/Scripts/ConvertFceToStructurePcd.py
> @@ -285,6 +285,10 @@ class Config(object):
>          comment_list = value_re.findall(line) # the string \\... in "Q...." line
>          comment_list[0] = comment_list[0].replace('//', '')
>          comment = comment_list[0].strip()
> +        comment_b = bytes(comment, encoding = "utf8")
> +        if b"\xae" in comment_b:
> +            comment_b = comment_b.replace(b"\xc2\xae", b"(R)") # Change the circle "R" character to ascii character
> +        comment = str(comment_b, encoding = "utf-8")
>          line=value_re.sub('',line) #delete \\... in "Q...." line
>          list1=line.split(' ')
>          value=self.value_parser(list1)
> --
> 2.26.1.windows.1
> 
> 
> 
> 
>