From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.6604.1685739075467522520 for ; Fri, 02 Jun 2023 13:51:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Ui/QdZSB; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.d.kinney@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685739075; x=1717275075; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=s5J3Iqz0EJklIo7IytaUcjVJ4SLjzDRbzpU2nfIiAiU=; b=Ui/QdZSBb4ndUefQODnr7qoZ8BlcI8mETEc22JEjRR6leYdk3BuZbJNY QtOjC8FLh/vusKkns7pzPgP4wz3oOq+tI8oTKPIqfgynUbAyIu28kkxY6 GBLK9D5FaOh1BGv4gJGgV1aphpJ7UNNzmJ3Spy4nNqkWS0GoMLONO5uHb /Vb+3Gzs+mhvDPMpPwkyv8l6jRr6bYvMhQMp00KUw9jIxEvVWkd7FiahZ UInbRT82PAh0xPg2vslq4HmdiVsFrcJVizVuHlUEhdj+zgXks1l0TcoQI g0SJqJ+58NW2GlU/l1qa9FfWhmeD+KOO9h+l26hCliO+L/H4chSQzhA4h w==; X-IronPort-AV: E=McAfee;i="6600,9927,10729"; a="340595413" X-IronPort-AV: E=Sophos;i="6.00,214,1681196400"; d="scan'208";a="340595413" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2023 13:51:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10729"; a="777819944" X-IronPort-AV: E=Sophos;i="6.00,214,1681196400"; d="scan'208";a="777819944" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 02 Jun 2023 13:51:13 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 2 Jun 2023 13:51:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 2 Jun 2023 13:51:12 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 2 Jun 2023 13:51:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZOz4Uu1vBuDJaA46ACWPydZTXhgrcYSPGFusFNn8aFVAx+9Hv0/IDxWuFfqOyoWOdoz12ciRf6EtA4QSFF8nwI6bmdFpUeJYMLZ7hke5rO3juUmjsvhlyrOv8IT62QDgwM3QkvAOZsoRa09pSJc2/pjJgCqr4IJdlp3n6KzQyTmH9mC0jfRp5TzdCtKy1Mswqo7zQVeV3r5Coi6msL4mYqWcE7PG3zKmFERlsH344P394mVWeIG4u0yzIVZDXtPL2aKuBnS3tvEcqxps2oan7Z728AOL3XCkU6l9w7pGVqsyXBe2ng1CzJzReJz6vQkP8awZWssXWrjVzJWXSPtBig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tU485enAokhZmgFPgnXus8ErR+X8WFXWU9qKgv0zMFY=; b=QiL/8iilg2yLu8TaGdsecdCR8IHuEUHDgDepqazdgSetk8VZlH3hgRCLRnS4gnKar5BUyUtiCQi5vdZZR6jiim0/LNEzCVQRCcbDkB+lxvsfoH8QEQcv7ZnMhzQ5/6Lf4VxjC1x1Oj5tMqzoNu2IurgjEBQj2Fu1mCUliSCkICAXKUMEYx9ce02hg34xE0YG/lvW3BNZPIIvVw/K/Z284uCXgf7q0zR5p4+OnVI01MEKBURSAqxlSd/aSWyilF79B57hBISpm3AzZDTId29gqwsrx54f+NXxR+GrEh3MgmNxZDNKrJFmfbPXUhngiskiWfH7cKvNSm8EFb39OmQR5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by BN9PR11MB5548.namprd11.prod.outlook.com (2603:10b6:408:105::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.26; Fri, 2 Jun 2023 20:51:09 +0000 Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4752:67f2:9956:b277]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4752:67f2:9956:b277%4]) with mapi id 15.20.6433.025; Fri, 2 Jun 2023 20:51:08 +0000 From: "Michael D Kinney" To: Oliver Smith-Denny , "devel@edk2.groups.io" CC: Sean Brogan , Michael Kubacki , "Gao, Liming" , "Kinney, Michael D" Subject: Re: [edk2-devel][PATCH v1 1/1] CharEncodingCheckPlugin: Remove Noisy Print Thread-Topic: [edk2-devel][PATCH v1 1/1] CharEncodingCheckPlugin: Remove Noisy Print Thread-Index: AQHZlZMqPWswnn5AHEappfVQJhzNt693/KEw Date: Fri, 2 Jun 2023 20:51:08 +0000 Message-ID: References: <20230602204504.1455-1-osde@linux.microsoft.com> In-Reply-To: <20230602204504.1455-1-osde@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|BN9PR11MB5548:EE_ x-ms-office365-filtering-correlation-id: 2ea648e3-9276-4fbb-d5a0-08db63ab178d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W+JfdLLZhhOadowseR40ju4Dulqd86cCQ9LT905fKlMEClmfFqqT51+R/LaukRUQ3SKLEh8bvw/uFl5OBd98uazAI/uJsg0ZX33aFktOXHI7xzFbIsFCdMKpmu53UwGKziw7Ak4EXd7icq2UDXPfqqKfnTjp72tNNtvIDq5mtARM856bzyRJ1FbtTQ+gtbZWpCNshN/E8Uht/24mmdwOsIKC/UTSeNJ/AVrMj2LrBxicJhWtwL9wLm7dZevqfKx09/aboFzelSf0ws3rrUYyc+Ke5eJ2eb/HFkBEn7Rab9OFazo1i2xdm5Zqwhz7Tva/iEPqFPJDhw+N6peCEIvMWsejbNSUS00QcvLG3nb8f2OG/jyQ9/OTnGuqcmBhmdbMnzP9rc5rXaluhVDi8NhO2PiHQPqE9aTf/jJp8CqriYQrbpsaL5mBQ8DXqBQNT2Iimj37mk/Jkg4xtKYnin82CdAJy36iuUvX7z2p/Zyy5Vs6F06Ltf7iKol9daLvQnCVRPKbLAoBrqmSkaf2XbbAF4AEH3lIYZjBqGp2P7R1L+zV4xY1ltlzn140ISWooZVK2ihvMkSJHXKKLEbSNcPwBiixYmrOavkiDf+7Eci9LZk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4929.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(376002)(346002)(396003)(39860400002)(451199021)(966005)(7696005)(71200400001)(33656002)(186003)(55016003)(83380400001)(107886003)(53546011)(9686003)(6506007)(26005)(54906003)(2906002)(110136005)(316002)(5660300002)(41300700001)(52536014)(86362001)(66946007)(38070700005)(76116006)(64756008)(66446008)(66476007)(66556008)(4326008)(122000001)(82960400001)(8936002)(8676002)(38100700002)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aeQXBYBcuSDybUBnYodK9oHItgUYwj1l7gUXujn/q1uxFEmGm4KTXF+KDzO5?= =?us-ascii?Q?k0RElkSA4Q/KR6YtlLwOjfmd0cth5pfv8TytJTR+VxDYIQVfFBiABSeJvWql?= =?us-ascii?Q?aASs/dyaEaGIwYUd29pk3EPDD4XO9BtRkPoLmCIkFpsO0BHAwCOxeWVcpU2X?= =?us-ascii?Q?nAPD6z2IMgEqTXZVnk2wXcQmEtN5j1bBG/p1X3etMCfR8zxNPM6tXyKRqSgL?= =?us-ascii?Q?OfBFrTomYFNjDae5bNQli1+9fL/mpMx1EcGAUSOOxOafzVsU71oWfGYDR5FH?= =?us-ascii?Q?9haPhixMAyMacA/YZoo+/XSpXW9cVtGE7dIizEDZfTKDeLmYOwj4J7jg1plk?= =?us-ascii?Q?HhkF4NB7ByV+bHyolXjBzdzDEqvVCII40TmToeVKbdK3ogsEuQ5nfppOfVkj?= =?us-ascii?Q?8pxK7MjbgUwpsISPck5aSLCQgHtTAzsTOYVMxilxsfK9PKHvoFbOjTm5CTEQ?= =?us-ascii?Q?w34r7fm9YeF73pSBH4WG9SeCovGwvZMIiAMP0aznvnkpAqZnKpuvSHIozwzd?= =?us-ascii?Q?+SsMcq04rPA+Ef1p5snqLJMk4RUgU5Lqvp8eHESO8JeD0WF49hB78xWGFuSC?= =?us-ascii?Q?jfNlGzc2mDWiBYLOuZQt7f8SFcBQRUeSTdSscPoOBnfb8/QCsSrK8Jd9N2U/?= =?us-ascii?Q?LUQRV7fPR0t9mSWksP91/x8+xsgzahFiazuGx/LSiWSB9XCOEqQ5QkndFyaF?= =?us-ascii?Q?2+edESFHRr+DaDO+sFPRNmuAHuHjUaP3vu/As1CDqb0wSfGv7/DZEvZskniX?= =?us-ascii?Q?nuSVpXPqyZUbfZUyWbeYXpUqIi3qgZSK1LN0Y5/KInprjNho0H1w/MvMozQF?= =?us-ascii?Q?bxtd0eS8DQCdRLSbUNhZpoAer0vdSTCwOqKo0orfRj++bL7/GVbcFVhEl/XS?= =?us-ascii?Q?Ts6mtFyWGKW6K0ls8nVdt9s8DoRj7GhMEMMU5uHn2lWsop4cMbuTCyCWgRvt?= =?us-ascii?Q?KQM+ZcsJYqAWxN/g52QhA4nR4IbqDqLGd3e2Yb7RaY7v19mbNa9Sh435ovH3?= =?us-ascii?Q?k1/zb5VGzCNKw2w/Vq9c7k9WkUZB2ra4gRo/j23bSU7FmVOz8RHwskSWJEVI?= =?us-ascii?Q?hPSnFwCQqM8Zyd5Hwropr5pdGBG7gRpZfsiMuIG2LMKbei3PhqyZF5GLibIy?= =?us-ascii?Q?3tvSeI7Clfr/ilEtxRH+SSu5iH4QVsn/KXrGQ9Ny90lXOYqwV/VhHooKfnUS?= =?us-ascii?Q?K8xSfapcPsnMMyAIQyWLHoLScKQUYRwgxwWz5WgygWm41qnpfctJxz7zQer8?= =?us-ascii?Q?suVxyUPLjIWVZTD/NqKpGoMAYg5BnekQU//5S3ZhI+Q7UBSF6SVp0LVuIUQd?= =?us-ascii?Q?ECwM1ufyA67JkM3Y4eiOR3F3ffSnHj4cxo+VhAnH2o5XDW8AqrZw1gfxVtEs?= =?us-ascii?Q?XHL/zOyj6cXRyvJf7Hm+7rw0JBTNcsz8dKOQ/q+R1qHhmzASKaK/pP+T3Vj0?= =?us-ascii?Q?GnEQUyXmgrNUNAk3pm1/PJXefDvcPboYY3u3l3nS/oawJFXGiEnreVB3+VvT?= =?us-ascii?Q?FENi0R/AP72cLpCLYtjv0rmOCLCErn4NpfZm3AWk0nr8S3bHoBWKf0TCw0fX?= =?us-ascii?Q?vrmqkjMbUqmfS9Em6cfTS4s8hayCVReI7O3OtAtZ/AWFO5fgLTrk5+ZZcI1X?= =?us-ascii?Q?1Q=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ea648e3-9276-4fbb-d5a0-08db63ab178d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 20:51:08.8308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IaFRvbSg/mVJk3Mup2ijRk91RccbEA8GMNSpSQHl0S8HCKexFPjaEZfUGMWA+hDxzHQkIqbfDA3kdPvEjD1xtnyOOi4BOcRmIITXb44AOmI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5548 Return-Path: michael.d.kinney@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney > -----Original Message----- > From: Oliver Smith-Denny > Sent: Friday, June 2, 2023 1:45 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Michael Kubacki > ; Kinney, Michael D > ; Gao, Liming > Subject: [edk2-devel][PATCH v1 1/1] CharEncodingCheckPlugin: Remove Noisy > Print >=20 > Currently, CharEncodingCheckPlugin prints a message for every > file that passes the test, which for some platforms can cause > most of the CI build log to be filled with this print. It does > not add any value, so this patch removes the noisy print and > only prints if the encoding check fails. >=20 > Github PR: https://github.com/tianocore/edk2/pull/4472 >=20 > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Liming Gao >=20 > Signed-off-by: Oliver Smith-Denny > --- > .pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py > b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py > index b09fb1704087..07d9e9ce223e 100644 > --- a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py > +++ b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py > @@ -93,9 +93,7 @@ class CharEncodingCheck(ICiBuildPlugin): > files =3D > [Edk2pathObj.GetAbsolutePathOnThisSystemFromEdk2RelativePath(x) for x in > files] > for a in files: > files_tested +=3D 1 > - if(self.TestEncodingOk(a, enc)): > - logging.debug("File {0} Passed Encoding Check > {1}".format(a, enc)) > - else: > + if not self.TestEncodingOk(a, enc): > tc.LogStdError("Encoding Failure in {0}. Not > {1}".format(a, enc)) > overall_status +=3D 1 >=20 > -- > 2.40.1