public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"pierre.gondois@arm.com" <pierre.gondois@arm.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <leif@nuviainc.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Sami Mujawar" <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms v5 1/6] edk2-platforms: add edk2 repository as a submodule
Date: Mon, 15 Nov 2021 17:36:06 +0000	[thread overview]
Message-ID: <CO1PR11MB49290B5F577D3D438BA35629D2989@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211115170856.336-2-Pierre.Gondois@arm.com>

Hi Pierre,

There are many ways to pull multiple repos into a CI build.

This method of adding edk2 as a submodule of edk2-platforms is functional,
but may cause some CI system to fetch the edk2 repo multiple times if they
are using a different methods to manage multiple repos.

PyTools, EdkRepo, and CI agent scripts are some of the alternate methods.

I think this topic requires a discussion with all the edk2-platforms platform
owners to determine how TianoCore can provide a consistent way to describe the
repository dependencies and allow some platforms to use latest edk2/master
and other platforms to use branch/tag/sha such as an edk2 stable tag release.
We need this to be simple and easy to use for both TianoCore developers and
easy to consume by the4 TianoCore downstream consumers.

In order to make progress on enabling CI for this specific platform now,
is it possible to fetch of edk2 repo using Azure Pipelines scripts?  Or
other techniques that do not add edk2 as a submodule dependency at this time?

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois
> Sent: Monday, November 15, 2021 9:09 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Liming Gao <gaoliming@byosoft.com.cn>; Sami Mujawar <sami.mujawar@arm.com>; Pierre Gondois <Pierre.Gondois@arm.com>
> Subject: [edk2-devel] [PATCH edk2-platforms v5 1/6] edk2-platforms: add edk2 repository as a submodule
> 
> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> Add the edk2 repository as a submodule:
> https://github.com/tianocore/edk2
> 
> Platforms in edk2-platforms often relies on modules available
> in the edk2 repository. In order to enable an upstream CI
> for edk2-platforms, adding edk2 as a submodule is a convenient
> way to advertise this dependency.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3509
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Co-authored-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>  .gitmodules | 3 +++
>  edk2        | 1 +
>  2 files changed, 4 insertions(+)
>  create mode 160000 edk2
> 
> diff --git a/.gitmodules b/.gitmodules
> index 88aafaf15820..ed4b2d436cdb 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,3 +1,6 @@
>  [submodule "Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi"]
>    path = Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi
>    url = https://github.com/riscv/opensbi
> +[submodule "edk2"]
> +	path = edk2
> +	url = https://github.com/tianocore/edk2/
> diff --git a/edk2 b/edk2
> new file mode 160000
> index 000000000000..e1e7306b5414
> --- /dev/null
> +++ b/edk2
> @@ -0,0 +1 @@
> +Subproject commit e1e7306b54147e65cb7347b060e94f336d4a82d2
> --
> 2.17.1
> 
> 
> 
> 
> 


  reply	other threads:[~2021-11-15 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 17:08 [PATCH edk2-platforms v5 0/6] Enable edk2-platforms CI for JunoPkg PierreGondois
2021-11-15 17:08 ` [PATCH edk2-platforms v5 1/6] edk2-platforms: add edk2 repository as a submodule PierreGondois
2021-11-15 17:36   ` Michael D Kinney [this message]
2021-11-15 17:08 ` [PATCH edk2-platforms v5 2/6] pip-requirements.txt: Add python pip requirements file PierreGondois
2021-11-15 17:08 ` [PATCH edk2-platforms v5 3/6] .pytool/Plugin: Add CI plugins PierreGondois
2021-11-15 17:08 ` [PATCH edk2-platforms v5 4/6] .azurepipelines: Add Azure Pipelines YML configuration files PierreGondois
2021-11-15 17:08 ` [PATCH edk2-platforms v5 5/6] .mergify: Add Mergify YML pull request rules configuration file PierreGondois
2021-11-15 17:08 ` [PATCH edk2-platforms v5 6/6] Platform/ARM: Juno: Add JunoPkg.ci.yaml for CI support PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB49290B5F577D3D438BA35629D2989@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox