[edk2-devel] PRs with issues reported by CodeQL

[edk2-devel] PRs with issues reported by CodeQL

[Michael D Kinney via groups.io]

EDK II Maintainers and Reviewers,

If a PR has an issue that is added by a CodeQL scan, and that
issue is later resolved by code updates to the PR, the PR will
not be merged by Mergify.

The reason is that the state of the conversation started by
CodeQL is not seen as resolved by Mergify, even though CodeQL 
believes it is resolved. This issue has been reported, but there
is no date for a fix yet.

This has impacted a handful of PRs since it was first observed a
couple months ago.

There are 2 options to merge a PR in this state.

1) [Recommended] Maintainer reopens the specific conversation 
   opened by CodeQL and adds a comment that the issue is now 
   resolved and then closes the conversation as resolved. The
   PR is now merged because Mergify sees all conversations as
   resolved.

   Example:

        https://github.com/tianocore/edk2/pull/10617#discussion_r1929813777

2) Close the current PR and open a new PR with the state of
   code that does not have any Code QL issues. Complete reviews 
   of the new PR and it will be merged after 'push' label set.

Best regards,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121045): https://edk2.groups.io/g/devel/message/121045
Mute This Topic: https://groups.io/mt/110825057/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-