* [PATCH v1 1/3] SourceLevelDebugPkg: Fix spelling errors
2022-10-04 15:18 [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI Michael Kubacki
@ 2022-10-04 15:18 ` Michael Kubacki
2022-10-04 15:18 ` [PATCH v1 2/3] SourceLevelDebugPkg: Add package CI YAML file Michael Kubacki
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Michael Kubacki @ 2022-10-04 15:18 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Fixes spelling errors in the package so the SpellCheck CI plugin can
be enabled.
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 8 +++----
SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c | 22 ++++++++++----------
SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c | 2 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c | 2 +-
SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFuncs.c | 2 +-
SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFuncs.c | 2 +-
SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h | 2 +-
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h | 2 +-
| 2 +-
10 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
index a1e61a6ef90e..b553a2a9aa0c 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
@@ -1,5 +1,5 @@
/** @file
- Commond Debug Agent library implementation. It mainly includes
+ Common Debug Agent library implementation. It mainly includes
the first C function called by exception/interrupt handlers,
read/write debug packet to communication with HOST based on transfer
protocol.
@@ -608,7 +608,7 @@ DebugAgentDataMsgPrint (
}
/**
- Read remaing debug packet except for the start symbol
+ Read remaining debug packet except for the start symbol
@param[in] Handle Pointer to Debug Port handle.
@param[in, out] DebugHeader Debug header buffer including start symbol.
@@ -616,7 +616,7 @@ DebugAgentDataMsgPrint (
@retval EFI_SUCCESS Read the symbol in BreakSymbol.
@retval EFI_CRC_ERROR CRC check fail.
@retval EFI_TIMEOUT Timeout occurs when reading debug packet.
- @retval EFI_DEVICE_ERROR Receive the old or responsed packet.
+ @retval EFI_DEVICE_ERROR Receive the old or response packet.
**/
EFI_STATUS
@@ -651,7 +651,7 @@ ReadRemainingBreakPacket (
if (IS_REQUEST (DebugHeader)) {
if (DebugHeader->SequenceNo == (UINT8)(Mailbox->HostSequenceNo + 1)) {
//
- // Only updagte HostSequenceNo for new command packet
+ // Only update HostSequenceNo for new command packet
//
UpdateMailboxContent (Mailbox, DEBUG_MAILBOX_HOST_SEQUENCE_NO_INDEX, DebugHeader->SequenceNo);
return EFI_SUCCESS;
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
index 6661275cc343..97d30c802df4 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
@@ -213,10 +213,10 @@ SERIAL_IO_DEVICE_PATH mSerialIoDevicePath = {
}
};
-#define DEBGU_SERIAL_IO_FIFO_DEPTH 10
+#define DEBUG_SERIAL_IO_FIFO_DEPTH 10
//
// Data buffer for Terminal input character and Debug Symbols.
-// The depth is DEBGU_SERIAL_IO_FIFO_DEPTH.
+// The depth is DEBUG_SERIAL_IO_FIFO_DEPTH.
// Fields:
// First UINT8: The index of the first data in array Data[].
// Last UINT8: The index, which you can put a new data into array Data[].
@@ -227,7 +227,7 @@ typedef struct {
UINT8 First;
UINT8 Last;
UINT8 Surplus;
- UINT8 Data[DEBGU_SERIAL_IO_FIFO_DEPTH];
+ UINT8 Data[DEBUG_SERIAL_IO_FIFO_DEPTH];
} DEBUG_SERIAL_FIFO;
//
@@ -236,10 +236,10 @@ typedef struct {
EFI_HANDLE mSerialIoHandle = NULL;
UINTN mLoopbackBuffer = 0;
DEBUG_SERIAL_FIFO mSerialFifoForTerminal = {
- 0, 0, DEBGU_SERIAL_IO_FIFO_DEPTH, { 0 }
+ 0, 0, DEBUG_SERIAL_IO_FIFO_DEPTH, { 0 }
};
DEBUG_SERIAL_FIFO mSerialFifoForDebug = {
- 0, 0, DEBGU_SERIAL_IO_FIFO_DEPTH, { 0 }
+ 0, 0, DEBUG_SERIAL_IO_FIFO_DEPTH, { 0 }
};
/**
@@ -251,11 +251,11 @@ DEBUG_SERIAL_FIFO mSerialFifoForDebug = {
**/
BOOLEAN
-IsDebugTermianlFifoEmpty (
+IsDebugTerminalFifoEmpty (
IN DEBUG_SERIAL_FIFO *Fifo
)
{
- if (Fifo->Surplus == DEBGU_SERIAL_IO_FIFO_DEPTH) {
+ if (Fifo->Surplus == DEBUG_SERIAL_IO_FIFO_DEPTH) {
return TRUE;
}
@@ -313,7 +313,7 @@ DebugTerminalFifoAdd (
Fifo->Data[Fifo->Last] = Data;
Fifo->Surplus--;
Fifo->Last++;
- if (Fifo->Last == DEBGU_SERIAL_IO_FIFO_DEPTH) {
+ if (Fifo->Last == DEBUG_SERIAL_IO_FIFO_DEPTH) {
Fifo->Last = 0;
}
@@ -339,7 +339,7 @@ DebugTerminalFifoRemove (
//
// if FIFO is empty, no data can remove
//
- if (IsDebugTermianlFifoEmpty (Fifo)) {
+ if (IsDebugTerminalFifoEmpty (Fifo)) {
return EFI_OUT_OF_RESOURCES;
}
@@ -349,7 +349,7 @@ DebugTerminalFifoRemove (
*Data = Fifo->Data[Fifo->First];
Fifo->Surplus++;
Fifo->First++;
- if (Fifo->First == DEBGU_SERIAL_IO_FIFO_DEPTH) {
+ if (Fifo->First == DEBUG_SERIAL_IO_FIFO_DEPTH) {
Fifo->First = 0;
}
@@ -532,7 +532,7 @@ SerialGetControl (
// Check to see if the Terminal FIFO is empty and
// check to see if the input buffer in the Debug Communication Library is empty
//
- if (!IsDebugTermianlFifoEmpty (&mSerialFifoForTerminal) || DebugPortPollBuffer (Handle)) {
+ if (!IsDebugTerminalFifoEmpty (&mSerialFifoForTerminal) || DebugPortPollBuffer (Handle)) {
*Control &= ~EFI_SERIAL_INPUT_BUFFER_EMPTY;
}
diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c
index 34c269e6b527..9953904725ac 100644
--- a/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c
+++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c
@@ -70,7 +70,7 @@ DebugPortInitialize (
}
/**
- Read data from debug device and save the datas in buffer.
+ Read data from debug device and save the data in a buffer.
Reads NumberOfBytes data bytes from a debug device into the buffer
specified by Buffer. The number of bytes actually read is returned.
diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c
index 479757f5bae2..da55f3e69ef0 100644
--- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c
+++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c
@@ -768,7 +768,7 @@ InitializeUsbDebugHardware (
}
/**
- Read data from debug device and save the datas in buffer.
+ Read data from debug device and save the data in a buffer.
Reads NumberOfBytes data bytes from a debug device into the buffer
specified by Buffer. The number of bytes actually read is returned.
diff --git a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFuncs.c b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFuncs.c
index 600bde10d656..3e6db0db8679 100644
--- a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFuncs.c
+++ b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFuncs.c
@@ -15,7 +15,7 @@
@param[in] InterruptType Interrupt type.
@retval TRUE IDT entries were setup by Debug Agent.
- @retval FALSE IDT entries were not setuo by Debug Agent.
+ @retval FALSE IDT entries were not setup by Debug Agent.
**/
BOOLEAN
diff --git a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFuncs.c b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFuncs.c
index 952285a8eac0..1baa88206b06 100644
--- a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFuncs.c
+++ b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFuncs.c
@@ -15,7 +15,7 @@
@param[in] InterruptType Interrupt type.
@retval TRUE IDT entries were setup by Debug Agent.
- @retval FALSE IDT entries were not setuo by Debug Agent.
+ @retval FALSE IDT entries were not setup by Debug Agent.
**/
BOOLEAN
diff --git a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
index ad7bccda285c..ebb2168632da 100644
--- a/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
+++ b/SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
@@ -71,7 +71,7 @@ DebugPortInitialize (
);
/**
- Read data from debug device and save the datas in buffer.
+ Read data from debug device and save the data in a buffer.
Reads NumberOfBytes data bytes from a debug device into the buffer
specified by Buffer. The number of bytes actually read is returned.
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h
index a0ede308efee..4c72f8f3a90c 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h
@@ -452,7 +452,7 @@ DebugAgentDataMsgPrint (
);
/**
- Read remaing debug packet except for the start symbol
+ Read remaining debug packet except for the start symbol
@param[in] Handle Pointer to Debug Port handle.
@param[in, out] DebugHeader Debug header buffer including start symbol.
diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h
index c73233ea49b0..cc5f294f334d 100644
--- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h
+++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h
@@ -586,7 +586,7 @@ XhcWriteDebugReg (
/**
Verifies if the bit positions specified by a mask are set in a register.
- @param[in, out] Register UNITN register
+ @param[in, out] Register UINTN register
@param[in] BitMask 32-bit mask
@return BOOLEAN - TRUE if all bits specified by the mask are enabled.
--git a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLib.h b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLib.h
index 149186b226f4..f428af963231 100644
--- a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLib.h
+++ b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLib.h
@@ -34,7 +34,7 @@ extern UINTN AsmInterruptHandle;
@param[in] InterruptType Interrupt type.
@retval TRUE IDT entries were setup by Debug Agent.
- @retval FALSE IDT entries were not setuo by Debug Agent.
+ @retval FALSE IDT entries were not setup by Debug Agent.
**/
BOOLEAN
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v1 2/3] SourceLevelDebugPkg: Add package CI YAML file
2022-10-04 15:18 [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI Michael Kubacki
2022-10-04 15:18 ` [PATCH v1 1/3] SourceLevelDebugPkg: Fix spelling errors Michael Kubacki
@ 2022-10-04 15:18 ` Michael Kubacki
2022-10-04 15:18 ` [PATCH v1 3/3] .azurepipelines: Add SourceLevelDebugPkg to CI Michael Kubacki
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Michael Kubacki @ 2022-10-04 15:18 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Michael D Kinney
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Adds the package as a supported package to .pytool/CISettings.py
and adds a CI YAML for the package so it can be run in CI.
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.pytool/CISettings.py | 1 +
SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml | 117 ++++++++++++++++++++
2 files changed, 118 insertions(+)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index aef850a54549..f2c6303b2a08 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -70,6 +70,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
"UnitTestFrameworkPkg",
"OvmfPkg",
"RedfishPkg",
+ "SourceLevelDebugPkg",
"UefiPayloadPkg"
)
diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml b/SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
new file mode 100644
index 000000000000..8887a6d10bc5
--- /dev/null
+++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
@@ -0,0 +1,117 @@
+## @file
+# Core CI configuration for SourceLevelDebugPkg
+#
+# Copyright (c) Microsoft Corporation
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ ## options defined .pytool/Plugin/LicenseCheck
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/CompilerPlugin
+ "CompilerPlugin": {
+ "DscPath": "SourceLevelDebugPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
+ "HostUnitTestCompilerPlugin": {
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/CharEncodingCheck
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/DependencyCheck
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "MdeModulePkg/MdeModulePkg.dec",
+ "MdePkg/MdePkg.dec",
+ "SecurityPkg/SecurityPkg.dec",
+ "SourceLevelDebugPkg/SourceLevelDebugPkg.dec",
+ "UefiCpuPkg/UefiCpuPkg.dec"
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[
+ "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
+ ],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[],
+ "IgnoreInf": []
+ },
+
+ ## options defined .pytool/Plugin/DscCompleteCheck
+ "DscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "SourceLevelDebugPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
+ "HostUnitTestDscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/GuidCheck
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": [],
+ "IgnoreDuplicates": [],
+ },
+
+ ## options defined .pytool/Plugin/LibraryClassCheck
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined .pytool/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": False, # All failures were addressed when SpellCheck was enabled in this package
+ "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
+ "ExtendWords": [ # words to extend to the dictionary for this package
+ "bidir",
+ "bsp's",
+ "capbility", # comes from external package
+ "dcddi",
+ "dcerstba",
+ "dcportsc",
+ "dcerstsz",
+ "epring",
+ "evalu",
+ "fxrestor",
+ "hccparams",
+ "hcsparams",
+ "iretd",
+ "iretq",
+ "isoch",
+ "mfindex",
+ "ompressed",
+ "portsc",
+ "sequenceno",
+ "smmentrybreak",
+ "stosd",
+ "stosq",
+ "ttach",
+ "urb's",
+ "xhc's"
+ ],
+ "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
+ "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+ }
+}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v1 3/3] .azurepipelines: Add SourceLevelDebugPkg to CI
2022-10-04 15:18 [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI Michael Kubacki
2022-10-04 15:18 ` [PATCH v1 1/3] SourceLevelDebugPkg: Fix spelling errors Michael Kubacki
2022-10-04 15:18 ` [PATCH v1 2/3] SourceLevelDebugPkg: Add package CI YAML file Michael Kubacki
@ 2022-10-04 15:18 ` Michael Kubacki
2022-10-04 15:49 ` [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI Michael D Kinney
2022-10-05 1:24 ` Wu, Hao A
4 siblings, 0 replies; 7+ messages in thread
From: Michael Kubacki @ 2022-10-04 15:18 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Michael D Kinney, Liming Gao, Hao A Wu
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Adds SourceLevelDebugPkg to the "OTHER" CI matrix job so it is built
in edk2 CI.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 54a74a1a9873..d1628f1aa55d 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -41,7 +41,7 @@ jobs:
Build.Pkgs: 'NetworkPkg,RedfishPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_OTHER:
- Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg'
+ Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,SourceLevelDebugPkg,StandaloneMmPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_FMP_FAT_TEST:
Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTablesPkg'
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI
2022-10-04 15:18 [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI Michael Kubacki
` (2 preceding siblings ...)
2022-10-04 15:18 ` [PATCH v1 3/3] .azurepipelines: Add SourceLevelDebugPkg to CI Michael Kubacki
@ 2022-10-04 15:49 ` Michael D Kinney
2022-10-05 1:24 ` Wu, Hao A
4 siblings, 0 replies; 7+ messages in thread
From: Michael D Kinney @ 2022-10-04 15:49 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io,
Kinney, Michael D
Cc: Wu, Hao A, Gao, Liming, Sean Brogan
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, October 4, 2022 8:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>
> Subject: [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
>
> 1. Fixes pre-existing spelling errors in the package.
> 2. Adds SourceLevelDebugPkg to edk2 CI.
>
> CI results are available in the PR:
> https://github.com/tianocore/edk2/pull/3439
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (3):
> SourceLevelDebugPkg: Fix spelling errors
> SourceLevelDebugPkg: Add package CI YAML file
> .azurepipelines: Add SourceLevelDebugPkg to CI
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 8 +-
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c | 22 ++--
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.c | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c | 2 +-
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFuncs.c | 2 +-
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFuncs.c | 2 +-
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> .pytool/CISettings.py | 1 +
> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h | 2 +-
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h | 2 +-
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Internal.h | 2 +-
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLib.h | 2 +-
> SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml | 117 ++++++++++++++++++++
> 13 files changed, 142 insertions(+), 24 deletions(-)
> create mode 100644 SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI
2022-10-04 15:18 [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI Michael Kubacki
` (3 preceding siblings ...)
2022-10-04 15:49 ` [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI Michael D Kinney
@ 2022-10-05 1:24 ` Wu, Hao A
2022-10-05 1:29 ` [edk2-devel] " Michael Kubacki
4 siblings, 1 reply; 7+ messages in thread
From: Wu, Hao A @ 2022-10-05 1:24 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Gao, Liming, Kinney, Michael D, Sean Brogan
For the series:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, October 4, 2022 11:19 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
> Subject: [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
>
> 1. Fixes pre-existing spelling errors in the package.
> 2. Adds SourceLevelDebugPkg to edk2 CI.
>
> CI results are available in the PR:
> https://github.com/tianocore/edk2/pull/3439
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (3):
> SourceLevelDebugPkg: Fix spelling errors
> SourceLevelDebugPkg: Add package CI YAML file
> .azurepipelines: Add SourceLevelDebugPkg to CI
>
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
> t.c | 8 +-
> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
> | 22 ++--
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
> municationLibSerialPort.c | 2 +-
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunic
> ationLibUsb.c | 2 +-
>
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFu
> ncs.c | 2 +-
>
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFu
> ncs.c | 2 +-
> .azurepipelines/templates/pr-gate-build-job.yml
> | 2 +-
> .pytool/CISettings.py | 1 +
> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
> | 2 +-
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
> t.h | 2 +-
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommuni
> cationLibUsb3Internal.h | 2 +-
>
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction
> Lib.h | 2 +-
> SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
> | 117 ++++++++++++++++++++
> 13 files changed, 142 insertions(+), 24 deletions(-) create mode 100644
> SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [edk2-devel] [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI
2022-10-05 1:24 ` Wu, Hao A
@ 2022-10-05 1:29 ` Michael Kubacki
0 siblings, 0 replies; 7+ messages in thread
From: Michael Kubacki @ 2022-10-05 1:29 UTC (permalink / raw)
To: devel, hao.a.wu; +Cc: Gao, Liming, Kinney, Michael D, Sean Brogan
Thanks for the quick review, especially during your holiday.
On 10/4/2022 9:24 PM, Wu, Hao A wrote:
> For the series:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
>
> Best Regards,
> Hao Wu
>
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Tuesday, October 4, 2022 11:19 PM
>> To: devel@edk2.groups.io
>> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
>> Subject: [PATCH v1 0/3] SourceLevelDebugPkg: Enable CI
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
>>
>> 1. Fixes pre-existing spelling errors in the package.
>> 2. Adds SourceLevelDebugPkg to edk2 CI.
>>
>> CI results are available in the PR:
>> https://github.com/tianocore/edk2/pull/3439
>>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (3):
>> SourceLevelDebugPkg: Fix spelling errors
>> SourceLevelDebugPkg: Add package CI YAML file
>> .azurepipelines: Add SourceLevelDebugPkg to CI
>>
>>
>> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
>> t.c | 8 +-
>> SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgent/SerialIo.c
>> | 22 ++--
>>
>> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCom
>> municationLibSerialPort.c | 2 +-
>>
>> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunic
>> ationLibUsb.c | 2 +-
>>
>> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandlerFu
>> ncs.c | 2 +-
>>
>> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandlerFu
>> ncs.c | 2 +-
>> .azurepipelines/templates/pr-gate-build-job.yml
>> | 2 +-
>> .pytool/CISettings.py | 1 +
>> SourceLevelDebugPkg/Include/Library/DebugCommunicationLib.h
>> | 2 +-
>>
>> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
>> t.h | 2 +-
>>
>> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommuni
>> cationLibUsb3Internal.h | 2 +-
>>
>> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction
>> Lib.h | 2 +-
>> SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
>> | 117 ++++++++++++++++++++
>> 13 files changed, 142 insertions(+), 24 deletions(-) create mode 100644
>> SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
>>
>> --
>> 2.28.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread