From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8C0CF7803D0 for ; Thu, 30 Nov 2023 19:32:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qwamhZrf40BkO5ESSYwKS9hPn3vkk6m7qTHSb4o66c8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701372747; v=1; b=HnrmQN+tW8x0AJK5HpcE8vbYwwtjobA6VmFkLZhuaz21jSZOAbFZfvz5Xkrsl7IW0+wOOlag akrBKqz/bQ4Cs3jX1UR4B1xtzy3lTmdCNxLl1sHAriVerOmVGjlZoR3mmAho+XY5Mx2uwX5Cduw zUWR9MGI0qsg0WiyhwVnGLTg= X-Received: by 127.0.0.2 with SMTP id SkvPYY7687511x7qPz0v0tID; Thu, 30 Nov 2023 11:32:27 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web11.2983.1701372746205547136 for ; Thu, 30 Nov 2023 11:32:26 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="381531" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="381531" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 11:32:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="835504836" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="835504836" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Nov 2023 11:32:25 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 11:32:24 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 30 Nov 2023 11:32:24 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 30 Nov 2023 11:32:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PXDP5NOC0i0NcZk1ydWpa8SfY/t63vtmyI5fYiVBeL3yDUXIPoMeW1q8P9sD3y0DWx6k0xoixsUd2Aps1yvPuE8MkPlFVT8pEkrQRXcVktzOOYxWfd1kSHAsou7Jjiv83UYwOBThyZUf7g+RsI4VgdGY/WxUfAndv2l2d7IOkRRqsiceBTrR2F502S34XwH7VwlJxH9Jng1QCIz0db5Kzejiu7xZXw3UDKcqazQhrpjnmc/jb/nPAZVGAZhBr5YXtvmAjCWwjmt+LuWXCFBIEdPnsVgaRbsC7D2eP7luJNJxQukK6zshjEWyjodIiZH4pE/YQlnUbkuyDnaEMcJK3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k4MOuhPzFnUlsEbRsxYadPHfIyURUSTvsrkPHUJxk3A=; b=CKeqo34uPiVIl9Ft0PT4LPa/n5Gr7TZWV7ThcyjNZRhNak69Zj6xv1Ut9xBJXJjjeHbP/PdJD+uhhDTuGcdubOXyLpxvOnjHoHH4aBa55tI+PIY0rbvLO8UXKM6G4XNu9v7Q67NmE04EfTwPCiBGD971jaHaXTygrvt6G90iqrpxd23qMz27WEDuSfdo6s+kbCqEfTHf9oiaqmv1VsbswRWprpGdbUHQZoPgFi7Yefnr8+v8BeczPJPcDu7z/M/fNjNdYdNsavZfq/qDMjw9OtfPl1z+kMtZhrDS/cfTYtHcama3Gjonk8MQf8slLS4wpqRUO3aUXBoY+EMVI/Ppsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH0PR11MB5109.namprd11.prod.outlook.com (2603:10b6:510:3e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Thu, 30 Nov 2023 19:32:21 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%5]) with mapi id 15.20.7046.023; Thu, 30 Nov 2023 19:32:21 +0000 From: "Michael D Kinney" To: Pedro Falcato , "devel@edk2.groups.io" CC: Savva Mitrofanov , "Gao, Liming" , "Liu, Zhiguang" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib Thread-Topic: [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib Thread-Index: AQHaIzdznpCVKJ9+MkKF51BUOHR3QLCTMeEQ Date: Thu, 30 Nov 2023 19:32:21 +0000 Message-ID: References: <20231130024611.67135-1-pedro.falcato@gmail.com> <20231130024611.67135-3-pedro.falcato@gmail.com> In-Reply-To: <20231130024611.67135-3-pedro.falcato@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH0PR11MB5109:EE_ x-ms-office365-filtering-correlation-id: 6448d78d-5fd4-4368-1e71-08dbf1db12b9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: GBJLsIb/2fx1S1b8lNF426Wsdck4NZ9y1YnilEFkWvkd/yZNSGDtY0OTGG08TM827jEEMWQnQXyZrnM+3V1vKZzVfP8X++5AxhbjrRvIPbvZz8xb6CSdRR95oX5IFfTAJPwYDcI8OFb3GBoXN9S1tpWATc08ZwETMxjHN0rtScqEieeCnem3VeFKoQ4e+4tLAEvqjKn97q1KeWooeJe3GFbqqiowxHvO09VzXosHP57fsL0D3V8ZzNqYxF9pOMpgOPYExtBx9Gj7TdpTC9CI9c8894Blo3ZIFDoH6JBNHvPX3/Y6oTTvKh0nuibqnlARPl/h9Br/DRbo0ywLKdZHfSd7N8c0KBp0IGDeVlx1Kyk/n4qR1Zs/C8UgUt+Mf19HxlHdeJwhJCq6X+3oTd4rH7CSj+AfudeWrObnaFDhkYFDsdVpr6J1UAo3xMfV7SU2VgA0+zrDmsbvaJWjJptKTxm3hXfvG2RMloHnmGL0ez+d4GXHEdAdwEkvIucV6RSOK/fZRVydc0lg2FTmoLj2Swv45x2WwqmoBWNJ7Pingd4KUp5eh7jvwugq6tKpRQ9UW2yw7ME7Dz9Jr9I6QdoRmGTdpdPuQ0k+ppXzEdBuqHS+ZErFZTHT9FI0mHlZfJMU x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aYprUF+cirJf6RpTQ4fM71vqWUqGhgJDBzhp80Dpd0GYPIFYjkz95TEqnD99?= =?us-ascii?Q?l9qndVo2T8xJA/pwjAZS1myb0xbge1jD1gZddR8AwfZI4pddQitpI0AxRa19?= =?us-ascii?Q?IvdJBT0XyxVSsBwe1QBeV1zKToGInZf+i3pYXKZyLZwCWXy0zlJeHB15QeFw?= =?us-ascii?Q?JRCpoAVLIJB5G2VhwuHUbD7mQKn79r6PjEMajRYSXIKSMX8zhwZvpbsjA+Dw?= =?us-ascii?Q?aKDh7FYRIMacd/DqaScC9fNfZV74nB3aeh0hzl/e9ih9bN3MGg+MecjbaHqs?= =?us-ascii?Q?Y1gydtL7bneVpukJcBm5ApESK6erwDwv1gpwa0T4tec/OApoGjtYVDjdmc/6?= =?us-ascii?Q?0c2JpLMcV1yzsqElrpv+nTNq7/CBSDGF6lG3Tu7hqp6J+RaLHnOZCHhzCAWL?= =?us-ascii?Q?Dc1ZXpiKcYMd9ZYoIyyypzjKFnH8QItZmOzTSZxqNVzlDsBtAje57MHM9snr?= =?us-ascii?Q?Ps2TBjFAzKPi0frjnrirwZgbSvyw1MoqztwBNBHPpknVGf+OrSHkY3Xc5tPF?= =?us-ascii?Q?YgDajONdbNqh6AyUHIudFTst3CO3I5jbuaXvuzXX/IWpMk19xEyDdCGOo/cx?= =?us-ascii?Q?lislPh5i9Vvrghr8Sjyk4enS095d3eJ8UhpG2m+HNfGI0oe42xdZifX+ORAL?= =?us-ascii?Q?t1qZJe4f6yjafDvauTxhRG+057R+1/CtB8ymiGM/yqHox44FP4Z/xtwzu3C+?= =?us-ascii?Q?JAttxTvrNPKYtpg2eL4tdNwBbMs9J/TiIKBb1XJMTIVhh3ZMiA3Jgir4DGfg?= =?us-ascii?Q?TYq1wXZNarc2OvihmKAvp1iWJv7JWsz8qAnnA0ray38w+bqzRPv3SM1f2jcF?= =?us-ascii?Q?tQXkg6Rg/ZYDJUE+ctcmZuPDY0R7iyDd09D+qPHu0BdSB1KgYVpDjq5ZAHS+?= =?us-ascii?Q?sz+TSUiFjEW7+4YyXapRGs/qZMuL7/bGVBYcCVmHU6IqbC4IViq252drbl0j?= =?us-ascii?Q?daEC0n017AFfuew7nLOAELadnPE1XI9uJuuGWDhMNvMUgls5XVMSXjwENcx7?= =?us-ascii?Q?XEo1gHfog2y3LBLrwQcF17k5Eh+NApojOlm/X6urUDW61mxMejiHyCknIeAL?= =?us-ascii?Q?ytvzAIkbYyZsigU5asTuN+7Yd3fPFEHrfgXLpqNyh+3omydDp1XB/WRJrRj8?= =?us-ascii?Q?1e1OFdq1kPNjsGqLD8oMkkIRaQfL+i7TABypYgwE6MYBX97ESsLUMoFrMnl4?= =?us-ascii?Q?/XqYz9huJv3r6cAbj+3TxzKNvD6vcqhd9sgHvVEFoqnKE3z4A2d+anT9MODF?= =?us-ascii?Q?yg2ap+croZGD+CSytDgPz0cvqMW5M7tPk0F3zfuT075Nd2P4i8gIdESpDDeh?= =?us-ascii?Q?jfXUm9cm40wGz5OwiT17V8Ng6pKCvDhn5UiwWOopYFMldIC6F/x2yRmI1ISE?= =?us-ascii?Q?fGezwpZ1JLEub0CKWpwNY5TaUE9BQLSl/C4urOkdV24g8GFylnknR0YvcP2n?= =?us-ascii?Q?rbtI76VjujM/HaITOGbCiZ45zm8FSfUtuiLKZnCK1QwkdkAKhw/s6JOL0FfL?= =?us-ascii?Q?xh8eHEKbH/xQDkodcbJ9OFl+11vZI25zUfmIA+bdaH3sUyGcfLH1CY3LcKek?= =?us-ascii?Q?GY3P1CF9+j1ibmHDtdvGp5vDfHb3tWOm/8uA9LtY1cqOrwOGbHk6rdFZjW8Z?= =?us-ascii?Q?qg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6448d78d-5fd4-4368-1e71-08dbf1db12b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 19:32:21.6800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sYf1VsowJmXkObM33xrogeECzzR/hOrzFcQ0nVBGMG8gLR952bPrfS4ZGLq2UjWyz6SIz95c0GeEKwszA4BWAw2oQA8CtCJwbTDlD4I5u0A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5109 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xk8Ey3gLGTuUlp3fsQfnhIVAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HnrmQN+t; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io With one comment below addressed Reviewed-by: Michael D Kinney > -----Original Message----- > From: Pedro Falcato > Sent: Wednesday, November 29, 2023 6:46 PM > To: devel@edk2.groups.io > Cc: Savva Mitrofanov ; Pedro Falcato > ; Gao, Liming ; Kinney= , > Michael D ; Liu, Zhiguang > > Subject: [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib >=20 > Add GoogleTestBaseLib, which contains gtest unit tests for BaseLib. > For now, only add checksum tests for CRC32C and CRC16; these tests check > for correctness on various inputs using precomputed hashes. >=20 > Signed-off-by: Pedro Falcato > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Zhiguang Liu > --- > .../Library/BaseLib/GoogleTestBaseLib.inf | 31 +++++++++ > .../Library/BaseLib/TestBaseLibMain.cpp | 23 +++++++ > .../Library/BaseLib/TestCheckSum.cpp | 64 +++++++++++++++++++ > .../SafeIntLibUintnIntnUnitTests64.cpp | 4 +- > MdePkg/Test/MdePkgHostTest.dsc | 5 ++ > 5 files changed, 125 insertions(+), 2 deletions(-) > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseLib/GoogleTestBaseLib.inf > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseLib/TestBaseLibMain.cpp > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseLib/TestCheckSum.cpp >=20 > diff --git a/MdePkg/Test/GoogleTest/Library/BaseLib/GoogleTestBaseLib.inf > b/MdePkg/Test/GoogleTest/Library/BaseLib/GoogleTestBaseLib.inf > new file mode 100644 > index 000000000000..c859e5f86b9e > --- /dev/null > +++ b/MdePkg/Test/GoogleTest/Library/BaseLib/GoogleTestBaseLib.inf > @@ -0,0 +1,31 @@ > +## @file > +# Host OS based Application that unit tests BaseLib using Google Test > +# > +# Copyright (c) 2023, Pedro Falcato. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D GoogleTestBaseLib > + FILE_GUID =3D 34D8CBBA-2442-455F-8454-5B06B12A8B62 > + MODULE_TYPE =3D HOST_APPLICATION > + VERSION_STRING =3D 1.0 > + > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES =3D IA32 X64 > +# > + > +[Sources] > + TestCheckSum.cpp > + TestBaseLibMain.cpp > + > +[Packages] > + MdePkg/MdePkg.dec > + UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > + > +[LibraryClasses] > + GoogleTestLib > + BaseLib > diff --git a/MdePkg/Test/GoogleTest/Library/BaseLib/TestBaseLibMain.cpp > b/MdePkg/Test/GoogleTest/Library/BaseLib/TestBaseLibMain.cpp > new file mode 100644 > index 000000000000..1a9941492be6 > --- /dev/null > +++ b/MdePkg/Test/GoogleTest/Library/BaseLib/TestBaseLibMain.cpp > @@ -0,0 +1,23 @@ > +/** @file > + Main routine for BaseLib google tests. > + > + Copyright (c) 2023 Pedro Falcato. All rights reserved
> + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#include > + > +// Note: Until we can --whole-archive libs, we're forced to include > secondary files from the main one. > +// Yuck. Though I agree with this comment, it does not need to be in the source code. Not sure I understand how --whole-archive can help, so please start=20 a new discussion or enter a BZ with the details. > + > +#include "TestCheckSum.cpp" > + > +int > +main ( > + int argc, > + char *argv[] > + ) > +{ > + testing::InitGoogleTest (&argc, argv); > + return RUN_ALL_TESTS (); > +} > diff --git a/MdePkg/Test/GoogleTest/Library/BaseLib/TestCheckSum.cpp > b/MdePkg/Test/GoogleTest/Library/BaseLib/TestCheckSum.cpp > new file mode 100644 > index 000000000000..fa97f11dfa9c > --- /dev/null > +++ b/MdePkg/Test/GoogleTest/Library/BaseLib/TestCheckSum.cpp > @@ -0,0 +1,64 @@ > +/** @file > + Unit tests for BaseLib's checksum capabilities. > + > + Copyright (c) 2023 Pedro Falcato. All rights reserved
> + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#include > +extern "C" { > +#include > +#include > +} > + > +// Precomputed crc32c and crc16-ansi for "hello" (without the null byte) > +constexpr STATIC UINT32 mHelloCrc32c =3D 0x9A71BB4C; > +constexpr STATIC UINT16 mHelloCrc16 =3D 0x34F6; > + > +TEST (Crc32c, BasicCheck) { > + // Note: The magic numbers below are precomputed checksums > + // Check for basic operation on even and odd numbers of bytes > + EXPECT_EQ (CalculateCrc32c ("hello", 5, 0), mHelloCrc32c); > + EXPECT_EQ ( > + CalculateCrc32c ("longlonglonglonglong", sizeof > ("longlonglonglonglong") - 1, 0), > + 0xC50F869D > + ); > + EXPECT_EQ (CalculateCrc32c ("h", 1, 0), 0xB96298FC); > + > + // Check if a checksum with no bytes correctly yields 0 > + EXPECT_EQ (CalculateCrc32c ("", 0, 0), 0U); > +} > + > +TEST (Crc32c, MultipartCheck) { > + // Test multi-part crc32c calculation. So that given a string of bytes > + // s[N], crc32c(s, N, 0) =3D=3D crc32c(s[N - 1], 1, crc32c(s, N - 1, 0= )) > + // and all other sorts of combinations one might imagine. > + UINT32 val; > + > + val =3D CalculateCrc32c ("hel", 3, 0); > + EXPECT_EQ (CalculateCrc32c (&"hello"[3], 2, val), mHelloCrc32c); > +} > + > +TEST (Crc16, BasicCheck) { > + // Note: The magic numbers below are precomputed checksums > + // Check for basic operation on even and odd numbers of bytes > + EXPECT_EQ (CalculateCrc16Ansi ("hello", 5, CRC16ANSI_INIT), > mHelloCrc16); > + EXPECT_EQ ( > + CalculateCrc16Ansi ("longlonglonglonglong", sizeof > ("longlonglonglonglong") - 1, CRC16ANSI_INIT), > + 0xF723 > + ); > + EXPECT_EQ (CalculateCrc16Ansi ("h", 1, CRC16ANSI_INIT), 0xAEBE); > + > + // Check if a checksum with no bytes correctly yields CRC16ANSI_INIT > + EXPECT_EQ (CalculateCrc16Ansi ("", 0, CRC16ANSI_INIT), CRC16ANSI_INIT)= ; > +} > + > +TEST (Crc16, MultipartCheck) { > + // Test multi-part crc16 calculation. So that given a string of bytes > + // s[N], crc16(s, N, 0) =3D=3D crc16(s[N - 1], 1, crc16(s, N - 1, 0)) > + // and all other sorts of combinations one might imagine. > + UINT16 val; > + > + val =3D CalculateCrc16Ansi ("hel", 3, CRC16ANSI_INIT); > + EXPECT_EQ (CalculateCrc16Ansi (&"hello"[3], 2, val), mHelloCrc16); > +} > diff --git > a/MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= s > ts64.cpp > b/MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= s > ts64.cpp > index 6efdd3be7c5e..9fc60c5c71f3 100644 > --- > a/MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= s > ts64.cpp > +++ > b/MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= s > ts64.cpp > @@ -10,8 +10,8 @@ >=20 > #include > extern "C" { > - #include > - #include > +#include > +#include > } >=20 > TEST (ConversionTestSuite, TestSafeInt32ToUintn) { > diff --git a/MdePkg/Test/MdePkgHostTest.dsc > b/MdePkg/Test/MdePkgHostTest.dsc > index b92b564d434a..583f8fc0ddd8 100644 > --- a/MdePkg/Test/MdePkgHostTest.dsc > +++ b/MdePkg/Test/MdePkgHostTest.dsc > @@ -20,6 +20,7 @@ > !include UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc >=20 > [LibraryClasses] > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf >=20 > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf >=20 > @@ -31,6 +32,10 @@ > MdePkg/Test/UnitTest/Library/BaseLib/BaseLibUnitTestsHost.inf >=20 > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/GoogleTestBaseSafeIntLib.in= f > MdePkg/Test/UnitTest/Library/DevicePathLib/TestDevicePathLibHost.inf > + # > + # BaseLib tests > + # > + MdePkg/Test/GoogleTest/Library/BaseLib/GoogleTestBaseLib.inf >=20 > # > # Build HOST_APPLICATION Libraries > -- > 2.43.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111911): https://edk2.groups.io/g/devel/message/111911 Mute This Topic: https://groups.io/mt/102886794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-