From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4F655AC146C for ; Tue, 16 Apr 2024 16:38:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=P8AKK/5/oiuoId6yl0CSFMmZSlUKZ+AOJOkoY9mxdz8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713285502; v=1; b=2ufwFwoOPKI7r3jAzUXAj/TZtRND60Bn2Ee82HuG1VcGiySDm0Q90jqbSDlY4/dyvxRreXLp /j/GlnTP9//6BFQaKmANhcl4XTwigISjGyJblRXEVG1RlBI1mkvswhcFjJ+zbxw67sWqKioGjyv F50sCYfjdFTeuF2/p6dNeSKIAsFPdnelzjdOrpL3Lk3reZ10Ro/uM8D2EdjyLhnPVxPEugIkvI4 JFqzee397JjdXxmspu84ZA/CeT8ICs7GUj7Jve6xMcx918vBvLvcJIrnTKoAxT9wceWPAQavALb uD3FkUBUA28tXSmrU/+Gf+cUPXFTGkIg/k8DB7RbIDf0A== X-Received: by 127.0.0.2 with SMTP id iYFtYY7687511xWnDd7GEaci; Tue, 16 Apr 2024 09:38:22 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web11.25636.1713285496873818121 for ; Tue, 16 Apr 2024 09:38:17 -0700 X-CSE-ConnectionGUID: k4yE89uFQXyFn1ykzR882w== X-CSE-MsgGUID: 0TTdKR7NS2aNZDfvrCdMwQ== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="26199178" X-IronPort-AV: E=Sophos;i="6.07,206,1708416000"; d="scan'208";a="26199178" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 09:38:16 -0700 X-CSE-ConnectionGUID: cX3d4tLCQxSWz8JN0cwSKg== X-CSE-MsgGUID: ZersNj0DRpGebON6uUUtYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,206,1708416000"; d="scan'208";a="59748767" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Apr 2024 09:38:16 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 09:38:16 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 09:38:15 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Apr 2024 09:38:15 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 09:38:15 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CY5PR11MB6415.namprd11.prod.outlook.com (2603:10b6:930:35::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Tue, 16 Apr 2024 16:38:13 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368%5]) with mapi id 15.20.7472.027; Tue, 16 Apr 2024 16:38:13 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Clark-williams, Zachary" , "Tan, Ming" CC: "Kasbekar, Saloni" , "Bi, Dandan" , "POLUDOV, FELIX" , "Liu, Liqi" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec Thread-Topic: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec Thread-Index: AQHae/eHzbgErTDKTkKr9vPrjR/N0bFhyTQAgAi9jDCAALo6cA== Date: Tue, 16 Apr 2024 16:38:13 +0000 Message-ID: References: <20240322011611.7297-1-ming.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CY5PR11MB6415:EE_ x-ms-office365-filtering-correlation-id: 1c00081a-8ae6-4d94-219e-08dc5e339bde x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pO4fAZuWcjv0s9OngSeF/Mj4MQSQdf+W3f/j1bUhvNu7NfxZ9U2IcIC+4N3oWdr8jXcts5023snsUtka9b/haAcoAlYOCEkzIfui73I4DRc9GcUghkFUC4xBlgtnNF8L8D6zxHt6oJsQPNEqKg4v6R7XUmzLmf2WuL2GyuhLGcCaxD66XEg705nBbYKwGAmJJSNhVu0OQqN/OwHMX06/g2GX0fFHmPbwdENK5jaFodNqbsgiolZVIi1X5d12xMHxymAcSs1SoVHYBBVFfqtReR84hBTRBTUG5NTLB3cy4UKQAHvJa6d4dDgBMZVCdx4wvxi3fDUcF50lp3Ac9aEzJQu68mIj9fIrKsn8/Ydg/ykhTobVBPA20kQhKbNRph1CVXYXmGGH3VbVecIBSgFe4aUuFDDPzXqAFAu3qjQcJh1d4Xcep6VpWotUTER3Uxei0SBFOil0YshiHTkJaAPNp/mo0O1dNqG1wezO7NM4DArwF6u9QRYN9/mybQ9WWSd9wsJuvYMk+MEkNsl+/nNjD8CP9P2FtMcU1rTypJDEcgkvLgCPQMhlSkW+jyWyAWnN1Q7d8uDO6Tyq60DLM9IsB9FeGxj8dLsmSWsbsjdmg9UAH1BHlFpOKpuX5cQ0xnS0yceu/50b1ovPPLrfB8uk5/jE0cFrCJKLgJauXmzCDTCxlVqOjMwn4o5N26xjpXib x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zu5pDDe6nEi4pGI9iDhbbcAQfpa+p0uBDrYl1ZP9VnBemtaW4G8Ij5SMOLd6?= =?us-ascii?Q?twnf3inUu38mGjNsO+Aq4+c7nwyWGIZbDzflYC4MWu+yzh6QKm3XJYkQT6K4?= =?us-ascii?Q?xoWgEMTR0LACsB+vFSJ4RPbYlDfzLJlC17DPljfukBk4uQUj46tj/w+y7nCs?= =?us-ascii?Q?rY5ztulT0lpbhKcz3JX4/ExtH0NyAIIBYa+LyBh+otHnRxg8mqd1Es+03JH2?= =?us-ascii?Q?bJJlQ92EafH2T7YHls45TIVgqdvKFnefSBTf+MG5ByYv+sM+pLEEMeVk3Tnk?= =?us-ascii?Q?TwPfrJO5HhD9FM5XuGrFsT5r0egPDdr8cvtFk7985Tmx8cq0CztXP77vzU8G?= =?us-ascii?Q?f8RV0md/8rF4bSEWrCFQA3BOGPFoZWey1CuFBuFO/2qIPZTIK1QKSLApQrde?= =?us-ascii?Q?pxHIvE2hT+02BgNVW3bPv38g6Xl8Su22EB94Jdt1taCM1nRsSZj1F4IOpQ3n?= =?us-ascii?Q?g6YDIShzf5NZq2RLreZy9hkSzg+wuga15EIIHRL1vzxzGmkO4590Q5U2vkvO?= =?us-ascii?Q?V6Nxfvs4z3GPbwrhonCCCrt2+dILfyfy3e34gI2enojFqC5jg+VWX6M4oIzm?= =?us-ascii?Q?SfMoaThzDtzDF1a9gDrOP/X+HTe7xMS5Q+GnE5sXgOIuxIrI1KlUbGoA9wHu?= =?us-ascii?Q?G8Mo84pohzafKiGYHXzs7A2OsFJZIrTzfQ4cDojvJtEECxEeLoa6h/LxscT/?= =?us-ascii?Q?HP8GfF5xWayc70U6yxX35KXij+sO+Zk1zrLVCKekCBDm8Sk2WhB4afVWBo74?= =?us-ascii?Q?4/qHCP52Keymnvq9bvx2vvgVdvBdTX+v3XvKEWaQ7G76pMKPDTxRPeeqZytg?= =?us-ascii?Q?Upzy1DPeIH+WF8bbO2mJxleRJ2WbXonre1EQHVtgzOkpRF/ChIOnJXBkp3dB?= =?us-ascii?Q?xI5k7ZUg9/aaTbHSYCscTu64js4QebH9bDjm3ogtXztXCf4Q9oigI+IZ7qQZ?= =?us-ascii?Q?/5ZPGhd5R3HHNI2EbmMXDrSaY8qCznVXcMjjhnKibffjdJm+dnTV5npSTc6J?= =?us-ascii?Q?Clwf7OnJaUXh0zlWWqNgQwjxSFW38d1t8AFmCSzw9ZajRDXo2Q91x18HZBgZ?= =?us-ascii?Q?IDZDdqbh/tUxJNDkZ5oLnW6/A8vmwWFhLSIiMrrG47dnRH2WCNUOOq6UPyme?= =?us-ascii?Q?zlJPBR6Kzzx6In26ZVJmJuLYbgmRCw/kqknBk8o2Yto+lfxPgM93NLtR1Axd?= =?us-ascii?Q?Yn5jawu47ovX9pyXM3fXdDchPVuvA0h7u/e/D/l9fGMbUe8C3QctgI6p3hNy?= =?us-ascii?Q?nEPeBts3IZFH0YXKTTjxp3oMmwDKX05htZqfHywR7PowzpQczeSFkoNS0cpx?= =?us-ascii?Q?joYC/jv1655kNuVaOYJ/Mj1QcL3bbYg4evwqrgUw/UPfznbKMSm/yDsezcHB?= =?us-ascii?Q?avbMJY0xt2vbJx7pG2tQOD0jTMf71XyQ2nuXjOb4SiLI1qLwixmh9JcOX/58?= =?us-ascii?Q?+6bwwICg94CkaxxSfMwIgQanMhO7M5cDl9EZvVRjjd1VQdZ79no43LMgXUDF?= =?us-ascii?Q?xWKg803ZR4//F3uSEEWtFXyvadqz0tYtUkE09RubQWROVV0ihPbSnC7zzhh3?= =?us-ascii?Q?tGlJZUdZcrPkPLkdqiFMqefCov4heS0UGDT3XtPEG97xQ0455h4cvEQfSJUz?= =?us-ascii?Q?Zg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c00081a-8ae6-4d94-219e-08dc5e339bde X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 16:38:13.0706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: njmDUiYO/82JbYMnWWVjQbPNHkoD54ikak7xbsylSxBgAWv+H0CkBuYEnPZuiyBz121tW120+Icq6ped96/d1xE8x/UfOc26ndygOcX/f8c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6415 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 09:38:17 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: h52Om3jbUZAts27lWT1JT6pQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=2ufwFwoO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Merged: https://github.com/tianocore/edk2/pull/5487 > -----Original Message----- > From: Kinney, Michael D > Sent: Monday, April 15, 2024 10:32 PM > To: devel@edk2.groups.io; Clark-williams, Zachary williams@intel.com>; Tan, Ming > Cc: Kasbekar, Saloni ; Bi, Dandan > ; POLUDOV, FELIX ; Liu, Liqi > ; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: > Update UI according to UEFI spec >=20 > Acked-by: Michael D Kinney >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Clark- > > williams, Zachary > > Sent: Wednesday, April 10, 2024 9:03 AM > > To: Tan, Ming ; devel@edk2.groups.io > > Cc: Kasbekar, Saloni ; Bi, Dandan > > ; POLUDOV, FELIX ; Liu, Liqi > > > > Subject: Re: [edk2-devel] [PATCH] > NetworkPkg/WifiConnectionManagerDxe: > > Update UI according to UEFI spec > > > > Reviewed-by: Zachary Clark-Williams williams@intel.com> > > > > -----Original Message----- > > From: Tan, Ming > > Sent: Thursday, March 21, 2024 6:16 PM > > To: devel@edk2.groups.io > > Cc: Kasbekar, Saloni ; Clark-williams, > > Zachary ; Bi, Dandan > > ; POLUDOV, FELIX ; Liu, Liqi > > > > Subject: [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI > > according to UEFI spec > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4736 > > > > In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for > > EFI_BROWSER_ACTION_FORM_OPEN: > > NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used > with > > this browser action because question values have not been retrieved > > yet. > > > > So should not call HiiGetBrowserData() and HiiSetBrowserData() in > > FORM_OPEN call back function. > > > > Now use wifi list key and enroll cert key instead of the connect > > action key, move wifi info display from open action to close action. > > > > Cc: Saloni Kasbekar > > Cc: Zachary Clark-williams > > Cc: Dandan Bi > > Cc: Felix Polyudov > > Signed-off-by: Liqi Liu > > Signed-off-by: Ming Tan > > --- > > PR: https://github.com/tianocore/edk2/pull/5487 > > > > .../WifiConnectionMgrHiiConfigAccess.c | 113 ++++++++++++--- > -- > > - > > 1 file changed, 74 insertions(+), 39 deletions(-) > > > > diff --git > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess > > .c > > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess > > .c > > index 431fcbb33a..f242bdf056 100644 > > --- > > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess > > .c > > +++ > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAcce > > +++ ss.c > > @@ -1412,7 +1412,9 @@ WifiMgrDxeHiiConfigAccessCallback ( > > return EFI_OUT_OF_RESOURCES; } - HiiGetBrowserData > > (&gWifiConfigFormSetGuid, mVendorStorageName, BufferSize, (UINT8 > > *)IfrNvData);+ if (Action !=3D EFI_BROWSER_ACTION_FORM_OPEN) {+ > > HiiGetBrowserData (&gWifiConfigFormSetGuid, mVendorStorageName, > > BufferSize, (UINT8 *)IfrNvData);+ } if (Action =3D=3D > > EFI_BROWSER_ACTION_FORM_OPEN) { switch (QuestionId) {@@ -1438,43 > > +1440,6 @@ WifiMgrDxeHiiConfigAccessCallback ( > > break; - case KEY_CONNECT_ACTION:-- if > (Private- > > >CurrentNic->UserSelectedProfile =3D=3D NULL) {- break;- > > }-- Profile =3D Private->CurrentNic->UserSelectedProfile;-- > > //- // Enter the network connection configuration page- > > // Recovery from restored data- //- if (HiiSetString > > (Private->RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId, > > NULL) =3D=3D 0) {- return EFI_OUT_OF_RESOURCES;- }-- > > IfrNvData->SecurityType =3D Profile->SecurityType;- if > > (HiiSetString (- Private->RegisteredHandle,- > > STRING_TOKEN (STR_SECURITY_TYPE),- > > mSecurityType[IfrNvData->SecurityType],- NULL- > > ) =3D=3D 0)- {- return EFI_OUT_OF_RESOURCES;- }-= - > > if ((IfrNvData->SecurityType =3D=3D SECURITY_TYPE_WPA2_ENTERPRISE) ||- > > (IfrNvData->SecurityType =3D=3D SECURITY_TYPE_WPA3_ENTERPRISE))- > {- > > IfrNvData->EapAuthMethod =3D Profile->EapAuthMethod;- > > IfrNvData->EapSecondAuthMethod =3D Profile->EapSecondAuthMethod;- > > StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile- > > >EapIdentity);- }-- break;- case > > KEY_ENROLLED_CERT_NAME: if (Private->CurrentNic- > > >UserSelectedProfile =3D=3D NULL) {@@ -1524,6 +1489,43 @@ > > WifiMgrDxeHiiConfigAccessCallback ( > > } } else if (Action =3D=3D EFI_BROWSER_ACTION_FORM_CLOSE) { > > switch (QuestionId) {+ case KEY_EAP_ENROLL_CERT_FROM_FILE:++ > > if (Private->CurrentNic->UserSelectedProfile =3D=3D NULL) {+ > > break;+ }++ Profile =3D Private->CurrentNic- > > >UserSelectedProfile;++ //+ // Enter the network > > connection configuration page+ // Recovery from restored > data+ > > //+ if (HiiSetString (Private->RegisteredHandle, STRING_TOKEN > > (STR_SSID), Profile->SSId, NULL) =3D=3D 0) {+ return > > EFI_OUT_OF_RESOURCES;+ }++ IfrNvData->SecurityType =3D > > Profile->SecurityType;+ if (HiiSetString (+ > > Private->RegisteredHandle,+ STRING_TOKEN > > (STR_SECURITY_TYPE),+ mSecurityType[IfrNvData- > > >SecurityType],+ NULL+ ) =3D=3D 0)+ {+ > > return EFI_OUT_OF_RESOURCES;+ }++ if ( (IfrNvData- > > >SecurityType =3D=3D SECURITY_TYPE_WPA2_ENTERPRISE)+ || > > (IfrNvData->SecurityType =3D=3D SECURITY_TYPE_WPA3_ENTERPRISE))+ > {+ > > IfrNvData->EapAuthMethod =3D Profile->EapAuthMethod;+ > > IfrNvData->EapSecondAuthMethod =3D Profile->EapSecondAuthMethod;+ > > StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile- > > >EapIdentity);+ }++ break;+ case > > KEY_CONNECT_ACTION: if (Private->CurrentNic- > > >UserSelectedProfile =3D=3D NULL) {@@ -1909,6 +1911,39 @@ > > WifiMgrDxeHiiConfigAccessCallback ( > > NULL ); }++ if > > (Private->CurrentNic->UserSelectedProfile =3D=3D NULL) {+ > > break;+ }++ Profile =3D Private->CurrentNic- > > >UserSelectedProfile;++ //+ // Enter the network > > connection configuration page+ // Recovery from restored > > data+ //+ if (HiiSetString (Private- > > >RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId, NULL) =3D=3D > 0) > > {+ return EFI_OUT_OF_RESOURCES;+ }++ > > IfrNvData->SecurityType =3D Profile->SecurityType;+ if > > (HiiSetString (+ Private->RegisteredHandle,+ > > STRING_TOKEN (STR_SECURITY_TYPE),+ > > mSecurityType[IfrNvData->SecurityType],+ NULL+ > > ) =3D=3D 0)+ {+ return EFI_OUT_OF_RESOURCES;+ > > }++ if ( (IfrNvData->SecurityType =3D=3D > > SECURITY_TYPE_WPA2_ENTERPRISE)+ || (IfrNvData- > > >SecurityType =3D=3D SECURITY_TYPE_WPA3_ENTERPRISE))+ {+ > > IfrNvData->EapAuthMethod =3D Profile->EapAuthMethod;+ > > IfrNvData->EapSecondAuthMethod =3D Profile->EapSecondAuthMethod;+ > > StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile- > > >EapIdentity);+ } } break;@@ -1944,7 > +1979,7 > > @@ WifiMgrDxeHiiConfigAccessCallback ( > > } } - if (!EFI_ERROR (Status)) {+ if (!EFI_ERROR (Status) > && > > (Action !=3D EFI_BROWSER_ACTION_FORM_OPEN)) { // // Pass > changed > > uncommitted data back to Form Browser. //-- > > 2.31.1.windows.1 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117888): https://edk2.groups.io/g/devel/message/117888 Mute This Topic: https://groups.io/mt/105077953/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-