From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E5AA2AC1977 for ; Tue, 23 Jan 2024 21:48:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=IJjv38yN2pJ71kCYQ+U3CAw46G2HhmQgUARKuS7QiDo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706046513; v=1; b=aV482yvvo/hCpJgxYSvdwzXpZPaTgPWGXb9gNK6P2dtX4/H3uGKhYIQvahdJBAuGXlVOPIwJ jE6Q4FsbjecIDZY8Uz2qkSYwEQzLn4ovLViWZ7UDuMKO9gyLLpk4rWIgBJQdKiT00FQfEcJYK+V x9zPlUiThU6ftRfP+5y6qL0U= X-Received: by 127.0.0.2 with SMTP id 8hFbYY7687511xQfMZeX2dJJ; Tue, 23 Jan 2024 13:48:33 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web11.7081.1706046512509714630 for ; Tue, 23 Jan 2024 13:48:33 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="23129387" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="23129387" X-Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 13:48:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="1754734" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 13:48:25 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 13:48:23 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 13:48:22 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 13:48:22 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 13:48:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKSXGgZL0V7p0LzSn4cHuWq46mqNO3alIburYu6Dqp2gu725VwtXGnpZd5p+QS8QGcfrjO0DUhmuzUCdw1rP6JYQcBT+X+5Biyx9OTokGO50J1NMqsegP4jo1Ii5icQZlnYPLgCkFwKfN7LjKwu1GPOPCrjlrQ1MQoqdDOMng9UWYQKyUdTIVCv37crGMM0uXQNJW6UJFD4cI+9qZ08nNTVgMqtq/kN3PD6X27Crk0fQ7fxdVo/RpIkIecjaiO+Hhuw3ZBF/gVdeWhA+nDvyqmQW2DvAXZHMXjaJrHN2IbFuAAey91LjJD4qyKipK5G6OJ07SrRA5I7vKg3EryiZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXLJa5z4HYnGoBzbYTVxTQlrfdM1LU0/Bhn713ZGiLQ=; b=CaJyocPQXutbyXDxB7xSyRuQURpaJFDNyuyJIpqy7gx2NMSz7291zTIX2S4QzbQU+0FU6f6RI+Gqe3cLS3GL0Av93QLVF8T/DcddHGkxCc6yM551LUr2ZTxW8zPSuBm6BEXvKoB53jETrzF1BtDViIY9BIV9yKuZe9f1bCfG8PJMeBgq2p5YnIXbzt1iu1MUAI2TmjTGfZFlhv2aKLVSi1mJus3zelYLLhOL62qcAQ0HnBl5m3Nr7zQ0qFpWJRvBGsqCY53sZwmyPIhP+n/Vw0NmhbeA+YERqHdTWjSYADQrIo1Jo2yPCbxCnkIGYWymw+VLk630Xgrsb+UO6h1MzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by IA1PR11MB6443.namprd11.prod.outlook.com (2603:10b6:208:3a8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Tue, 23 Jan 2024 21:48:19 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 21:48:19 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Huang, Qing" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance Thread-Topic: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance Thread-Index: AQHaTfCThqSanrTJc0yRxPI6KPMB8rDnpabAgABKL9A= Date: Tue, 23 Jan 2024 21:48:19 +0000 Message-ID: References: <20240123113649.712-1-qing.huang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|IA1PR11MB6443:EE_ x-ms-office365-filtering-correlation-id: 211eb467-2bb8-4c35-fab4-08dc1c5d034b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: HRz/TNaAIRyytZr4wMLEKaDwTNvhCoHa6zSgKsCLimU+Cwg+vmE9BhhhFNw0TVkoOWxAMSYuVmk4wnhIg3+QnCVOsyjSJFFM4hKgeE0BLCQwkxAmQymrTSL9c4d2MpZl3hjQfbVPAY/nmHg3wEL5AInKLyptEHuAsGj0k8mkiXOOrl+uFyAj+dMolWx8CuGV/3F+ziRPB6YI+qWmoCkzhs3Y5xb2XpcNjALO5VJPh7Icf/HsyqyHVyzIZKhbcbEoaxkorNF2YbAP0DnMioQg3Idsle7aNSSMfdwhVFShZxD21AEo5AsYOJTdKStbkUcUhe4DXmKrGdhl98LTSmrzAtEcysLunRu7ZGqbbHgbshy24C3Mm6hwxAK7fNEyISTIbSb3cav84COB+tsK2CvtrVL6LR7o0rkjmxijA1PY9eC2wPyiP7LQxtdbYUjuI425viY+jnjbMjMNVOAvzUK1nFigm3T73enAV1GRDWPJGgWWjppEqP96YJxWUrRuwQ3fkyD3mkZ3Lapi2t1FjHJMHxcSGQrHXHNWu18qCSgoE36j8IcoISedzU5aZ4aCv2OWsl5rsOrO+XrJq77/KAUN7zYHPbFCk2U6H/Fj/p2dVr6aJUCPDhYyW3Tw7307f4h/LTVHTBmRXq0Hl066DCMPZA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ATT/GLyDikEXYMy42daUlQn5M3Y9cyBA5AcDptIWpRZ7vJFUPxNVilB6dXJc?= =?us-ascii?Q?CCA/14BBJzMBmnZseFPnGT6DWXaiWhfADxNBsDDw8i85pOl6vgVk94fazBUP?= =?us-ascii?Q?Z/j+/urol92zTNCsBn/hxCptw8uH0thav8mSGeUnOo56UF1/yVw3nJX9vPfM?= =?us-ascii?Q?mEEQac+u5Ic//xlddy6aLtk1V/NBO2srjPoLDrBE9kZXQTSnk6C7Squ8BCi6?= =?us-ascii?Q?4VBG9I/C+Db0n8pDpsPHzgAMcvfly9nIzwk785GjNyjXyCQVPcoCDQmYzZpK?= =?us-ascii?Q?PLFNG2ajDNKF90+FG5yDHBvgEEEvgJQG+kAW69GPIH4NhF8RSvGdxj9Tsrg8?= =?us-ascii?Q?xoJ4jPYxf64nsbz5TDjQcW8T9REuLSUuC02+rnURgjkYwUNA0LjQFYR+/otp?= =?us-ascii?Q?4C0DP+ws6NGEpqyCz0gG0QhIjCzydB9cgqvDdTmFbY7HBoA+s+lIPMITim2M?= =?us-ascii?Q?JcENvZNmu9o4F86FVT1osE2tg3yZ3s031lJSmA97KVFPAC8S+iKAf1PgwU2e?= =?us-ascii?Q?rWQb5Qk+2khDuH6mN9YREbDzeFgrz6zgNJ7rQhQROeat0D4waKOkOsirlyF/?= =?us-ascii?Q?4iM37z1TfrylFborQtXaexmhcRGSvyw5Y0FGCqaPooaJESGTiMb8Blh7BS0a?= =?us-ascii?Q?8p+/Z+P48/19YOWOCuCLGk7AusYazDEiUjNrHVi8zWflsuHk+AujhUY0R5OZ?= =?us-ascii?Q?0ed3i7aiw/j4TrLHqlFZYL+wdbtSIrryR1krWmRKnMssXrDdKgcXUJ329MR/?= =?us-ascii?Q?WScP890w8Zd+6OmCRvs/GjMxdA9A4yJPGqxNHv6TVYKt0l67AckGwOsiGT0j?= =?us-ascii?Q?BTWt/msfDJeeY/ZBAPNQQklJZ9qwEoEg3BCjKRkzgE34UCfJCL9G+9xqyyPs?= =?us-ascii?Q?JK4ushsIP07/WgZaqaszkis0PwFIUpAuIWlkKxIBocAx7O60fisn2oOBv4lv?= =?us-ascii?Q?mUrzft2ZqLq3PqQXIxwIHv0STz+par/GiofIa2qAi+DZDoCvK6f7eQSePumr?= =?us-ascii?Q?QBVKDREsATKxX+jaCF3fXJXoEV/FqXeJK3NHgmjJCrQ8jAu+pmnmr9b2gxbt?= =?us-ascii?Q?xjve36IWEXIvwMtXkJEwKe+hR+XsQjT/zW5N9z4v4KuwHP8aEkz/8qQwjlUT?= =?us-ascii?Q?N7XL6PKtwrF7XtEV+5dsRs02Lp/GTp4IFrE034eOz7ad6tZo2FKI8QHSV4b+?= =?us-ascii?Q?cWT/HL2WvWN9pQx6EDjjDltnttMMxpXbrcSytCCWJXlIygWEHJbV0zwWuUNb?= =?us-ascii?Q?gbqQ9lyQKaN1q/par0O4RikkwxIARKpqgcWYqjV1vmu8AQXY3zYTwFHMhVWw?= =?us-ascii?Q?Gbj8TV57ZMFsVjmU4lrmcP/TtO43X6cPwPlfOtBg1HzjpNxeObWJeDEBZvNW?= =?us-ascii?Q?odqehafHFZR/dYBX/nibnNOtvkHbMqzvK6DDAc1GiWastBHa3/r9tVisZjrW?= =?us-ascii?Q?DMUYtl9BdTA6SqeHG4mMebWoPDEHU+9btVpst4uKzwP35K90x8ScbDQiCMqB?= =?us-ascii?Q?2CKR+LgG7WrMbaMbnrj51/INFcrXqdYbZ1KVemrmKt+6DWca8pZE+Z4bdDXJ?= =?us-ascii?Q?eUKmrRiVYvMT+MsQo7Vey1xYFxRkTcWCO4N6eL40hraLui/6UZCDspfOXVdQ?= =?us-ascii?Q?sw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 211eb467-2bb8-4c35-fab4-08dc1c5d034b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 21:48:19.2074 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pwIp518DyzdkhWJUXtngSbewWRiSIN+BfIT6Bo8PgEJIhFvbKrXge2VBdoXsHS+7iPL9o3rEfFEnK0zTiUcR3TMaxt+TTBFuXaBDKeV5Mng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6443 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XDc0gwx5FsWtGzRozrXq1XI0x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aV482yvv; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Merged: https://github.com/tianocore/edk2/pull/5291 > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, January 23, 2024 9:26 AM > To: devel@edk2.groups.io; Huang, Qing > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub > function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance >=20 > Hi Qing, >=20 > Thank you for this update to add the missing API to BaseCpuLibNull. >=20 > There are a few very minor comments below. I will make those updates > in the PR for merge. With those changes: >=20 > Reviewed-by: Michael D Kinney >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Huang, > > Qing > > Sent: Tuesday, January 23, 2024 3:37 AM > > To: devel@edk2.groups.io > > Cc: Huang, Qing > > Subject: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub > > function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance >=20 > Subject line too long >=20 > > > > CpuLib.h exposes StandardSignatureIsAuthenticAMD() API and we require > > stub function in its BaseCpuLibNull library > > instance to avoid potential link issue. > > >=20 > Missing Cc for MdePkg maintainers. >=20 > > Signed-off-by: Qing Huang > > --- > > MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c | 17 ++++++++++++++++- > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > > b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > > index 3ba7a35096..ba7981551d 100644 > > --- a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > > +++ b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > > @@ -1,7 +1,7 @@ > > /** @file > > Null instance of CPU Library. > > > > - Copyright (c) 2020, Intel Corporation. All rights reserved.
> > + Copyright (c) 2020 - 2024, Intel Corporation. All rights > > reserved.
>=20 > Updating end year not required for Intel copyright statements. >=20 > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -35,3 +35,18 @@ CpuFlushTlb ( > > ) > > { > > } > > + > > +/** > > + Determine if the standard CPU signature is "AuthenticAMD". > > + > > + @retval TRUE The CPU signature matches. > > + @retval FALSE The CPU signature does not match. > > +**/ > > +BOOLEAN > > +EFIAPI > > +StandardSignatureIsAuthenticAMD ( > > + VOID > > + ) > > +{ > > + return FALSE; > > +} > > -- > > 2.42.0.windows.2 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114231): https://edk2.groups.io/g/devel/message/114231 Mute This Topic: https://groups.io/mt/103907626/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-