From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Lien, HoraceX" <horacex.lien@intel.com>
Cc: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version
Date: Thu, 31 Aug 2023 15:56:00 +0000 [thread overview]
Message-ID: <CO1PR11MB49291592BF03D0328D63A5EDD2E5A@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com>
Are mPrivateData.Smbios.MajorVersion and mPrivateData.Smbios.MinorVersion
guaranteed to be in range 0..9?
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> horacex.lien@intel.com
> Sent: Wednesday, August 30, 2023 2:13 AM
> To: devel@edk2.groups.io
> Cc: Lien, HoraceX <horacex.lien@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not
> match with SMBIOS version
>
> From: HoraceX Lien <horacex.lien@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4544
>
> These value of Major/Minor version are updated from SMBIOS memory data,
> but BCD Revision is updated from PCD PcdSmbiosVersion.
> We should also update PCD PcdSmbiosVersion from SMBIOS memory data,
> to ensure that get consistent version value.
>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: HoraceX Lien <horacex.lien@intel.com>
> ---
> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c
> b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c
> index 1a86e69d3c..e3f6215033 100644
> --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c
> +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c
> @@ -1072,7 +1072,7 @@ SmbiosCreateTable (
> DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry point
> structure\n"));
>
> EntryPointStructureData.MajorVersion =
> mPrivateData.Smbios.MajorVersion;
>
> EntryPointStructureData.MinorVersion =
> mPrivateData.Smbios.MinorVersion;
>
> - EntryPointStructureData.SmbiosBcdRevision = (UINT8)((PcdGet16
> (PcdSmbiosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16 (PcdSmbiosVersion) &
> 0x0f);
>
> + EntryPointStructureData.SmbiosBcdRevision =
> (mPrivateData.Smbios.MajorVersion << 4) | mPrivateData.Smbios.MinorVersion;
>
> PhysicalAddress = 0xffffffff;
>
> Status = gBS->AllocatePages (
>
> AllocateMaxAddress,
>
> --
> 2.31.1.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#108150): https://edk2.groups.io/g/devel/message/108150
> Mute This Topic: https://groups.io/mt/101057293/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108195): https://edk2.groups.io/g/devel/message/108195
Mute This Topic: https://groups.io/mt/101057293/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-08-31 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 9:12 [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version horacex.lien
2023-08-31 15:56 ` Michael D Kinney [this message]
2023-09-01 7:06 ` Lien, HoraceX
[not found] ` <1780B48BF009A270.23790@groups.io>
2023-09-07 9:40 ` Lien, HoraceX
2023-09-07 22:05 ` Michael D Kinney
2023-09-08 9:35 ` Lien, HoraceX
2023-09-14 9:32 ` Lien, HoraceX
2023-09-14 17:48 ` Michael D Kinney
2023-09-15 7:35 ` Lien, HoraceX
2023-09-20 1:03 ` Guo, Gua
2023-09-20 1:35 ` Michael D Kinney
2023-09-20 1:52 ` Guo, Gua
[not found] ` <17867875CCCD5E00.29111@groups.io>
2023-09-22 5:10 ` Guo, Gua
2023-09-22 16:19 ` Michael D Kinney
2023-09-23 0:21 ` Guo, Gua
2023-09-23 3:06 ` Michael D Kinney
2023-09-23 3:09 ` Guo, Gua
2023-09-25 2:13 ` Lien, HoraceX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49291592BF03D0328D63A5EDD2E5A@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox