From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6800F740034 for ; Thu, 31 Aug 2023 15:56:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=76vqBdDMtdI/pQsYyE/44Qbd4RpNmY0Agu1ApAh4XgU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693497367; v=1; b=cNF78+Y9YMM7XvV/6WZmmvlpuDmk3h2Yne6RewYsh/fFWiMhmRx0C/lsEFGSoTLmYUlXqB64 5PqKXUVpdKZULAZbXcOSqNxgv5oO0eVYbyeJbGypzNeLbzaFwkZ7nLprfStMvvvZIeqzl5pIRkY D1hLL9zWhBRU8SCK+8/nRmu8= X-Received: by 127.0.0.2 with SMTP id NuBYYY7687511xTKw2kCj09Y; Thu, 31 Aug 2023 08:56:07 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.1475.1693497366464464133 for ; Thu, 31 Aug 2023 08:56:06 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="361003919" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="361003919" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 08:56:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="829743262" X-IronPort-AV: E=Sophos;i="6.02,217,1688454000"; d="scan'208";a="829743262" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Aug 2023 08:56:04 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 31 Aug 2023 08:56:03 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 31 Aug 2023 08:56:03 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 31 Aug 2023 08:56:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ILvbRSgmkfnRt7SvJ/VNqoUKJ3wOiqzat6tLD+5qz18dO0NldvqpLG/zwevQKeIdvEiSyaU3IWO7CBlWk9mJlmTa2hWXOzEp2myz36jMHo2XjbysWgofsc7vmlrSGWiwYcKtXlkynywfME42JZ3gFEnKquBn3drB1i5cd4488xggDuX81zmTtRT5Ef6iFgaxMI2kELgi4GR/YDY6Und+e2NTNuerlTyl0jHEcKPq5lYb81wq7y+i5yyNk/y+P0Uz5tl5VUwAH65EPXgPpYEQI+faOrq0iIBJtHWMxqbmeoEfla5c+XYFP83lQFe2NVkAepGvuFPlzkQNqgPffzxkzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XCiYmlu41tEDNoGT63cyV8eI+B9r7plmEiLqRxpIH30=; b=PLtancq7WXGw69NgzXCF4LAhdJ6+LTAeOCoOyvyTc7G4Jm2HO/8stioeA9q6acyzhhS7e/wFjLCJbZ/wyASlopCzhCB9p7zzvtS2yq4Hi7te/8Fvc+tJzKPst2N20DjjS+BDjOLotIVbi4EwXXiKlqPAoQAMxnXHhte4PiFJ+LACUT/B3/V09SUZT2Ub9byz+ojSwHjf4bhji3/P72ljh6JVxwHHZYTJMjlbnmz4pDByl24DhePvhPStmtip6Wpkt43So79ySEK5d5NS4jS1+D5rAyBsmjq1+MIh9TxWtb0c0MPDnshBF3YzUdoAKB1X38i3VfNc8GHAYAn+i9liUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by BL1PR11MB5253.namprd11.prod.outlook.com (2603:10b6:208:310::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.21; Thu, 31 Aug 2023 15:56:01 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11%2]) with mapi id 15.20.6699.035; Thu, 31 Aug 2023 15:56:01 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Lien, HoraceX" CC: "Liu, Zhiguang" , "Bi, Dandan" , "Zeng, Star" , "Gao, Zhichao" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version Thread-Index: AQHZ22UDlonZ8eWV50a1a49r60TCnLAEkDqg Date: Thu, 31 Aug 2023 15:56:00 +0000 Message-ID: References: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> In-Reply-To: <0439b4b435989b2604d325451ae0fa6b70bb0a20.1693386097.git.horacex.lien@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|BL1PR11MB5253:EE_ x-ms-office365-filtering-correlation-id: 3a393fa5-a4c5-4a08-b0b4-08dbaa3ac600 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: MchqlDgETHYCOiCZ0RWGe3NpMxeudIthEwdI0FbsEgbzACjWPUj8vzub9y9iVXyJm350bU/wOMSRhfMHyZRNp/VM5A17EGWejZV4z+JwYihVBqQndImp8oWR5Q5q1ucEmj8xXL+H6W+pRewMiIF6+l+hDbTYawHof69WtbomnhiFNvpBZOBGvjAOT/uq3fFDhZqPB4DNRAUBqh+zfzYaLX7LZLFcNNbqSR09gbGsILeHKJQTmJYsktRnjdKL5CS7K1kkAIK848vYCzyp/ppMEcG3iojMEdGvmxPYuobWej9uigZUePbJFAPQ1StcYnDgSEIjV3iaTo7EspqcHtFd9pd7YH57fLcSxFjydERixsfebTOMibXqXOhPYG/+cauaRSgz6ChiDUjcKbxdki8DPDsw17SZ2Bf4a5EJEBByAEAMPIoHAviW4/1IhHLPjwQNIcbT+fiarKU4ZnU0gf/xG9Xre2XlRT/SjvA3iMD+TiC97SVfJyzSsAlAEUsFrBSNFXMFGnOD74DZTgrRXkeaxCyyvQCQIsP6Qli434FfVgAEdwPT0I18gnOIIu11itCiKnSjxqUoXFfpSkkH/Pqo3RYIkvJ//qElst76qYMUIZP3hVKleuKXIOF8JniRd9yd0LLyclu1c3Gt0EYUIwWgAg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cozld+991duM0VVbYDU/Tj/jkfmGNnb6lBzmMHzK0/jb9mS1nuHdxo4Df6Jp?= =?us-ascii?Q?1+ZHdXWdU5MTo6x75LJjb2Eg+c0LcWP83e6tZM2YIlHtBoZB8UbLRCIwY7wi?= =?us-ascii?Q?n3nnTVKWzjw3iL15Xo8PgVCnzlEkjAKPOXMYi4WsI6M8ObONXlmttSE08Y1Z?= =?us-ascii?Q?5n901CN8Q9V7ADkauI3ehcQH+JOKd+3FBv1Yzq190pqH+QvXcN4fD/dFOQMW?= =?us-ascii?Q?oX8Oe6McgVQX5jeXqEe0TevmLQva9r5QaotBc8q+U42VdgkGafEBjBVwcqrS?= =?us-ascii?Q?JC7aWKvC+aZxZYYZoIuE87S2p8ZWRBnd/PxqUfgHYWerdqe7A9IsJF2cxRa0?= =?us-ascii?Q?wYLEZD9UpZMzohk2g+M6qKC71UHjl65cyd3d+PtCdjLz96lGmjDnz2APR4+a?= =?us-ascii?Q?t8ruOEtAXzRvjiFNL4OqEU7fC3w5DfgNQvhFr74Etdh8h2C5nNsw/QgSzDu5?= =?us-ascii?Q?NWwPp0kZSkDLRxuqQRFYfYXyPPtfWbkR6Z7JerKAAOxdIdsYxt3T5iQPrtvQ?= =?us-ascii?Q?UI0yb+nBEH+KxahUAQjX3m3n/bHoBmzrhKnLOdS/+m7ChnOYFoHi8jSK3S7p?= =?us-ascii?Q?yIqH8c0e+8uufzfOpZyhk5pXcn1nzOTdiuKErmHq12zQqwrNb2y7zjEcrb0O?= =?us-ascii?Q?bmOtdVhfEmlRWBR/ipygVhcd2LJ0I+9Bq5bK9KZeuhF1fx4O0wp3e8q/Tn2S?= =?us-ascii?Q?qmLXK4XoQq/A3jL7jSUHo07exlee23Rv0LjpV7qe/3gctRXX0Yevxfu856NS?= =?us-ascii?Q?Ut76R2mEJyimNjSg/FYBOXHUQm1STo75FLBMpzXdGXNejuTRJ3F+Hmhp2my9?= =?us-ascii?Q?hrozvGYmetqwgCqMjjQYZmCp9fDQO5ZCCUJ+uNn60L/NtYk/6srM36dSLJs1?= =?us-ascii?Q?mn5bUw8lJhEIShNx2kF9Ki0UzsAD7dMcNCvTpnpXeOJKaombHJDHvQrMPN7k?= =?us-ascii?Q?O+uNYFh2Ml7dw0OW0T7Bu+KXfcHjKHcdGVvyA3H/zWXC0FqCZzxxLl+w/4E+?= =?us-ascii?Q?9GJqIR9k4hp72BoPzUcE92qauFDb7KqiXCtVO1xPqv9gcj8sCYmJ+UyspF+n?= =?us-ascii?Q?h9qbl2CMRFLmXdXMZJEFipq4JSibUGz/zUP64H5PUaxUiBFPS0BfSsnP3tNr?= =?us-ascii?Q?KIVy+YiZNkVXV+ez7Kq4LDFjZFGnMQYsmf3OS7tU67tiHiPxL9b65yIZYk+5?= =?us-ascii?Q?cKcD0FgOA1P8B4tUxfNYdJFNlUoGHKfMWd+yxCWut+th4Co+/Arj4YNACaF6?= =?us-ascii?Q?/d6spK1+vYQ7G6Pk5MRQndPsjxaI4dExaiNIEjmWW2OnOXitWUxqCa2vsf2M?= =?us-ascii?Q?g8R8kfAczec+5OLTkG1m/dW6HMnurwYzA4n13OlCeWx9r+mxjBR1Lp3jVUxR?= =?us-ascii?Q?NSYegHN0Oh4KVJaFMy9/tPKsHOZOZlTRCdaFpB+6Daz4RHtjjHPZ2P+X1vvR?= =?us-ascii?Q?ITRJ4loCyTj1j9Y3P/n7g2pKndSIoMGCZEcH7sT8Vg3dvfBEvCoz3faOLvz4?= =?us-ascii?Q?BK642o2zsiAEmxR4ajm8KqMJT69MFtXZpQlFip/ri0JO2IRlZelmuO29JWdj?= =?us-ascii?Q?yj0mdxEyFdzrWWl7XLkSb2sSYqNaTzWIWsHmgFFbHBWPkC9bDu4AoIOiqmBN?= =?us-ascii?Q?Qg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a393fa5-a4c5-4a08-b0b4-08dbaa3ac600 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2023 15:56:00.9433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UlMArNOkzwbypHtQtEsn17AVS6LVzUn4qFgU19eVezyCCO7oVzBJEcitma6lqA6Z8ZUC7gN0YBOy0sZWptbQo6MT8uySlNvTslDHWXDgq8s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5253 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vZSykV4A5C2sKGyN1FpFzyGmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cNF78+Y9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Are mPrivateData.Smbios.MajorVersion and mPrivateData.Smbios.MinorVersion guaranteed to be in range 0..9? Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > horacex.lien@intel.com > Sent: Wednesday, August 30, 2023 2:13 AM > To: devel@edk2.groups.io > Cc: Lien, HoraceX ; Liu, Zhiguang > ; Bi, Dandan ; Zeng, Star > ; Gao, Zhichao > Subject: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is = not > match with SMBIOS version >=20 > From: HoraceX Lien >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4544 >=20 > These value of Major/Minor version are updated from SMBIOS memory data, > but BCD Revision is updated from PCD PcdSmbiosVersion. > We should also update PCD PcdSmbiosVersion from SMBIOS memory data, > to ensure that get consistent version value. >=20 > Cc: Zhiguang Liu > Cc: Dandan Bi > Cc: Star Zeng > Cc: Zhichao Gao > Signed-off-by: HoraceX Lien > --- > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > index 1a86e69d3c..e3f6215033 100644 > --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > @@ -1072,7 +1072,7 @@ SmbiosCreateTable ( > DEBUG ((DEBUG_INFO, "SmbiosCreateTable: Initialize 32-bit entry poin= t > structure\n")); >=20 > EntryPointStructureData.MajorVersion =3D > mPrivateData.Smbios.MajorVersion; >=20 > EntryPointStructureData.MinorVersion =3D > mPrivateData.Smbios.MinorVersion; >=20 > - EntryPointStructureData.SmbiosBcdRevision =3D (UINT8)((PcdGet16 > (PcdSmbiosVersion) >> 4) & 0xf0) | (UINT8)(PcdGet16 (PcdSmbiosVersion) & > 0x0f); >=20 > + EntryPointStructureData.SmbiosBcdRevision =3D > (mPrivateData.Smbios.MajorVersion << 4) | mPrivateData.Smbios.MinorVersio= n; >=20 > PhysicalAddress =3D 0xffffffff; >=20 > Status =3D gBS->AllocatePages ( >=20 > AllocateMaxAddres= s, >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#108150): https://edk2.groups.io/g/devel/message/10815= 0 > Mute This Topic: https://groups.io/mt/101057293/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108195): https://edk2.groups.io/g/devel/message/108195 Mute This Topic: https://groups.io/mt/101057293/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-