From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BD8E8D81111 for ; Tue, 27 Feb 2024 06:33:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lgYHpnvygzbYJZV67fNEGBzmM0nU3cmwMY8tu3Tkvko=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709015610; v=1; b=khk3kKYEyOpYNTxdypPjh3TtHGro9TpziH+KRUcO1e6UvKsA4zb2Etno2dmXJvuioCe8mNmZ 2Q5zUI9F7ksRFFE+gI8/jaIKBQm0wDMnY6wo9cirH9agh/4xbs1aLn8U1V5EL3BaX8Q4f58omTy B2aTd0k7pQxd0UlG97XuQOIM= X-Received: by 127.0.0.2 with SMTP id Q2URYY7687511x5BORUiRN5K; Mon, 26 Feb 2024 22:33:30 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web10.7000.1709015609551802244 for ; Mon, 26 Feb 2024 22:33:29 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="3201528" X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="3201528" X-Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 22:33:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="6867444" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Feb 2024 22:33:29 -0800 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 26 Feb 2024 22:33:28 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 26 Feb 2024 22:33:28 -0800 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 26 Feb 2024 22:33:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHmkKt3ftNCbEUXuCoMnKc0i0dbYG3YAYp7P8poUF+qbMoG0TBW2eW/ULVkqv4d9r0/ot/nA0UGZsrtSu8SBdgjl9u2/pxITjSMdTCUBoQBiZQnkuhhPhb+8Elqq8JEo8Xmq5Kix+MoM1/W5I6aiov2vWJ9PeQHfTOEfEGMdxQZEFlSRZTEuFuTgiGq83LvQ+tRfCjiHsSFgdCkiNGiYo5yqlP1s3IuBoWG/31bhyCOxvnzKEMr/pCKPEF15M2c4acfucBZqcCRkkU0yGbZlW6L4w1OeVLNzzJgqodipqHl1fS2Up9M3V85EqOycJphSrHMEIHmafaSeAAZH+YoaXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yE6L7gbzB/4YH/MwcZW8fgyc9eRBnl5+djnEykwEC2g=; b=P7zvL5vzq1pLxp3+sO7VLKDjmrOo90pqi4pKGKG9v+QGedG/IqzPXhGyJtz4WfXuHajZdAEtWMkhSjOBKIcIYzMcVisZfhIHUVs8lYoPuSSbEQCEwr3f7T1tiiyB5bsBcQaecJib/2i/oU3Ru3Qpg8ke2aDWUdUu2mqU6ssBBO+h4zDHGccxOKSmCa4zLVB1J3RfvyQTciYRMcVXJ6v7aZH2MTmySwcnVKtnVWdI9Nd2GOuviQVqRDnLi6lYw/SMSwvxvkTYyzQsqiFxmZTvYddvkm8P7XjbifABg7fBuAQhj8w15My/oAxBVmtBlg90lMqTbDDLve8UUD7ZqLku8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by BL3PR11MB6361.namprd11.prod.outlook.com (2603:10b6:208:3b4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Tue, 27 Feb 2024 06:33:23 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368%5]) with mapi id 15.20.7339.024; Tue, 27 Feb 2024 06:33:23 +0000 From: "Michael D Kinney" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: Sean Brogan , Joey Vagedes , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions being deprecated Thread-Topic: [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions being deprecated Thread-Index: AQHaaTb0xbBX+E2EokimZ9f4w/f6bbEdusuQ Date: Tue, 27 Feb 2024 06:33:23 +0000 Message-ID: References: <20240227043847.125-1-mikuback@linux.microsoft.com> In-Reply-To: <20240227043847.125-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|BL3PR11MB6361:EE_ x-ms-office365-filtering-correlation-id: 33f65b29-6dfd-4726-ad56-08dc375dff4e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: d5xC+lXXyO2ylLnpzkV4moto2c/MAlkYvvqWqk61Lq16VCaRDEeTa8Ip6yyp2uieNnsEhnFb8hXiNLA0B9XOdFMli7m/LOz9vQAsPOQ5+P7Nlz5R2cPZNC7byO01+oMGsmmfmTqgKJ9SoZ/VM4t4ee5lByTduCnMqFtuMcCGqwXZbMnxZ6DgOP6olWos4uS/61sYDTi0Ek+5Od6n7Xl80ymb0TlbCtYY72DJambeYdn3BttISXw4GBq9QkB2QVKBKLqU/bkEkuQggPMHqw8BJW9EU032wf39QvNdE31QmQ2YFg+S5eM87E8Owe3R2ZtxDwHHLPjEh50H/8V0MTGZuzUmHxD6McaVN1ca0dRF8zxdG3UiyoNPw3cPS1smGCC17p1a6breI55TQvRNiZkATo4DPn4npayT8TwxdI/6FPzwWIOA/hZXck8FHoHjzals0HvC2hrfi0jPy92Kb4AsMH/82Bylopj0mu3K+2QCwgmnSmSp93XN6Hm5HzN0gZ4fCN/eVl0T0jyjrcMqGazYUULINOJgEWDqj3EGAICP90V72BUPBU4vFmdf2n5gUmTqREe6PuYL+60ytYWs/8daNMc3KBMYoeEE8twetTh16ctA9LH+q2en6b82lKa4ujQFeba9ddBGmsa5Z7GdHnuNZ9CU22qn7LzuCMP1WuJXzGgC2fPmnhbgqIjqS3IEMCnmcUTQB9y7qQLy6JilT1MU1g== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mX4ken3bqX/qUGyR5ggJmd3VwD2u0EQAKs0dyeQkLOn7aRiceyO73sGyHGwd?= =?us-ascii?Q?XKkMF7vTiMPcasyALBiO2gel9RJiu+dtQ06qkJOGt7/RRYE0NuAXaJ0ZDfSi?= =?us-ascii?Q?BNACl2unN6Bgtk4zhX+93xjXaJVezIei2oWxNpxDIQyp+RMVJ3Vk7kLBb+Mk?= =?us-ascii?Q?UG/w1JK6Fzcymq8HPfqT5HSXU4/ZOd4Uq0ltr+ZNbyj8vv8p2AEmYCgDiJN3?= =?us-ascii?Q?1kmp6lxfuEpuBsdt8UlcJX4LqkBkIrLVa35+kUro9FYMtP4WHIo+AXh+LuYa?= =?us-ascii?Q?qaXDOrDD6JYL9x0b70Qgj/8VfeITTmRDYl9fEWONW/+JO5eymrUu0VfoPONz?= =?us-ascii?Q?w2kTr6fJ8AS6wHDOIU+nNgpY7gAqmwZfoK3Io1Mjy80Ok2kfi+mfSLD9vLs5?= =?us-ascii?Q?fSMtnYnTpEumL6VwWmSjYa3dlvYdnhHPKBvipOxJ4woCB7qGaC6d9iHjJeYb?= =?us-ascii?Q?VDMtsl6bQ7BbbiVS0kZ62bVBqzgYPNgKJss09P79lBDxeFyNljLQYKNSclSJ?= =?us-ascii?Q?zo9dfoJ2SVU1bzBfiGbZLh40BXs5G8AxApl5fa3crJN9FUUFEr9ff6hmBmfu?= =?us-ascii?Q?ndHGsXxA69/S3s2U9/U0cGHktIdFzBSgRa86pMjz2L9bv1X5kv65EY1Tktkl?= =?us-ascii?Q?44Jwr3oQfvl7j2FuLUaGSGRi3Apik8YLf0XWA/N7C+pG8mwZcV+Wgrf5RHTy?= =?us-ascii?Q?m3hYSZr8PIb/IK/7hiWCoDf0DEd9FQysa+6NIj8rTiyVrGE1FduTFEQaG1GL?= =?us-ascii?Q?lKjCbuS2M27kvS5h4LXDnRYJyNwMR3p2sjLH42pzeOGmenZWdyARCHuiAB1y?= =?us-ascii?Q?Av7L5de5PY/WO+dv7xxtWR5jw0a5Y41LIOAVPwP5e7RilGQn98jpyb/DMdrG?= =?us-ascii?Q?MCCZZsT2oGsK+luDBiztdD5Ek86gJ/UvERNvUboGcv7aynjjv/xeyk3njpes?= =?us-ascii?Q?8+ST5I+1p37Ob8Ecvs1M2VA0Vhfzfn4N1n7ntbvAcYGXgXmlHU/UQHArVids?= =?us-ascii?Q?sPrMEqUILjcGzncI46zlQhw6Zlaq0dCz1k7wPaSSafP52J+tHsb+d84vd0TU?= =?us-ascii?Q?e9JwZ1N1Yni5KNdSjGZEusMolj59JYiIVsNC3fdV1AtC3lGWkS9y8Bd6Pq+I?= =?us-ascii?Q?/GPUyxFb0ogc4WLgwMS1Fbkx1AdnkHBtxQTL+KS9V8tmv1vbM4bCM6JwulPa?= =?us-ascii?Q?u77zG1QHvNdHv9sxCVUiAiUmsEgPg9qo4VXA1m9UuQAWd2aQaivR0Wa0Frjx?= =?us-ascii?Q?DIIR3m+BOVmgV+g5Q1KaqRw4FcBdoLsK28bTF/PVueqrNUZi8v4N2kptRxBv?= =?us-ascii?Q?qRHa9uTgFDuv43WAtDpunXAqJSTDHu4n8B4B8gI2y/5TbpAVV6epgXKrSO8K?= =?us-ascii?Q?ojoYZOj3lp05uPJV5WhNWxebKGePDlVHt9jhMPVd6GDtHw5+GqT9KepUc3Hy?= =?us-ascii?Q?qMCT8Xi8Lw7ytof8KRSyUc1zLtD7CYcUKqKrT+yCZIOgmcjDLrM7WumIw+gH?= =?us-ascii?Q?77ISiLDAL0GYtPEjdAxhwT6okLB1CeAMSr2FzCCIVtXWbQC84LeXkMo4WBh2?= =?us-ascii?Q?rFJYMi2NUbtgGBosQ/LBCI68tl7Qasx7Yr3Hz4U3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33f65b29-6dfd-4726-ad56-08dc375dff4e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2024 06:33:23.4273 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZZdr/14bfeDI/YjbWKWUgeUQUMOavMub9YyBkYPvKrM+Mzo0T9MwXdwlOIVlo7esk21AzPPuEx7oxfB6L7jn4JpTUEFyXPt63n7ecgvP7Jk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6361 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dj6b0V17T8i7H7kII97FyBzcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=khk3kKYE; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Monday, February 26, 2024 8:39 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Joey Vagedes > ; Kinney, Michael D > > Subject: [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions > being deprecated >=20 > From: Michael Kubacki >=20 > Currently CodeQL runs have the following warnings: >=20 > Node.js 16 actions are deprecated. Please update the following > actions to use Node.js 20: actions/setup-python@v4, > actions/upload-artifact@v3, actions/cache@v3. For more information > see: > https://github.blog/changelog/2023-09-22-github-actions- > transitioning-from-node-16-to-node-20/. >=20 > And: >=20 > CodeQL Action v2 will be deprecated on December 5th, 2024. Please > update all occurrences of the CodeQL Action in your workflow files > to v3. For more information, see: > https://github.blog/changelog/2024-01-12-code-scanning-deprecation- > of-codeql-action-v2/ >=20 > The first is resolved by updating the actions to the latest versions > that were released to use Node.js 20. The second is specifically > referring to the codeql-action/upload-sarif action which is at v2. >=20 > This change updates all of the actions to the latest releases to > prevent deprecated versions from continuing to be used. >=20 > Cc: Sean Brogan > Cc: Joey Vagedes > Cc: Michael D Kinney > Signed-off-by: Michael Kubacki > --- > .github/workflows/codeql.yml | 37 +++++++++++++------- > 1 file changed, 24 insertions(+), 13 deletions(-) >=20 > diff --git a/.github/workflows/codeql.yml > b/.github/workflows/codeql.yml > index c91e9d4dbeb3..e0c5f69f6cdf 100644 > --- a/.github/workflows/codeql.yml > +++ b/.github/workflows/codeql.yml > @@ -79,7 +79,7 @@ jobs: > uses: actions/checkout@v4 >=20 > - name: Install Python > - uses: actions/setup-python@v4 > + uses: actions/setup-python@v5 > with: > python-version: '3.11' > cache: 'pip' > @@ -136,15 +136,26 @@ jobs: >=20 > print(f'ci_setup_supported=3D{str(ci_setup_supported).lower()}', file=3Df= h) > print(f'setup_supported=3D{str(setup_supported).lower()}', > file=3Dfh) >=20 > + - name: Convert Arch to Log Format > + id: convert_arch_hyphen > + env: > + ARCH_LIST: ${{ matrix.ArchList }} > + shell: python > + run: | > + import os > + > + with open(os.environ['GITHUB_OUTPUT'], 'a') as fh: > + print(f'arch_list=3D{os.environ["ARCH_LIST"].replace(",", "- > ")}', file=3Dfh) I do not see this change described in the commit message. Is it related? > + > - name: Setup > if: steps.get_ci_file_operations.outputs.setup_supported =3D=3D > 'true' > run: stuart_setup -c .pytool/CISettings.py -t DEBUG -a ${{ > matrix.ArchList }} TOOL_CHAIN_TAG=3DVS2019 >=20 > - name: Upload Setup Log As An Artifact > - uses: actions/upload-artifact@v3 > + uses: actions/upload-artifact@v4 > if: (success() || failure()) && > steps.get_ci_file_operations.outputs.setup_supported =3D=3D 'true' > with: > - name: ${{ matrix.Package }}-Logs > + name: ${{ matrix.Package }}-${{ > steps.convert_arch_hyphen.outputs.arch_list }}-Setup-Log > path: | > **/SETUPLOG.txt > retention-days: 7 > @@ -155,10 +166,10 @@ jobs: > run: stuart_ci_setup -c .pytool/CISettings.py -t DEBUG -a ${{ > matrix.ArchList }} TOOL_CHAIN_TAG=3DVS2019 >=20 > - name: Upload CI Setup Log As An Artifact > - uses: actions/upload-artifact@v3 > + uses: actions/upload-artifact@v4 > if: (success() || failure()) && > steps.get_ci_file_operations.outputs.ci_setup_supported =3D=3D 'true' > with: > - name: ${{ matrix.Package }}-Logs > + name: ${{ matrix.Package }}-${{ > steps.convert_arch_hyphen.outputs.arch_list }}-CI-Setup-Log > path: | > **/CISETUP.txt > retention-days: 7 > @@ -168,10 +179,10 @@ jobs: > run: stuart_update -c .pytool/CISettings.py -t DEBUG -a ${{ > matrix.ArchList }} TOOL_CHAIN_TAG=3DVS2019 >=20 > - name: Upload Update Log As An Artifact > - uses: actions/upload-artifact@v3 > + uses: actions/upload-artifact@v4 > if: success() || failure() > with: > - name: ${{ matrix.Package }}-Logs > + name: ${{ matrix.Package }}-${{ > steps.convert_arch_hyphen.outputs.arch_list }}-Update-Log > path: | > **/UPDATE_LOG.txt > retention-days: 7 > @@ -228,7 +239,7 @@ jobs: >=20 > - name: Attempt to Load CodeQL CLI From Cache > id: codeqlcli_cache > - uses: actions/cache@v3 > + uses: actions/cache@v4 > with: > path: ${{ steps.cache_key_gen.outputs.codeql_cli_ext_dep_dir > }} > key: ${{ steps.cache_key_gen.outputs.codeql_cli_cache_key }} > @@ -284,10 +295,10 @@ jobs: > delete_dirs(build_path) >=20 > - name: Upload Build Logs As An Artifact > - uses: actions/upload-artifact@v3 > + uses: actions/upload-artifact@v4 > if: success() || failure() > with: > - name: ${{ matrix.Package }}-Logs > + name: ${{ matrix.Package }}-${{ > steps.convert_arch_hyphen.outputs.arch_list }}-Build-Logs > path: | > **/BUILD_REPORT.TXT > **/OVERRIDELOG.TXT > @@ -329,10 +340,10 @@ jobs: > print(f'upload_sarif_file=3Dfalse', file=3Dfh) >=20 > - name: Upload CodeQL Results (SARIF) As An Artifact > - uses: actions/upload-artifact@v3 > + uses: actions/upload-artifact@v4 > if: steps.env_data.outputs.upload_sarif_file =3D=3D 'true' > with: > - name: ${{ matrix.Package }}-CodeQL-SARIF > + name: ${{ matrix.Package }}-${{ > steps.convert_arch_hyphen.outputs.arch_list }}-CodeQL-SARIF > path: | > ${{ steps.env_data.outputs.emacs_file_path }} > ${{ steps.env_data.outputs.sarif_file_path }} > @@ -340,7 +351,7 @@ jobs: > if-no-files-found: warn >=20 > - name: Upload CodeQL Results (SARIF) To GitHub Code Scanning > - uses: github/codeql-action/upload-sarif@v2 > + uses: github/codeql-action/upload-sarif@v3 > if: steps.env_data.outputs.upload_sarif_file =3D=3D 'true' > with: > # Path to SARIF file relative to the root of the repository. > -- > 2.40.1.vfs.0.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116003): https://edk2.groups.io/g/devel/message/116003 Mute This Topic: https://groups.io/mt/104597854/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-