Re: [edk2-devel] [edk2-stable202402][Patch V3 2/7] UnitTestFrameworkPkg: MSFT CC_FLAGS add /MT to for host builds

["Michael D Kinney" <michael.d.kinney@intel.com>]

The goal was to get everything to /EHs.  I can't recall if using /MT
required it or if this could be moved to the next patch.

Mike

> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Friday, February 9, 2024 6:26 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] [edk2-stable202402][Patch V3 2/7]
> UnitTestFrameworkPkg: MSFT CC_FLAGS add /MT to for host builds
> 
> Did this patch intend to swap /EHsc with /EHs? It looks like that was
> planned for patch 3/7.
> 
> On 2/9/2024 3:32 PM, Michael D Kinney wrote:
> > Add /MT to MSFT CC_FLAGS to always use release libraries
> > when building host-based unit tests so any exceptions
> > generated during host-based test execution generate an
> > error message in stderr instead of a popup window.
> >
> > Use /MTd when -D UNIT_TESTING_DEBUG is to use debug
> > libraries when building host-based unit tests so any
> > exceptions generated during host-based test execution
> > generate a popup window with option to attach a debugger.
> >
> > Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >   UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf | 2 +-
> >   UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc        | 3
> ++-
> >   2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git
> a/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf
> b/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf
> > index 0104384953c3..bdab98a54f0e 100644
> > --- a/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf
> > +++ b/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf
> > @@ -28,6 +28,6 @@ [Packages]
> >     UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec
> >
> >   [BuildOptions]
> > -  MSFT:*_*_*_CC_FLAGS   == /c /EHsc /Zi /Od
> > +  MSFT:*_*_*_CC_FLAGS   == /c /EHs /Zi /Od /MT
> >     GCC:*_*_IA32_CC_FLAGS == -g -c -fshort-wchar -O0 -m32
> >     GCC:*_*_X64_CC_FLAGS  == -g -c -fshort-wchar -O0 -m64
> > diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> > index b8068fd91c98..00f8d9a895be 100644
> > --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> > +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> > @@ -24,9 +24,10 @@ [LibraryClasses.common.HOST_APPLICATION]
> >
> PeiServicesTablePointerLib|UnitTestFrameworkPkg/Library/UnitTestPeiServ
> icesTablePointerLib/UnitTestPeiServicesTablePointerLib.inf
> >
> >   [BuildOptions]
> > +  MSFT:*_*_*_CC_FLAGS = /MT
> >     GCC:*_*_*_CC_FLAGS = -fno-pie
> >   !ifdef $(UNIT_TESTING_DEBUG)
> > -  MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1
> > +  MSFT:*_*_*_CC_FLAGS  = /MTd -D UNIT_TESTING_DEBUG=1
> >     GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1
> >     XCODE:*_*_*_CC_FLAGS = -D UNIT_TESTING_DEBUG=1
> >   !endif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115343): https://edk2.groups.io/g/devel/message/115343
Mute This Topic: https://groups.io/mt/104267257/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-