From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8F964740038 for ; Wed, 24 Jan 2024 00:28:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=O9M6BU5z0y4XMvlF4EGIG5P4CufkWZCVkZUm/x5Z9+A=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706056126; v=1; b=GS0/+esfWk8ytoRjKD4hrXxHfMEiKec3Is2lrK8NmbCXV4GP7say6mNfKtuccX3opWivqRHH 6UE7w6Xj1aIU2aj8rE1mVfIoZzD93z0VWNZVcCjYHumtIiIfHkkvdWD2tz6zJhqcsnjjVUSt3kU Wmb7IXA35xSxtnGDZk+cSd5I= X-Received: by 127.0.0.2 with SMTP id ZhZmYY7687511xgZbF43bBOg; Tue, 23 Jan 2024 16:28:46 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.11018.1706056125401820705 for ; Tue, 23 Jan 2024 16:28:45 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="398851262" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="398851262" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 16:28:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="959320605" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="959320605" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 16:28:44 -0800 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 16:28:43 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 16:28:43 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 16:28:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bGYBv4Cu53YUeC9HNxw2Huc9UiVO1rNXMaQ3Vn+mpbW8vpokQZ+pq4xXugDqb65rnuqkwcUAu2TDN/YeZnhHYeMfhLkhyZS8MoDEhWjLr4HBFs9silQS4gSnpvTUwNfGZzDpztvsrQnyS+I+wJGV59LfrQKFb+1EDMrjEHbcHDJeYjckIM/bRULChDaoi6AkJJB6mG/mO49dy22vtqO3BbflEpPi7ZeRE/G9HLGETCnPJSKCeVF4UUycqXBDFFK+bn6vczQkpYs1dDFZ9cp5hnkAgGPszrYK4DxKz4mRmKV3RAUISeykT5/9fFXYyf6iL97U1tUGv6IMJnmMBiOaqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BADPorB79QYfxjCPM6mSZTRay4Om1JdudhvFBgzGzAM=; b=b7aVswXlUN+Dqm1ZOxjKbCyURNsFxLz6zUMe089ajXqEEtpLUrtokJWeNUMBJFiaFBI8HqH7TBXGrP9tVpQEoRjUfRUKJ2sBq4EInzE/eB12WQfEUliKknzJzW2a35Nhnh53ibtj4xzHbRDOYB/tK7gtowNKHwqPXk5FPpVI89UcBCZ4eRK0QMCYdhIdUtSjAZUWMKFZTXo+8cQTzdMKlXBCq5Tv3er8tAl1fDOlvpOzD9He/kmu/f1F1xd3Be9i7/a4atWXnUkIHyUKGCFmoBWXrkVnbzX2IFFsGLFYTm+0G+S8xoBpjl+P/qC52R0/a+m0DZPri5kC7hULHXPR0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH7PR11MB6652.namprd11.prod.outlook.com (2603:10b6:510:1aa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.37; Wed, 24 Jan 2024 00:28:39 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7202.035; Wed, 24 Jan 2024 00:28:38 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Chen, Christine" , "S, Ashraf Ali" CC: Rebecca Cran , "Gao, Liming" , "Feng, Bob C" , "Chan, Amy" , "Chaganty, Rangasai V" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaN0ca1mG7JbRKIEeE9YUxHjwFPLDPJOiAgBkkelA= Date: Wed, 24 Jan 2024 00:28:38 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH7PR11MB6652:EE_ x-ms-office365-filtering-correlation-id: 65eb4811-3e35-4496-e692-08dc1c7368e3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: IOSqLXevhwCHJDFiS8VWZf19KZ+qQx38fBnwvZUF4qL6fL6u1BxoJc3d08X9HYbyWW823lR0KQVmIohxTTsFuaxn6z5xxSyi842yy5TPDNKaDyUDA2FIFn+VQnkUbiFtj4AkGYszN1SlkRxrnBFJLGDjbk172HkZ32b3VXwbqeTcFAUe6giucCLqSk8WeVFxepza3uu7+qPnFC2YFFhBWg8EqmUTcDqmvDFcNdlHlV/WigjM9hRXYOsSWVTEn+2um9TXXWuqXE0BQHJP9KCPOvSmTbeSHIqSybTs9Be8sCreIPQgvdr5X2Ek5FZFvYiypa/xPFs4/3xOu9HkUdVtcNLQfAzSHBB5Ev4FFD7WKC7+F0u3uGCjVPsL2+jg4JQ3GrFiuCa4ffQ0MMLa3yVdEIjAAh4nzM8OTb6WbPC7b9zW1iLaNU1164I0epjcKHo80JpOj4WmZMk0HgrwViksvTPK7RGmr7AGDJ38EPRRcQW+89xBcmYYpvmbbp88yAYIWngbpyiDqm/iVV/um/ewGxZPyXsQKQde0mV4qcWhSMVLOfDkwQZ8ZrWdo4XK6cmOx8vmcCf4YPU4AC93w5i+M4AUj/JfFs7TxVnDvkNZP+wi0JG0TiWVQQHxVKOJbO0BTBnQJkam/7Q0/zboEb3GhQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u8YnhwajLN78FMwOkB/l8KO06ZF72Cn/2uO8OwoWqrOaJBL24vveHDygWnSS?= =?us-ascii?Q?DlQfhndAXptC2znT1oQeB6aBpMdA4cVy6U7tod9z4T1P9pk4yj7z5nas2IcT?= =?us-ascii?Q?3zigTkFW9OnOkGr/tWngWJZa7mQDTXf668MX/shuTi8AzSGOln3kxE2S+X41?= =?us-ascii?Q?BCWlUGyz6Zh4C28xQe7oO8iLHRddQ4FYHMuy802hPFg2Q2PdqwXJNqGyO/WO?= =?us-ascii?Q?NJUHq5W4SnGb/gM6W6D+UedIDYSmhlWbz42a022dvx835iVbHkHL2U1rDpBL?= =?us-ascii?Q?rMTTkFE9dSIdE2WUR3KOQLo1eb/P2xfuN5psafWkIxIjK+8+qLMiHG72Gdpd?= =?us-ascii?Q?wYvgvkS18hQSqnFT3kJRHtFEIkTQ4vW/5+8gbm4xNVombOXs1n2lWb4MPHda?= =?us-ascii?Q?PVyWtsd/MYcr0rtrMP4pdZi/Gwdi79s27KysZWfNdT+ulfOVqexxkdr39J0K?= =?us-ascii?Q?fFvAy4Rh16OWd4QVnUohGt1rR90bxEoBKf2EPURkKt9Nq8RmYtd5j+PkBqAu?= =?us-ascii?Q?hoiQJGd3I0+Rw166KxoMa4AuPWoX/Aa1tzu38vnAipzFq+Dnn4RwUBzv/7mj?= =?us-ascii?Q?mxRye0FM3w+UIbeuFrGWXDvbYe5lkczbl0vCE8djtv8NLs9o86qQwHN7TPEZ?= =?us-ascii?Q?tJhad1+dZM4WlQN5F1EIYAXk2jlg2/9aFK8G6tp2D8Z4mPFXfaD0jlJgX8MJ?= =?us-ascii?Q?81WEA2HbJ6RTJssT6Ixsf9c5nna2pIoxZ17+FIra3bSgSiEdbVwXJH2nmdbE?= =?us-ascii?Q?Q2b8a9ksd/9TKhLsC6KlEEUyqM00QA6yLBf5OD6ccJJkXDqp1hcuB+5f24H2?= =?us-ascii?Q?zh8CH1102KQ26XV1UkH+gSRoLCP/+5/i6m1oCsa7E+vQ8w5Ehrx2UwTtml4R?= =?us-ascii?Q?z9dzCuKKg8KeD7RrVfc2vu0il3qWHY/au7rJQJxIPM4fLsCIFp7KGqzSdeyk?= =?us-ascii?Q?7t94KVoP4BT/y+pNnaxQo4hTdM4d9BFXVKR+WSZ+U5TwgXqi/20gnKgeQO/K?= =?us-ascii?Q?HKEW7oS4MkQBhksPl0/ml95OB1IHL50WS+tWsj2G5MpD0S32uH4+4L3Q8WV8?= =?us-ascii?Q?y+Me/cFU0g4LKDXFU88N9bxDDlPQetY/C8WXBl4bWo5fDnoCG31tJQl3Wp7P?= =?us-ascii?Q?x/EO4R8VhP2HXCXqroiiUOinrMOxQRqwh6XHs1Hxxknr76da4/hwfTFGOF6r?= =?us-ascii?Q?NUmXFqM5wsaO72mgmAJN6G68nk9RX7YHL8rnEP5BciVghs4U7kStAZ3umYR2?= =?us-ascii?Q?NGnZ6GH1OmM5tQg1re0uceVzrlVjb+4eriXSf/ii/ZsZAjyurd+YAPgqeAVd?= =?us-ascii?Q?5fzMztnl9s+1TtfYT4fPi3WuJc0Ehfb0J50JZH0nJjmL3AmTEOBvuy4gMh7E?= =?us-ascii?Q?HgicCgJAqbywqjD5ysRCc4Hvc9U2cpj66Jsh87a/upTSNUM6FsxTqevG0LkM?= =?us-ascii?Q?tef78fQSP7ZNWPiAJFyhCfScDGNjbn91h0oQABgw6vDQnmWC/KEZTgS1LUJv?= =?us-ascii?Q?wlno83hu8yFbPnWuxksGv8X+wlYAr/ExeXtn4L8oqR/EzryJQvO4oat2BV3J?= =?us-ascii?Q?ORyQjKlwKnrTeLAiIF8Kabbo9cuhHQ9UR4sFWhgzSYpJZ2cXzd7fBEPpnmwP?= =?us-ascii?Q?lg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65eb4811-3e35-4496-e692-08dc1c7368e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2024 00:28:38.5977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6xRggik+58nSAlxCaI+fFvbP0YiWkMTNwEJvVcu1Lq9GQL/JLrDS87UfJ0z0C+KRlXQDUbl+GKs2GyF+HdUNAbu34HH99IqveHMwEfwL6mk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6652 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rLzhKFyfIKCeVFQolLvtcguwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="GS0/+esf"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Christine, I did not see this merged yet. Is this change also in edk2-basetools repo? I do not see it there. I thought the process was to do changed in edk2-basetools repo first where= =20 there are a large set of CI checks and then make the same change in the edk2 repo. Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Sunday, January 7, 2024 4:29 PM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Chan, > Amy ; Chaganty, Rangasai V > > Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of > SkuName and SkuId from allskuset >=20 > Reviewed-by: Yuwei Chen >=20 > > -----Original Message----- > > From: S, Ashraf Ali > > Sent: Monday, December 25, 2023 11:28 PM > > To: devel@edk2.groups.io > > Cc: S, Ashraf Ali ; Chen, Christine > > ; Rebecca Cran ; Gao, Liming > > ; Feng, Bob C ; Chan, > > Amy ; Chaganty, Rangasai V > > > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId > > from allskuset > > > > Currently when the platform has many SKUs then allskuset will be > having so > > many duplicate. and while parsing the allskuset will take longer time > while > > assing Pcd.SkuInfoList. > > This patch is to eliminate those duplicate entires to reduce the build > time > > > > Cc: Yuwei Chen > > Cc: Rebecca Cran > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Amy Chan > > Cc: Sai Chaganty > > Signed-off-by: Ashraf Ali S > > --- > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > index 592d4824a4..dac81454a9 100644 > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > self._DynamicPcdList.sort() > > allskuset =3D [(SkuName, Sku.SkuId) for pcd in > self._DynamicPcdList for > > (SkuName, Sku) in pcd.SkuInfoList.items()] > > + # Remove duplicate sets in the list > > + allskuset =3D list(set(allskuset)) > > for pcd in self._DynamicPcdList: > > if len(pcd.SkuInfoList) =3D=3D 1: > > for (SkuName, SkuId) in allskuset: > > -- > > 2.39.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114245): https://edk2.groups.io/g/devel/message/114245 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-