public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "kraxel@redhat.com" <kraxel@redhat.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Rebecca Cran <rebecca@bsdio.com>,
	"Kubacki, Michael" <michael.kubacki@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
Date: Thu, 30 May 2024 14:10:29 +0000	[thread overview]
Message-ID: <CO1PR11MB4929249DDDACCFFB0D2F7546D2F32@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <gidvbm7vhgno3qsz2szmhxmwtxred74gzrtilhliwms6tkfxvd@uiwqtcjw42qf>

All Maintainer.txt rules are matches and all maintainers/reviewers are combined

CODEOWNERS only matches the last rule.

I do not think your suggestion works. 

Mike

> -----Original Message-----
> From: kraxel@redhat.com <kraxel@redhat.com>
> Sent: Thursday, May 30, 2024 1:33 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>; devel@edk2.groups.io;
> Rebecca Cran <rebecca@bsdio.com>; Kubacki, Michael
> <michael.kubacki@microsoft.com>
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On Wed, May 29, 2024 at 08:06:00PM GMT, Kinney, Michael D wrote:
> > We could, but that would require manually syncing CODEOWNERS
> > with Maintainer.txt until that part of the process is automated.
> 
> https://github.com/tianocore/edk2/pull/5703 ;)
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119396): https://edk2.groups.io/g/devel/message/119396
Mute This Topic: https://groups.io/mt/106355103/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-05-30 14:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 18:53 [edk2-devel] GitHub PR Code Review process now active Michael D Kinney
2024-05-29  6:38 ` Gerd Hoffmann
2024-05-29 15:00   ` Michael D Kinney
2024-05-29 16:38     ` Gerd Hoffmann
2024-05-29 18:09       ` Michael D Kinney
2024-05-29 18:18         ` Rebecca Cran
2024-05-29 18:27           ` Michael D Kinney
2024-05-29 19:25             ` Michael Kubacki
2024-05-29 20:06               ` Michael D Kinney
2024-05-30  0:51                 ` Michael Kubacki
2024-05-30 17:38                   ` Saloni Kasbekar
2024-05-30 18:00                     ` Michael D Kinney
2024-05-31  3:50                       ` Michael D Kinney
2024-05-31  4:36                         ` Michael Kubacki
2024-06-21  5:15                       ` Dhaval Sharma
2024-06-21  5:25                         ` Michael D Kinney
2024-05-30  8:32                 ` Gerd Hoffmann
2024-05-30 14:10                   ` Michael D Kinney [this message]
2024-05-29 10:40 ` Chang, Abner via groups.io
2024-05-29 14:44   ` Michael D Kinney
2024-05-29 14:48     ` Chang, Abner via groups.io
2024-05-30  0:41       ` Yao, Jiewen
2024-06-03 16:13 ` Neal Gompa
2024-06-03 16:26   ` Michael D Kinney
2024-06-03 18:46     ` Neal Gompa
2024-06-03 19:38       ` Michael D Kinney
2024-06-05 22:21         ` Michael D Kinney
2024-06-05 22:47           ` Rebecca Cran via groups.io
2024-06-05 23:27             ` Michael D Kinney
2024-06-16 22:08               ` Rebecca Cran
2024-06-06  1:21           ` Guo Dong
2024-06-06  1:37             ` Michael D Kinney
2024-06-04 13:23       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929249DDDACCFFB0D2F7546D2F32@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox