public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Chao Li <lichao@loongson.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64
Date: Tue, 31 Jan 2023 15:45:00 +0000	[thread overview]
Message-ID: <CO1PR11MB49292557C3F60BB7F0529117D2D09@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230131102851.1935112-1-lichao@loongson.cn>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>



> -----Original Message-----
> From: Chao Li <lichao@loongson.cn>
> Sent: Tuesday, January 31, 2023 2:29 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> Subject: [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64
> 
> The UINT64 and INT64 should be defined as unsigned long long and long long
> in the linux64 bit environment, but now defined as unsigned long and long,
> so fix it.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4330
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Chao Li <lichao@loongson.cn>
> ---
>  MdePkg/Include/LoongArch64/ProcessorBind.h | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/MdePkg/Include/LoongArch64/ProcessorBind.h b/MdePkg/Include/LoongArch64/ProcessorBind.h
> index 502d479099..7064fd1e7c 100644
> --- a/MdePkg/Include/LoongArch64/ProcessorBind.h
> +++ b/MdePkg/Include/LoongArch64/ProcessorBind.h
> @@ -28,17 +28,17 @@
>  // Assume standard LoongArch 64-bit alignment.
>  // Need to check portability of long long
>  //
> -typedef unsigned long   UINT64;
> -typedef long            INT64;
> -typedef unsigned int    UINT32;
> -typedef int             INT32;
> -typedef unsigned short  UINT16;
> -typedef unsigned short  CHAR16;
> -typedef short           INT16;
> -typedef unsigned char   BOOLEAN;
> -typedef unsigned char   UINT8;
> -typedef char            CHAR8;
> -typedef char            INT8;
> +typedef unsigned long long  UINT64;
> +typedef long long           INT64;
> +typedef unsigned int        UINT32;
> +typedef int                 INT32;
> +typedef unsigned short      UINT16;
> +typedef unsigned short      CHAR16;
> +typedef short               INT16;
> +typedef unsigned char       BOOLEAN;
> +typedef unsigned char       UINT8;
> +typedef char                CHAR8;
> +typedef char                INT8;
> 
>  //
>  // Unsigned value of native width.  (4 bytes on supported 32-bit processor instructions,
> --
> 2.27.0


      reply	other threads:[~2023-01-31 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 10:28 [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64 Chao Li
2023-01-31 15:45 ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB49292557C3F60BB7F0529117D2D09@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox