public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64
@ 2023-01-31 10:28 Chao Li
  2023-01-31 15:45 ` Michael D Kinney
  0 siblings, 1 reply; 2+ messages in thread
From: Chao Li @ 2023-01-31 10:28 UTC (permalink / raw)
  To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu

The UINT64 and INT64 should be defined as unsigned long long and long long
in the linux64 bit environment, but now defined as unsigned long and long,
so fix it.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4330

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Chao Li <lichao@loongson.cn>
---
 MdePkg/Include/LoongArch64/ProcessorBind.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/MdePkg/Include/LoongArch64/ProcessorBind.h b/MdePkg/Include/LoongArch64/ProcessorBind.h
index 502d479099..7064fd1e7c 100644
--- a/MdePkg/Include/LoongArch64/ProcessorBind.h
+++ b/MdePkg/Include/LoongArch64/ProcessorBind.h
@@ -28,17 +28,17 @@
 // Assume standard LoongArch 64-bit alignment.
 // Need to check portability of long long
 //
-typedef unsigned long   UINT64;
-typedef long            INT64;
-typedef unsigned int    UINT32;
-typedef int             INT32;
-typedef unsigned short  UINT16;
-typedef unsigned short  CHAR16;
-typedef short           INT16;
-typedef unsigned char   BOOLEAN;
-typedef unsigned char   UINT8;
-typedef char            CHAR8;
-typedef char            INT8;
+typedef unsigned long long  UINT64;
+typedef long long           INT64;
+typedef unsigned int        UINT32;
+typedef int                 INT32;
+typedef unsigned short      UINT16;
+typedef unsigned short      CHAR16;
+typedef short               INT16;
+typedef unsigned char       BOOLEAN;
+typedef unsigned char       UINT8;
+typedef char                CHAR8;
+typedef char                INT8;
 
 //
 // Unsigned value of native width.  (4 bytes on supported 32-bit processor instructions,
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64
  2023-01-31 10:28 [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64 Chao Li
@ 2023-01-31 15:45 ` Michael D Kinney
  0 siblings, 0 replies; 2+ messages in thread
From: Michael D Kinney @ 2023-01-31 15:45 UTC (permalink / raw)
  To: Chao Li, devel@edk2.groups.io
  Cc: Gao, Liming, Liu, Zhiguang, Kinney, Michael D

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>



> -----Original Message-----
> From: Chao Li <lichao@loongson.cn>
> Sent: Tuesday, January 31, 2023 2:29 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> Subject: [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64
> 
> The UINT64 and INT64 should be defined as unsigned long long and long long
> in the linux64 bit environment, but now defined as unsigned long and long,
> so fix it.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4330
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Chao Li <lichao@loongson.cn>
> ---
>  MdePkg/Include/LoongArch64/ProcessorBind.h | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/MdePkg/Include/LoongArch64/ProcessorBind.h b/MdePkg/Include/LoongArch64/ProcessorBind.h
> index 502d479099..7064fd1e7c 100644
> --- a/MdePkg/Include/LoongArch64/ProcessorBind.h
> +++ b/MdePkg/Include/LoongArch64/ProcessorBind.h
> @@ -28,17 +28,17 @@
>  // Assume standard LoongArch 64-bit alignment.
>  // Need to check portability of long long
>  //
> -typedef unsigned long   UINT64;
> -typedef long            INT64;
> -typedef unsigned int    UINT32;
> -typedef int             INT32;
> -typedef unsigned short  UINT16;
> -typedef unsigned short  CHAR16;
> -typedef short           INT16;
> -typedef unsigned char   BOOLEAN;
> -typedef unsigned char   UINT8;
> -typedef char            CHAR8;
> -typedef char            INT8;
> +typedef unsigned long long  UINT64;
> +typedef long long           INT64;
> +typedef unsigned int        UINT32;
> +typedef int                 INT32;
> +typedef unsigned short      UINT16;
> +typedef unsigned short      CHAR16;
> +typedef short               INT16;
> +typedef unsigned char       BOOLEAN;
> +typedef unsigned char       UINT8;
> +typedef char                CHAR8;
> +typedef char                INT8;
> 
>  //
>  // Unsigned value of native width.  (4 bytes on supported 32-bit processor instructions,
> --
> 2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-31 15:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-31 10:28 [PATCH v1] MdePkg: Fix UINT64 and INT64 word length for LoongArch64 Chao Li
2023-01-31 15:45 ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox