public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] Change edk2-cmocka default branch on GitHub?
@ 2024-10-03 15:09 Dionna Glaze via groups.io
  2024-10-03 17:28 ` Michael D Kinney
  0 siblings, 1 reply; 4+ messages in thread
From: Dionna Glaze via groups.io @ 2024-10-03 15:09 UTC (permalink / raw)
  To: devel

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Hi y'all, I'm following some new internal process for mirroring open source
projects and they're asking for the edk2-cmocka repo on GitHub to change
its default branch from repo-sync to master. Will that break things, or is
that a reasonable request? I can't really offer this change as a PR since
it's a setting and not code.

-- 
-Dionna Glaze, PhD, CISSP, CCSP (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120602): https://edk2.groups.io/g/devel/message/120602
Mute This Topic: https://groups.io/mt/108800799/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1369 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Change edk2-cmocka default branch on GitHub?
  2024-10-03 15:09 [edk2-devel] Change edk2-cmocka default branch on GitHub? Dionna Glaze via groups.io
@ 2024-10-03 17:28 ` Michael D Kinney
  2024-10-03 17:50   ` Dionna Glaze via groups.io
  0 siblings, 1 reply; 4+ messages in thread
From: Michael D Kinney @ 2024-10-03 17:28 UTC (permalink / raw)
  To: devel@edk2.groups.io, dionnaglaze@google.com; +Cc: Kinney, Michael D

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

I am curious why the branch name is important.

The .gitmodules file (https://github.com/tianocore/edk2/blob/master/.gitmodules) content does not specify a branch name

[submodule "UnitTestFrameworkPkg/Library/CmockaLib/cmocka"]
                path = UnitTestFrameworkPkg/Library/CmockaLib/cmocka
                url = https://github.com/tianocore/edk2-cmocka.git

The submodule link in edk2 repo is a sha hash with no branch name.

https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg/Library/CmockaLib

Thanks,

Mike


From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dionna Glaze via groups.io
Sent: Thursday, October 3, 2024 8:09 AM
To: devel@edk2.groups.io
Subject: [edk2-devel] Change edk2-cmocka default branch on GitHub?

Hi y'all, I'm following some new internal process for mirroring open source projects and they're asking for the edk2-cmocka repo on GitHub to change its default branch from repo-sync to master. Will that break things, or is that a reasonable request? I can't really offer this change as a PR since it's a setting and not code.

--
-Dionna Glaze, PhD, CISSP, CCSP (she/her)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120603): https://edk2.groups.io/g/devel/message/120603
Mute This Topic: https://groups.io/mt/108800799/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6280 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Change edk2-cmocka default branch on GitHub?
  2024-10-03 17:28 ` Michael D Kinney
@ 2024-10-03 17:50   ` Dionna Glaze via groups.io
  2024-10-03 18:43     ` Michael D Kinney
  0 siblings, 1 reply; 4+ messages in thread
From: Dionna Glaze via groups.io @ 2024-10-03 17:50 UTC (permalink / raw)
  To: Kinney, Michael D; +Cc: devel@edk2.groups.io

[-- Attachment #1: Type: text/plain, Size: 1947 bytes --]

Every branch we import has to have a LICENSE file, and repo-sync doesn't.
So I guess you could solve this a couple ways.

On Thu, Oct 3, 2024 at 10:29 AM Kinney, Michael D <
michael.d.kinney@intel.com> wrote:

> I am curious why the branch name is important.
>
>
>
> The .gitmodules file (
> https://github.com/tianocore/edk2/blob/master/.gitmodules) content does
> not specify a branch name
>
>
>
> [submodule "UnitTestFrameworkPkg/Library/CmockaLib/cmocka"]
>
>                 path = UnitTestFrameworkPkg/Library/CmockaLib/cmocka
>
>                 url = https://github.com/tianocore/edk2-cmocka.git
>
>
>
> The submodule link in edk2 repo is a sha hash with no branch name.
>
>
>
>
> https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg/Library/CmockaLib
>
>
>
> Thanks,
>
>
>
> Mike
>
>
>
>
>
> *From:* devel@edk2.groups.io <devel@edk2.groups.io> *On Behalf Of *Dionna
> Glaze via groups.io
> *Sent:* Thursday, October 3, 2024 8:09 AM
> *To:* devel@edk2.groups.io
> *Subject:* [edk2-devel] Change edk2-cmocka default branch on GitHub?
>
>
>
> Hi y'all, I'm following some new internal process for mirroring open
> source projects and they're asking for the edk2-cmocka repo on GitHub to
> change its default branch from repo-sync to master. Will that break things,
> or is that a reasonable request? I can't really offer this change as a PR
> since it's a setting and not code.
>
>
>
> --
>
> -Dionna Glaze, PhD, CISSP, CCSP (she/her)
>
> 
>


-- 
-Dionna Glaze, PhD, CISSP, CCSP (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120604): https://edk2.groups.io/g/devel/message/120604
Mute This Topic: https://groups.io/mt/108800799/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5666 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Change edk2-cmocka default branch on GitHub?
  2024-10-03 17:50   ` Dionna Glaze via groups.io
@ 2024-10-03 18:43     ` Michael D Kinney
  0 siblings, 0 replies; 4+ messages in thread
From: Michael D Kinney @ 2024-10-03 18:43 UTC (permalink / raw)
  To: Dionna Amalie Glaze; +Cc: devel@edk2.groups.io, Kinney, Michael D

[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]

Thank you for noticing the oversight.  It has been resolved.

Mike

From: Dionna Amalie Glaze <dionnaglaze@google.com>
Sent: Thursday, October 3, 2024 10:50 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] Change edk2-cmocka default branch on GitHub?

Every branch we import has to have a LICENSE file, and repo-sync doesn't. So I guess you could solve this a couple ways.

On Thu, Oct 3, 2024 at 10:29 AM Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>> wrote:
I am curious why the branch name is important.

The .gitmodules file (https://github.com/tianocore/edk2/blob/master/.gitmodules) content does not specify a branch name

[submodule "UnitTestFrameworkPkg/Library/CmockaLib/cmocka"]
                path = UnitTestFrameworkPkg/Library/CmockaLib/cmocka
                url = https://github.com/tianocore/edk2-cmocka.git

The submodule link in edk2 repo is a sha hash with no branch name.

https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg/Library/CmockaLib

Thanks,

Mike


From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Dionna Glaze via groups.io<http://groups.io>
Sent: Thursday, October 3, 2024 8:09 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [edk2-devel] Change edk2-cmocka default branch on GitHub?

Hi y'all, I'm following some new internal process for mirroring open source projects and they're asking for the edk2-cmocka repo on GitHub to change its default branch from repo-sync to master. Will that break things, or is that a reasonable request? I can't really offer this change as a PR since it's a setting and not code.

--
-Dionna Glaze, PhD, CISSP, CCSP (she/her)



--
-Dionna Glaze, PhD, CISSP, CCSP (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120605): https://edk2.groups.io/g/devel/message/120605
Mute This Topic: https://groups.io/mt/108800799/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 10188 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-03 18:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-03 15:09 [edk2-devel] Change edk2-cmocka default branch on GitHub? Dionna Glaze via groups.io
2024-10-03 17:28 ` Michael D Kinney
2024-10-03 17:50   ` Dionna Glaze via groups.io
2024-10-03 18:43     ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox