public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"rebecca@bsdio.com" <rebecca@bsdio.com>
Cc: Andrew Fish <afish@apple.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details
Date: Mon, 27 Feb 2023 18:23:02 +0000	[thread overview]
Message-ID: <CO1PR11MB492926A3A594540D5564C51CD2AF9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB4929BD96C2A766C299D80D40D2AF9@CO1PR11MB4929.namprd11.prod.outlook.com>

.gitmodules also must also use tabs.

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, February 27, 2023 10:22 AM
> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io; rebecca@bsdio.com
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details
> 
> .gitmodules must be lf.  Not sure about other git config files.
> 
> Mike
> 
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Monday, February 27, 2023 10:18 AM
> > To: devel@edk2.groups.io; rebecca@bsdio.com
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>
> > Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details
> >
> > On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote:
> > >
> > > Is it just .sh files that need lf endings, or are there others?
> > >
> >
> > I think this only applies to .sh files.
> >
> > >
> > >
> > > On 2/27/23 9:14 AM, Michael D Kinney wrote:
> > > > There are a few file types that must be lf instead of crlf.  Can those be added as well?
> > > >
> > > > Mike
> > > >
> > > >> -----Original Message-----
> > > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> > > >> Sent: Monday, February 27, 2023 5:03 AM
> > > >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io
> > > >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > > >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details
> > > >>
> > > >> On 2/27/23 1:04 AM, Ard Biesheuvel wrote:
> > > >>
> > > >>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote:
> > > >>>> Add a .editorconfig file which editors can use for basic formatting
> > > >>>> details of files, such as tabs/spaces, line endings etc.
> > > >>>>
> > > >>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > > >>> Thank you very much for this - this is very useful.
> > > >>>
> > > >>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > > >>>
> > > >>> Could we add .dsc/.inf/.dec/etc files as well?
> > > >> I'll move the c/c++ indentation up to the [*] section so it applies to
> > > >> .dsc/.inf/etc too.
> > > >>
> > > >>
> > > >> --
> > > >> Rebecca Cran
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > > 
> > >
> > >

  reply	other threads:[~2023-02-27 18:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27  3:47 [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details Rebecca Cran
2023-02-27  8:04 ` [edk2-devel] " Ard Biesheuvel
2023-02-27 13:02   ` Rebecca Cran
2023-02-27 16:14     ` Michael D Kinney
2023-02-27 16:35       ` Rebecca Cran
2023-02-27 18:18         ` Ard Biesheuvel
2023-02-27 18:22           ` Michael D Kinney
2023-02-27 18:23             ` Michael D Kinney [this message]
2023-02-28 18:20               ` Rebecca Cran
2023-02-28 18:53                 ` Ard Biesheuvel
2023-02-28 21:32                 ` Michael D Kinney
2023-03-01  3:22                   ` Rebecca Cran
2023-03-01  3:27                     ` Michael D Kinney
2023-02-28  6:43             ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB492926A3A594540D5564C51CD2AF9@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox