From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 87DC478003C for ; Thu, 18 Jan 2024 22:44:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Eu707bEQncyIMyDnIcGua6TkQ1+0loApRmKbAdsaGw8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705617872; v=1; b=CLdVRc716+u06LxIeaK0Vdhex57+6UJkagL40CA5TySJrZTORf8daWISfBbKPqwNqcUULLgz QUjBWD1xr15F/zXYholO7rGoOsAsxkg1nflvAsb/ApeKsP2L5HCXZ7Kvh2d0jS4obebNqrxwUR8 r1uvhW8wInEOeQ+3sR9DpVwE= X-Received: by 127.0.0.2 with SMTP id BlnsYY7687511x8fYAi7ruIz; Thu, 18 Jan 2024 14:44:32 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mx.groups.io with SMTP id smtpd.web11.7638.1705617871115255317 for ; Thu, 18 Jan 2024 14:44:31 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="497041" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="497041" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 14:44:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="855147944" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="855147944" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jan 2024 14:44:25 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 14:44:21 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 14:44:20 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Jan 2024 14:44:20 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Jan 2024 14:44:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UBwcy1kur8bvHDGLI31a2dDlt2NQ4lUdKqc18I8Tu+F4QeTBH4bXlmf+0KZu5c+Sza+rVka95r5AetGM0cnv8KvW98pgR1OZpWzHua8LvNpAOG/TjEDuD0v/DVGi+pEeijUh47JoXfuBQnQ8ApeX3QlbUsdv62vimks+CHpH2vr8tgMVIN6TEKNFMaNOCmNln1e1ckJkG5p/KtN0mDE+Nj9WI+urcpauNYHMdwUGBLHvh8quTWY6JB39nIW13Uwan3qG6nqmAzGMPy0VNx14Sh6CIzMb4426zUEyJZY5gxw14QLH8QlZ0KbnNVlEVj6vQojnbrqShsfpM+wsSbsWYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D2X04bV+BZpjqvF9c0Bb4mf+F+j4N8POlBb9Eiu0nEA=; b=Wn/Fxueskw9MXNgvRXaQ+Ey0QLF7DkcRheBdtHETdGzZ95c4MVEWle8LzG8Fd5UW4Sr70/tnVTjEVwjMk+ntbqqnauqLa9WYLrU95E3sCyrFvFi4HCQjZIzTBD+E5rkHhELYOsn2jh1rr78DHWvNg7ii25x4RXblzObNXIkUAW9YepaXxm/PgPgvMXJ4ZzPC+PVszgT/MaB6/MFaZ5uLr71tlgPuog7J7Ydq1+FbixI8YTOWxmUUcQzQ9L07YxDpyNu918XR2Z3I/j47u+r8U3n0zYrglUojNn7L0VoY/332qj2cYU6Rz5bJLwOwpG2d/nSruDz9vUYTPIeTlfIFaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by DM4PR11MB7397.namprd11.prod.outlook.com (2603:10b6:8:103::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Thu, 18 Jan 2024 22:44:17 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 22:44:17 +0000 From: "Michael D Kinney" To: "Pethaiyan, Madhan" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Xu, Wei6" , "Tan, Ming" , "S, Ashraf Ali" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Topic: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Index: AQHaQf3ri8yJvnyzKkqDxn26CDrvubDfVK8AgAC5xiCAACbykIAAA87A Date: Thu, 18 Jan 2024 22:44:17 +0000 Message-ID: References: <2d53b710572890495a268f208027c8de1e9b7fea.1704696138.git.madhan.pethaiyan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|DM4PR11MB7397:EE_ x-ms-office365-filtering-correlation-id: 46facc8c-bf8d-4eee-8dc7-08dc187700ef x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 8sjQIwsCB8iyeaf1Cub94iIikTsXNtKXgp4sE4JyuNURrqYBWKW17NwKlFkUyFdvJezfNtXfJujBFxMzxtj5BfrjHnFDzWzaEc9Z3PvA8R599Lp/tjCONzlvIGdyfvz+h7D5wHpXE7NvA5GQTXYZL7MpJuT6rmdW2jdsqPr6yKPid9hX4zTCZQVRuVGwvtFs/qAp+dvcQQIEkmDAX1b6UeJ4YJxEhLjRo3qmzjs4rV82+vwuYCdh2xCCJASMj+gPStxP1mDmMl9GjeZvEajvcKK18tL9G1o/u/WVEy+AhQjsrXL0hEv5uwW6GgjoEfVpXQNwQvyviSjMueDMqjMIjVzv5aiMY8hvDUKrwxXzt+FQq1JXbNSb4tUMv6ExmAISs3ggHlVRDaSJNXMT31+WXOSiqrYBNdgrPx3sr8QrjrRLg5lIUXC+kKu+w/5KbdU0Nn0FbNMKpSi5jvWyyohe0OpkTkzYo9+Nn7VDFesgno9icFkuvppTL/0XKSx2Pqse22p6xlTi9cEc5asTjfjvizYiaENKC35H2SiU+MIcnWKDFrNBeKN6FZeb9tB5gXowsUtu5uHWGRuO+51nntli1Kty7UkjCMntVETbhwBeYOga/zeoxGS8wx/7Cna12o+j x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5gJ9ibmicdiJmVgZUZlH6FtnmKQl5wlfhoI9y+W3wyjwRPQA+uFo2qSFkQb2?= =?us-ascii?Q?tXfg55pwkHBmD5QJEENJDaR35edE8K7yn56NFDi4yBOpYys7/MIRMBEKngMz?= =?us-ascii?Q?+a24RIh0A+4Sg0Vd4rYPVY6uqhC5mp4znuw46PTvW5PSFFVezCCsJ1TqfKZw?= =?us-ascii?Q?a84ytefUxaGg/OTYOUZ5mI5ZkTsrtRgpQSe9ChJbQ6+0iAtqzyG1H1x8ID+h?= =?us-ascii?Q?82y4P7ax8DoxiY3mNg94i3Yf5OKw0MohEuLT+kGOq55yWKADH0r6vYLMBexd?= =?us-ascii?Q?142h4h5dKu7ghGM+/ebnKLA8Cbv8WSUWiqo1g7IR9Zi7ybWrDZMIpvpDLyhY?= =?us-ascii?Q?xB+Jpj0w4hM9jDyaro0SHaQiJcNF8n9rIpN/PmFQtLx+AuzN2PMz7xbGBdkA?= =?us-ascii?Q?wjm4q3c/e7ogaEQ0574KU4lIUHJ9X6rp1XXmWbi8EyquLMYr3wKOa6XakXTt?= =?us-ascii?Q?3ZukV1oxnvICBqP19DXRgkw7WQDvbxsKMfYmhAcqRou4KkfipB1Njoz7cp56?= =?us-ascii?Q?0CpZ5LPGk6gHMNe9mPhnSTUVU/gxCi0ij+vO54kO+NvexLGuNYTY89u6nUep?= =?us-ascii?Q?x9UErbHwhoHuKUGDP1x1P6B7SUPnm9zDWo/V9A1Bna+wO8hJd3JFkVXq5sNf?= =?us-ascii?Q?umwZjNpEmt6d1QTyFWC+POa0jZzpOJJHKfqF55oWmGuAqON2f8kQk40+RyqH?= =?us-ascii?Q?dMW61LoKgABcodV//dTt4Ji3MBPQinx6Eihx9KWcb3QieZqsDE5OTAe9F16I?= =?us-ascii?Q?GDKuS/0YvkrcU6lkjVtus7vuiy+7l2q5u4kW5lwjMH6TNcjliRtbt4JYCIqF?= =?us-ascii?Q?hFP2Q3hEUqSNm44gUkTwDCi7HVDt5DL7AXOfn4Q9YnWXedSyCzR/uv0y18Gh?= =?us-ascii?Q?zNlUyODtmXlAmRFg/I2aeqtV7YJPeYmLVVGuj6gI+lTme/aP2LdUFiiGpqQT?= =?us-ascii?Q?f7rNDUf5XqgdrvGH64TTT07jtCHqVKp7qK4z1PmHQSrQ1w+JB0/1/MV8uLId?= =?us-ascii?Q?kvK3UvcmkkT8DL7g2v60C5OWsMsYdQD9Cq73TYdBJhF1K7tZjqEAmtT8VGff?= =?us-ascii?Q?daW6zmxI4U+woO9N+lka9T68k6ZLFZeC6x300J209/hMAJaDNZ9GCOoYp2W9?= =?us-ascii?Q?BTUk+TeoMlXoweUFe24lGfeTgmoJy6HP68l8Y+9tOb2f64l+8jxPI0r/vZb8?= =?us-ascii?Q?/WULMdmrlmLRp8TZ48eR78inUXLs+B5IvsRz9SbfP4S4N+6rAZZ7+Uvf8pKB?= =?us-ascii?Q?Dh70sshUlFpFE/J9FaS6xLRg0YJ8e77Br/udLU4HRjO65JPmFarMSLdJP9Eh?= =?us-ascii?Q?6g0fZYQ0vB3SJI+qtb/xPoFmEGLGi9Xn/EeJZNO9nLCArApZG8o0RNmn/EHO?= =?us-ascii?Q?dE5w/zzKGMg6CN5fcT0Xb7jKzz3ThM5mrdjs4NLsnyOs+rjGymR6rcjpzh6F?= =?us-ascii?Q?515gzfzISmQflBEVJQMVWk415zlpl+kZ/LjtBum97NqgdkQUQjJbnxVwifHt?= =?us-ascii?Q?M6Mma5DGhJdAd8VMus75uQ/SdH1fqnPPp4dPUKbp2izw2KM9jn+avTbG3h6w?= =?us-ascii?Q?My/1RHDvI+slFmvN2koVoEz9atBiaqliX91uoP6/yFSN9e46qDm7HXGX6zEd?= =?us-ascii?Q?IA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46facc8c-bf8d-4eee-8dc7-08dc187700ef X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2024 22:44:17.5228 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9JJWwMDCwAn9F1CHQ0zR/yrAcP4hQSzQCEJsb7TMHy1xO16kX64yBfL4FWW8DRQ7fSAdwB917zwICiq95SqrTBgL9NpEGLjD4zj8TmyL2dk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7397 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1Bd6a94WB9Qah1RlM6qrey5hx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CLdVRc71; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Madhan, There are 2 additional files that need function header updates: * SignedCapsulePkg\Universal\SystemFirmwareUpdate\SystemFirmwareCommonDxe.c * SignedCapsulePkg\Universal\SystemFirmwareUpdate\SystemFirmwareDxe.h In addition, there are function headers in the edk2-platforms repo that=20 also need to be updated in separate patch series. * edk2-platforms\Silicon\Intel\IntelSiliconPkg\Feature\Capsule\MicrocodeUpd= ateDxe\MicrocodeFmp.c * edk2-platforms\Silicon\Intel\IntelSiliconPkg\Feature\Capsule\MicrocodeUpd= ateDxe\MicrocodeUpdate.h Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, January 18, 2024 2:30 PM > To: Pethaiyan, Madhan ; devel@edk2.groups.io > Cc: Gao, Liming ; Xu, Wei6 > ; Tan, Ming ; S, Ashraf Ali > ; Kinney, Michael D > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition >=20 > Hi Madhan, >=20 > The patch you provided does fix the logic in the .c file, but the update > is > incomplete. >=20 > * FmpDevicePkg/FmpDxe/FmpDxe.c - Update GetTheImageInfo() function > header > to match the UEFI 2.10 specification that includes all the conditions > to > return EFI_INVALID_PARAMETER. >=20 > * FmpDevicePkg/FmpDxe/FmpDxe.h - Update GetTheImageInfo() function > header > to match the UEFI 2.10 specification that includes all the conditions > to > return EFI_INVALID_PARAMETER. >=20 > * MdePkg/Include/Protocol/FirmwareManagement.h - Update function header > For EFI_FIRMWARE_MANAGEMENT_PROTOCOL_GET_IMAGE_INFO to match the UEFI > 2.10 > specification that includes all the conditions to return > EFI_INVALID_PARAMETER. >=20 > Also, when trying to search for these, I found that the FmpDxe > implementation > uses the function name "GetTheImageInfo()" for the protocol service > called > "GetImageInfo()". I recommend the FmpDxe implementation be updated so > the > function name matches the name of the protocol service. >=20 > I will wait for a V3 patch set to review as a whole before merging. >=20 > Also, the UEFI SCTs would need to be updated for this additional return > status. > please enter a Bugzilla and work with the UEFI SCT team to get them > updated. >=20 > Thanks, >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Thursday, January 18, 2024 12:03 PM > > To: Pethaiyan, Madhan ; > devel@edk2.groups.io > > Cc: Gao, Liming ; Xu, Wei6 > > ; Tan, Ming ; S, Ashraf Ali > > ; Kinney, Michael D > > > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing > condition > > > > Reviewed-by: Michael D Kinney > > > > > > > > > -----Original Message----- > > > From: Pethaiyan, Madhan > > > Sent: Thursday, January 18, 2024 12:57 AM > > > To: devel@edk2.groups.io > > > Cc: Gao, Liming ; Kinney, Michael D > > > ; Xu, Wei6 ; Tan, > Ming > > > ; S, Ashraf Ali > > > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing > > condition > > > > > > Hi All, > > > > > > I had corrected the description, added the UEFI spec version and > > section > > > details . Please check and approve it > > > > > > Thanks, > > > P. Madhan > > > > > > -----Original Message----- > > > From: Pethaiyan, Madhan > > > Sent: Monday, January 8, 2024 12:13 PM > > > To: devel@edk2.groups.io > > > Cc: Pethaiyan, Madhan ; Gao, Liming > > > ; Kinney, Michael D > > > ; Xu, Wei6 > > > Subject: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition > > > > > > From: "Pethaiyan, Madhan" > > > > > > UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing > > > condition check under GetImageInfo function, if the > PackageVersionName > > > is NULL return EFI_INVALID_PARAMETER > > > > > > Signed-off-by: Pethaiyan Madhan > > > Cc: Liming Gao > > > Cc: Michael D Kinney > > > Cc: Wei6 Xu > > > --- > > > FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c > > b/FmpDevicePkg/FmpDxe/FmpDxe.c > > > index 1e7ec4a09e..e87094f84c 100644 > > > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > > > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > > > @@ -495,7 +495,7 @@ GetTheImageInfo ( > > > // Confirm that buffer isn't null > > > // > > > if ( (ImageInfo =3D=3D NULL) || (DescriptorVersion =3D=3D NULL) |= | > > > (DescriptorCount =3D=3D NULL) || (DescriptorSize =3D=3D NULL) > > > - || (PackageVersion =3D=3D NULL)) > > > + || (PackageVersion =3D=3D NULL) || (PackageVersionName =3D=3D N= ULL)) > > > { > > > DEBUG ((DEBUG_ERROR, "FmpDxe(%s): GetImageInfo() - Pointer > > > Parameter is NULL.\n", mImageIdName)); > > > Status =3D EFI_INVALID_PARAMETER; > > > -- > > > 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114013): https://edk2.groups.io/g/devel/message/114013 Mute This Topic: https://groups.io/mt/103620853/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-