Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC

["Michael D Kinney" <michael.d.kinney@intel.com>]

Michael,

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

This has been waiting for a while, so I will go ahead and push.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Thursday, June 17, 2021 4:34 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC
> 
> MinPlatformPkg maintainers, can we please get this in soon if there are
> no concerns?
> 
> Thanks,
> Michael
> 
> On 6/7/2021 10:30 AM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3033
> >
> > Adds several libraries and modules to the MinPlatformPkg build that
> > are currently missing.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++++++++++++--
> >   1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > index 35cbd40abb05..c64f784275bb 100644
> > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > @@ -156,7 +156,9 @@ [Components]
> >     MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/BoardAcpiTableLibNull.inf
> >     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/DxeMultiBoardAcpiSupportLib.inf
> >     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf
> > +  MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> >
> > +  MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLibNull.inf
> >     MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
> >
> >     MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> > @@ -169,9 +171,15 @@ [Components]
> >     MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
> >     MinPlatformPkg/FspWrapper/Library/DxeFspWrapperPlatformLib/DxeFspWrapperPlatformLib.inf
> >
> > +  MinPlatformPkg/Library/CompressLib/CompressLib.inf
> > +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf
> > +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
> > +  MinPlatformPkg/Library/SerialPortTerminalLib/SerialPortTerminalLib.inf
> > +
> >     MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
> >
> >     MinPlatformPkg/Pci/Library/PciHostBridgeLibSimple/PciHostBridgeLibSimple.inf
> > +  MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.inf
> >
> >     MinPlatformPkg/PlatformInit/ReportFv/ReportFvPei.inf
> >     MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
> > @@ -182,6 +190,8 @@ [Components]
> >     MinPlatformPkg/PlatformInit/Library/BoardInitLibNull/BoardInitLibNull.inf
> >     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/PeiMultiBoardInitSupportLib.inf
> >     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/DxeMultiBoardInitSupportLib.inf
> > +  MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
> > +  MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
> >     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem.inf
> >     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMem.inf
> >     MinPlatformPkg/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf
> > @@ -194,16 +204,16 @@ [Components]
> >     MinPlatformPkg/Test/Library/TestPointCheckLib/SecTestPointCheckLib.inf
> >     MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
> >     MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
> > +  MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
> >     MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
> >     MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
> >     MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointLib.inf
> >     MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.inf
> >     MinPlatformPkg/Test/TestPointDumpApp/TestPointDumpApp.inf
> >
> > -!if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
> > +  MinPlatformPkg/Tcg/Library/TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.inf
> >     MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
> >     MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
> > -!endif
> >
> >   [BuildOptions]
> >     *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> >
> 
> 
> 
>