Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC
       [not found] <16865343B1F8ED56.31052@groups.io>
@ 2021-06-17 23:34 ` Michael Kubacki
  2021-07-08 22:44   ` Michael D Kinney
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kubacki @ 2021-06-17 23:34 UTC (permalink / raw)
  To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong

MinPlatformPkg maintainers, can we please get this in soon if there are 
no concerns?

Thanks,
Michael

On 6/7/2021 10:30 AM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3033
> 
> Adds several libraries and modules to the MinPlatformPkg build that
> are currently missing.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 35cbd40abb05..c64f784275bb 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -156,7 +156,9 @@ [Components]
>     MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/BoardAcpiTableLibNull.inf
>     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/DxeMultiBoardAcpiSupportLib.inf
>     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf
> +  MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
>   
> +  MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLibNull.inf
>     MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
>   
>     MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> @@ -169,9 +171,15 @@ [Components]
>     MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
>     MinPlatformPkg/FspWrapper/Library/DxeFspWrapperPlatformLib/DxeFspWrapperPlatformLib.inf
>   
> +  MinPlatformPkg/Library/CompressLib/CompressLib.inf
> +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf
> +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
> +  MinPlatformPkg/Library/SerialPortTerminalLib/SerialPortTerminalLib.inf
> +
>     MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
>   
>     MinPlatformPkg/Pci/Library/PciHostBridgeLibSimple/PciHostBridgeLibSimple.inf
> +  MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.inf
>   
>     MinPlatformPkg/PlatformInit/ReportFv/ReportFvPei.inf
>     MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
> @@ -182,6 +190,8 @@ [Components]
>     MinPlatformPkg/PlatformInit/Library/BoardInitLibNull/BoardInitLibNull.inf
>     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/PeiMultiBoardInitSupportLib.inf
>     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/DxeMultiBoardInitSupportLib.inf
> +  MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
> +  MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
>     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem.inf
>     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMem.inf
>     MinPlatformPkg/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf
> @@ -194,16 +204,16 @@ [Components]
>     MinPlatformPkg/Test/Library/TestPointCheckLib/SecTestPointCheckLib.inf
>     MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
>     MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
> +  MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
>     MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
>     MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
>     MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointLib.inf
>     MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.inf
>     MinPlatformPkg/Test/TestPointDumpApp/TestPointDumpApp.inf
>   
> -!if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
> +  MinPlatformPkg/Tcg/Library/TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.inf
>     MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
>     MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
> -!endif
>   
>   [BuildOptions]
>     *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC
  2021-06-17 23:34 ` [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC Michael Kubacki
@ 2021-07-08 22:44   ` Michael D Kinney
  2021-07-08 22:47     ` Michael D Kinney
  0 siblings, 1 reply; 3+ messages in thread
From: Michael D Kinney @ 2021-07-08 22:44 UTC (permalink / raw)
  To: devel@edk2.groups.io, mikuback@linux.microsoft.com,
	Kinney, Michael D
  Cc: Chiu, Chasel, Desimone, Nathaniel L, Liming Gao, Dong, Eric

Michael,

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

This has been waiting for a while, so I will go ahead and push.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Thursday, June 17, 2021 4:34 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC
> 
> MinPlatformPkg maintainers, can we please get this in soon if there are
> no concerns?
> 
> Thanks,
> Michael
> 
> On 6/7/2021 10:30 AM, Michael Kubacki wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3033
> >
> > Adds several libraries and modules to the MinPlatformPkg build that
> > are currently missing.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++++++++++++--
> >   1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > index 35cbd40abb05..c64f784275bb 100644
> > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > @@ -156,7 +156,9 @@ [Components]
> >     MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/BoardAcpiTableLibNull.inf
> >     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/DxeMultiBoardAcpiSupportLib.inf
> >     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf
> > +  MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> >
> > +  MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLibNull.inf
> >     MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
> >
> >     MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> > @@ -169,9 +171,15 @@ [Components]
> >     MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
> >     MinPlatformPkg/FspWrapper/Library/DxeFspWrapperPlatformLib/DxeFspWrapperPlatformLib.inf
> >
> > +  MinPlatformPkg/Library/CompressLib/CompressLib.inf
> > +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf
> > +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
> > +  MinPlatformPkg/Library/SerialPortTerminalLib/SerialPortTerminalLib.inf
> > +
> >     MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
> >
> >     MinPlatformPkg/Pci/Library/PciHostBridgeLibSimple/PciHostBridgeLibSimple.inf
> > +  MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.inf
> >
> >     MinPlatformPkg/PlatformInit/ReportFv/ReportFvPei.inf
> >     MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
> > @@ -182,6 +190,8 @@ [Components]
> >     MinPlatformPkg/PlatformInit/Library/BoardInitLibNull/BoardInitLibNull.inf
> >     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/PeiMultiBoardInitSupportLib.inf
> >     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/DxeMultiBoardInitSupportLib.inf
> > +  MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
> > +  MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
> >     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem.inf
> >     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMem.inf
> >     MinPlatformPkg/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf
> > @@ -194,16 +204,16 @@ [Components]
> >     MinPlatformPkg/Test/Library/TestPointCheckLib/SecTestPointCheckLib.inf
> >     MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
> >     MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
> > +  MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
> >     MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
> >     MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
> >     MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointLib.inf
> >     MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.inf
> >     MinPlatformPkg/Test/TestPointDumpApp/TestPointDumpApp.inf
> >
> > -!if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
> > +  MinPlatformPkg/Tcg/Library/TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.inf
> >     MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
> >     MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
> > -!endif
> >
> >   [BuildOptions]
> >     *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> >
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC
  2021-07-08 22:44   ` Michael D Kinney
@ 2021-07-08 22:47     ` Michael D Kinney
  0 siblings, 0 replies; 3+ messages in thread
From: Michael D Kinney @ 2021-07-08 22:47 UTC (permalink / raw)
  To: devel@edk2.groups.io, mikuback@linux.microsoft.com,
	Kinney, Michael D
  Cc: Chiu, Chasel, Desimone, Nathaniel L, Liming Gao, Dong, Eric

Pushed as:

https://github.com/tianocore/edk2-platforms/commit/35c8ba10fe00db810f83730b23b1538daa75efa7

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, July 8, 2021 3:44 PM
> To: devel@edk2.groups.io; mikuback@linux.microsoft.com; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC
> 
> Michael,
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> This has been waiting for a while, so I will go ahead and push.
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> > Sent: Thursday, June 17, 2021 4:34 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC
> >
> > MinPlatformPkg maintainers, can we please get this in soon if there are
> > no concerns?
> >
> > Thanks,
> > Michael
> >
> > On 6/7/2021 10:30 AM, Michael Kubacki wrote:
> > > From: Michael Kubacki <michael.kubacki@microsoft.com>
> > >
> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3033
> > >
> > > Adds several libraries and modules to the MinPlatformPkg build that
> > > are currently missing.
> > >
> > > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Eric Dong <eric.dong@intel.com>
> > > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > > ---
> > >   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++++++++++++--
> > >   1 file changed, 12 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > > index 35cbd40abb05..c64f784275bb 100644
> > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> > > @@ -156,7 +156,9 @@ [Components]
> > >     MinPlatformPkg/Acpi/Library/BoardAcpiTableLibNull/BoardAcpiTableLibNull.inf
> > >     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/DxeMultiBoardAcpiSupportLib.inf
> > >     MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf
> > > +  MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> > >
> > > +  MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLibNull.inf
> > >     MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
> > >
> > >     MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> > > @@ -169,9 +171,15 @@ [Components]
> > >     MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
> > >     MinPlatformPkg/FspWrapper/Library/DxeFspWrapperPlatformLib/DxeFspWrapperPlatformLib.inf
> > >
> > > +  MinPlatformPkg/Library/CompressLib/CompressLib.inf
> > > +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf
> > > +  MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
> > > +  MinPlatformPkg/Library/SerialPortTerminalLib/SerialPortTerminalLib.inf
> > > +
> > >     MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
> > >
> > >     MinPlatformPkg/Pci/Library/PciHostBridgeLibSimple/PciHostBridgeLibSimple.inf
> > > +  MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.inf
> > >
> > >     MinPlatformPkg/PlatformInit/ReportFv/ReportFvPei.inf
> > >     MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
> > > @@ -182,6 +190,8 @@ [Components]
> > >     MinPlatformPkg/PlatformInit/Library/BoardInitLibNull/BoardInitLibNull.inf
> > >     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/PeiMultiBoardInitSupportLib.inf
> > >     MinPlatformPkg/PlatformInit/Library/MultiBoardInitSupportLib/DxeMultiBoardInitSupportLib.inf
> > > +  MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
> > > +  MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
> > >     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem.inf
> > >     MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMem.inf
> > >     MinPlatformPkg/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf
> > > @@ -194,16 +204,16 @@ [Components]
> > >     MinPlatformPkg/Test/Library/TestPointCheckLib/SecTestPointCheckLib.inf
> > >     MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
> > >     MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
> > > +  MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
> > >     MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLib.inf
> > >     MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
> > >     MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointLib.inf
> > >     MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.inf
> > >     MinPlatformPkg/Test/TestPointDumpApp/TestPointDumpApp.inf
> > >
> > > -!if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
> > > +  MinPlatformPkg/Tcg/Library/TpmPlatformHierarchyLib/TpmPlatformHierarchyLib.inf
> > >     MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
> > >     MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
> > > -!endif
> > >
> > >   [BuildOptions]
> > >     *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> > >
> >
> >
> > 
> >


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-08 22:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <16865343B1F8ED56.31052@groups.io>
2021-06-17 23:34 ` [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC Michael Kubacki
2021-07-08 22:44   ` Michael D Kinney
2021-07-08 22:47     ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox