* [PATCH v7 0/3] RISC-V SBI-backed SerialLib
@ 2023-04-07 21:44 Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers Andrei Warkentin
` (3 more replies)
0 siblings, 4 replies; 17+ messages in thread
From: Andrei Warkentin @ 2023-04-07 21:44 UTC (permalink / raw)
To: devel; +Cc: Andrei Warkentin
Hello,
Here are three patches that provide a SerialLib backed by SBI console.
Both legacy and DBCN mechanisms are supported in various execution environments and have been tested with UART and HTIF consoles.
MdePkg reviewers: please review MdePkg.dsc changes.
This is also available at
https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
A CI run is at https://github.com/tianocore/edk2/pull/4252
Compared to v6:
- Unify the two SerialLib implementations under one directory and
factor out the code somewhat.
- Sunil's feedback on correctness.
Compared to v5:
Rename components as per Michael Kinney's suggestions.
Compared to v4:
(not sent out). CC MdePkg maintainers, fix copyright date in SecMain.c.
Compared to v3
EccCheck fixes. Add MdePkg infs to DSC.
Compared to v2:
- Probes legacy extension as well.
- Encode supported module types in the INF file. This is done using LIBRARY_CLASS,
as MODULE_TYPE cannot encode multiple types, so MODULE_TYPE is retained as BASE.
- Update INF version and generate brand new GUIDs instead of editing them.
- Checked that all patches retain ^M endings.
Andrei Warkentin (3):
MdePkg: BaseRiscVSbiLib: make more useful to consumers
MdePkg: add SBI-based SerialPortLib for RISC-V
OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
MdePkg/MdePkg.dsc | 2 +
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf | 40 +++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf | 37 +++
OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++-
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h | 41 +++
OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c | 3 +-
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c | 208 ++++++++++++++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c | 289 ++++++++++++++++++++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c | 132 +++++++++
OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +-
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni | 16 ++
13 files changed, 808 insertions(+), 6 deletions(-)
create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c
create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni
--
2.25.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v7 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers
2023-04-07 21:44 [PATCH v7 0/3] RISC-V SBI-backed SerialLib Andrei Warkentin
@ 2023-04-07 21:44 ` Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V Andrei Warkentin
` (2 subsequent siblings)
3 siblings, 0 replies; 17+ messages in thread
From: Andrei Warkentin @ 2023-04-07 21:44 UTC (permalink / raw)
To: devel; +Cc: Andrei Warkentin, Daniel Schaefer, Gerd Hoffmann, Sunil V L
Add a few more definitions and make SbiCall and TranslateError
usable (not static) by library users.
Cc: Daniel Schaefer <git@danielschaefer.me>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
---
MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++++++++++++++++++--
MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c | 3 +-
2 files changed, 38 insertions(+), 5 deletions(-)
diff --git a/MdePkg/Include/Library/BaseRiscVSbiLib.h b/MdePkg/Include/Library/BaseRiscVSbiLib.h
index e75520b4b888..2244165a6b6a 100644
--- a/MdePkg/Include/Library/BaseRiscVSbiLib.h
+++ b/MdePkg/Include/Library/BaseRiscVSbiLib.h
@@ -2,6 +2,7 @@
Library to call the RISC-V SBI ecalls
Copyright (c) 2021-2022, Hewlett Packard Development LP. All rights reserved.<BR>
+ Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -18,10 +19,28 @@
#include <Uefi.h>
/* SBI Extension IDs */
-#define SBI_EXT_TIME 0x54494D45
-#define SBI_EXT_SRST 0x53525354
+#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1
+#define SBI_EXT_0_1_CONSOLE_GETCHAR 0x2
+#define SBI_EXT_BASE 0x10
+#define SBI_EXT_DBCN 0x4442434E
+#define SBI_EXT_TIME 0x54494D45
+#define SBI_EXT_SRST 0x53525354
-/* SBI function IDs for TIME extension*/
+/* SBI function IDs for base extension */
+#define SBI_EXT_BASE_SPEC_VERSION 0x0
+#define SBI_EXT_BASE_IMPL_ID 0x1
+#define SBI_EXT_BASE_IMPL_VERSION 0x2
+#define SBI_EXT_BASE_PROBE_EXT 0x3
+#define SBI_EXT_BASE_GET_MVENDORID 0x4
+#define SBI_EXT_BASE_GET_MARCHID 0x5
+#define SBI_EXT_BASE_GET_MIMPID 0x6
+
+/* SBI function IDs for DBCN extension */
+#define SBI_EXT_DBCN_WRITE 0x0
+#define SBI_EXT_DBCN_READ 0x1
+#define SBI_EXT_DBCN_WRITE_BYTE 0x2
+
+/* SBI function IDs for TIME extension */
#define SBI_EXT_TIME_SET_TIMER 0x0
/* SBI function IDs for SRST extension */
@@ -62,6 +81,21 @@ typedef struct {
UINTN Value; ///< Value returned
} SBI_RET;
+SBI_RET
+EFIAPI
+SbiCall (
+ IN UINTN ExtId,
+ IN UINTN FuncId,
+ IN UINTN NumArgs,
+ ...
+ );
+
+EFI_STATUS
+EFIAPI
+TranslateError (
+ IN UINTN SbiError
+ );
+
VOID
EFIAPI
SbiSetTimer (
diff --git a/MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c b/MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c
index 2ba8f5ed366a..1141abfab9d0 100644
--- a/MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c
+++ b/MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c
@@ -4,6 +4,7 @@
It allows calling an SBI function via an ecall from S-Mode.
Copyright (c) 2021-2022, Hewlett Packard Development LP. All rights reserved.<BR>
+ Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -31,7 +32,6 @@
@retval Returns SBI_RET structure with value and error code.
**/
-STATIC
SBI_RET
EFIAPI
SbiCall (
@@ -88,7 +88,6 @@ SbiCall (
@param[in] SbiError SBI error code
@retval EFI_STATUS
**/
-STATIC
EFI_STATUS
EFIAPI
TranslateError (
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V
2023-04-07 21:44 [PATCH v7 0/3] RISC-V SBI-backed SerialLib Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers Andrei Warkentin
@ 2023-04-07 21:44 ` Andrei Warkentin
2023-04-12 7:15 ` Sunil V L
2023-04-07 21:44 ` [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Andrei Warkentin
2023-04-07 22:08 ` [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib Michael D Kinney
3 siblings, 1 reply; 17+ messages in thread
From: Andrei Warkentin @ 2023-04-07 21:44 UTC (permalink / raw)
To: devel
Cc: Andrei Warkentin, Daniel Schaefer, Sunil V L, Michael D Kinney,
Liming Gao, Zhiguang Liu, Gerd Hoffmann
These are implementations of SerialPortLib using SBI console services.
- BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP) environments
- BaseSerialPortLibRiscVSbiLibRam is appropriate for PrePI/DXE environments
Tested with:
- Qemu RiscVVirt (non-DBCN case, backed by UART)
- TinyEMU + RiscVVirt (non-DBCN case, HTIF)
- TinyEMU + RiscVVirt (DBCN case, HTIF)
Cc: Daniel Schaefer <git@danielschaefer.me>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
---
MdePkg/MdePkg.dsc | 2 +
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf | 41 +++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf | 38 +++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h | 41 +++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c | 208 ++++++++++++++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c | 289 ++++++++++++++++++++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c | 132 +++++++++
MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni | 16 ++
8 files changed, 767 insertions(+)
diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
index 0ac7618b4623..a810ad0d147d 100644
--- a/MdePkg/MdePkg.dsc
+++ b/MdePkg/MdePkg.dsc
@@ -192,5 +192,7 @@ [Components.ARM, Components.AARCH64]
[Components.RISCV64]
MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.inf
+ MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
+ MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
[BuildOptions]
diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
new file mode 100644
index 000000000000..2340ac6bfe67
--- /dev/null
+++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
@@ -0,0 +1,41 @@
+## @file
+# Serial Port Library backed by SBI console.
+#
+# Meant for SEC and PEI (XIP) environments.
+#
+# Due to limitations of SBI console interface and XIP environments
+# (on use of globals), this library instance does not implement reading
+# and polling the serial port. See PrePiDxeSerialPortLibRiscVSbiRam.inf
+# for the full-featured variant meant for PrePi and DXE environments.
+#
+# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+#
+##
+
+[Defines]
+ INF_VERSION = 0x0001001B
+ BASE_NAME = BaseSerialPortLibRiscVSbiLib
+ MODULE_UNI_FILE = BaseSerialPortLibRiscVSbiLib.uni
+ FILE_GUID = 639fad38-4bfd-4eb9-9f09-e97c7947d480
+ MODULE_TYPE = BASE
+ VERSION_STRING = 1.0
+ LIBRARY_CLASS = SerialPortLib | SEC PEI_CORE PEIM
+
+
+#
+# VALID_ARCHITECTURES = RISCV64
+#
+
+[Sources]
+ BaseSerialPortLibRiscVSbiLib.c
+ Common.c
+ Common.h
+
+[Packages]
+ MdePkg/MdePkg.dec
+
+[LibraryClasses]
+ RiscVSbiLib
diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
new file mode 100644
index 000000000000..d09573ca5b36
--- /dev/null
+++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
@@ -0,0 +1,38 @@
+## @file
+# Serial Port Library backed by SBI console.
+#
+# Meant for PrePi and DXE environments (where globals are allowed). See
+# BaseSerialPortLibRiscVSbiLib.inf for a reduced variant appropriate
+# for SEC and PEI (XIP) environments.
+#
+# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+#
+##
+
+[Defines]
+ INF_VERSION = 0x0001001B
+ BASE_NAME = BaseSerialPortLibRiscVSbiLibRam
+ MODULE_UNI_FILE = BaseSerialPortLibRiscVSbiLib.uni
+ FILE_GUID = 872af743-ab56-45b4-a065-602567f4820c
+ MODULE_TYPE = BASE
+ VERSION_STRING = 1.0
+ LIBRARY_CLASS = SerialPortLib | SEC DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_DRIVER UEFI_APPLICATION
+
+
+#
+# VALID_ARCHITECTURES = RISCV64
+#
+
+[Sources]
+ BaseSerialPortLibRiscVSbiLibRam.c
+ Common.c
+ Common.h
+
+[Packages]
+ MdePkg/MdePkg.dec
+
+[LibraryClasses]
+ RiscVSbiLib
diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
new file mode 100644
index 000000000000..98c1a5d3865e
--- /dev/null
+++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
@@ -0,0 +1,41 @@
+/** @file
+ Serial Port Library backed by SBI console.
+
+ Common functionality shared by PrePiDxeSerialPortLibRiscVSbi and
+ PrePiDxeSerialPortLibRiscVSbiRam implementations.
+
+ Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef SERIAL_PORT_SBI_COMMON_H_
+#define SERIAL_PORT_SBI_COMMON_H_
+
+#include <Base.h>
+#include <Library/SerialPortLib.h>
+#include <Library/BaseRiscVSbiLib.h>
+
+BOOLEAN
+SbiImplementsDbcn (
+ VOID
+ );
+
+BOOLEAN
+SbiImplementsLegacyPutchar (
+ VOID
+ );
+
+UINTN
+SbiLegacyPutchar (
+ IN UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ );
+
+UINTN
+SbiDbcnWrite (
+ IN UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ );
+
+#endif /* SERIAL_PORT_SBI_COMMON_H_ */
diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
new file mode 100644
index 000000000000..f4f2959cf8cc
--- /dev/null
+++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
@@ -0,0 +1,208 @@
+/** @file
+ Serial Port Library backed by SBI console.
+
+ Meant for SEC and PEI (XIP) environments.
+
+ Due to limitations of SBI console interface and XIP environments
+ (on use of globals), this library instance does not implement reading
+ and polling the serial port. See BaseSerialPortLibRiscVSbiLibRam.c for
+ the full-featured variant meant for PrePi and DXE environments.
+
+ Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include "Common.h"
+
+/**
+ Initialize the serial device hardware.
+
+ If no initialization is required, then return RETURN_SUCCESS.
+ If the serial device was successfully initialized, then return RETURN_SUCCESS.
+ If the serial device could not be initialized, then return RETURN_DEVICE_ERROR.
+
+ @retval RETURN_SUCCESS The serial device was initialized.
+ @retval RETURN_DEVICE_ERROR The serial device could not be initialized.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortInitialize (
+ VOID
+ )
+{
+ return RETURN_SUCCESS;
+}
+
+/**
+ Write data from buffer to serial device.
+
+ Writes NumberOfBytes data bytes from Buffer to the serial device.
+ The number of bytes actually written to the serial device is returned.
+ If the return value is less than NumberOfBytes, then the write operation failed.
+ If NumberOfBytes is zero, then return 0.
+
+ @param Buffer The pointer to the data buffer to be written.
+ @param NumberOfBytes The number of bytes to written to the serial device.
+
+ @retval 0 NumberOfBytes is 0.
+ @retval >0 The number of bytes written to the serial device.
+ If this value is less than NumberOfBytes, then the write operation failed.
+
+**/
+UINTN
+EFIAPI
+SerialPortWrite (
+ IN UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ )
+{
+ if (NumberOfBytes == 0) {
+ return 0;
+ }
+
+ if (SbiImplementsDbcn ()) {
+ return SbiDbcnWrite (Buffer, NumberOfBytes);
+ }
+
+ if (SbiImplementsLegacyPutchar ()) {
+ return SbiLegacyPutchar (Buffer, NumberOfBytes);
+ }
+
+ /*
+ * Neither DBCN or legacy extension were present.
+ */
+ return 0;
+}
+
+/**
+ Read data from serial device and save the datas in buffer.
+
+ Reads NumberOfBytes data bytes from a serial device into the buffer
+ specified by Buffer. The number of bytes actually read is returned.
+ If the return value is less than NumberOfBytes, then the rest operation failed.
+ If NumberOfBytes is zero, then return 0.
+
+ @param Buffer The pointer to the data buffer to store the data read from the serial device.
+ @param NumberOfBytes The number of bytes which will be read.
+
+ @retval 0 Read data failed; No data is to be read.
+ @retval >0 The actual number of bytes read from serial device.
+
+**/
+UINTN
+EFIAPI
+SerialPortRead (
+ OUT UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ )
+{
+ return 0;
+}
+
+/**
+ Polls a serial device to see if there is any data waiting to be read.
+
+ Polls a serial device to see if there is any data waiting to be read.
+ If there is data waiting to be read from the serial device, then TRUE is returned.
+ If there is no data waiting to be read from the serial device, then FALSE is returned.
+
+ @retval TRUE Data is waiting to be read from the serial device.
+ @retval FALSE There is no data waiting to be read from the serial device.
+
+**/
+BOOLEAN
+EFIAPI
+SerialPortPoll (
+ VOID
+ )
+{
+ return FALSE;
+}
+
+/**
+ Sets the control bits on a serial device.
+
+ @param Control Sets the bits of Control that are settable.
+
+ @retval RETURN_SUCCESS The new control bits were set on the serial device.
+ @retval RETURN_UNSUPPORTED The serial device does not support this operation.
+ @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortSetControl (
+ IN UINT32 Control
+ )
+{
+ return RETURN_SUCCESS;
+}
+
+/**
+ Retrieve the status of the control bits on a serial device.
+
+ @param Control A pointer to return the current control signals from the serial device.
+
+ @retval RETURN_SUCCESS The control bits were read from the serial device.
+ @retval RETURN_UNSUPPORTED The serial device does not support this operation.
+ @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortGetControl (
+ OUT UINT32 *Control
+ )
+{
+ *Control = 0;
+ return RETURN_SUCCESS;
+}
+
+/**
+ Sets the baud rate, receive FIFO depth, transmit/receice time out, parity,
+ data bits, and stop bits on a serial device.
+
+ @param BaudRate The requested baud rate. A BaudRate value of 0 will use the
+ device's default interface speed.
+ On output, the value actually set.
+ @param ReveiveFifoDepth The requested depth of the FIFO on the receive side of the
+ serial interface. A ReceiveFifoDepth value of 0 will use
+ the device's default FIFO depth.
+ On output, the value actually set.
+ @param Timeout The requested time out for a single character in microseconds.
+ This timeout applies to both the transmit and receive side of the
+ interface. A Timeout value of 0 will use the device's default time
+ out value.
+ On output, the value actually set.
+ @param Parity The type of parity to use on this serial device. A Parity value of
+ DefaultParity will use the device's default parity value.
+ On output, the value actually set.
+ @param DataBits The number of data bits to use on the serial device. A DataBits
+ vaule of 0 will use the device's default data bit setting.
+ On output, the value actually set.
+ @param StopBits The number of stop bits to use on this serial device. A StopBits
+ value of DefaultStopBits will use the device's default number of
+ stop bits.
+ On output, the value actually set.
+
+ @retval RETURN_SUCCESS The new attributes were set on the serial device.
+ @retval RETURN_UNSUPPORTED The serial device does not support this operation.
+ @retval RETURN_INVALID_PARAMETER One or more of the attributes has an unsupported value.
+ @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortSetAttributes (
+ IN OUT UINT64 *BaudRate,
+ IN OUT UINT32 *ReceiveFifoDepth,
+ IN OUT UINT32 *Timeout,
+ IN OUT EFI_PARITY_TYPE *Parity,
+ IN OUT UINT8 *DataBits,
+ IN OUT EFI_STOP_BITS_TYPE *StopBits
+ )
+{
+ return RETURN_SUCCESS;
+}
diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c
new file mode 100644
index 000000000000..fafba87b7cd1
--- /dev/null
+++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c
@@ -0,0 +1,289 @@
+/** @file
+ Serial Port Library backed by SBI console.
+
+ Meant for PrePi and DXE environments (where globals are allowed). See
+ BaseSerialPortLibRiscVSbiLib.c for a reduced variant appropriate for
+ SEC and PEI (XIP) environments.
+
+ Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include <Base.h>
+#include <Library/SerialPortLib.h>
+#include <Library/BaseRiscVSbiLib.h>
+#include "Common.h"
+
+STATIC BOOLEAN mHaveDbcn = FALSE;
+STATIC BOOLEAN mHaveLegacyPutchar = FALSE;
+STATIC BOOLEAN mHaveLegacyGetchar = FALSE;
+STATIC INT64 mLastGetChar = -1;
+
+/**
+ Return whether the legacy console getchar extension is implemented.
+
+ @retval TRUE Extension is implemented.
+ @retval FALSE Extension is not implemented.
+
+**/
+STATIC
+BOOLEAN
+SbiImplementsLegacyGetchar (
+ VOID
+ )
+{
+ SBI_RET Ret;
+
+ Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1, SBI_EXT_0_1_CONSOLE_GETCHAR);
+ if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
+ (Ret.Value != 0))
+ {
+ return TRUE;
+ }
+
+ return FALSE;
+}
+
+/**
+ Initialize the serial device hardware.
+
+ If no initialization is required, then return RETURN_SUCCESS.
+ If the serial device was successfully initialized, then return RETURN_SUCCESS.
+ If the serial device could not be initialized, then return RETURN_DEVICE_ERROR.
+
+ @retval RETURN_SUCCESS The serial device was initialized.
+ @retval RETURN_DEVICE_ERROR The serial device could not be initialized.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortInitialize (
+ VOID
+ )
+{
+ if (SbiImplementsDbcn ()) {
+ mHaveDbcn = TRUE;
+ return RETURN_SUCCESS;
+ }
+
+ if (SbiImplementsLegacyPutchar ()) {
+ mHaveLegacyPutchar = TRUE;
+ }
+
+ if (SbiImplementsLegacyGetchar ()) {
+ mHaveLegacyGetchar = TRUE;
+ }
+
+ return (mHaveLegacyGetchar && mHaveLegacyPutchar) ?
+ RETURN_SUCCESS :
+ RETURN_DEVICE_ERROR;
+}
+
+/**
+ Write data from buffer to serial device.
+
+ Writes NumberOfBytes data bytes from Buffer to the serial device.
+ The number of bytes actually written to the serial device is returned.
+ If the return value is less than NumberOfBytes, then the write operation failed.
+ If NumberOfBytes is zero, then return 0.
+
+ @param Buffer The pointer to the data buffer to be written.
+ @param NumberOfBytes The number of bytes to written to the serial device.
+
+ @retval 0 NumberOfBytes is 0.
+ @retval >0 The number of bytes written to the serial device.
+ If this value is less than NumberOfBytes, then the write operation failed.
+
+**/
+UINTN
+EFIAPI
+SerialPortWrite (
+ IN UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ )
+{
+ if (NumberOfBytes == 0) {
+ return 0;
+ }
+
+ if (mHaveDbcn) {
+ return SbiDbcnWrite (Buffer, NumberOfBytes);
+ } else if (mHaveLegacyPutchar) {
+ return SbiLegacyPutchar (Buffer, NumberOfBytes);
+ }
+
+ /*
+ * Neither DBCN or legacy extension were present.
+ */
+ return 0;
+}
+
+/**
+ Read data from serial device and save the datas in buffer.
+
+ Reads NumberOfBytes data bytes from a serial device into the buffer
+ specified by Buffer. The number of bytes actually read is returned.
+ If the return value is less than NumberOfBytes, then the rest operation failed.
+ If NumberOfBytes is zero, then return 0.
+
+ @param Buffer The pointer to the data buffer to store the data read from the serial device.
+ @param NumberOfBytes The number of bytes which will be read.
+
+ @retval 0 Read data failed; No data is to be read.
+ @retval >0 The actual number of bytes read from serial device.
+
+**/
+UINTN
+EFIAPI
+SerialPortRead (
+ OUT UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ )
+{
+ UINTN Index;
+
+ Index = 0;
+ while ((Index < NumberOfBytes) && SerialPortPoll ()) {
+ Buffer[Index++] = (UINT8)mLastGetChar;
+ mLastGetChar = -1;
+ }
+
+ return Index;
+}
+
+/**
+ Polls a serial device to see if there is any data waiting to be read.
+
+ Polls a serial device to see if there is any data waiting to be read.
+ If there is data waiting to be read from the serial device, then TRUE is returned.
+ If there is no data waiting to be read from the serial device, then FALSE is returned.
+
+ @retval TRUE Data is waiting to be read from the serial device.
+ @retval FALSE There is no data waiting to be read from the serial device.
+
+**/
+BOOLEAN
+EFIAPI
+SerialPortPoll (
+ VOID
+ )
+{
+ /*
+ * Careful. OpenSBI with HTIF console will return -1 followed by -2
+ * if there is no character received. So just check for values >= 0.
+ */
+
+ if (mLastGetChar >= 0) {
+ return TRUE;
+ }
+
+ if (mHaveDbcn) {
+ UINT8 Buffer;
+ SBI_RET Ret;
+
+ Ret = SbiCall (
+ SBI_EXT_DBCN,
+ SBI_EXT_DBCN_READ,
+ 3,
+ 1,
+ ((UINTN)&Buffer),
+ 0
+ );
+ if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
+ (Ret.Value == 1))
+ {
+ mLastGetChar = Buffer;
+ }
+ } else if (mHaveLegacyGetchar) {
+ mLastGetChar = (INT64)SbiCall (SBI_EXT_0_1_CONSOLE_GETCHAR, 0, 0).Error;
+ }
+
+ return mLastGetChar >= 0;
+}
+
+/**
+ Sets the control bits on a serial device.
+
+ @param Control Sets the bits of Control that are settable.
+
+ @retval RETURN_SUCCESS The new control bits were set on the serial device.
+ @retval RETURN_UNSUPPORTED The serial device does not support this operation.
+ @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortSetControl (
+ IN UINT32 Control
+ )
+{
+ return RETURN_SUCCESS;
+}
+
+/**
+ Retrieve the status of the control bits on a serial device.
+
+ @param Control A pointer to return the current control signals from the serial device.
+
+ @retval RETURN_SUCCESS The control bits were read from the serial device.
+ @retval RETURN_UNSUPPORTED The serial device does not support this operation.
+ @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortGetControl (
+ OUT UINT32 *Control
+ )
+{
+ *Control = 0;
+ return RETURN_SUCCESS;
+}
+
+/**
+ Sets the baud rate, receive FIFO depth, transmit/receice time out, parity,
+ data bits, and stop bits on a serial device.
+
+ @param BaudRate The requested baud rate. A BaudRate value of 0 will use the
+ device's default interface speed.
+ On output, the value actually set.
+ @param ReveiveFifoDepth The requested depth of the FIFO on the receive side of the
+ serial interface. A ReceiveFifoDepth value of 0 will use
+ the device's default FIFO depth.
+ On output, the value actually set.
+ @param Timeout The requested time out for a single character in microseconds.
+ This timeout applies to both the transmit and receive side of the
+ interface. A Timeout value of 0 will use the device's default time
+ out value.
+ On output, the value actually set.
+ @param Parity The type of parity to use on this serial device. A Parity value of
+ DefaultParity will use the device's default parity value.
+ On output, the value actually set.
+ @param DataBits The number of data bits to use on the serial device. A DataBits
+ vaule of 0 will use the device's default data bit setting.
+ On output, the value actually set.
+ @param StopBits The number of stop bits to use on this serial device. A StopBits
+ value of DefaultStopBits will use the device's default number of
+ stop bits.
+ On output, the value actually set.
+
+ @retval RETURN_SUCCESS The new attributes were set on the serial device.
+ @retval RETURN_UNSUPPORTED The serial device does not support this operation.
+ @retval RETURN_INVALID_PARAMETER One or more of the attributes has an unsupported value.
+ @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
+
+**/
+RETURN_STATUS
+EFIAPI
+SerialPortSetAttributes (
+ IN OUT UINT64 *BaudRate,
+ IN OUT UINT32 *ReceiveFifoDepth,
+ IN OUT UINT32 *Timeout,
+ IN OUT EFI_PARITY_TYPE *Parity,
+ IN OUT UINT8 *DataBits,
+ IN OUT EFI_STOP_BITS_TYPE *StopBits
+ )
+{
+ return RETURN_SUCCESS;
+}
diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
new file mode 100644
index 000000000000..4926ac675b62
--- /dev/null
+++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
@@ -0,0 +1,132 @@
+/** @file
+ Serial Port Library backed by SBI console.
+
+ Common functionality shared by PrePiDxeSerialPortLibRiscVSbi and
+ PrePiDxeSerialPortLibRiscVSbiRam implementations.
+
+ Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include "Common.h"
+
+/**
+ Return whether the DBCN extension is implemented.
+
+ @retval TRUE Extension is implemented.
+ @retval FALSE Extension is not implemented.
+
+**/
+BOOLEAN
+SbiImplementsDbcn (
+ VOID
+ )
+{
+ SBI_RET Ret;
+
+ Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1, SBI_EXT_DBCN);
+ if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
+ (Ret.Value != 0))
+ {
+ return TRUE;
+ }
+
+ return FALSE;
+}
+
+/**
+ Return whether the legacy console putchar extension is implemented.
+
+ @retval TRUE Extension is implemented.
+ @retval FALSE Extension is not implemented.
+
+**/
+BOOLEAN
+SbiImplementsLegacyPutchar (
+ VOID
+ )
+{
+ SBI_RET Ret;
+
+ Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1, SBI_EXT_0_1_CONSOLE_PUTCHAR);
+ if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
+ (Ret.Value != 0))
+ {
+ return TRUE;
+ }
+
+ return FALSE;
+}
+
+/**
+ Write data from buffer to console via SBI legacy putchar extension.
+
+ The number of bytes actually written to the SBI console is returned.
+ If the return value is less than NumberOfBytes, then the write operation failed.
+
+ @param Buffer The pointer to the data buffer to be written.
+ @param NumberOfBytes The number of bytes to written to the serial device.
+
+ @retval >=0 The number of bytes written to the serial device.
+ If this value is less than NumberOfBytes, then the
+ write operation failed.
+
+**/
+UINTN
+SbiLegacyPutchar (
+ IN UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ )
+{
+ SBI_RET Ret;
+ UINTN Index;
+
+ for (Index = 0; Index < NumberOfBytes; Index++) {
+ Ret = SbiCall (SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, 1, Buffer[Index]);
+ if ((INT64)Ret.Error < 0) {
+ break;
+ }
+ }
+
+ return Index;
+}
+
+/**
+ Write data from buffer to console via SBI DBCN.
+
+ The number of bytes actually written to the SBI console is returned.
+ If the return value is less than NumberOfBytes, then the write operation failed.
+
+ @param Buffer The pointer to the data buffer to be written.
+ @param NumberOfBytes The number of bytes to written to the serial device.
+
+ @retval >=0 The number of bytes written to the serial device.
+ If this value is less than NumberOfBytes, then the
+ write operation failed.
+
+**/
+UINTN
+SbiDbcnWrite (
+ IN UINT8 *Buffer,
+ IN UINTN NumberOfBytes
+ )
+{
+ SBI_RET Ret;
+
+ Ret = SbiCall (
+ SBI_EXT_DBCN,
+ SBI_EXT_DBCN_WRITE,
+ 3,
+ NumberOfBytes,
+ ((UINTN)Buffer),
+ 0
+ );
+
+ /*
+ * May do partial writes. Don't bother decoding
+ * Ret.Error as we're only interested in number of
+ * bytes written to console.
+ */
+ return Ret.Value;
+}
diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni
new file mode 100644
index 000000000000..7b22caa5a090
--- /dev/null
+++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni
@@ -0,0 +1,16 @@
+// /** @file
+// Serial Port Library backed by SBI console.
+//
+// Serial Port Library backed by SBI console.
+//
+// Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+//
+// SPDX-License-Identifier: BSD-2-Clause-Patent
+//
+// **/
+
+
+#string STR_MODULE_ABSTRACT #language en-US "Serial Port Library backed by SBI console"
+
+#string STR_MODULE_DESCRIPTION #language en-US "Serial Port Library backed by SBI console."
+
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
2023-04-07 21:44 [PATCH v7 0/3] RISC-V SBI-backed SerialLib Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V Andrei Warkentin
@ 2023-04-07 21:44 ` Andrei Warkentin
2023-04-08 2:22 ` [edk2-devel] " Yao, Jiewen
2023-04-07 22:08 ` [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib Michael D Kinney
3 siblings, 1 reply; 17+ messages in thread
From: Andrei Warkentin @ 2023-04-07 21:44 UTC (permalink / raw)
To: devel; +Cc: Andrei Warkentin, Daniel Schaefer, Sunil V L
If the SerialPortLib had any initialization needed, this
would be skipped in the RiscVVirt Sec. Follow the example
seen elsewhere (ArmVirtPkg PrePi).
Seen with BaseSerialPortLibRiscVSbiLibRam not using DBCN in Sec,
yet using DBCN elsewhere.
Cc: Daniel Schaefer <git@danielschaefer.me>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
---
OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +++-
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.inf b/OvmfPkg/RiscVVirt/Sec/SecMain.inf
index aed35d3af596..0e2a5785e8a4 100644
--- a/OvmfPkg/RiscVVirt/Sec/SecMain.inf
+++ b/OvmfPkg/RiscVVirt/Sec/SecMain.inf
@@ -48,6 +48,7 @@ [LibraryClasses]
FdtLib
MemoryAllocationLib
HobLib
+ SerialPortLib
[Ppis]
gEfiTemporaryRamSupportPpiGuid # PPI ALWAYS_PRODUCED
diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.h b/OvmfPkg/RiscVVirt/Sec/SecMain.h
index 83a8058efe40..7c7650f0d298 100644
--- a/OvmfPkg/RiscVVirt/Sec/SecMain.h
+++ b/OvmfPkg/RiscVVirt/Sec/SecMain.h
@@ -29,6 +29,7 @@
#include <Library/PrePiLib.h>
#include <Library/PlatformInitLib.h>
#include <Library/PrePiHobListPointerLib.h>
+#include <Library/SerialPortLib.h>
#include <Register/RiscV64/RiscVImpl.h>
/**
diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.c b/OvmfPkg/RiscVVirt/Sec/SecMain.c
index adf73f2eb66c..b35c77774510 100644
--- a/OvmfPkg/RiscVVirt/Sec/SecMain.c
+++ b/OvmfPkg/RiscVVirt/Sec/SecMain.c
@@ -1,7 +1,7 @@
/** @file
RISC-V SEC phase module for Qemu Virt.
- Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2008 - 2023, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2022, Ventana Micro Systems Inc. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -57,6 +57,8 @@ SecStartup (
UINT64 StackBase;
UINT32 StackSize;
+ SerialPortInitialize ();
+
//
// Report Status Code to indicate entering SEC core
//
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-04-07 21:44 [PATCH v7 0/3] RISC-V SBI-backed SerialLib Andrei Warkentin
` (2 preceding siblings ...)
2023-04-07 21:44 ` [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Andrei Warkentin
@ 2023-04-07 22:08 ` Michael D Kinney
2023-04-25 19:26 ` Andrei Warkentin
[not found] ` <1759444C5DA596CB.10313@groups.io>
3 siblings, 2 replies; 17+ messages in thread
From: Michael D Kinney @ 2023-04-07 22:08 UTC (permalink / raw)
To: devel@edk2.groups.io, Warkentin, Andrei; +Cc: Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei Warkentin
> Sent: Friday, April 7, 2023 2:44 PM
> To: devel@edk2.groups.io
> Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Hello,
>
> Here are three patches that provide a SerialLib backed by SBI console.
> Both legacy and DBCN mechanisms are supported in various execution environments and have been tested with UART and HTIF
> consoles.
>
> MdePkg reviewers: please review MdePkg.dsc changes.
>
> This is also available at
> https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
>
> A CI run is at https://github.com/tianocore/edk2/pull/4252
>
> Compared to v6:
>
> - Unify the two SerialLib implementations under one directory and
> factor out the code somewhat.
> - Sunil's feedback on correctness.
>
> Compared to v5:
>
> Rename components as per Michael Kinney's suggestions.
>
> Compared to v4:
>
> (not sent out). CC MdePkg maintainers, fix copyright date in SecMain.c.
>
> Compared to v3
>
> EccCheck fixes. Add MdePkg infs to DSC.
>
> Compared to v2:
> - Probes legacy extension as well.
> - Encode supported module types in the INF file. This is done using LIBRARY_CLASS,
> as MODULE_TYPE cannot encode multiple types, so MODULE_TYPE is retained as BASE.
> - Update INF version and generate brand new GUIDs instead of editing them.
> - Checked that all patches retain ^M endings.
>
> Andrei Warkentin (3):
> MdePkg: BaseRiscVSbiLib: make more useful to consumers
> MdePkg: add SBI-based SerialPortLib for RISC-V
> OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
>
> MdePkg/MdePkg.dsc | 2 +
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf | 40 +++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf | 37 +++
> OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
> MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++-
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h | 41 +++
> OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
> MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c | 3 +-
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c | 208 ++++++++++++++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c | 289 ++++++++++++++++++++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c | 132 +++++++++
> OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +-
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni | 16 ++
> 13 files changed, 808 insertions(+), 6 deletions(-)
> create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
> create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
> create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
> create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c
> create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni
>
> --
> 2.25.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
2023-04-07 21:44 ` [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Andrei Warkentin
@ 2023-04-08 2:22 ` Yao, Jiewen
0 siblings, 0 replies; 17+ messages in thread
From: Yao, Jiewen @ 2023-04-08 2:22 UTC (permalink / raw)
To: devel@edk2.groups.io, Warkentin, Andrei; +Cc: Daniel Schaefer, Sunil V L
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei
> Warkentin
> Sent: Saturday, April 8, 2023 5:44 AM
> To: devel@edk2.groups.io
> Cc: Warkentin, Andrei <andrei.warkentin@intel.com>; Daniel Schaefer
> <git@danielschaefer.me>; Sunil V L <sunilvl@ventanamicro.com>
> Subject: [edk2-devel] [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing
> SerialPortInitialize to Sec
>
> If the SerialPortLib had any initialization needed, this
> would be skipped in the RiscVVirt Sec. Follow the example
> seen elsewhere (ArmVirtPkg PrePi).
>
> Seen with BaseSerialPortLibRiscVSbiLibRam not using DBCN in Sec,
> yet using DBCN elsewhere.
>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
> ---
> OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
> OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
> OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +++-
> 3 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.inf
> b/OvmfPkg/RiscVVirt/Sec/SecMain.inf
> index aed35d3af596..0e2a5785e8a4 100644
> --- a/OvmfPkg/RiscVVirt/Sec/SecMain.inf
> +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.inf
> @@ -48,6 +48,7 @@ [LibraryClasses]
> FdtLib
> MemoryAllocationLib
> HobLib
> + SerialPortLib
>
> [Ppis]
> gEfiTemporaryRamSupportPpiGuid # PPI ALWAYS_PRODUCED
> diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.h
> b/OvmfPkg/RiscVVirt/Sec/SecMain.h
> index 83a8058efe40..7c7650f0d298 100644
> --- a/OvmfPkg/RiscVVirt/Sec/SecMain.h
> +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.h
> @@ -29,6 +29,7 @@
> #include <Library/PrePiLib.h>
> #include <Library/PlatformInitLib.h>
> #include <Library/PrePiHobListPointerLib.h>
> +#include <Library/SerialPortLib.h>
> #include <Register/RiscV64/RiscVImpl.h>
>
> /**
> diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.c
> b/OvmfPkg/RiscVVirt/Sec/SecMain.c
> index adf73f2eb66c..b35c77774510 100644
> --- a/OvmfPkg/RiscVVirt/Sec/SecMain.c
> +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.c
> @@ -1,7 +1,7 @@
> /** @file
> RISC-V SEC phase module for Qemu Virt.
>
> - Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2008 - 2023, Intel Corporation. All rights reserved.<BR>
> Copyright (c) 2022, Ventana Micro Systems Inc. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -57,6 +57,8 @@ SecStartup (
> UINT64 StackBase;
> UINT32 StackSize;
>
> + SerialPortInitialize ();
> +
> //
> // Report Status Code to indicate entering SEC core
> //
> --
> 2.25.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V
2023-04-07 21:44 ` [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V Andrei Warkentin
@ 2023-04-12 7:15 ` Sunil V L
2023-04-18 23:31 ` [edk2-devel] " Andrei Warkentin
0 siblings, 1 reply; 17+ messages in thread
From: Sunil V L @ 2023-04-12 7:15 UTC (permalink / raw)
To: Andrei Warkentin
Cc: devel, Daniel Schaefer, Michael D Kinney, Liming Gao,
Zhiguang Liu, Gerd Hoffmann
Thanks, Andrei. Just one nit comment below.
Otherwise, LGTM.
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
On Fri, Apr 07, 2023 at 04:44:24PM -0500, Andrei Warkentin wrote:
> These are implementations of SerialPortLib using SBI console services.
> - BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP) environments
> - BaseSerialPortLibRiscVSbiLibRam is appropriate for PrePI/DXE environments
>
> Tested with:
> - Qemu RiscVVirt (non-DBCN case, backed by UART)
> - TinyEMU + RiscVVirt (non-DBCN case, HTIF)
> - TinyEMU + RiscVVirt (DBCN case, HTIF)
>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
> ---
> MdePkg/MdePkg.dsc | 2 +
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf | 41 +++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf | 38 +++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h | 41 +++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c | 208 ++++++++++++++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c | 289 ++++++++++++++++++++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c | 132 +++++++++
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni | 16 ++
> 8 files changed, 767 insertions(+)
>
> diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
> index 0ac7618b4623..a810ad0d147d 100644
> --- a/MdePkg/MdePkg.dsc
> +++ b/MdePkg/MdePkg.dsc
> @@ -192,5 +192,7 @@ [Components.ARM, Components.AARCH64]
>
> [Components.RISCV64]
> MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.inf
> + MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
> + MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
>
> [BuildOptions]
> diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
> new file mode 100644
> index 000000000000..2340ac6bfe67
> --- /dev/null
> +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
> @@ -0,0 +1,41 @@
> +## @file
> +# Serial Port Library backed by SBI console.
> +#
> +# Meant for SEC and PEI (XIP) environments.
> +#
> +# Due to limitations of SBI console interface and XIP environments
> +# (on use of globals), this library instance does not implement reading
> +# and polling the serial port. See PrePiDxeSerialPortLibRiscVSbiRam.inf
> +# for the full-featured variant meant for PrePi and DXE environments.
> +#
> +# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +#
> +##
> +
> +[Defines]
> + INF_VERSION = 0x0001001B
> + BASE_NAME = BaseSerialPortLibRiscVSbiLib
> + MODULE_UNI_FILE = BaseSerialPortLibRiscVSbiLib.uni
> + FILE_GUID = 639fad38-4bfd-4eb9-9f09-e97c7947d480
> + MODULE_TYPE = BASE
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = SerialPortLib | SEC PEI_CORE PEIM
> +
> +
> +#
> +# VALID_ARCHITECTURES = RISCV64
> +#
> +
> +[Sources]
> + BaseSerialPortLibRiscVSbiLib.c
> + Common.c
> + Common.h
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> + RiscVSbiLib
> diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
> new file mode 100644
> index 000000000000..d09573ca5b36
> --- /dev/null
> +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
> @@ -0,0 +1,38 @@
> +## @file
> +# Serial Port Library backed by SBI console.
> +#
> +# Meant for PrePi and DXE environments (where globals are allowed). See
> +# BaseSerialPortLibRiscVSbiLib.inf for a reduced variant appropriate
> +# for SEC and PEI (XIP) environments.
> +#
> +# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +#
> +##
> +
> +[Defines]
> + INF_VERSION = 0x0001001B
> + BASE_NAME = BaseSerialPortLibRiscVSbiLibRam
> + MODULE_UNI_FILE = BaseSerialPortLibRiscVSbiLib.uni
> + FILE_GUID = 872af743-ab56-45b4-a065-602567f4820c
> + MODULE_TYPE = BASE
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = SerialPortLib | SEC DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_DRIVER UEFI_APPLICATION
> +
> +
> +#
> +# VALID_ARCHITECTURES = RISCV64
> +#
> +
> +[Sources]
> + BaseSerialPortLibRiscVSbiLibRam.c
> + Common.c
> + Common.h
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> + RiscVSbiLib
> diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> new file mode 100644
> index 000000000000..98c1a5d3865e
> --- /dev/null
> +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> @@ -0,0 +1,41 @@
> +/** @file
> + Serial Port Library backed by SBI console.
> +
> + Common functionality shared by PrePiDxeSerialPortLibRiscVSbi and
> + PrePiDxeSerialPortLibRiscVSbiRam implementations.
> +
> + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef SERIAL_PORT_SBI_COMMON_H_
> +#define SERIAL_PORT_SBI_COMMON_H_
> +
> +#include <Base.h>
> +#include <Library/SerialPortLib.h>
> +#include <Library/BaseRiscVSbiLib.h>
> +
> +BOOLEAN
> +SbiImplementsDbcn (
> + VOID
> + );
> +
> +BOOLEAN
> +SbiImplementsLegacyPutchar (
> + VOID
> + );
> +
> +UINTN
> +SbiLegacyPutchar (
> + IN UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + );
> +
> +UINTN
> +SbiDbcnWrite (
> + IN UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + );
> +
> +#endif /* SERIAL_PORT_SBI_COMMON_H_ */
> diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
> new file mode 100644
> index 000000000000..f4f2959cf8cc
> --- /dev/null
> +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
> @@ -0,0 +1,208 @@
> +/** @file
> + Serial Port Library backed by SBI console.
> +
> + Meant for SEC and PEI (XIP) environments.
> +
> + Due to limitations of SBI console interface and XIP environments
> + (on use of globals), this library instance does not implement reading
> + and polling the serial port. See BaseSerialPortLibRiscVSbiLibRam.c for
> + the full-featured variant meant for PrePi and DXE environments.
> +
> + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include "Common.h"
> +
> +/**
> + Initialize the serial device hardware.
> +
> + If no initialization is required, then return RETURN_SUCCESS.
> + If the serial device was successfully initialized, then return RETURN_SUCCESS.
> + If the serial device could not be initialized, then return RETURN_DEVICE_ERROR.
> +
> + @retval RETURN_SUCCESS The serial device was initialized.
> + @retval RETURN_DEVICE_ERROR The serial device could not be initialized.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortInitialize (
> + VOID
> + )
> +{
> + return RETURN_SUCCESS;
> +}
> +
> +/**
> + Write data from buffer to serial device.
> +
> + Writes NumberOfBytes data bytes from Buffer to the serial device.
> + The number of bytes actually written to the serial device is returned.
> + If the return value is less than NumberOfBytes, then the write operation failed.
> + If NumberOfBytes is zero, then return 0.
> +
> + @param Buffer The pointer to the data buffer to be written.
> + @param NumberOfBytes The number of bytes to written to the serial device.
> +
> + @retval 0 NumberOfBytes is 0.
> + @retval >0 The number of bytes written to the serial device.
> + If this value is less than NumberOfBytes, then the write operation failed.
> +
> +**/
> +UINTN
> +EFIAPI
> +SerialPortWrite (
> + IN UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + )
> +{
> + if (NumberOfBytes == 0) {
> + return 0;
> + }
> +
> + if (SbiImplementsDbcn ()) {
> + return SbiDbcnWrite (Buffer, NumberOfBytes);
> + }
> +
> + if (SbiImplementsLegacyPutchar ()) {
> + return SbiLegacyPutchar (Buffer, NumberOfBytes);
> + }
> +
> + /*
> + * Neither DBCN or legacy extension were present.
> + */
> + return 0;
> +}
> +
> +/**
> + Read data from serial device and save the datas in buffer.
> +
> + Reads NumberOfBytes data bytes from a serial device into the buffer
> + specified by Buffer. The number of bytes actually read is returned.
> + If the return value is less than NumberOfBytes, then the rest operation failed.
> + If NumberOfBytes is zero, then return 0.
> +
> + @param Buffer The pointer to the data buffer to store the data read from the serial device.
> + @param NumberOfBytes The number of bytes which will be read.
> +
> + @retval 0 Read data failed; No data is to be read.
> + @retval >0 The actual number of bytes read from serial device.
> +
> +**/
> +UINTN
> +EFIAPI
> +SerialPortRead (
> + OUT UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + )
> +{
> + return 0;
> +}
> +
> +/**
> + Polls a serial device to see if there is any data waiting to be read.
> +
> + Polls a serial device to see if there is any data waiting to be read.
> + If there is data waiting to be read from the serial device, then TRUE is returned.
> + If there is no data waiting to be read from the serial device, then FALSE is returned.
> +
> + @retval TRUE Data is waiting to be read from the serial device.
> + @retval FALSE There is no data waiting to be read from the serial device.
> +
> +**/
> +BOOLEAN
> +EFIAPI
> +SerialPortPoll (
> + VOID
> + )
> +{
> + return FALSE;
> +}
> +
> +/**
> + Sets the control bits on a serial device.
> +
> + @param Control Sets the bits of Control that are settable.
> +
> + @retval RETURN_SUCCESS The new control bits were set on the serial device.
> + @retval RETURN_UNSUPPORTED The serial device does not support this operation.
> + @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortSetControl (
> + IN UINT32 Control
> + )
> +{
> + return RETURN_SUCCESS;
> +}
> +
> +/**
> + Retrieve the status of the control bits on a serial device.
> +
> + @param Control A pointer to return the current control signals from the serial device.
> +
> + @retval RETURN_SUCCESS The control bits were read from the serial device.
> + @retval RETURN_UNSUPPORTED The serial device does not support this operation.
> + @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortGetControl (
> + OUT UINT32 *Control
> + )
> +{
> + *Control = 0;
> + return RETURN_SUCCESS;
> +}
> +
> +/**
> + Sets the baud rate, receive FIFO depth, transmit/receice time out, parity,
> + data bits, and stop bits on a serial device.
> +
> + @param BaudRate The requested baud rate. A BaudRate value of 0 will use the
> + device's default interface speed.
> + On output, the value actually set.
> + @param ReveiveFifoDepth The requested depth of the FIFO on the receive side of the
> + serial interface. A ReceiveFifoDepth value of 0 will use
> + the device's default FIFO depth.
> + On output, the value actually set.
> + @param Timeout The requested time out for a single character in microseconds.
> + This timeout applies to both the transmit and receive side of the
> + interface. A Timeout value of 0 will use the device's default time
> + out value.
> + On output, the value actually set.
> + @param Parity The type of parity to use on this serial device. A Parity value of
> + DefaultParity will use the device's default parity value.
> + On output, the value actually set.
> + @param DataBits The number of data bits to use on the serial device. A DataBits
> + vaule of 0 will use the device's default data bit setting.
> + On output, the value actually set.
> + @param StopBits The number of stop bits to use on this serial device. A StopBits
> + value of DefaultStopBits will use the device's default number of
> + stop bits.
> + On output, the value actually set.
> +
> + @retval RETURN_SUCCESS The new attributes were set on the serial device.
> + @retval RETURN_UNSUPPORTED The serial device does not support this operation.
> + @retval RETURN_INVALID_PARAMETER One or more of the attributes has an unsupported value.
> + @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortSetAttributes (
> + IN OUT UINT64 *BaudRate,
> + IN OUT UINT32 *ReceiveFifoDepth,
> + IN OUT UINT32 *Timeout,
> + IN OUT EFI_PARITY_TYPE *Parity,
> + IN OUT UINT8 *DataBits,
> + IN OUT EFI_STOP_BITS_TYPE *StopBits
> + )
> +{
> + return RETURN_SUCCESS;
> +}
> diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c
> new file mode 100644
> index 000000000000..fafba87b7cd1
> --- /dev/null
> +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c
> @@ -0,0 +1,289 @@
> +/** @file
> + Serial Port Library backed by SBI console.
> +
> + Meant for PrePi and DXE environments (where globals are allowed). See
> + BaseSerialPortLibRiscVSbiLib.c for a reduced variant appropriate for
> + SEC and PEI (XIP) environments.
> +
> + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Base.h>
> +#include <Library/SerialPortLib.h>
> +#include <Library/BaseRiscVSbiLib.h>
> +#include "Common.h"
> +
> +STATIC BOOLEAN mHaveDbcn = FALSE;
> +STATIC BOOLEAN mHaveLegacyPutchar = FALSE;
> +STATIC BOOLEAN mHaveLegacyGetchar = FALSE;
> +STATIC INT64 mLastGetChar = -1;
> +
> +/**
> + Return whether the legacy console getchar extension is implemented.
> +
> + @retval TRUE Extension is implemented.
> + @retval FALSE Extension is not implemented.
> +
> +**/
> +STATIC
> +BOOLEAN
> +SbiImplementsLegacyGetchar (
> + VOID
> + )
> +{
> + SBI_RET Ret;
> +
> + Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1, SBI_EXT_0_1_CONSOLE_GETCHAR);
> + if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
> + (Ret.Value != 0))
> + {
> + return TRUE;
> + }
> +
> + return FALSE;
> +}
> +
> +/**
> + Initialize the serial device hardware.
> +
> + If no initialization is required, then return RETURN_SUCCESS.
> + If the serial device was successfully initialized, then return RETURN_SUCCESS.
> + If the serial device could not be initialized, then return RETURN_DEVICE_ERROR.
> +
> + @retval RETURN_SUCCESS The serial device was initialized.
> + @retval RETURN_DEVICE_ERROR The serial device could not be initialized.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortInitialize (
> + VOID
> + )
> +{
> + if (SbiImplementsDbcn ()) {
> + mHaveDbcn = TRUE;
> + return RETURN_SUCCESS;
> + }
> +
> + if (SbiImplementsLegacyPutchar ()) {
> + mHaveLegacyPutchar = TRUE;
> + }
> +
> + if (SbiImplementsLegacyGetchar ()) {
> + mHaveLegacyGetchar = TRUE;
> + }
> +
> + return (mHaveLegacyGetchar && mHaveLegacyPutchar) ?
> + RETURN_SUCCESS :
> + RETURN_DEVICE_ERROR;
> +}
> +
> +/**
> + Write data from buffer to serial device.
> +
> + Writes NumberOfBytes data bytes from Buffer to the serial device.
> + The number of bytes actually written to the serial device is returned.
> + If the return value is less than NumberOfBytes, then the write operation failed.
> + If NumberOfBytes is zero, then return 0.
> +
> + @param Buffer The pointer to the data buffer to be written.
> + @param NumberOfBytes The number of bytes to written to the serial device.
> +
> + @retval 0 NumberOfBytes is 0.
> + @retval >0 The number of bytes written to the serial device.
> + If this value is less than NumberOfBytes, then the write operation failed.
> +
> +**/
> +UINTN
> +EFIAPI
> +SerialPortWrite (
> + IN UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + )
> +{
> + if (NumberOfBytes == 0) {
> + return 0;
> + }
> +
> + if (mHaveDbcn) {
> + return SbiDbcnWrite (Buffer, NumberOfBytes);
> + } else if (mHaveLegacyPutchar) {
> + return SbiLegacyPutchar (Buffer, NumberOfBytes);
> + }
> +
> + /*
> + * Neither DBCN or legacy extension were present.
> + */
> + return 0;
> +}
> +
> +/**
> + Read data from serial device and save the datas in buffer.
> +
> + Reads NumberOfBytes data bytes from a serial device into the buffer
> + specified by Buffer. The number of bytes actually read is returned.
> + If the return value is less than NumberOfBytes, then the rest operation failed.
> + If NumberOfBytes is zero, then return 0.
> +
> + @param Buffer The pointer to the data buffer to store the data read from the serial device.
> + @param NumberOfBytes The number of bytes which will be read.
> +
> + @retval 0 Read data failed; No data is to be read.
> + @retval >0 The actual number of bytes read from serial device.
> +
> +**/
> +UINTN
> +EFIAPI
> +SerialPortRead (
> + OUT UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + )
> +{
> + UINTN Index;
> +
> + Index = 0;
> + while ((Index < NumberOfBytes) && SerialPortPoll ()) {
> + Buffer[Index++] = (UINT8)mLastGetChar;
> + mLastGetChar = -1;
> + }
> +
> + return Index;
> +}
> +
> +/**
> + Polls a serial device to see if there is any data waiting to be read.
> +
> + Polls a serial device to see if there is any data waiting to be read.
> + If there is data waiting to be read from the serial device, then TRUE is returned.
> + If there is no data waiting to be read from the serial device, then FALSE is returned.
> +
> + @retval TRUE Data is waiting to be read from the serial device.
> + @retval FALSE There is no data waiting to be read from the serial device.
> +
> +**/
> +BOOLEAN
> +EFIAPI
> +SerialPortPoll (
> + VOID
> + )
> +{
> + /*
> + * Careful. OpenSBI with HTIF console will return -1 followed by -2
> + * if there is no character received. So just check for values >= 0.
> + */
> +
> + if (mLastGetChar >= 0) {
> + return TRUE;
> + }
> +
> + if (mHaveDbcn) {
> + UINT8 Buffer;
> + SBI_RET Ret;
> +
> + Ret = SbiCall (
> + SBI_EXT_DBCN,
> + SBI_EXT_DBCN_READ,
> + 3,
> + 1,
> + ((UINTN)&Buffer),
> + 0
> + );
> + if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
> + (Ret.Value == 1))
> + {
> + mLastGetChar = Buffer;
> + }
> + } else if (mHaveLegacyGetchar) {
> + mLastGetChar = (INT64)SbiCall (SBI_EXT_0_1_CONSOLE_GETCHAR, 0, 0).Error;
> + }
> +
> + return mLastGetChar >= 0;
> +}
> +
> +/**
> + Sets the control bits on a serial device.
> +
> + @param Control Sets the bits of Control that are settable.
> +
> + @retval RETURN_SUCCESS The new control bits were set on the serial device.
> + @retval RETURN_UNSUPPORTED The serial device does not support this operation.
> + @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortSetControl (
> + IN UINT32 Control
> + )
> +{
> + return RETURN_SUCCESS;
> +}
> +
> +/**
> + Retrieve the status of the control bits on a serial device.
> +
> + @param Control A pointer to return the current control signals from the serial device.
> +
> + @retval RETURN_SUCCESS The control bits were read from the serial device.
> + @retval RETURN_UNSUPPORTED The serial device does not support this operation.
> + @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortGetControl (
> + OUT UINT32 *Control
> + )
> +{
> + *Control = 0;
> + return RETURN_SUCCESS;
> +}
> +
> +/**
> + Sets the baud rate, receive FIFO depth, transmit/receice time out, parity,
> + data bits, and stop bits on a serial device.
> +
> + @param BaudRate The requested baud rate. A BaudRate value of 0 will use the
> + device's default interface speed.
> + On output, the value actually set.
> + @param ReveiveFifoDepth The requested depth of the FIFO on the receive side of the
> + serial interface. A ReceiveFifoDepth value of 0 will use
> + the device's default FIFO depth.
> + On output, the value actually set.
> + @param Timeout The requested time out for a single character in microseconds.
> + This timeout applies to both the transmit and receive side of the
> + interface. A Timeout value of 0 will use the device's default time
> + out value.
> + On output, the value actually set.
> + @param Parity The type of parity to use on this serial device. A Parity value of
> + DefaultParity will use the device's default parity value.
> + On output, the value actually set.
> + @param DataBits The number of data bits to use on the serial device. A DataBits
> + vaule of 0 will use the device's default data bit setting.
> + On output, the value actually set.
> + @param StopBits The number of stop bits to use on this serial device. A StopBits
> + value of DefaultStopBits will use the device's default number of
> + stop bits.
> + On output, the value actually set.
> +
> + @retval RETURN_SUCCESS The new attributes were set on the serial device.
> + @retval RETURN_UNSUPPORTED The serial device does not support this operation.
> + @retval RETURN_INVALID_PARAMETER One or more of the attributes has an unsupported value.
> + @retval RETURN_DEVICE_ERROR The serial device is not functioning correctly.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortSetAttributes (
> + IN OUT UINT64 *BaudRate,
> + IN OUT UINT32 *ReceiveFifoDepth,
> + IN OUT UINT32 *Timeout,
> + IN OUT EFI_PARITY_TYPE *Parity,
> + IN OUT UINT8 *DataBits,
> + IN OUT EFI_STOP_BITS_TYPE *StopBits
> + )
> +{
> + return RETURN_SUCCESS;
> +}
> diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> new file mode 100644
> index 000000000000..4926ac675b62
> --- /dev/null
> +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> @@ -0,0 +1,132 @@
> +/** @file
> + Serial Port Library backed by SBI console.
> +
> + Common functionality shared by PrePiDxeSerialPortLibRiscVSbi and
> + PrePiDxeSerialPortLibRiscVSbiRam implementations.
> +
> + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include "Common.h"
> +
> +/**
> + Return whether the DBCN extension is implemented.
> +
> + @retval TRUE Extension is implemented.
> + @retval FALSE Extension is not implemented.
> +
> +**/
> +BOOLEAN
> +SbiImplementsDbcn (
> + VOID
> + )
> +{
> + SBI_RET Ret;
> +
> + Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1, SBI_EXT_DBCN);
> + if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
> + (Ret.Value != 0))
> + {
> + return TRUE;
> + }
> +
> + return FALSE;
> +}
> +
> +/**
> + Return whether the legacy console putchar extension is implemented.
> +
> + @retval TRUE Extension is implemented.
> + @retval FALSE Extension is not implemented.
> +
> +**/
> +BOOLEAN
> +SbiImplementsLegacyPutchar (
> + VOID
> + )
> +{
> + SBI_RET Ret;
> +
> + Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1, SBI_EXT_0_1_CONSOLE_PUTCHAR);
> + if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
> + (Ret.Value != 0))
> + {
> + return TRUE;
> + }
> +
> + return FALSE;
> +}
> +
> +/**
> + Write data from buffer to console via SBI legacy putchar extension.
> +
> + The number of bytes actually written to the SBI console is returned.
> + If the return value is less than NumberOfBytes, then the write operation failed.
> +
> + @param Buffer The pointer to the data buffer to be written.
> + @param NumberOfBytes The number of bytes to written to the serial device.
> +
> + @retval >=0 The number of bytes written to the serial device.
> + If this value is less than NumberOfBytes, then the
> + write operation failed.
> +
> +**/
> +UINTN
> +SbiLegacyPutchar (
> + IN UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + )
> +{
> + SBI_RET Ret;
> + UINTN Index;
> +
> + for (Index = 0; Index < NumberOfBytes; Index++) {
> + Ret = SbiCall (SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, 1, Buffer[Index]);
> + if ((INT64)Ret.Error < 0) {
> + break;
> + }
> + }
> +
> + return Index;
> +}
> +
> +/**
> + Write data from buffer to console via SBI DBCN.
> +
> + The number of bytes actually written to the SBI console is returned.
> + If the return value is less than NumberOfBytes, then the write operation failed.
> +
> + @param Buffer The pointer to the data buffer to be written.
> + @param NumberOfBytes The number of bytes to written to the serial device.
> +
> + @retval >=0 The number of bytes written to the serial device.
> + If this value is less than NumberOfBytes, then the
> + write operation failed.
> +
> +**/
> +UINTN
> +SbiDbcnWrite (
> + IN UINT8 *Buffer,
> + IN UINTN NumberOfBytes
> + )
> +{
> + SBI_RET Ret;
> +
> + Ret = SbiCall (
> + SBI_EXT_DBCN,
> + SBI_EXT_DBCN_WRITE,
> + 3,
> + NumberOfBytes,
> + ((UINTN)Buffer),
> + 0
> + );
> +
> + /*
> + * May do partial writes. Don't bother decoding
> + * Ret.Error as we're only interested in number of
> + * bytes written to console.
> + */
> + return Ret.Value;
> +}
> diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni
> new file mode 100644
> index 000000000000..7b22caa5a090
> --- /dev/null
> +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni
> @@ -0,0 +1,16 @@
> +// /** @file
> +// Serial Port Library backed by SBI console.
> +//
> +// Serial Port Library backed by SBI console.
Duplicate sentence.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V
2023-04-12 7:15 ` Sunil V L
@ 2023-04-18 23:31 ` Andrei Warkentin
0 siblings, 0 replies; 17+ messages in thread
From: Andrei Warkentin @ 2023-04-18 23:31 UTC (permalink / raw)
To: devel@edk2.groups.io, sunilvl@ventanamicro.com
Cc: Daniel Schaefer, Kinney, Michael D, Gao, Liming, Liu, Zhiguang,
Gerd Hoffmann
Hi Sunil,
Not saying it's right, but I followed a specific pattern seen elsewhere, e.g. ./MdeModulePkg/Core/PiSmmCore/PiSmmIpl.uni, where the two sentences are either the same or mildly rephrased.
A
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sunil V L
> Sent: Wednesday, April 12, 2023 2:16 AM
> To: Warkentin, Andrei <andrei.warkentin@intel.com>
> Cc: devel@edk2.groups.io; Daniel Schaefer <git@danielschaefer.me>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Gerd
> Hoffmann <kraxel@redhat.com>
> Subject: Re: [edk2-devel] [PATCH v7 2/3] MdePkg: add SBI-based
> SerialPortLib for RISC-V
>
> Thanks, Andrei. Just one nit comment below.
>
> Otherwise, LGTM.
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
>
> On Fri, Apr 07, 2023 at 04:44:24PM -0500, Andrei Warkentin wrote:
> > These are implementations of SerialPortLib using SBI console services.
> > - BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP)
> > environments
> > - BaseSerialPortLibRiscVSbiLibRam is appropriate for PrePI/DXE
> > environments
> >
> > Tested with:
> > - Qemu RiscVVirt (non-DBCN case, backed by UART)
> > - TinyEMU + RiscVVirt (non-DBCN case, HTIF)
> > - TinyEMU + RiscVVirt (DBCN case, HTIF)
> >
> > Cc: Daniel Schaefer <git@danielschaefer.me>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> > Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
> > ---
> > MdePkg/MdePkg.dsc | 2 +
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.in
> f | 41 +++
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRa
> m.inf | 38 +++
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h |
> 41 +++
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
> | 208 ++++++++++++++
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRa
> m.c | 289 ++++++++++++++++++++
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c |
> 132 +++++++++
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.u
> ni | 16 ++
> > 8 files changed, 767 insertions(+)
> >
> > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc index
> > 0ac7618b4623..a810ad0d147d 100644
> > --- a/MdePkg/MdePkg.dsc
> > +++ b/MdePkg/MdePkg.dsc
> > @@ -192,5 +192,7 @@ [Components.ARM, Components.AARCH64]
> >
> > [Components.RISCV64]
> > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.inf
> > +
> > + MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > + iLib.inf
> > + MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > + iLibRam.inf
> >
> > [BuildOptions]
> > diff --git
> > a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLib.inf
> > b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLib.inf
> > new file mode 100644
> > index 000000000000..2340ac6bfe67
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > +++ cVSbiLib.inf
> > @@ -0,0 +1,41 @@
> > +## @file
> > +# Serial Port Library backed by SBI console.
> > +#
> > +# Meant for SEC and PEI (XIP) environments.
> > +#
> > +# Due to limitations of SBI console interface and XIP environments #
> > +(on use of globals), this library instance does not implement reading
> > +# and polling the serial port. See
> > +PrePiDxeSerialPortLibRiscVSbiRam.inf
> > +# for the full-featured variant meant for PrePi and DXE environments.
> > +#
> > +# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR> #
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent # # ##
> > +
> > +[Defines]
> > + INF_VERSION = 0x0001001B
> > + BASE_NAME = BaseSerialPortLibRiscVSbiLib
> > + MODULE_UNI_FILE = BaseSerialPortLibRiscVSbiLib.uni
> > + FILE_GUID = 639fad38-4bfd-4eb9-9f09-e97c7947d480
> > + MODULE_TYPE = BASE
> > + VERSION_STRING = 1.0
> > + LIBRARY_CLASS = SerialPortLib | SEC PEI_CORE PEIM
> > +
> > +
> > +#
> > +# VALID_ARCHITECTURES = RISCV64
> > +#
> > +
> > +[Sources]
> > + BaseSerialPortLibRiscVSbiLib.c
> > + Common.c
> > + Common.h
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > +
> > +[LibraryClasses]
> > + RiscVSbiLib
> > diff --git
> > a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLibRam.inf
> > b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLibRam.inf
> > new file mode 100644
> > index 000000000000..d09573ca5b36
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > +++ cVSbiLibRam.inf
> > @@ -0,0 +1,38 @@
> > +## @file
> > +# Serial Port Library backed by SBI console.
> > +#
> > +# Meant for PrePi and DXE environments (where globals are allowed).
> > +See # BaseSerialPortLibRiscVSbiLib.inf for a reduced variant
> > +appropriate # for SEC and PEI (XIP) environments.
> > +#
> > +# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR> #
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent # # ##
> > +
> > +[Defines]
> > + INF_VERSION = 0x0001001B
> > + BASE_NAME = BaseSerialPortLibRiscVSbiLibRam
> > + MODULE_UNI_FILE = BaseSerialPortLibRiscVSbiLib.uni
> > + FILE_GUID = 872af743-ab56-45b4-a065-602567f4820c
> > + MODULE_TYPE = BASE
> > + VERSION_STRING = 1.0
> > + LIBRARY_CLASS = SerialPortLib | SEC DXE_CORE DXE_DRIVER
> DXE_RUNTIME_DRIVER UEFI_DRIVER UEFI_APPLICATION
> > +
> > +
> > +#
> > +# VALID_ARCHITECTURES = RISCV64
> > +#
> > +
> > +[Sources]
> > + BaseSerialPortLibRiscVSbiLibRam.c
> > + Common.c
> > + Common.h
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > +
> > +[LibraryClasses]
> > + RiscVSbiLib
> > diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > new file mode 100644
> > index 000000000000..98c1a5d3865e
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > @@ -0,0 +1,41 @@
> > +/** @file
> > + Serial Port Library backed by SBI console.
> > +
> > + Common functionality shared by PrePiDxeSerialPortLibRiscVSbi and
> > + PrePiDxeSerialPortLibRiscVSbiRam implementations.
> > +
> > + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> > + SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +**/
> > +
> > +#ifndef SERIAL_PORT_SBI_COMMON_H_
> > +#define SERIAL_PORT_SBI_COMMON_H_
> > +
> > +#include <Base.h>
> > +#include <Library/SerialPortLib.h>
> > +#include <Library/BaseRiscVSbiLib.h>
> > +
> > +BOOLEAN
> > +SbiImplementsDbcn (
> > + VOID
> > + );
> > +
> > +BOOLEAN
> > +SbiImplementsLegacyPutchar (
> > + VOID
> > + );
> > +
> > +UINTN
> > +SbiLegacyPutchar (
> > + IN UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + );
> > +
> > +UINTN
> > +SbiDbcnWrite (
> > + IN UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + );
> > +
> > +#endif /* SERIAL_PORT_SBI_COMMON_H_ */
> > diff --git
> > a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLib.c
> > b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLib.c
> > new file mode 100644
> > index 000000000000..f4f2959cf8cc
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > +++ cVSbiLib.c
> > @@ -0,0 +1,208 @@
> > +/** @file
> > + Serial Port Library backed by SBI console.
> > +
> > + Meant for SEC and PEI (XIP) environments.
> > +
> > + Due to limitations of SBI console interface and XIP environments
> > + (on use of globals), this library instance does not implement
> > + reading and polling the serial port. See
> > + BaseSerialPortLibRiscVSbiLibRam.c for the full-featured variant meant for
> PrePi and DXE environments.
> > +
> > + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> > + SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +**/
> > +
> > +#include "Common.h"
> > +
> > +/**
> > + Initialize the serial device hardware.
> > +
> > + If no initialization is required, then return RETURN_SUCCESS.
> > + If the serial device was successfully initialized, then return
> RETURN_SUCCESS.
> > + If the serial device could not be initialized, then return
> RETURN_DEVICE_ERROR.
> > +
> > + @retval RETURN_SUCCESS The serial device was initialized.
> > + @retval RETURN_DEVICE_ERROR The serial device could not be
> initialized.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortInitialize (
> > + VOID
> > + )
> > +{
> > + return RETURN_SUCCESS;
> > +}
> > +
> > +/**
> > + Write data from buffer to serial device.
> > +
> > + Writes NumberOfBytes data bytes from Buffer to the serial device.
> > + The number of bytes actually written to the serial device is returned.
> > + If the return value is less than NumberOfBytes, then the write operation
> failed.
> > + If NumberOfBytes is zero, then return 0.
> > +
> > + @param Buffer The pointer to the data buffer to be written.
> > + @param NumberOfBytes The number of bytes to written to the serial
> device.
> > +
> > + @retval 0 NumberOfBytes is 0.
> > + @retval >0 The number of bytes written to the serial device.
> > + If this value is less than NumberOfBytes, then the write
> operation failed.
> > +
> > +**/
> > +UINTN
> > +EFIAPI
> > +SerialPortWrite (
> > + IN UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + )
> > +{
> > + if (NumberOfBytes == 0) {
> > + return 0;
> > + }
> > +
> > + if (SbiImplementsDbcn ()) {
> > + return SbiDbcnWrite (Buffer, NumberOfBytes); }
> > +
> > + if (SbiImplementsLegacyPutchar ()) {
> > + return SbiLegacyPutchar (Buffer, NumberOfBytes); }
> > +
> > + /*
> > + * Neither DBCN or legacy extension were present.
> > + */
> > + return 0;
> > +}
> > +
> > +/**
> > + Read data from serial device and save the datas in buffer.
> > +
> > + Reads NumberOfBytes data bytes from a serial device into the buffer
> > + specified by Buffer. The number of bytes actually read is returned.
> > + If the return value is less than NumberOfBytes, then the rest operation
> failed.
> > + If NumberOfBytes is zero, then return 0.
> > +
> > + @param Buffer The pointer to the data buffer to store the data
> read from the serial device.
> > + @param NumberOfBytes The number of bytes which will be read.
> > +
> > + @retval 0 Read data failed; No data is to be read.
> > + @retval >0 The actual number of bytes read from serial device.
> > +
> > +**/
> > +UINTN
> > +EFIAPI
> > +SerialPortRead (
> > + OUT UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + )
> > +{
> > + return 0;
> > +}
> > +
> > +/**
> > + Polls a serial device to see if there is any data waiting to be read.
> > +
> > + Polls a serial device to see if there is any data waiting to be read.
> > + If there is data waiting to be read from the serial device, then TRUE is
> returned.
> > + If there is no data waiting to be read from the serial device, then FALSE is
> returned.
> > +
> > + @retval TRUE Data is waiting to be read from the serial device.
> > + @retval FALSE There is no data waiting to be read from the serial
> device.
> > +
> > +**/
> > +BOOLEAN
> > +EFIAPI
> > +SerialPortPoll (
> > + VOID
> > + )
> > +{
> > + return FALSE;
> > +}
> > +
> > +/**
> > + Sets the control bits on a serial device.
> > +
> > + @param Control Sets the bits of Control that are settable.
> > +
> > + @retval RETURN_SUCCESS The new control bits were set on the
> serial device.
> > + @retval RETURN_UNSUPPORTED The serial device does not support
> this operation.
> > + @retval RETURN_DEVICE_ERROR The serial device is not functioning
> correctly.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortSetControl (
> > + IN UINT32 Control
> > + )
> > +{
> > + return RETURN_SUCCESS;
> > +}
> > +
> > +/**
> > + Retrieve the status of the control bits on a serial device.
> > +
> > + @param Control A pointer to return the current control signals
> from the serial device.
> > +
> > + @retval RETURN_SUCCESS The control bits were read from the serial
> device.
> > + @retval RETURN_UNSUPPORTED The serial device does not support
> this operation.
> > + @retval RETURN_DEVICE_ERROR The serial device is not functioning
> correctly.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortGetControl (
> > + OUT UINT32 *Control
> > + )
> > +{
> > + *Control = 0;
> > + return RETURN_SUCCESS;
> > +}
> > +
> > +/**
> > + Sets the baud rate, receive FIFO depth, transmit/receice time out,
> > +parity,
> > + data bits, and stop bits on a serial device.
> > +
> > + @param BaudRate The requested baud rate. A BaudRate value of 0
> will use the
> > + device's default interface speed.
> > + On output, the value actually set.
> > + @param ReveiveFifoDepth The requested depth of the FIFO on the
> receive side of the
> > + serial interface. A ReceiveFifoDepth value of 0 will use
> > + the device's default FIFO depth.
> > + On output, the value actually set.
> > + @param Timeout The requested time out for a single character in
> microseconds.
> > + This timeout applies to both the transmit and receive side
> of the
> > + interface. A Timeout value of 0 will use the device's
> default time
> > + out value.
> > + On output, the value actually set.
> > + @param Parity The type of parity to use on this serial device. A
> Parity value of
> > + DefaultParity will use the device's default parity value.
> > + On output, the value actually set.
> > + @param DataBits The number of data bits to use on the serial
> device. A DataBits
> > + vaule of 0 will use the device's default data bit setting.
> > + On output, the value actually set.
> > + @param StopBits The number of stop bits to use on this serial
> device. A StopBits
> > + value of DefaultStopBits will use the device's default
> number of
> > + stop bits.
> > + On output, the value actually set.
> > +
> > + @retval RETURN_SUCCESS The new attributes were set on the
> serial device.
> > + @retval RETURN_UNSUPPORTED The serial device does not support
> this operation.
> > + @retval RETURN_INVALID_PARAMETER One or more of the attributes
> has an unsupported value.
> > + @retval RETURN_DEVICE_ERROR The serial device is not functioning
> correctly.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortSetAttributes (
> > + IN OUT UINT64 *BaudRate,
> > + IN OUT UINT32 *ReceiveFifoDepth,
> > + IN OUT UINT32 *Timeout,
> > + IN OUT EFI_PARITY_TYPE *Parity,
> > + IN OUT UINT8 *DataBits,
> > + IN OUT EFI_STOP_BITS_TYPE *StopBits
> > + )
> > +{
> > + return RETURN_SUCCESS;
> > +}
> > diff --git
> > a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLibRam.c
> > b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLibRam.c
> > new file mode 100644
> > index 000000000000..fafba87b7cd1
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > +++ cVSbiLibRam.c
> > @@ -0,0 +1,289 @@
> > +/** @file
> > + Serial Port Library backed by SBI console.
> > +
> > + Meant for PrePi and DXE environments (where globals are allowed).
> > + See BaseSerialPortLibRiscVSbiLib.c for a reduced variant
> > + appropriate for SEC and PEI (XIP) environments.
> > +
> > + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> > + SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +**/
> > +
> > +#include <Base.h>
> > +#include <Library/SerialPortLib.h>
> > +#include <Library/BaseRiscVSbiLib.h>
> > +#include "Common.h"
> > +
> > +STATIC BOOLEAN mHaveDbcn = FALSE;
> > +STATIC BOOLEAN mHaveLegacyPutchar = FALSE; STATIC BOOLEAN
> > +mHaveLegacyGetchar = FALSE;
> > +STATIC INT64 mLastGetChar = -1;
> > +
> > +/**
> > + Return whether the legacy console getchar extension is implemented.
> > +
> > + @retval TRUE Extension is implemented.
> > + @retval FALSE Extension is not implemented.
> > +
> > +**/
> > +STATIC
> > +BOOLEAN
> > +SbiImplementsLegacyGetchar (
> > + VOID
> > + )
> > +{
> > + SBI_RET Ret;
> > +
> > + Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1,
> > + SBI_EXT_0_1_CONSOLE_GETCHAR); if ((TranslateError (Ret.Error) ==
> EFI_SUCCESS) &&
> > + (Ret.Value != 0))
> > + {
> > + return TRUE;
> > + }
> > +
> > + return FALSE;
> > +}
> > +
> > +/**
> > + Initialize the serial device hardware.
> > +
> > + If no initialization is required, then return RETURN_SUCCESS.
> > + If the serial device was successfully initialized, then return
> RETURN_SUCCESS.
> > + If the serial device could not be initialized, then return
> RETURN_DEVICE_ERROR.
> > +
> > + @retval RETURN_SUCCESS The serial device was initialized.
> > + @retval RETURN_DEVICE_ERROR The serial device could not be
> initialized.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortInitialize (
> > + VOID
> > + )
> > +{
> > + if (SbiImplementsDbcn ()) {
> > + mHaveDbcn = TRUE;
> > + return RETURN_SUCCESS;
> > + }
> > +
> > + if (SbiImplementsLegacyPutchar ()) {
> > + mHaveLegacyPutchar = TRUE;
> > + }
> > +
> > + if (SbiImplementsLegacyGetchar ()) {
> > + mHaveLegacyGetchar = TRUE;
> > + }
> > +
> > + return (mHaveLegacyGetchar && mHaveLegacyPutchar) ?
> > + RETURN_SUCCESS :
> > + RETURN_DEVICE_ERROR;
> > +}
> > +
> > +/**
> > + Write data from buffer to serial device.
> > +
> > + Writes NumberOfBytes data bytes from Buffer to the serial device.
> > + The number of bytes actually written to the serial device is returned.
> > + If the return value is less than NumberOfBytes, then the write operation
> failed.
> > + If NumberOfBytes is zero, then return 0.
> > +
> > + @param Buffer The pointer to the data buffer to be written.
> > + @param NumberOfBytes The number of bytes to written to the serial
> device.
> > +
> > + @retval 0 NumberOfBytes is 0.
> > + @retval >0 The number of bytes written to the serial device.
> > + If this value is less than NumberOfBytes, then the write
> operation failed.
> > +
> > +**/
> > +UINTN
> > +EFIAPI
> > +SerialPortWrite (
> > + IN UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + )
> > +{
> > + if (NumberOfBytes == 0) {
> > + return 0;
> > + }
> > +
> > + if (mHaveDbcn) {
> > + return SbiDbcnWrite (Buffer, NumberOfBytes); } else if
> > + (mHaveLegacyPutchar) {
> > + return SbiLegacyPutchar (Buffer, NumberOfBytes); }
> > +
> > + /*
> > + * Neither DBCN or legacy extension were present.
> > + */
> > + return 0;
> > +}
> > +
> > +/**
> > + Read data from serial device and save the datas in buffer.
> > +
> > + Reads NumberOfBytes data bytes from a serial device into the buffer
> > + specified by Buffer. The number of bytes actually read is returned.
> > + If the return value is less than NumberOfBytes, then the rest operation
> failed.
> > + If NumberOfBytes is zero, then return 0.
> > +
> > + @param Buffer The pointer to the data buffer to store the data
> read from the serial device.
> > + @param NumberOfBytes The number of bytes which will be read.
> > +
> > + @retval 0 Read data failed; No data is to be read.
> > + @retval >0 The actual number of bytes read from serial device.
> > +
> > +**/
> > +UINTN
> > +EFIAPI
> > +SerialPortRead (
> > + OUT UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + )
> > +{
> > + UINTN Index;
> > +
> > + Index = 0;
> > + while ((Index < NumberOfBytes) && SerialPortPoll ()) {
> > + Buffer[Index++] = (UINT8)mLastGetChar;
> > + mLastGetChar = -1;
> > + }
> > +
> > + return Index;
> > +}
> > +
> > +/**
> > + Polls a serial device to see if there is any data waiting to be read.
> > +
> > + Polls a serial device to see if there is any data waiting to be read.
> > + If there is data waiting to be read from the serial device, then TRUE is
> returned.
> > + If there is no data waiting to be read from the serial device, then FALSE is
> returned.
> > +
> > + @retval TRUE Data is waiting to be read from the serial device.
> > + @retval FALSE There is no data waiting to be read from the serial
> device.
> > +
> > +**/
> > +BOOLEAN
> > +EFIAPI
> > +SerialPortPoll (
> > + VOID
> > + )
> > +{
> > + /*
> > + * Careful. OpenSBI with HTIF console will return -1 followed by -2
> > + * if there is no character received. So just check for values >= 0.
> > + */
> > +
> > + if (mLastGetChar >= 0) {
> > + return TRUE;
> > + }
> > +
> > + if (mHaveDbcn) {
> > + UINT8 Buffer;
> > + SBI_RET Ret;
> > +
> > + Ret = SbiCall (
> > + SBI_EXT_DBCN,
> > + SBI_EXT_DBCN_READ,
> > + 3,
> > + 1,
> > + ((UINTN)&Buffer),
> > + 0
> > + );
> > + if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
> > + (Ret.Value == 1))
> > + {
> > + mLastGetChar = Buffer;
> > + }
> > + } else if (mHaveLegacyGetchar) {
> > + mLastGetChar = (INT64)SbiCall (SBI_EXT_0_1_CONSOLE_GETCHAR, 0,
> > + 0).Error; }
> > +
> > + return mLastGetChar >= 0;
> > +}
> > +
> > +/**
> > + Sets the control bits on a serial device.
> > +
> > + @param Control Sets the bits of Control that are settable.
> > +
> > + @retval RETURN_SUCCESS The new control bits were set on the
> serial device.
> > + @retval RETURN_UNSUPPORTED The serial device does not support
> this operation.
> > + @retval RETURN_DEVICE_ERROR The serial device is not functioning
> correctly.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortSetControl (
> > + IN UINT32 Control
> > + )
> > +{
> > + return RETURN_SUCCESS;
> > +}
> > +
> > +/**
> > + Retrieve the status of the control bits on a serial device.
> > +
> > + @param Control A pointer to return the current control signals
> from the serial device.
> > +
> > + @retval RETURN_SUCCESS The control bits were read from the serial
> device.
> > + @retval RETURN_UNSUPPORTED The serial device does not support
> this operation.
> > + @retval RETURN_DEVICE_ERROR The serial device is not functioning
> correctly.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortGetControl (
> > + OUT UINT32 *Control
> > + )
> > +{
> > + *Control = 0;
> > + return RETURN_SUCCESS;
> > +}
> > +
> > +/**
> > + Sets the baud rate, receive FIFO depth, transmit/receice time out,
> > +parity,
> > + data bits, and stop bits on a serial device.
> > +
> > + @param BaudRate The requested baud rate. A BaudRate value of 0
> will use the
> > + device's default interface speed.
> > + On output, the value actually set.
> > + @param ReveiveFifoDepth The requested depth of the FIFO on the
> receive side of the
> > + serial interface. A ReceiveFifoDepth value of 0 will use
> > + the device's default FIFO depth.
> > + On output, the value actually set.
> > + @param Timeout The requested time out for a single character in
> microseconds.
> > + This timeout applies to both the transmit and receive side
> of the
> > + interface. A Timeout value of 0 will use the device's
> default time
> > + out value.
> > + On output, the value actually set.
> > + @param Parity The type of parity to use on this serial device. A
> Parity value of
> > + DefaultParity will use the device's default parity value.
> > + On output, the value actually set.
> > + @param DataBits The number of data bits to use on the serial
> device. A DataBits
> > + vaule of 0 will use the device's default data bit setting.
> > + On output, the value actually set.
> > + @param StopBits The number of stop bits to use on this serial
> device. A StopBits
> > + value of DefaultStopBits will use the device's default
> number of
> > + stop bits.
> > + On output, the value actually set.
> > +
> > + @retval RETURN_SUCCESS The new attributes were set on the
> serial device.
> > + @retval RETURN_UNSUPPORTED The serial device does not support
> this operation.
> > + @retval RETURN_INVALID_PARAMETER One or more of the attributes
> has an unsupported value.
> > + @retval RETURN_DEVICE_ERROR The serial device is not functioning
> correctly.
> > +
> > +**/
> > +RETURN_STATUS
> > +EFIAPI
> > +SerialPortSetAttributes (
> > + IN OUT UINT64 *BaudRate,
> > + IN OUT UINT32 *ReceiveFifoDepth,
> > + IN OUT UINT32 *Timeout,
> > + IN OUT EFI_PARITY_TYPE *Parity,
> > + IN OUT UINT8 *DataBits,
> > + IN OUT EFI_STOP_BITS_TYPE *StopBits
> > + )
> > +{
> > + return RETURN_SUCCESS;
> > +}
> > diff --git a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > new file mode 100644
> > index 000000000000..4926ac675b62
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > @@ -0,0 +1,132 @@
> > +/** @file
> > + Serial Port Library backed by SBI console.
> > +
> > + Common functionality shared by PrePiDxeSerialPortLibRiscVSbi and
> > + PrePiDxeSerialPortLibRiscVSbiRam implementations.
> > +
> > + Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> > + SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +**/
> > +
> > +#include "Common.h"
> > +
> > +/**
> > + Return whether the DBCN extension is implemented.
> > +
> > + @retval TRUE Extension is implemented.
> > + @retval FALSE Extension is not implemented.
> > +
> > +**/
> > +BOOLEAN
> > +SbiImplementsDbcn (
> > + VOID
> > + )
> > +{
> > + SBI_RET Ret;
> > +
> > + Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1,
> > + SBI_EXT_DBCN); if ((TranslateError (Ret.Error) == EFI_SUCCESS) &&
> > + (Ret.Value != 0))
> > + {
> > + return TRUE;
> > + }
> > +
> > + return FALSE;
> > +}
> > +
> > +/**
> > + Return whether the legacy console putchar extension is implemented.
> > +
> > + @retval TRUE Extension is implemented.
> > + @retval FALSE Extension is not implemented.
> > +
> > +**/
> > +BOOLEAN
> > +SbiImplementsLegacyPutchar (
> > + VOID
> > + )
> > +{
> > + SBI_RET Ret;
> > +
> > + Ret = SbiCall (SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, 1,
> > + SBI_EXT_0_1_CONSOLE_PUTCHAR); if ((TranslateError (Ret.Error) ==
> EFI_SUCCESS) &&
> > + (Ret.Value != 0))
> > + {
> > + return TRUE;
> > + }
> > +
> > + return FALSE;
> > +}
> > +
> > +/**
> > + Write data from buffer to console via SBI legacy putchar extension.
> > +
> > + The number of bytes actually written to the SBI console is returned.
> > + If the return value is less than NumberOfBytes, then the write operation
> failed.
> > +
> > + @param Buffer The pointer to the data buffer to be written.
> > + @param NumberOfBytes The number of bytes to written to the serial
> device.
> > +
> > + @retval >=0 The number of bytes written to the serial device.
> > + If this value is less than NumberOfBytes, then the
> > + write operation failed.
> > +
> > +**/
> > +UINTN
> > +SbiLegacyPutchar (
> > + IN UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + )
> > +{
> > + SBI_RET Ret;
> > + UINTN Index;
> > +
> > + for (Index = 0; Index < NumberOfBytes; Index++) {
> > + Ret = SbiCall (SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, 1, Buffer[Index]);
> > + if ((INT64)Ret.Error < 0) {
> > + break;
> > + }
> > + }
> > +
> > + return Index;
> > +}
> > +
> > +/**
> > + Write data from buffer to console via SBI DBCN.
> > +
> > + The number of bytes actually written to the SBI console is returned.
> > + If the return value is less than NumberOfBytes, then the write operation
> failed.
> > +
> > + @param Buffer The pointer to the data buffer to be written.
> > + @param NumberOfBytes The number of bytes to written to the serial
> device.
> > +
> > + @retval >=0 The number of bytes written to the serial device.
> > + If this value is less than NumberOfBytes, then the
> > + write operation failed.
> > +
> > +**/
> > +UINTN
> > +SbiDbcnWrite (
> > + IN UINT8 *Buffer,
> > + IN UINTN NumberOfBytes
> > + )
> > +{
> > + SBI_RET Ret;
> > +
> > + Ret = SbiCall (
> > + SBI_EXT_DBCN,
> > + SBI_EXT_DBCN_WRITE,
> > + 3,
> > + NumberOfBytes,
> > + ((UINTN)Buffer),
> > + 0
> > + );
> > +
> > + /*
> > + * May do partial writes. Don't bother decoding
> > + * Ret.Error as we're only interested in number of
> > + * bytes written to console.
> > + */
> > + return Ret.Value;
> > +}
> > diff --git
> > a/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLib.uni
> > b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > iLib.uni
> > new file mode 100644
> > index 000000000000..7b22caa5a090
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > +++ cVSbiLib.uni
> > @@ -0,0 +1,16 @@
> > +// /** @file
> > +// Serial Port Library backed by SBI console.
> > +//
> > +// Serial Port Library backed by SBI console.
> Duplicate sentence.
>
>
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-04-07 22:08 ` [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib Michael D Kinney
@ 2023-04-25 19:26 ` Andrei Warkentin
2023-04-26 6:44 ` Sunil V L
[not found] ` <1759444C5DA596CB.10313@groups.io>
1 sibling, 1 reply; 17+ messages in thread
From: Andrei Warkentin @ 2023-04-25 19:26 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io; +Cc: Sunil V L
Thanks for the review. I believe this patch set is ready for merging. Sunil had one comment on the contents of the UNI file, which I clarified. Sunil, anything else you wanted from this patch set or is it good to go?
A
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, April 7, 2023 5:09 PM
> To: devel@edk2.groups.io; Warkentin, Andrei
> <andrei.warkentin@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei
> > Warkentin
> > Sent: Friday, April 7, 2023 2:44 PM
> > To: devel@edk2.groups.io
> > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > Hello,
> >
> > Here are three patches that provide a SerialLib backed by SBI console.
> > Both legacy and DBCN mechanisms are supported in various execution
> > environments and have been tested with UART and HTIF consoles.
> >
> > MdePkg reviewers: please review MdePkg.dsc changes.
> >
> > This is also available at
> > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> >
> > A CI run is at https://github.com/tianocore/edk2/pull/4252
> >
> > Compared to v6:
> >
> > - Unify the two SerialLib implementations under one directory and
> > factor out the code somewhat.
> > - Sunil's feedback on correctness.
> >
> > Compared to v5:
> >
> > Rename components as per Michael Kinney's suggestions.
> >
> > Compared to v4:
> >
> > (not sent out). CC MdePkg maintainers, fix copyright date in SecMain.c.
> >
> > Compared to v3
> >
> > EccCheck fixes. Add MdePkg infs to DSC.
> >
> > Compared to v2:
> > - Probes legacy extension as well.
> > - Encode supported module types in the INF file. This is done using
> LIBRARY_CLASS,
> > as MODULE_TYPE cannot encode multiple types, so MODULE_TYPE is
> retained as BASE.
> > - Update INF version and generate brand new GUIDs instead of editing
> them.
> > - Checked that all patches retain ^M endings.
> >
> > Andrei Warkentin (3):
> > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > MdePkg: add SBI-based SerialPortLib for RISC-V
> > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
> >
> > MdePkg/MdePkg.dsc | 2 +
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.in
> f | 40 +++
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRa
> m.inf | 37 +++
> > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
> > MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++-
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h |
> 41 +++
> > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
> > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c | 3
> +-
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
> | 208 ++++++++++++++
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRa
> m.c | 289 ++++++++++++++++++++
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c |
> 132 +++++++++
> > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +-
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.u
> ni | 16 ++
> > 13 files changed, 808 insertions(+), 6 deletions(-) create mode
> > 100644
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ib.inf create mode 100644
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ibRam.inf create mode 100644
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > create mode 100644
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ib.c create mode 100644
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ibRam.c create mode 100644
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > create mode 100644
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ib.uni
> >
> > --
> > 2.25.1
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-04-25 19:26 ` Andrei Warkentin
@ 2023-04-26 6:44 ` Sunil V L
0 siblings, 0 replies; 17+ messages in thread
From: Sunil V L @ 2023-04-26 6:44 UTC (permalink / raw)
To: devel, andrei.warkentin; +Cc: Kinney, Michael D
On Tue, Apr 25, 2023 at 07:26:41PM +0000, Andrei Warkentin wrote:
> Thanks for the review. I believe this patch set is ready for merging. Sunil had one comment on the contents of the UNI file, which I clarified. Sunil, anything else you wanted from this patch set or is it good to go?
>
Hi Andrei,
Please go ahead. LGTM.
Thanks,
Sunil
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
[not found] ` <1759444C5DA596CB.10313@groups.io>
@ 2023-05-11 20:25 ` Andrei Warkentin
[not found] ` <175E309BD5A0B986.27409@groups.io>
1 sibling, 0 replies; 17+ messages in thread
From: Andrei Warkentin @ 2023-05-11 20:25 UTC (permalink / raw)
To: devel@edk2.groups.io, Warkentin, Andrei, Kinney, Michael D; +Cc: Sunil V L
Hi Michael,
When can you or one of the MdePkg maintainers merge the SBI SerialLib patch set?
A
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei
> Warkentin
> Sent: Tuesday, April 25, 2023 2:27 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Thanks for the review. I believe this patch set is ready for merging. Sunil had
> one comment on the contents of the UNI file, which I clarified. Sunil,
> anything else you wanted from this patch set or is it good to go?
>
> A
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Friday, April 7, 2023 5:09 PM
> > To: devel@edk2.groups.io; Warkentin, Andrei
> > <andrei.warkentin@intel.com>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Andrei Warkentin
> > > Sent: Friday, April 7, 2023 2:44 PM
> > > To: devel@edk2.groups.io
> > > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > >
> > > Hello,
> > >
> > > Here are three patches that provide a SerialLib backed by SBI console.
> > > Both legacy and DBCN mechanisms are supported in various execution
> > > environments and have been tested with UART and HTIF consoles.
> > >
> > > MdePkg reviewers: please review MdePkg.dsc changes.
> > >
> > > This is also available at
> > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> > >
> > > A CI run is at https://github.com/tianocore/edk2/pull/4252
> > >
> > > Compared to v6:
> > >
> > > - Unify the two SerialLib implementations under one directory and
> > > factor out the code somewhat.
> > > - Sunil's feedback on correctness.
> > >
> > > Compared to v5:
> > >
> > > Rename components as per Michael Kinney's suggestions.
> > >
> > > Compared to v4:
> > >
> > > (not sent out). CC MdePkg maintainers, fix copyright date in SecMain.c.
> > >
> > > Compared to v3
> > >
> > > EccCheck fixes. Add MdePkg infs to DSC.
> > >
> > > Compared to v2:
> > > - Probes legacy extension as well.
> > > - Encode supported module types in the INF file. This is done using
> > LIBRARY_CLASS,
> > > as MODULE_TYPE cannot encode multiple types, so MODULE_TYPE is
> > retained as BASE.
> > > - Update INF version and generate brand new GUIDs instead of editing
> > them.
> > > - Checked that all patches retain ^M endings.
> > >
> > > Andrei Warkentin (3):
> > > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > > MdePkg: add SBI-based SerialPortLib for RISC-V
> > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
> > >
> > > MdePkg/MdePkg.dsc | 2 +
> > >
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.in
> > f | 40 +++
> > >
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ibRa
> > m.inf | 37 +++
> > > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
> > > MdePkg/Include/Library/BaseRiscVSbiLib.h | 40
> ++-
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> |
> > 41 +++
> > > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
> > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c | 3
> > +-
> > >
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ib.c
> > | 208 ++++++++++++++
> > >
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRa
> > m.c | 289 ++++++++++++++++++++
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> |
> > 132 +++++++++
> > > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +-
> > >
> >
> MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.u
> > ni | 16 ++
> > > 13 files changed, 808 insertions(+), 6 deletions(-) create mode
> > > 100644
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > iL
> > > ib.inf create mode 100644
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > iL
> > > ibRam.inf create mode 100644
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > create mode 100644
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > iL
> > > ib.c create mode 100644
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > iL
> > > ibRam.c create mode 100644
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > create mode 100644
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > iL
> > > ib.uni
> > >
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
> > >
>
>
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
[not found] ` <175E309BD5A0B986.27409@groups.io>
@ 2023-05-17 4:58 ` Andrei Warkentin
2023-05-17 5:06 ` Michael D Kinney
0 siblings, 1 reply; 17+ messages in thread
From: Andrei Warkentin @ 2023-05-17 4:58 UTC (permalink / raw)
To: devel@edk2.groups.io, Warkentin, Andrei, Kinney, Michael D; +Cc: Sunil V L
Hi folks,
Is there a particular process that I'm not following to get a patch set merged after all the reviews and sign-offs have been completed?
The SBI SerialLib patches were last updated April 7th.
A
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei
> Warkentin
> Sent: Thursday, May 11, 2023 3:26 PM
> To: devel@edk2.groups.io; Warkentin, Andrei
> <andrei.warkentin@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Hi Michael,
>
> When can you or one of the MdePkg maintainers merge the SBI SerialLib
> patch set?
>
> A
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei
> > Warkentin
> > Sent: Tuesday, April 25, 2023 2:27 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > devel@edk2.groups.io
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > Thanks for the review. I believe this patch set is ready for merging.
> > Sunil had one comment on the contents of the UNI file, which I
> > clarified. Sunil, anything else you wanted from this patch set or is it good
> to go?
> >
> > A
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Friday, April 7, 2023 5:09 PM
> > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > <andrei.warkentin@intel.com>
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > >
> > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > Andrei Warkentin
> > > > Sent: Friday, April 7, 2023 2:44 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > > >
> > > > Hello,
> > > >
> > > > Here are three patches that provide a SerialLib backed by SBI console.
> > > > Both legacy and DBCN mechanisms are supported in various execution
> > > > environments and have been tested with UART and HTIF consoles.
> > > >
> > > > MdePkg reviewers: please review MdePkg.dsc changes.
> > > >
> > > > This is also available at
> > > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> > > >
> > > > A CI run is at https://github.com/tianocore/edk2/pull/4252
> > > >
> > > > Compared to v6:
> > > >
> > > > - Unify the two SerialLib implementations under one directory and
> > > > factor out the code somewhat.
> > > > - Sunil's feedback on correctness.
> > > >
> > > > Compared to v5:
> > > >
> > > > Rename components as per Michael Kinney's suggestions.
> > > >
> > > > Compared to v4:
> > > >
> > > > (not sent out). CC MdePkg maintainers, fix copyright date in SecMain.c.
> > > >
> > > > Compared to v3
> > > >
> > > > EccCheck fixes. Add MdePkg infs to DSC.
> > > >
> > > > Compared to v2:
> > > > - Probes legacy extension as well.
> > > > - Encode supported module types in the INF file. This is done
> > > > using
> > > LIBRARY_CLASS,
> > > > as MODULE_TYPE cannot encode multiple types, so MODULE_TYPE is
> > > retained as BASE.
> > > > - Update INF version and generate brand new GUIDs instead of
> > > > editing
> > > them.
> > > > - Checked that all patches retain ^M endings.
> > > >
> > > > Andrei Warkentin (3):
> > > > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > > > MdePkg: add SBI-based SerialPortLib for RISC-V
> > > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
> > > >
> > > > MdePkg/MdePkg.dsc | 2 +
> > > >
> > >
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ib.in
> > > f | 40 +++
> > > >
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > iL
> > > ibRa
> > > m.inf | 37 +++
> > > > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
> > > > MdePkg/Include/Library/BaseRiscVSbiLib.h | 40
> > ++-
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > |
> > > 41 +++
> > > > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
> > > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c |
> 3
> > > +-
> > > >
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > iL
> > > ib.c
> > > | 208 ++++++++++++++
> > > >
> > >
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ibRa
> > > m.c | 289 ++++++++++++++++++++
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > |
> > > 132 +++++++++
> > > > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +-
> > > >
> > >
> > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > ib.u
> > > ni | 16 ++
> > > > 13 files changed, 808 insertions(+), 6 deletions(-) create mode
> > > > 100644
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > Sb
> > > > iL
> > > > ib.inf create mode 100644
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > Sb
> > > > iL
> > > > ibRam.inf create mode 100644
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > create mode 100644
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > Sb
> > > > iL
> > > > ib.c create mode 100644
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > Sb
> > > > iL
> > > > ibRam.c create mode 100644
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > create mode 100644
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > Sb
> > > > iL
> > > > ib.uni
> > > >
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> >
> >
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-05-17 4:58 ` Andrei Warkentin
@ 2023-05-17 5:06 ` Michael D Kinney
2023-05-17 5:26 ` Andrei Warkentin
0 siblings, 1 reply; 17+ messages in thread
From: Michael D Kinney @ 2023-05-17 5:06 UTC (permalink / raw)
To: Warkentin, Andrei, devel@edk2.groups.io, Gao, Liming
Cc: Sunil V L, Kinney, Michael D
Are the commit messages all up to date in the PR with all Rbs? And is the correct PR
https://github.com/tianocore/edk2/pull/4252
Liming, this was completed well before soft freeze and looks like low risk. It should be merged for stable tag.
Mike
> -----Original Message-----
> From: Warkentin, Andrei <andrei.warkentin@intel.com>
> Sent: Tuesday, May 16, 2023 9:58 PM
> To: devel@edk2.groups.io; Warkentin, Andrei <andrei.warkentin@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Hi folks,
>
> Is there a particular process that I'm not following to get a patch set merged
> after all the reviews and sign-offs have been completed?
>
> The SBI SerialLib patches were last updated April 7th.
>
> A
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei
> > Warkentin
> > Sent: Thursday, May 11, 2023 3:26 PM
> > To: devel@edk2.groups.io; Warkentin, Andrei
> > <andrei.warkentin@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > Hi Michael,
> >
> > When can you or one of the MdePkg maintainers merge the SBI SerialLib
> > patch set?
> >
> > A
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrei
> > > Warkentin
> > > Sent: Tuesday, April 25, 2023 2:27 PM
> > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > devel@edk2.groups.io
> > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > >
> > > Thanks for the review. I believe this patch set is ready for merging.
> > > Sunil had one comment on the contents of the UNI file, which I
> > > clarified. Sunil, anything else you wanted from this patch set or is it good
> > to go?
> > >
> > > A
> > >
> > > > -----Original Message-----
> > > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > Sent: Friday, April 7, 2023 5:09 PM
> > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > <andrei.warkentin@intel.com>
> > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > > >
> > > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > Andrei Warkentin
> > > > > Sent: Friday, April 7, 2023 2:44 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > > > >
> > > > > Hello,
> > > > >
> > > > > Here are three patches that provide a SerialLib backed by SBI console.
> > > > > Both legacy and DBCN mechanisms are supported in various execution
> > > > > environments and have been tested with UART and HTIF consoles.
> > > > >
> > > > > MdePkg reviewers: please review MdePkg.dsc changes.
> > > > >
> > > > > This is also available at
> > > > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> > > > >
> > > > > A CI run is at https://github.com/tianocore/edk2/pull/4252
> > > > >
> > > > > Compared to v6:
> > > > >
> > > > > - Unify the two SerialLib implementations under one directory and
> > > > > factor out the code somewhat.
> > > > > - Sunil's feedback on correctness.
> > > > >
> > > > > Compared to v5:
> > > > >
> > > > > Rename components as per Michael Kinney's suggestions.
> > > > >
> > > > > Compared to v4:
> > > > >
> > > > > (not sent out). CC MdePkg maintainers, fix copyright date in SecMain.c.
> > > > >
> > > > > Compared to v3
> > > > >
> > > > > EccCheck fixes. Add MdePkg infs to DSC.
> > > > >
> > > > > Compared to v2:
> > > > > - Probes legacy extension as well.
> > > > > - Encode supported module types in the INF file. This is done
> > > > > using
> > > > LIBRARY_CLASS,
> > > > > as MODULE_TYPE cannot encode multiple types, so MODULE_TYPE is
> > > > retained as BASE.
> > > > > - Update INF version and generate brand new GUIDs instead of
> > > > > editing
> > > > them.
> > > > > - Checked that all patches retain ^M endings.
> > > > >
> > > > > Andrei Warkentin (3):
> > > > > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > > > > MdePkg: add SBI-based SerialPortLib for RISC-V
> > > > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
> > > > >
> > > > > MdePkg/MdePkg.dsc | 2 +
> > > > >
> > > >
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > > ib.in
> > > > f | 40 +++
> > > > >
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > > iL
> > > > ibRa
> > > > m.inf | 37 +++
> > > > > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 +
> > > > > MdePkg/Include/Library/BaseRiscVSbiLib.h |
> 40
> > > ++-
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > |
> > > > 41 +++
> > > > > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 +
> > > > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c |
> > 3
> > > > +-
> > > > >
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSb
> > > > iL
> > > > ib.c
> > > > | 208 ++++++++++++++
> > > > >
> > > >
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > > ibRa
> > > > m.c | 289 ++++++++++++++++++++
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > |
> > > > 132 +++++++++
> > > > > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +-
> > > > >
> > > >
> > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiL
> > > ib.u
> > > > ni | 16 ++
> > > > > 13 files changed, 808 insertions(+), 6 deletions(-) create mode
> > > > > 100644
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > Sb
> > > > > iL
> > > > > ib.inf create mode 100644
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > Sb
> > > > > iL
> > > > > ibRam.inf create mode 100644
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > create mode 100644
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > Sb
> > > > > iL
> > > > > ib.c create mode 100644
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > Sb
> > > > > iL
> > > > > ibRam.c create mode 100644
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > create mode 100644
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > Sb
> > > > > iL
> > > > > ib.uni
> > > > >
> > > > > --
> > > > > 2.25.1
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-05-17 5:06 ` Michael D Kinney
@ 2023-05-17 5:26 ` Andrei Warkentin
2023-05-17 18:03 ` Michael D Kinney
0 siblings, 1 reply; 17+ messages in thread
From: Andrei Warkentin @ 2023-05-17 5:26 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io, Gao, Liming; +Cc: Sunil V L
Save for the last one from you - yes (as that reviewed-by came after I resent the patch set, after the successful CI run)
A
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, May 17, 2023 12:07 AM
> To: Warkentin, Andrei <andrei.warkentin@intel.com>;
> devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Are the commit messages all up to date in the PR with all Rbs? And is the
> correct PR
>
> https://github.com/tianocore/edk2/pull/4252
>
> Liming, this was completed well before soft freeze and looks like low risk. It
> should be merged for stable tag.
>
> Mike
>
> > -----Original Message-----
> > From: Warkentin, Andrei <andrei.warkentin@intel.com>
> > Sent: Tuesday, May 16, 2023 9:58 PM
> > To: devel@edk2.groups.io; Warkentin, Andrei
> > <andrei.warkentin@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > Hi folks,
> >
> > Is there a particular process that I'm not following to get a patch
> > set merged after all the reviews and sign-offs have been completed?
> >
> > The SBI SerialLib patches were last updated April 7th.
> >
> > A
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Andrei Warkentin
> > > Sent: Thursday, May 11, 2023 3:26 PM
> > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > <andrei.warkentin@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > >
> > > Hi Michael,
> > >
> > > When can you or one of the MdePkg maintainers merge the SBI
> > > SerialLib patch set?
> > >
> > > A
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > Andrei Warkentin
> > > > Sent: Tuesday, April 25, 2023 2:27 PM
> > > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > devel@edk2.groups.io
> > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > SerialLib
> > > >
> > > > Thanks for the review. I believe this patch set is ready for merging.
> > > > Sunil had one comment on the contents of the UNI file, which I
> > > > clarified. Sunil, anything else you wanted from this patch set or
> > > > is it good
> > > to go?
> > > >
> > > > A
> > > >
> > > > > -----Original Message-----
> > > > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > Sent: Friday, April 7, 2023 5:09 PM
> > > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > > <andrei.warkentin@intel.com>
> > > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > SerialLib
> > > > >
> > > > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > > Andrei Warkentin
> > > > > > Sent: Friday, April 7, 2023 2:44 PM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > SerialLib
> > > > > >
> > > > > > Hello,
> > > > > >
> > > > > > Here are three patches that provide a SerialLib backed by SBI
> console.
> > > > > > Both legacy and DBCN mechanisms are supported in various
> > > > > > execution environments and have been tested with UART and HTIF
> consoles.
> > > > > >
> > > > > > MdePkg reviewers: please review MdePkg.dsc changes.
> > > > > >
> > > > > > This is also available at
> > > > > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> > > > > >
> > > > > > A CI run is at https://github.com/tianocore/edk2/pull/4252
> > > > > >
> > > > > > Compared to v6:
> > > > > >
> > > > > > - Unify the two SerialLib implementations under one directory and
> > > > > > factor out the code somewhat.
> > > > > > - Sunil's feedback on correctness.
> > > > > >
> > > > > > Compared to v5:
> > > > > >
> > > > > > Rename components as per Michael Kinney's suggestions.
> > > > > >
> > > > > > Compared to v4:
> > > > > >
> > > > > > (not sent out). CC MdePkg maintainers, fix copyright date in
> SecMain.c.
> > > > > >
> > > > > > Compared to v3
> > > > > >
> > > > > > EccCheck fixes. Add MdePkg infs to DSC.
> > > > > >
> > > > > > Compared to v2:
> > > > > > - Probes legacy extension as well.
> > > > > > - Encode supported module types in the INF file. This is done
> > > > > > using
> > > > > LIBRARY_CLASS,
> > > > > > as MODULE_TYPE cannot encode multiple types, so
> MODULE_TYPE
> > > > > > is
> > > > > retained as BASE.
> > > > > > - Update INF version and generate brand new GUIDs instead of
> > > > > > editing
> > > > > them.
> > > > > > - Checked that all patches retain ^M endings.
> > > > > >
> > > > > > Andrei Warkentin (3):
> > > > > > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > > > > > MdePkg: add SBI-based SerialPortLib for RISC-V
> > > > > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
> > > > > >
> > > > > > MdePkg/MdePkg.dsc | 2 +
> > > > > >
> > > > >
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > SbiL
> > > > ib.in
> > > > > f | 40 +++
> > > > > >
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > > > > cVSb
> > > > > iL
> > > > > ibRa
> > > > > m.inf | 37 +++
> > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1
> +
> > > > > > MdePkg/Include/Library/BaseRiscVSbiLib.h |
> > 40
> > > > ++-
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > |
> > > > > 41 +++
> > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1
> +
> > > > > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c
> |
> > > 3
> > > > > +-
> > > > > >
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > > > > cVSb
> > > > > iL
> > > > > ib.c
> > > > > | 208 ++++++++++++++
> > > > > >
> > > > >
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > SbiL
> > > > ibRa
> > > > > m.c | 289 ++++++++++++++++++++
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > |
> > > > > 132 +++++++++
> > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4
> +-
> > > > > >
> > > > >
> > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > SbiL
> > > > ib.u
> > > > > ni | 16 ++
> > > > > > 13 files changed, 808 insertions(+), 6 deletions(-) create
> > > > > > mode
> > > > > > 100644
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > iscV
> > > > > > Sb
> > > > > > iL
> > > > > > ib.inf create mode 100644
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > iscV
> > > > > > Sb
> > > > > > iL
> > > > > > ibRam.inf create mode 100644
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > > create mode 100644
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > iscV
> > > > > > Sb
> > > > > > iL
> > > > > > ib.c create mode 100644
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > iscV
> > > > > > Sb
> > > > > > iL
> > > > > > ibRam.c create mode 100644
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > > create mode 100644
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > iscV
> > > > > > Sb
> > > > > > iL
> > > > > > ib.uni
> > > > > >
> > > > > > --
> > > > > > 2.25.1
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-05-17 5:26 ` Andrei Warkentin
@ 2023-05-17 18:03 ` Michael D Kinney
2023-05-17 23:47 ` Michael D Kinney
0 siblings, 1 reply; 17+ messages in thread
From: Michael D Kinney @ 2023-05-17 18:03 UTC (permalink / raw)
To: Warkentin, Andrei, devel@edk2.groups.io, Gao, Liming
Cc: Sunil V L, Kinney, Michael D
I will take care of it today.
Mike
> -----Original Message-----
> From: Warkentin, Andrei <andrei.warkentin@intel.com>
> Sent: Tuesday, May 16, 2023 10:27 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io;
> Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Save for the last one from you - yes (as that reviewed-by came after I resent
> the patch set, after the successful CI run)
>
> A
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Wednesday, May 17, 2023 12:07 AM
> > To: Warkentin, Andrei <andrei.warkentin@intel.com>;
> > devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > Are the commit messages all up to date in the PR with all Rbs? And is the
> > correct PR
> >
> > https://github.com/tianocore/edk2/pull/4252
> >
> > Liming, this was completed well before soft freeze and looks like low risk. It
> > should be merged for stable tag.
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > Sent: Tuesday, May 16, 2023 9:58 PM
> > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > <andrei.warkentin@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > >
> > > Hi folks,
> > >
> > > Is there a particular process that I'm not following to get a patch
> > > set merged after all the reviews and sign-offs have been completed?
> > >
> > > The SBI SerialLib patches were last updated April 7th.
> > >
> > > A
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > Andrei Warkentin
> > > > Sent: Thursday, May 11, 2023 3:26 PM
> > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > <andrei.warkentin@intel.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > > >
> > > > Hi Michael,
> > > >
> > > > When can you or one of the MdePkg maintainers merge the SBI
> > > > SerialLib patch set?
> > > >
> > > > A
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > Andrei Warkentin
> > > > > Sent: Tuesday, April 25, 2023 2:27 PM
> > > > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > > devel@edk2.groups.io
> > > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > SerialLib
> > > > >
> > > > > Thanks for the review. I believe this patch set is ready for merging.
> > > > > Sunil had one comment on the contents of the UNI file, which I
> > > > > clarified. Sunil, anything else you wanted from this patch set or
> > > > > is it good
> > > > to go?
> > > > >
> > > > > A
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > > Sent: Friday, April 7, 2023 5:09 PM
> > > > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > > > <andrei.warkentin@intel.com>
> > > > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > SerialLib
> > > > > >
> > > > > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > > > Andrei Warkentin
> > > > > > > Sent: Friday, April 7, 2023 2:44 PM
> > > > > > > To: devel@edk2.groups.io
> > > > > > > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > > > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > > SerialLib
> > > > > > >
> > > > > > > Hello,
> > > > > > >
> > > > > > > Here are three patches that provide a SerialLib backed by SBI
> > console.
> > > > > > > Both legacy and DBCN mechanisms are supported in various
> > > > > > > execution environments and have been tested with UART and HTIF
> > consoles.
> > > > > > >
> > > > > > > MdePkg reviewers: please review MdePkg.dsc changes.
> > > > > > >
> > > > > > > This is also available at
> > > > > > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> > > > > > >
> > > > > > > A CI run is at https://github.com/tianocore/edk2/pull/4252
> > > > > > >
> > > > > > > Compared to v6:
> > > > > > >
> > > > > > > - Unify the two SerialLib implementations under one directory and
> > > > > > > factor out the code somewhat.
> > > > > > > - Sunil's feedback on correctness.
> > > > > > >
> > > > > > > Compared to v5:
> > > > > > >
> > > > > > > Rename components as per Michael Kinney's suggestions.
> > > > > > >
> > > > > > > Compared to v4:
> > > > > > >
> > > > > > > (not sent out). CC MdePkg maintainers, fix copyright date in
> > SecMain.c.
> > > > > > >
> > > > > > > Compared to v3
> > > > > > >
> > > > > > > EccCheck fixes. Add MdePkg infs to DSC.
> > > > > > >
> > > > > > > Compared to v2:
> > > > > > > - Probes legacy extension as well.
> > > > > > > - Encode supported module types in the INF file. This is done
> > > > > > > using
> > > > > > LIBRARY_CLASS,
> > > > > > > as MODULE_TYPE cannot encode multiple types, so
> > MODULE_TYPE
> > > > > > > is
> > > > > > retained as BASE.
> > > > > > > - Update INF version and generate brand new GUIDs instead of
> > > > > > > editing
> > > > > > them.
> > > > > > > - Checked that all patches retain ^M endings.
> > > > > > >
> > > > > > > Andrei Warkentin (3):
> > > > > > > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > > > > > > MdePkg: add SBI-based SerialPortLib for RISC-V
> > > > > > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
> > > > > > >
> > > > > > > MdePkg/MdePkg.dsc | 2 +
> > > > > > >
> > > > > >
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > SbiL
> > > > > ib.in
> > > > > > f | 40 +++
> > > > > > >
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > > > > > cVSb
> > > > > > iL
> > > > > > ibRa
> > > > > > m.inf | 37 +++
> > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.inf |
> 1
> > +
> > > > > > > MdePkg/Include/Library/BaseRiscVSbiLib.h
> |
> > > 40
> > > > > ++-
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > |
> > > > > > 41 +++
> > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1
> > +
> > > > > > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c
> > |
> > > > 3
> > > > > > +-
> > > > > > >
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > > > > > cVSb
> > > > > > iL
> > > > > > ib.c
> > > > > > | 208 ++++++++++++++
> > > > > > >
> > > > > >
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > SbiL
> > > > > ibRa
> > > > > > m.c | 289 ++++++++++++++++++++
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > |
> > > > > > 132 +++++++++
> > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4
> > +-
> > > > > > >
> > > > > >
> > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > SbiL
> > > > > ib.u
> > > > > > ni | 16 ++
> > > > > > > 13 files changed, 808 insertions(+), 6 deletions(-) create
> > > > > > > mode
> > > > > > > 100644
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > iscV
> > > > > > > Sb
> > > > > > > iL
> > > > > > > ib.inf create mode 100644
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > iscV
> > > > > > > Sb
> > > > > > > iL
> > > > > > > ibRam.inf create mode 100644
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > > > create mode 100644
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > iscV
> > > > > > > Sb
> > > > > > > iL
> > > > > > > ib.c create mode 100644
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > iscV
> > > > > > > Sb
> > > > > > > iL
> > > > > > > ibRam.c create mode 100644
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > > > create mode 100644
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > iscV
> > > > > > > Sb
> > > > > > > iL
> > > > > > > ib.uni
> > > > > > >
> > > > > > > --
> > > > > > > 2.25.1
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-05-17 18:03 ` Michael D Kinney
@ 2023-05-17 23:47 ` Michael D Kinney
2023-05-18 3:36 ` Andrei Warkentin
0 siblings, 1 reply; 17+ messages in thread
From: Michael D Kinney @ 2023-05-17 23:47 UTC (permalink / raw)
To: Warkentin, Andrei, devel@edk2.groups.io, Gao, Liming
Cc: Sunil V L, Kinney, Michael D
Merged:
https://github.com/tianocore/edk2/pull/4406
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, May 17, 2023 11:03 AM
> To: Warkentin, Andrei <andrei.warkentin@intel.com>; devel@edk2.groups.io;
> Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> I will take care of it today.
>
> Mike
>
> > -----Original Message-----
> > From: Warkentin, Andrei <andrei.warkentin@intel.com>
> > Sent: Tuesday, May 16, 2023 10:27 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io;
> > Gao, Liming <gaoliming@byosoft.com.cn>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > Save for the last one from you - yes (as that reviewed-by came after I resent
> > the patch set, after the successful CI run)
> >
> > A
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Wednesday, May 17, 2023 12:07 AM
> > > To: Warkentin, Andrei <andrei.warkentin@intel.com>;
> > > devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> > > Cc: Sunil V L <sunilvl@ventanamicro.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > >
> > > Are the commit messages all up to date in the PR with all Rbs? And is the
> > > correct PR
> > >
> > > https://github.com/tianocore/edk2/pull/4252
> > >
> > > Liming, this was completed well before soft freeze and looks like low risk.
> It
> > > should be merged for stable tag.
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > Sent: Tuesday, May 16, 2023 9:58 PM
> > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > <andrei.warkentin@intel.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > > >
> > > > Hi folks,
> > > >
> > > > Is there a particular process that I'm not following to get a patch
> > > > set merged after all the reviews and sign-offs have been completed?
> > > >
> > > > The SBI SerialLib patches were last updated April 7th.
> > > >
> > > > A
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > Andrei Warkentin
> > > > > Sent: Thursday, May 11, 2023 3:26 PM
> > > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > > <andrei.warkentin@intel.com>; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>
> > > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > > > >
> > > > > Hi Michael,
> > > > >
> > > > > When can you or one of the MdePkg maintainers merge the SBI
> > > > > SerialLib patch set?
> > > > >
> > > > > A
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > > Andrei Warkentin
> > > > > > Sent: Tuesday, April 25, 2023 2:27 PM
> > > > > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > > > devel@edk2.groups.io
> > > > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > SerialLib
> > > > > >
> > > > > > Thanks for the review. I believe this patch set is ready for merging.
> > > > > > Sunil had one comment on the contents of the UNI file, which I
> > > > > > clarified. Sunil, anything else you wanted from this patch set or
> > > > > > is it good
> > > > > to go?
> > > > > >
> > > > > > A
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > > > Sent: Friday, April 7, 2023 5:09 PM
> > > > > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > > > > <andrei.warkentin@intel.com>
> > > > > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > > SerialLib
> > > > > > >
> > > > > > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > > >
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf
> Of
> > > > > > > > Andrei Warkentin
> > > > > > > > Sent: Friday, April 7, 2023 2:44 PM
> > > > > > > > To: devel@edk2.groups.io
> > > > > > > > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > > > > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > > > SerialLib
> > > > > > > >
> > > > > > > > Hello,
> > > > > > > >
> > > > > > > > Here are three patches that provide a SerialLib backed by SBI
> > > console.
> > > > > > > > Both legacy and DBCN mechanisms are supported in various
> > > > > > > > execution environments and have been tested with UART and
> HTIF
> > > consoles.
> > > > > > > >
> > > > > > > > MdePkg reviewers: please review MdePkg.dsc changes.
> > > > > > > >
> > > > > > > > This is also available at
> > > > > > > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> > > > > > > >
> > > > > > > > A CI run is at https://github.com/tianocore/edk2/pull/4252
> > > > > > > >
> > > > > > > > Compared to v6:
> > > > > > > >
> > > > > > > > - Unify the two SerialLib implementations under one directory
> and
> > > > > > > > factor out the code somewhat.
> > > > > > > > - Sunil's feedback on correctness.
> > > > > > > >
> > > > > > > > Compared to v5:
> > > > > > > >
> > > > > > > > Rename components as per Michael Kinney's suggestions.
> > > > > > > >
> > > > > > > > Compared to v4:
> > > > > > > >
> > > > > > > > (not sent out). CC MdePkg maintainers, fix copyright date in
> > > SecMain.c.
> > > > > > > >
> > > > > > > > Compared to v3
> > > > > > > >
> > > > > > > > EccCheck fixes. Add MdePkg infs to DSC.
> > > > > > > >
> > > > > > > > Compared to v2:
> > > > > > > > - Probes legacy extension as well.
> > > > > > > > - Encode supported module types in the INF file. This is done
> > > > > > > > using
> > > > > > > LIBRARY_CLASS,
> > > > > > > > as MODULE_TYPE cannot encode multiple types, so
> > > MODULE_TYPE
> > > > > > > > is
> > > > > > > retained as BASE.
> > > > > > > > - Update INF version and generate brand new GUIDs instead of
> > > > > > > > editing
> > > > > > > them.
> > > > > > > > - Checked that all patches retain ^M endings.
> > > > > > > >
> > > > > > > > Andrei Warkentin (3):
> > > > > > > > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > > > > > > > MdePkg: add SBI-based SerialPortLib for RISC-V
> > > > > > > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec
> > > > > > > >
> > > > > > > > MdePkg/MdePkg.dsc | 2 +
> > > > > > > >
> > > > > > >
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > > SbiL
> > > > > > ib.in
> > > > > > > f | 40 +++
> > > > > > > >
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > > > > > > cVSb
> > > > > > > iL
> > > > > > > ibRa
> > > > > > > m.inf | 37 +++
> > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.inf |
> > 1
> > > +
> > > > > > > > MdePkg/Include/Library/BaseRiscVSbiLib.h
> > |
> > > > 40
> > > > > > ++-
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > > |
> > > > > > > 41 +++
> > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.h |
> 1
> > > +
> > > > > > > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c
> > > |
> > > > > 3
> > > > > > > +-
> > > > > > > >
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRis
> > > > > > > cVSb
> > > > > > > iL
> > > > > > > ib.c
> > > > > > > | 208 ++++++++++++++
> > > > > > > >
> > > > > > >
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > > SbiL
> > > > > > ibRa
> > > > > > > m.c | 289 ++++++++++++++++++++
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > > |
> > > > > > > 132 +++++++++
> > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.c |
> 4
> > > +-
> > > > > > > >
> > > > > > >
> > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscV
> > > > > > SbiL
> > > > > > ib.u
> > > > > > > ni | 16 ++
> > > > > > > > 13 files changed, 808 insertions(+), 6 deletions(-) create
> > > > > > > > mode
> > > > > > > > 100644
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > > iscV
> > > > > > > > Sb
> > > > > > > > iL
> > > > > > > > ib.inf create mode 100644
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > > iscV
> > > > > > > > Sb
> > > > > > > > iL
> > > > > > > > ibRam.inf create mode 100644
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > > > > create mode 100644
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > > iscV
> > > > > > > > Sb
> > > > > > > > iL
> > > > > > > > ib.c create mode 100644
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > > iscV
> > > > > > > > Sb
> > > > > > > > iL
> > > > > > > > ibRam.c create mode 100644
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > > > > create mode 100644
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibR
> > > > > > > > iscV
> > > > > > > > Sb
> > > > > > > > iL
> > > > > > > > ib.uni
> > > > > > > >
> > > > > > > > --
> > > > > > > > 2.25.1
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
2023-05-17 23:47 ` Michael D Kinney
@ 2023-05-18 3:36 ` Andrei Warkentin
0 siblings, 0 replies; 17+ messages in thread
From: Andrei Warkentin @ 2023-05-18 3:36 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io, Gao, Liming; +Cc: Sunil V L
Thank you, Michael, appreciate your help!
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, May 17, 2023 6:48 PM
> To: Warkentin, Andrei <andrei.warkentin@intel.com>;
> devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Sunil V L <sunilvl@ventanamicro.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
>
> Merged:
>
> https://github.com/tianocore/edk2/pull/4406
>
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Wednesday, May 17, 2023 11:03 AM
> > To: Warkentin, Andrei <andrei.warkentin@intel.com>;
> > devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> >
> > I will take care of it today.
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > Sent: Tuesday, May 16, 2023 10:27 PM
> > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > devel@edk2.groups.io;
> > > Gao, Liming <gaoliming@byosoft.com.cn>
> > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib
> > >
> > > Save for the last one from you - yes (as that reviewed-by came after
> > > I resent the patch set, after the successful CI run)
> > >
> > > A
> > >
> > > > -----Original Message-----
> > > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > Sent: Wednesday, May 17, 2023 12:07 AM
> > > > To: Warkentin, Andrei <andrei.warkentin@intel.com>;
> > > > devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>
> > > > Cc: Sunil V L <sunilvl@ventanamicro.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > SerialLib
> > > >
> > > > Are the commit messages all up to date in the PR with all Rbs?
> > > > And is the correct PR
> > > >
> > > > https://github.com/tianocore/edk2/pull/4252
> > > >
> > > > Liming, this was completed well before soft freeze and looks like low
> risk.
> > It
> > > > should be merged for stable tag.
> > > >
> > > > Mike
> > > >
> > > > > -----Original Message-----
> > > > > From: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > > Sent: Tuesday, May 16, 2023 9:58 PM
> > > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > > <andrei.warkentin@intel.com>; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>
> > > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > SerialLib
> > > > >
> > > > > Hi folks,
> > > > >
> > > > > Is there a particular process that I'm not following to get a
> > > > > patch set merged after all the reviews and sign-offs have been
> completed?
> > > > >
> > > > > The SBI SerialLib patches were last updated April 7th.
> > > > >
> > > > > A
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > > Andrei Warkentin
> > > > > > Sent: Thursday, May 11, 2023 3:26 PM
> > > > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > > > <andrei.warkentin@intel.com>; Kinney, Michael D
> > > > > > <michael.d.kinney@intel.com>
> > > > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > SerialLib
> > > > > >
> > > > > > Hi Michael,
> > > > > >
> > > > > > When can you or one of the MdePkg maintainers merge the SBI
> > > > > > SerialLib patch set?
> > > > > >
> > > > > > A
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf
> > > > > > > Of Andrei Warkentin
> > > > > > > Sent: Tuesday, April 25, 2023 2:27 PM
> > > > > > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > > > > devel@edk2.groups.io
> > > > > > > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > > > > > > Subject: Re: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > > SerialLib
> > > > > > >
> > > > > > > Thanks for the review. I believe this patch set is ready for merging.
> > > > > > > Sunil had one comment on the contents of the UNI file, which
> > > > > > > I clarified. Sunil, anything else you wanted from this patch
> > > > > > > set or is it good
> > > > > > to go?
> > > > > > >
> > > > > > > A
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > > > > Sent: Friday, April 7, 2023 5:09 PM
> > > > > > > > To: devel@edk2.groups.io; Warkentin, Andrei
> > > > > > > > <andrei.warkentin@intel.com>
> > > > > > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > > > > > > > Subject: RE: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > > > SerialLib
> > > > > > > >
> > > > > > > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > > > >
> > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On
> > > > > > > > > Behalf
> > Of
> > > > > > > > > Andrei Warkentin
> > > > > > > > > Sent: Friday, April 7, 2023 2:44 PM
> > > > > > > > > To: devel@edk2.groups.io
> > > > > > > > > Cc: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > > > > > > > Subject: [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed
> > > > > > > > > SerialLib
> > > > > > > > >
> > > > > > > > > Hello,
> > > > > > > > >
> > > > > > > > > Here are three patches that provide a SerialLib backed
> > > > > > > > > by SBI
> > > > console.
> > > > > > > > > Both legacy and DBCN mechanisms are supported in various
> > > > > > > > > execution environments and have been tested with UART
> > > > > > > > > and
> > HTIF
> > > > consoles.
> > > > > > > > >
> > > > > > > > > MdePkg reviewers: please review MdePkg.dsc changes.
> > > > > > > > >
> > > > > > > > > This is also available at
> > > > > > > > > https://github.com/andreiw/edk2-rv-wip/tree/patchset-2
> > > > > > > > >
> > > > > > > > > A CI run is at
> > > > > > > > > https://github.com/tianocore/edk2/pull/4252
> > > > > > > > >
> > > > > > > > > Compared to v6:
> > > > > > > > >
> > > > > > > > > - Unify the two SerialLib implementations under one
> > > > > > > > > directory
> > and
> > > > > > > > > factor out the code somewhat.
> > > > > > > > > - Sunil's feedback on correctness.
> > > > > > > > >
> > > > > > > > > Compared to v5:
> > > > > > > > >
> > > > > > > > > Rename components as per Michael Kinney's suggestions.
> > > > > > > > >
> > > > > > > > > Compared to v4:
> > > > > > > > >
> > > > > > > > > (not sent out). CC MdePkg maintainers, fix copyright
> > > > > > > > > date in
> > > > SecMain.c.
> > > > > > > > >
> > > > > > > > > Compared to v3
> > > > > > > > >
> > > > > > > > > EccCheck fixes. Add MdePkg infs to DSC.
> > > > > > > > >
> > > > > > > > > Compared to v2:
> > > > > > > > > - Probes legacy extension as well.
> > > > > > > > > - Encode supported module types in the INF file. This is
> > > > > > > > > done using
> > > > > > > > LIBRARY_CLASS,
> > > > > > > > > as MODULE_TYPE cannot encode multiple types, so
> > > > MODULE_TYPE
> > > > > > > > > is
> > > > > > > > retained as BASE.
> > > > > > > > > - Update INF version and generate brand new GUIDs
> > > > > > > > > instead of editing
> > > > > > > > them.
> > > > > > > > > - Checked that all patches retain ^M endings.
> > > > > > > > >
> > > > > > > > > Andrei Warkentin (3):
> > > > > > > > > MdePkg: BaseRiscVSbiLib: make more useful to consumers
> > > > > > > > > MdePkg: add SBI-based SerialPortLib for RISC-V
> > > > > > > > > OvmfPkg: RiscVVirt: Add missing SerialPortInitialize
> > > > > > > > > to Sec
> > > > > > > > >
> > > > > > > > > MdePkg/MdePkg.dsc | 2 +
> > > > > > > > >
> > > > > > > >
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLi
> > > > > > > bRiscV
> > > > > > > SbiL
> > > > > > > ib.in
> > > > > > > > f | 40 +++
> > > > > > > > >
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPort
> > > > > > > > LibRis
> > > > > > > > cVSb
> > > > > > > > iL
> > > > > > > > ibRa
> > > > > > > > m.inf | 37 +++
> > > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.inf
> |
> > > 1
> > > > +
> > > > > > > > > MdePkg/Include/Library/BaseRiscVSbiLib.h
> > > |
> > > > > 40
> > > > > > > ++-
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > > > |
> > > > > > > > 41 +++
> > > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.h
> |
> > 1
> > > > +
> > > > > > > > > MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c
> > > > |
> > > > > > 3
> > > > > > > > +-
> > > > > > > > >
> > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPort
> > > > > > > > LibRis
> > > > > > > > cVSb
> > > > > > > > iL
> > > > > > > > ib.c
> > > > > > > > | 208 ++++++++++++++
> > > > > > > > >
> > > > > > > >
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLi
> > > > > > > bRiscV
> > > > > > > SbiL
> > > > > > > ibRa
> > > > > > > > m.c | 289 ++++++++++++++++++++
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > > > |
> > > > > > > > 132 +++++++++
> > > > > > > > > OvmfPkg/RiscVVirt/Sec/SecMain.c
> |
> > 4
> > > > +-
> > > > > > > > >
> > > > > > > >
> > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLi
> > > > > > > bRiscV
> > > > > > > SbiL
> > > > > > > ib.u
> > > > > > > > ni | 16 ++
> > > > > > > > > 13 files changed, 808 insertions(+), 6 deletions(-)
> > > > > > > > > create mode
> > > > > > > > > 100644
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo
> > > > > > > > > rtLibR
> > > > > > > > > iscV
> > > > > > > > > Sb
> > > > > > > > > iL
> > > > > > > > > ib.inf create mode 100644
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo
> > > > > > > > > rtLibR
> > > > > > > > > iscV
> > > > > > > > > Sb
> > > > > > > > > iL
> > > > > > > > > ibRam.inf create mode 100644
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
> > > > > > > > > create mode 100644
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo
> > > > > > > > > rtLibR
> > > > > > > > > iscV
> > > > > > > > > Sb
> > > > > > > > > iL
> > > > > > > > > ib.c create mode 100644
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo
> > > > > > > > > rtLibR
> > > > > > > > > iscV
> > > > > > > > > Sb
> > > > > > > > > iL
> > > > > > > > > ibRam.c create mode 100644
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
> > > > > > > > > create mode 100644
> > > > > > > > > MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPo
> > > > > > > > > rtLibR
> > > > > > > > > iscV
> > > > > > > > > Sb
> > > > > > > > > iL
> > > > > > > > > ib.uni
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > 2.25.1
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2023-05-18 3:37 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 21:44 [PATCH v7 0/3] RISC-V SBI-backed SerialLib Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V Andrei Warkentin
2023-04-12 7:15 ` Sunil V L
2023-04-18 23:31 ` [edk2-devel] " Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Andrei Warkentin
2023-04-08 2:22 ` [edk2-devel] " Yao, Jiewen
2023-04-07 22:08 ` [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib Michael D Kinney
2023-04-25 19:26 ` Andrei Warkentin
2023-04-26 6:44 ` Sunil V L
[not found] ` <1759444C5DA596CB.10313@groups.io>
2023-05-11 20:25 ` Andrei Warkentin
[not found] ` <175E309BD5A0B986.27409@groups.io>
2023-05-17 4:58 ` Andrei Warkentin
2023-05-17 5:06 ` Michael D Kinney
2023-05-17 5:26 ` Andrei Warkentin
2023-05-17 18:03 ` Michael D Kinney
2023-05-17 23:47 ` Michael D Kinney
2023-05-18 3:36 ` Andrei Warkentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox