From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.21387.1683734427714737682 for ; Wed, 10 May 2023 09:00:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=bR4UsX/5; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.d.kinney@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683734427; x=1715270427; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qwuxF1gAqDAwyFYYUKr7FCSBoJuO/XJ3HHV7JZeu75Y=; b=bR4UsX/5q2I4PYeBAaN53wFLxUMPmc/CLv5jtVg55YFxKfc8MUGd+7Iv TpGRxReiwnOIAXfjz3klY2kFzlEy30863WLdtiCMMYeFlS8UL+ZSiFmi6 VH7B+F2hrjgh3ExVBhGYYQHtuD61C2lSAYccGzUDfGsAC2OfBf8sx6mQz u8IoR3VjfTu09AiuXFMglP6aSThFFGnTW4HYnoOu7siwYu51q+mTv/8QA TUt8az00qj0T5sxwzZytI2zHtJFcmd82xjMF2gfu4fJwLx5hmc/obK0tQ luMhFKy7MvLWbiA+kgnX98kqolztmF0aI6+o4hBIjdwN0JpD8pZRKMIRN Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="347712063" X-IronPort-AV: E=Sophos;i="5.99,265,1677571200"; d="scan'208";a="347712063" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2023 09:00:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="1029264252" X-IronPort-AV: E=Sophos;i="5.99,265,1677571200"; d="scan'208";a="1029264252" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 10 May 2023 09:00:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 10 May 2023 09:00:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 10 May 2023 09:00:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 10 May 2023 09:00:24 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 10 May 2023 09:00:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4muYPUUQKbECohirWEbNtu0cC0CBsc8FPhT8o5oDzTL5cl26MLz+UmqwcKnxPEdHzxMn2JrroNLUk6wqQvr+Z4pH4pd5NUtshgReet92s6DX7nHsSgxsPJ1ZlzAkP9mt8hGvVngqrZ++w3DgFPWRxAZH52Z2W3NOR6Q8F+WmfS2Bju9UvPpp+Qsga4GsohzAHnT60AWdyLcEc+FECx/94ZlMx5OUdsE5xZwNbzES74Y9lhW5zoeTYVo2JQJtTFSC5NVNqQQRMsD30D4pTJSF5XZvEElWPMTGaGMyzEteLRVhbVLKThzMB9UWV2UcnBnWT0SZycmIxs7JQ9JFLJMLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nH5kTGbohZc+GdYty30BsPYNE079jL4kgTaH1sxX6jY=; b=ht7KIBWyCKaZDARMIl1M8q7hcGVLBffoz82gRXWZ2DHAo9wFzi3KnSjMcH/L3/eLX8+0LX+ldCXyBs7eBYePf4JrO+5bZs940JdDADwMoBu/P66DFDxObWgEc+Jn4xhXLmkbWsCxwzAUiRkfu5gNq35SMFTU1+l+qXcgbqcAu7uFrm5guh5XNotpXqsFV6U/6yVP5ZYvWY5qFoezIZXR/t0GvDKuJcZYHBWHs5x+R4cd0FOa0z6bL4JdL+7yX02MyDElkEVouypeScz4gMc4WhrqQAYO4JGzwNt7vds1Cfrn5NEsQ4kIbP8uQujTxjReIXeMNhDFojz2ua5ERCKkNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by MN6PR11MB8101.namprd11.prod.outlook.com (2603:10b6:208:46e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Wed, 10 May 2023 16:00:18 +0000 Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::6e8f:1c7:b499:a84d]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::6e8f:1c7:b499:a84d%4]) with mapi id 15.20.6387.019; Wed, 10 May 2023 16:00:18 +0000 From: "Michael D Kinney" To: "Guo, Gua" , "devel@edk2.groups.io" , "Gao, Liming" CC: "Kinney, Michael D" Subject: Re: [PATCH v5 0/4] MdePkg: Add MipiSysTLib library Thread-Topic: [PATCH v5 0/4] MdePkg: Add MipiSysTLib library Thread-Index: AQHZgyC0rxgRxlF5iEKWVF2VrlpEuK9TqmuQ Date: Wed, 10 May 2023 16:00:18 +0000 Message-ID: References: <20230510092033.993-1-gua.guo@intel.com> In-Reply-To: <20230510092033.993-1-gua.guo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|MN6PR11MB8101:EE_ x-ms-office365-filtering-correlation-id: 44de3cda-e871-41b8-e66e-08db516fa6d9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cmQ5JGPDYMWmc1OiscwSRy7kr4Qna4x678FmOIxeva06tz/PQ4vIpvM27/ETcL6J73cbMhxdnclh9wHM7s5PQ78Fys3vobVB0LYl2mLbk4S3nvonUK0nxSEwV/mRCIvHHEGSBF6iybEKP2HCc2Rl/lYQfsAFzcGwYMjvEEOp5T88n/hxFdwzbhg9cM2Fvjmlefd27Jyh3MuIQdStGT4ny1S2INedXvw7ZQmvSZdf8AKVhOjdwV9rNXJQ+qLVu2OppxW8akewsnlZi1pE4fH1P1i7t6iXiKzF5gKF4Nqsbben1wsfC/4YoNh3mQd0Woa1Xzlqta1EzVqIjUeLVNaDh6dhnCdMvaUTXyaHsr7s2t7kUz8N9xaf51ALDpncbcO8lG5ZbPgwg3XrKr7EADYXv3ZDhxOxBH97bNJgp3TF8uZTRxIA59W2a+FR+tknFJFwXUuqj8gwNv3IX5d24wnpvAv2CtoZqRL2xtmGIa76/ImQ7d2nHWlL13QhATw786X3ewXS7cdWjONO6seOddt6fUPs1PjpGvkDy45yRqD4GagG8hWvOe+Y9RJT5DDsEua2ijbGchae07lpLhuXqYlLhQPBfhVqHukpWprfoHpNhuEotutqVq1zTAMnef4GSGcr6IVhX9WZhONqEXVlj/N4Mw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4929.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199021)(8676002)(41300700001)(316002)(110136005)(71200400001)(478600001)(52536014)(8936002)(76116006)(2906002)(66476007)(5660300002)(64756008)(66446008)(66556008)(66946007)(4326008)(966005)(53546011)(6506007)(26005)(9686003)(107886003)(186003)(82960400001)(7696005)(55016003)(83380400001)(38070700005)(33656002)(38100700002)(122000001)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OjS0Hsbvlz3tM4OjwLTgAG1oGPm8aA4hLzU3oU7cIqUtuyY3NIoOA2dVKRil?= =?us-ascii?Q?NLi9E1haH+yPdXicTHKZLSlbLhsA1ka2yPt5jiueAtrg9xC8eylXzeQpTumr?= =?us-ascii?Q?f3YVbM74ECJ6gOSdEpaXZuIWphd1g05rnw6RcWpLRWqMsSs2Dfz3uFQPTlEf?= =?us-ascii?Q?QPLIHyZDCRF0RIG2z2h6JjsmsluiIAFPXLVtltoXLIpRblBe/01q5khiGISz?= =?us-ascii?Q?qGnZ89+PikNsJzIgLkKQa8/i+TFWEthms+97pN0Ek6YcQzXl1HkVXecXAjaJ?= =?us-ascii?Q?x0nBe8ZmN9wxOBrxGoCtoYjha6DY1hQO+HKw3GoR1xOTJe7Tq4JEpB6YkZd1?= =?us-ascii?Q?VsGIlSlF3qQRjBAFVVPx7aR2fchNgz7KYYcMj/A71ChfsCMhdwA7akZcgYhU?= =?us-ascii?Q?kJ7LSE6MGWD7I6CYJfINi9NX8bmL6w8VrU9OmUG/ZjtYx+ffz2itrZ88Cv+t?= =?us-ascii?Q?FFblH4UlmbInwMwIvouyVyGKSeARrcVq5GyC7MSgPLWyWpzwgbEoU7s4gdTS?= =?us-ascii?Q?36ffr1JvsdBSvugbNj+WueZbFbjHAjtv8mH3h59gf/n1ODSWO6xVtx8eF/ED?= =?us-ascii?Q?hLYbtr1EUEBWVhW1LH7ew7emQZ4NrZ5U4IlQybu5rKMGh4MZYJv+PNIFbwmH?= =?us-ascii?Q?T0m3mGu+TyPwKDf9PyQEC6Tfl45Yn5F7smJRshiHdHQwNQBlbcwQEdD7YmBd?= =?us-ascii?Q?gHfOMQTxW6fwk3PpAa+gaye0UJXNpfocAGXTHmzdXi9r9Q2CYOKjsEaEynLe?= =?us-ascii?Q?h1FLi8dRuIEWkzVvd5gKnvUFdIXKd9L0jiFJ1kgrN2zG2emd2vkEyDcRB3OB?= =?us-ascii?Q?J3uBnQNw6RCJJohNOQ/6VLFm5VcEtSmE+JO20NrJZXwLQleJI55vU8MDSacL?= =?us-ascii?Q?cjq/uPY5xPyp9oQpEVRD5cf4ceK5k9oBtCrOVkE2i4OT+IDMMVqwf/HZELSY?= =?us-ascii?Q?R6ol95WVvI9rD2ssjuAamf/d3/T5uzR1d6N6JWX5vhQLZgXs8wpmj/I4Mz1t?= =?us-ascii?Q?H5bUmTqDUH2xrYnYK5JjvyD+v7K+i5DYMW3VdUlS3iPs24FL4FQChhDg/v5a?= =?us-ascii?Q?QEUn+X+KPd4G+FkA2zZ7ChuWGG9zkQU+K+9m74k7gigCavo+DKWiBko9FS+8?= =?us-ascii?Q?y6dfRhdlsAf+3F6ynLiQmDK1Tqd9kP1zOs9Zd7PjqOQEqDN2epF2yHbaPg+F?= =?us-ascii?Q?YrjDbLU90z1K0GsFi7V+x/5f7QBiMcJGWxUl/K0481+hEysqoVwYoOj7LYJu?= =?us-ascii?Q?585wLZXMSv3l6u9JmEOnprI1FPv4ORzd7m2BchIedYwScaFWc37+QA7QmPb9?= =?us-ascii?Q?vyaiMhYpFpEnE3mH2cY1vKpds+d5dXhHal/NrgxJtPCXD8bjOttqli4q7AlN?= =?us-ascii?Q?ch0AK7lnoirPTlA6SmuuHcmgodjkRLajJMqjSb7OlP0oolnUy6QwlO71sEHD?= =?us-ascii?Q?rMzIF6UGQa956SIZ0CmEH7p70+/+lxMS9mx2FRqya1bhrnI9IpwM3KcMSxRx?= =?us-ascii?Q?UoJGK7f4n6jntRr8x2hav02A7dWO13Y3lC3cja67jM+q5A1uBnGC0rJIeQN8?= =?us-ascii?Q?ume5LEv97PjF38FlJFJIgBYsYf+7hcoKqPz/F6ZcCkv46MmyeKlTJOGggVOH?= =?us-ascii?Q?XQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44de3cda-e871-41b8-e66e-08db516fa6d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2023 16:00:18.5003 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d9IuCeJwosZeTZzCBUOXp745WI6ROy11kwNnAkExf69Bre7KDHQNMBwgtqQPGPR4TfHnGSA+eJU/ndBvSTmHcTbCRgcMpSjVACU1xxbiD0o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8101 Return-Path: michael.d.kinney@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Michael D Kinney Liming, this code review started well before the soft freeze. It has now p= assed review. We should include this in this stable-tag release. Mike > -----Original Message----- > From: Guo, Gua > Sent: Wednesday, May 10, 2023 2:20 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Guo, Gua > > Subject: [PATCH v5 0/4] MdePkg: Add MipiSysTLib library >=20 > From: Gua Guo >=20 > V5: if no other open, it will be final change > - https://github.com/tianocore/edk2/pull/3901 > Fix random exception when long run catalog debug message >=20 > V4 > - https://github.com/tianocore/edk2/pull/3901 - Done > Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make > implement code more simple. >=20 > V3 > - https://github.com/tianocore/edk2/pull/3901 - Done > - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why > MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? > Solution: Remove this macro, use Library Constructor to allocate it > dynamiclly. > - Open: > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon > .c: SwapBytesGuid () algorithm wrong. > Solution: Follow correct algorithm to implement it. > VOID > EFIAPI > SwapBytesGuid ( > IN GUID *Guid, <----------- In PreMem, guid is global = data so region > is readonly, add output data to support it. > OUT GUID *ConvertedGuid > ); >=20 > - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D > Solution: use *_*_*_CC_FLAGS =3D -DMIPI_SYST_STATIC to unified both. >=20 >=20 > V2 > - https://github.com/tianocore/edk2/pull/3901 > - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why > MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? > - Open: > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon > .c: SwapBytesGuid () algorithm wrong. > - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D >=20 > V1 > Previous PR: > - https://github.com/tianocore/edk2/pull/3613 > - TraceHubDebugLib without submodule - Reject >=20 > - https://github.com/tianocore/edk2/pull/3793 > - TraceHubDebugLib with submodule and without seperate into MipiSysTLib > and TraceHubDebugLib - Reject >=20 > Gua Guo (4): > MdePkg: Add MipiSysTLib library > MdePkg: Add NULL library of TraceHubDebugSysTLib > MdeModulePkg: Add TraceHubDebugSysTLib library > Maintainers.txt: Update reviewers and maintainers for > TraceHubDebugLib. >=20 > .gitmodules | 11 +- > .pytool/CISettings.py | 2 + > Maintainers.txt | 18 + > .../Include/Guid/TraceHubDebugInfoHob.h | 24 + > .../BaseTraceHubDebugSysTLib.c | 245 ++++++ > .../BaseTraceHubDebugSysTLib.inf | 44 + > .../DxeSmmTraceHubDebugSysTLib.c | 263 ++++++ > .../DxeSmmTraceHubDebugSysTLib.inf | 51 ++ > .../InternalTraceHubApi.c | 74 ++ > .../InternalTraceHubApi.h | 37 + > .../InternalTraceHubApiCommon.c | 200 +++++ > .../InternalTraceHubApiCommon.h | 119 +++ > .../PeiTraceHubDebugSysTLib.c | 282 +++++++ > .../PeiTraceHubDebugSysTLib.inf | 50 ++ > .../Library/TraceHubDebugSysTLib/Readme.md | 26 + > MdeModulePkg/MdeModulePkg.dec | 21 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > MdeModulePkg/MdeModulePkg.uni | 18 + > MdePkg/Include/Library/MipiSysTLib.h | 66 ++ > MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++ > MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++ > MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++ > MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 52 ++ > MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++ > MdePkg/Library/MipiSysTLib/Platform.h | 138 +++ > MdePkg/Library/MipiSysTLib/Readme.md | 25 + > MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 ++++++++++++++++++ > MdePkg/Library/MipiSysTLib/mipisyst | 1 + > .../TraceHubDebugSysTLibNull.c | 76 ++ > .../TraceHubDebugSysTLibNull.inf | 29 + > MdePkg/MdePkg.ci.yaml | 12 +- > MdePkg/MdePkg.dec | 9 + > MdePkg/MdePkg.dsc | 2 + > ReadMe.rst | 1 + > 34 files changed, 3181 insertions(+), 7 deletions(-) > create mode 100644 MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.i > nf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTL > ib.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTL > ib.inf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon > .c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon > .h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.inf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md > create mode 100644 MdePkg/Include/Library/MipiSysTLib.h > create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h > create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py > create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c > create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf > create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c > create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h > create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md > create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h > create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst > create mode 100644 > MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c > create mode 100644 > MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf >=20 > -- > 2.39.2.windows.1