* [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
@ 2023-01-12 5:14 Chang, Abner
2023-02-14 2:18 ` [edk2-devel] " Ni, Ray
0 siblings, 1 reply; 7+ messages in thread
From: Chang, Abner @ 2023-01-12 5:14 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Ray Ni, Garrett Kirkendall, Abner Chang
From: Abner Chang <abner.chang@amd.com>
In V4: Update the copyright to 2023.
In V3: Add AMD copyright.
In V2: Remove the signed-off-by: Abner Chang
Display PCIe Vendor ID and Device ID in DEBUG message.
Signed-off-by: Jiangang He <jiangang.he@amd.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
Cc: Abner Chang <abner.chang@amd.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index 8eca8596958..6594b8eae83 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -3,6 +3,7 @@
Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
+Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -227,13 +228,15 @@ PciSearchDevice (
DEBUG ((
DEBUG_INFO,
- "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
+ "PciBus: Discovered %s @ [%02x|%02x|%02x] [VID = 0x%x, DID = 0x%0x]\n",
IS_PCI_BRIDGE (Pci) ? L"PPB" :
IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
L"PCI",
Bus,
Device,
- Func
+ Func,
+ Pci->Hdr.VendorId,
+ Pci->Hdr.DeviceId
));
if (!IS_PCI_BRIDGE (Pci)) {
--
2.37.1.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
2023-01-12 5:14 [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices Chang, Abner
@ 2023-02-14 2:18 ` Ni, Ray
2023-02-14 23:27 ` Michael D Kinney
0 siblings, 1 reply; 7+ messages in thread
From: Ni, Ray @ 2023-02-14 2:18 UTC (permalink / raw)
To: devel@edk2.groups.io, abner.chang@amd.com; +Cc: Wu, Hao A, Garrett Kirkendall
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Thursday, January 12, 2023 1:14 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> <abner.chang@amd.com>
> Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> information of PCIe devices
>
> From: Abner Chang <abner.chang@amd.com>
>
> In V4: Update the copyright to 2023.
> In V3: Add AMD copyright.
> In V2: Remove the signed-off-by: Abner Chang
>
> Display PCIe Vendor ID and Device ID in DEBUG message.
>
> Signed-off-by: Jiangang He <jiangang.he@amd.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> ---
> MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index 8eca8596958..6594b8eae83 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -3,6 +3,7 @@
>
> Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -227,13 +228,15 @@ PciSearchDevice (
>
> DEBUG ((
> DEBUG_INFO,
> - "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> + "PciBus: Discovered %s @ [%02x|%02x|%02x] [VID = 0x%x, DID =
> 0x%0x]\n",
> IS_PCI_BRIDGE (Pci) ? L"PPB" :
> IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> L"PCI",
> Bus,
> Device,
> - Func
> + Func,
> + Pci->Hdr.VendorId,
> + Pci->Hdr.DeviceId
> ));
>
> if (!IS_PCI_BRIDGE (Pci)) {
> --
> 2.37.1.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
2023-02-14 2:18 ` [edk2-devel] " Ni, Ray
@ 2023-02-14 23:27 ` Michael D Kinney
2023-02-15 0:28 ` Chang, Abner
2023-02-15 1:23 ` Michael D Kinney
0 siblings, 2 replies; 7+ messages in thread
From: Michael D Kinney @ 2023-02-14 23:27 UTC (permalink / raw)
To: devel@edk2.groups.io, Ni, Ray, abner.chang@amd.com
Cc: Wu, Hao A, Garrett Kirkendall, Kinney, Michael D
Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Monday, February 13, 2023 6:18 PM
> To: devel@edk2.groups.io; abner.chang@amd.com
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>
> Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Thursday, January 12, 2023 1:14 PM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> > Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > <abner.chang@amd.com>
> > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > In V4: Update the copyright to 2023.
> > In V3: Add AMD copyright.
> > In V2: Remove the signed-off-by: Abner Chang
> >
> > Display PCIe Vendor ID and Device ID in DEBUG message.
> >
> > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > ---
> > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > index 8eca8596958..6594b8eae83 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > @@ -3,6 +3,7 @@
> >
> > Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> > (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > **/
> > @@ -227,13 +228,15 @@ PciSearchDevice (
> >
> > DEBUG ((
> > DEBUG_INFO,
> > - "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > + "PciBus: Discovered %s @ [%02x|%02x|%02x] [VID = 0x%x, DID =
> > 0x%0x]\n",
> > IS_PCI_BRIDGE (Pci) ? L"PPB" :
> > IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > L"PCI",
> > Bus,
> > Device,
> > - Func
> > + Func,
> > + Pci->Hdr.VendorId,
> > + Pci->Hdr.DeviceId
> > ));
> >
> > if (!IS_PCI_BRIDGE (Pci)) {
> > --
> > 2.37.1.windows.1
> >
> >
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
2023-02-14 23:27 ` Michael D Kinney
@ 2023-02-15 0:28 ` Chang, Abner
2023-02-15 0:40 ` Michael D Kinney
2023-02-15 1:23 ` Michael D Kinney
1 sibling, 1 reply; 7+ messages in thread
From: Chang, Abner @ 2023-02-15 0:28 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io, Ni, Ray
Cc: Wu, Hao A, Kirkendall, Garrett
[AMD Official Use Only - General]
Thanks Ray and Mike, I will create PR and merge it.
Abner
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, February 15, 2023 7:27 AM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Chang, Abner
> <Abner.Chang@amd.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> information of PCIe devices
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni,
> Ray
> > Sent: Monday, February 13, 2023 6:18 PM
> > To: devel@edk2.groups.io; abner.chang@amd.com
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall
> > <garrett.kirkendall@amd.com>
> > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Chang, Abner via groups.io
> > > Sent: Thursday, January 12, 2023 1:14 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > <abner.chang@amd.com>
> > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > From: Abner Chang <abner.chang@amd.com>
> > >
> > > In V4: Update the copyright to 2023.
> > > In V3: Add AMD copyright.
> > > In V2: Remove the signed-off-by: Abner Chang
> > >
> > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > >
> > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > ---
> > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++-
> -
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > index 8eca8596958..6594b8eae83 100644
> > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > @@ -3,6 +3,7 @@
> > >
> > > Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > reserved.<BR>
> > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > +reserved.<BR>
> > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > > **/
> > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > >
> > > DEBUG ((
> > > DEBUG_INFO,
> > > - "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > + "PciBus: Discovered %s @ [%02x|%02x|%02x] [VID = 0x%x, DID =
> > > 0x%0x]\n",
> > > IS_PCI_BRIDGE (Pci) ? L"PPB" :
> > > IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > > L"PCI",
> > > Bus,
> > > Device,
> > > - Func
> > > + Func,
> > > + Pci->Hdr.VendorId,
> > > + Pci->Hdr.DeviceId
> > > ));
> > >
> > > if (!IS_PCI_BRIDGE (Pci)) {
> > > --
> > > 2.37.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
2023-02-15 0:28 ` Chang, Abner
@ 2023-02-15 0:40 ` Michael D Kinney
2023-02-15 0:41 ` Chang, Abner
0 siblings, 1 reply; 7+ messages in thread
From: Michael D Kinney @ 2023-02-15 0:40 UTC (permalink / raw)
To: devel@edk2.groups.io, abner.chang@amd.com, Ni, Ray
Cc: Wu, Hao A, Kirkendall, Garrett, Kinney, Michael D
It is already in process of being merged
https://github.com/tianocore/edk2/pull/4042
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Tuesday, February 14, 2023 4:29 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>
> Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
>
> [AMD Official Use Only - General]
>
> Thanks Ray and Mike, I will create PR and merge it.
>
> Abner
>
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Wednesday, February 15, 2023 7:27 AM
> > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Chang, Abner
> > <Abner.Chang@amd.com>
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> > <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni,
> > Ray
> > > Sent: Monday, February 13, 2023 6:18 PM
> > > To: devel@edk2.groups.io; abner.chang@amd.com
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall
> > > <garrett.kirkendall@amd.com>
> > > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > Reviewed-by: Ray Ni <ray.ni@intel.com>
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > Chang, Abner via groups.io
> > > > Sent: Thursday, January 12, 2023 1:14 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > > <abner.chang@amd.com>
> > > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > > information of PCIe devices
> > > >
> > > > From: Abner Chang <abner.chang@amd.com>
> > > >
> > > > In V4: Update the copyright to 2023.
> > > > In V3: Add AMD copyright.
> > > > In V2: Remove the signed-off-by: Abner Chang
> > > >
> > > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > > >
> > > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > ---
> > > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++-
> > -
> > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > index 8eca8596958..6594b8eae83 100644
> > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > @@ -3,6 +3,7 @@
> > > >
> > > > Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > > reserved.<BR>
> > > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > > +reserved.<BR>
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > > >
> > > > **/
> > > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > > >
> > > > DEBUG ((
> > > > DEBUG_INFO,
> > > > - "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > > + "PciBus: Discovered %s @ [%02x|%02x|%02x] [VID = 0x%x, DID =
> > > > 0x%0x]\n",
> > > > IS_PCI_BRIDGE (Pci) ? L"PPB" :
> > > > IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > > > L"PCI",
> > > > Bus,
> > > > Device,
> > > > - Func
> > > > + Func,
> > > > + Pci->Hdr.VendorId,
> > > > + Pci->Hdr.DeviceId
> > > > ));
> > > >
> > > > if (!IS_PCI_BRIDGE (Pci)) {
> > > > --
> > > > 2.37.1.windows.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
2023-02-15 0:40 ` Michael D Kinney
@ 2023-02-15 0:41 ` Chang, Abner
0 siblings, 0 replies; 7+ messages in thread
From: Chang, Abner @ 2023-02-15 0:41 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io, Ni, Ray
Cc: Wu, Hao A, Kirkendall, Garrett
[AMD Official Use Only - General]
Ah ok, thanks!
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, February 15, 2023 8:41 AM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ni, Ray
> <ray.ni@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> information of PCIe devices
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> It is already in process of being merged
>
> https://github.com/tianocore/edk2/pull/4042
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Tuesday, February 14, 2023 4:29 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> > <Garrett.Kirkendall@amd.com>
> > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > [AMD Official Use Only - General]
> >
> > Thanks Ray and Mike, I will create PR and merge it.
> >
> > Abner
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Wednesday, February 15, 2023 7:27 AM
> > > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Chang, Abner
> > > <Abner.Chang@amd.com>
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> > > <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni,
> > > Ray
> > > > Sent: Monday, February 13, 2023 6:18 PM
> > > > To: devel@edk2.groups.io; abner.chang@amd.com
> > > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall
> > > > <garrett.kirkendall@amd.com>
> > > > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display
> > > > more information of PCIe devices
> > > >
> > > > Reviewed-by: Ray Ni <ray.ni@intel.com>
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > Chang, Abner via groups.io
> > > > > Sent: Thursday, January 12, 2023 1:14 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > > > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > > > <abner.chang@amd.com>
> > > > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > > > information of PCIe devices
> > > > >
> > > > > From: Abner Chang <abner.chang@amd.com>
> > > > >
> > > > > In V4: Update the copyright to 2023.
> > > > > In V3: Add AMD copyright.
> > > > > In V2: Remove the signed-off-by: Abner Chang
> > > > >
> > > > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > > > >
> > > > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > ---
> > > > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7
> > > > > +++++-
> > > -
> > > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git
> > > > > a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > index 8eca8596958..6594b8eae83 100644
> > > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > @@ -3,6 +3,7 @@
> > > > >
> > > > > Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > > > reserved.<BR>
> > > > > (C) Copyright 2015 Hewlett Packard Enterprise Development
> > > > > LP<BR>
> > > > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > > > +reserved.<BR>
> > > > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > > > >
> > > > > **/
> > > > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > > > >
> > > > > DEBUG ((
> > > > > DEBUG_INFO,
> > > > > - "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > > > + "PciBus: Discovered %s @ [%02x|%02x|%02x] [VID = 0x%x, DID
> > > > > + =
> > > > > 0x%0x]\n",
> > > > > IS_PCI_BRIDGE (Pci) ? L"PPB" :
> > > > > IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > > > > L"PCI",
> > > > > Bus,
> > > > > Device,
> > > > > - Func
> > > > > + Func,
> > > > > + Pci->Hdr.VendorId,
> > > > > + Pci->Hdr.DeviceId
> > > > > ));
> > > > >
> > > > > if (!IS_PCI_BRIDGE (Pci)) {
> > > > > --
> > > > > 2.37.1.windows.1
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
2023-02-14 23:27 ` Michael D Kinney
2023-02-15 0:28 ` Chang, Abner
@ 2023-02-15 1:23 ` Michael D Kinney
1 sibling, 0 replies; 7+ messages in thread
From: Michael D Kinney @ 2023-02-15 1:23 UTC (permalink / raw)
To: devel@edk2.groups.io, Ni, Ray, abner.chang@amd.com
Cc: Wu, Hao A, Garrett Kirkendall, Kinney, Michael D
Merged
PR: https://github.com/tianocore/edk2/pull/4042
Commit: https://github.com/tianocore/edk2/commit/f9c6b5134e5e2c5ca977f422119b1255412acd53
Mike
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Tuesday, February 14, 2023 3:27 PM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; abner.chang@amd.com
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
>
> Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> > Sent: Monday, February 13, 2023 6:18 PM
> > To: devel@edk2.groups.io; abner.chang@amd.com
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>
> > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
> >
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > > Abner via groups.io
> > > Sent: Thursday, January 12, 2023 1:14 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> > > Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > <abner.chang@amd.com>
> > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > From: Abner Chang <abner.chang@amd.com>
> > >
> > > In V4: Update the copyright to 2023.
> > > In V3: Add AMD copyright.
> > > In V2: Remove the signed-off-by: Abner Chang
> > >
> > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > >
> > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > ---
> > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > index 8eca8596958..6594b8eae83 100644
> > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > @@ -3,6 +3,7 @@
> > >
> > > Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > > **/
> > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > >
> > > DEBUG ((
> > > DEBUG_INFO,
> > > - "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > + "PciBus: Discovered %s @ [%02x|%02x|%02x] [VID = 0x%x, DID =
> > > 0x%0x]\n",
> > > IS_PCI_BRIDGE (Pci) ? L"PPB" :
> > > IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > > L"PCI",
> > > Bus,
> > > Device,
> > > - Func
> > > + Func,
> > > + Pci->Hdr.VendorId,
> > > + Pci->Hdr.DeviceId
> > > ));
> > >
> > > if (!IS_PCI_BRIDGE (Pci)) {
> > > --
> > > 2.37.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-15 1:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-12 5:14 [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices Chang, Abner
2023-02-14 2:18 ` [edk2-devel] " Ni, Ray
2023-02-14 23:27 ` Michael D Kinney
2023-02-15 0:28 ` Chang, Abner
2023-02-15 0:40 ` Michael D Kinney
2023-02-15 0:41 ` Chang, Abner
2023-02-15 1:23 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox