public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Jayaprakash, N" <n.jayaprakash@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Rebecca Cran <rebecca@bsdio.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI fails to compile with GCC
Date: Thu, 31 Aug 2023 17:24:56 +0000	[thread overview]
Message-ID: <CO1PR11MB492930DCAA21DBDC23F7E90BD2E5A@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230831161300.1241-2-n.jayaprakash@intel.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: Jayaprakash, N <n.jayaprakash@intel.com>
> Sent: Thursday, August 31, 2023 9:13 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI
> fails to compile with GCC
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4545
> 
> The compilation issues reported in the BZ are fixed by
> defining below 2 macros in pyconfig.h
> HAVE_ADDRINFO
> HAVE_SOCKADDR_STORAGE
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>  .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h        | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> index 3b9eceb..983cfda 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> @@ -66,7 +66,7 @@
>  #undef HAVE_ACOSH
> 
>  /* struct addrinfo (netdb.h) */
> -#undef HAVE_ADDRINFO
> +#define HAVE_ADDRINFO   1
> 
>  /* Define to 1 if you have the 'alarm' function. */
>  #undef HAVE_ALARM
> @@ -683,7 +683,7 @@
>  #undef HAVE_SOCKADDR_SA_LEN
> 
>  /* struct sockaddr_storage (sys/socket.h) */
> -#undef HAVE_SOCKADDR_STORAGE
> +#define HAVE_SOCKADDR_STORAGE   1
> 
>  /* Define if you have the 'socketpair' function. */
>  #undef HAVE_SOCKETPAIR
> --
> 2.40.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108202): https://edk2.groups.io/g/devel/message/108202
Mute This Topic: https://groups.io/mt/101077159/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2023-08-31 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 16:12 [edk2-devel] [edk2-libc Patch 0/1] python socket module fails with GCC compiler Jayaprakash, N
2023-08-31 16:13 ` [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI fails to compile with GCC Jayaprakash, N
2023-08-31 17:24   ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB492930DCAA21DBDC23F7E90BD2E5A@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox